)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"621a1f20d3f4a2c0d6dc57702ff184f1e2014a96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dc53bc58_a485e1da","updated":"2021-12-16 11:16:52.000000000","message":"Is that still required?","commit_id":"ae8d6c0c73f670f102518f24e20716b4f49ee6ca"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"616e0c88f12d42e381001ecad31b5b4265a17afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"711e1b91_c1438944","in_reply_to":"dc53bc58_a485e1da","updated":"2021-12-17 03:58:00.000000000","message":"I think it is required to support UEFI boot mode. Patch is updated.","commit_id":"ae8d6c0c73f670f102518f24e20716b4f49ee6ca"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"82bdc27d4dd528c5c79ba8293f7a90c098c03504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1132a049_6e47dd51","updated":"2021-12-21 10:23:51.000000000","message":"check experimental","commit_id":"b91406df21289fb96a0f420cb89da780b5beebf7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a7482cd49a4dbb52fa57d35dcae30e22dc135c2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8744297e_63430704","updated":"2021-12-21 07:35:37.000000000","message":"recheck","commit_id":"b91406df21289fb96a0f420cb89da780b5beebf7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a82467b3127b6d1c6cb3c8c7396e656a78a51ac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"630f1b6d_3f268fb3","updated":"2021-12-21 13:29:08.000000000","message":"check experimental","commit_id":"957a2219a0b20a5af734e5b4c80004b820597937"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"80956ffa5e916c067dc239a9173f9dc3d0717b52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"590ee304_4478314d","updated":"2021-12-21 16:55:31.000000000","message":"check experimental","commit_id":"5bf101e932a3203f340d0cffbe078554c9594b81"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bda584668da16f22a39fab0fa89ce5dde498dcaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f61bf3e4_3073aa89","updated":"2021-12-22 18:34:17.000000000","message":"lgtm, Marcin to confirm for aarch64","commit_id":"5bf101e932a3203f340d0cffbe078554c9594b81"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"49a7a3a49f788ecfd74220e58ad17d6ede39312e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c3d443e9_32394fd7","updated":"2022-01-26 01:39:32.000000000","message":"recheck","commit_id":"5bf101e932a3203f340d0cffbe078554c9594b81"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7925904b0604872f770dcd2797ecdd8fdf0b2203","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"87f56bc2_4387cdc9","updated":"2022-01-26 19:48:50.000000000","message":"I made it independent of CI testing","commit_id":"b6e057d694d90d50ea278411d0edf20afe427e13"}],"docker/ironic/ironic-pxe/extend_start.sh":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"108b8ad400b89252b61340f1497f4d2a2d3d3797","unresolved":false,"context_lines":[{"line_number":4,"context_line":"function prepare_pxe {"},{"line_number":5,"context_line":"    chown -R ironic: /tftpboot"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\tif [[ \"${ironic_arch}\" \u003d~ aarch64 ]]; then"},{"line_number":8,"context_line":"\t\tmodules\u003d\"boot chain configfile efinet ext2 fat gettext help hfsplus loadenv \\"},{"line_number":9,"context_line":"\t\tlsefi normal part_gpt part_msdos read search search_fs_file search_fs_uuid \\"},{"line_number":10,"context_line":"\t\tsearch_label terminal terminfo tftp linux\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f493fa4_a3526311","line":7,"updated":"2020-04-30 10:23:03.000000000","message":"change tabs to spaces","commit_id":"fd94d3072376ddaff09dad25a6cfc18c70881e08"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab90cd240a49bb0066e04dc5d54166a0785a364c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            grub_mkimage\u003dgrub2-mkimage"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_87f2d26e","line":18,"range":{"start_line":18,"start_character":68,"end_line":18,"end_character":72},"updated":"2020-04-30 12:06:04.000000000","message":"This was previously EFI/centos. Is it ok to change?","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"d09ab731535fff5a891bc0b674d1d5c83118bc9f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            grub_mkimage\u003dgrub2-mkimage"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_447d096d","line":18,"range":{"start_line":18,"start_character":68,"end_line":18,"end_character":72},"in_reply_to":"1f493fa4_769ad213","updated":"2020-05-06 02:40:01.000000000","message":"For ironic doc[1], it use distros provided grub efi so it need to create grub.cfg dir as distros. Kolla generates grub efi itself now, but maybe we should use distros\u0027 grub efi instead like ironic doc. Anyway, changing grub.cfg dir will also need to Synchronous change kolla-ansible[2] , if we want to change it I prefer a separate patch for it.\n\n[1]: https://docs.openstack.org/ironic/latest/install/configure-pxe.html#uefi-pxe-grub-setup\n[2]: \nhttps://github.com/openstack/kolla-ansible/blob/0a1ccc2612240ff15c255eeafc67f56835278adf/ansible/roles/ironic/templates/ironic-pxe.json.j2#L1","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"eabfedd1a196517f701134ddf9e2f9a39e2bc4c5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            grub_mkimage\u003dgrub2-mkimage"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_769ad213","line":18,"range":{"start_line":18,"start_character":68,"end_line":18,"end_character":72},"in_reply_to":"1f493fa4_87f2d26e","updated":"2020-04-30 14:55:16.000000000","message":"I need to double check this. The ironic doc tells it will need this dir.\nhttps://docs.openstack.org/ironic/latest/install/configure-pxe.html#pxe-multi-architecture-setup","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab90cd240a49bb0066e04dc5d54166a0785a364c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"function prepare_pxe {"},{"line_number":5,"context_line":"    chown -R ironic: /tftpboot"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    if [[ \"${ironic_arch}\" \u003d~ aarch64 ]]; then"},{"line_number":8,"context_line":"        modules\u003d\"boot chain configfile efinet ext2 fat gettext help hfsplus \\"},{"line_number":9,"context_line":"            loadenv lsefi normal part_gpt part_msdos read search search_fs_file \\"},{"line_number":10,"context_line":"            search_fs_uuidi search_label terminal terminfo tftp linux\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":13,"context_line":"            grub_mkimage\u003dgrub-mkimage"},{"line_number":14,"context_line":"        elif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ centos|rhel ]]; then"},{"line_number":15,"context_line":"            grub_mkimage\u003dgrub2-mkimage"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"},{"line_number":22,"context_line":"                        /usr/lib/syslinux/chain.c32 \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_c7333a61","line":19,"range":{"start_line":7,"start_character":0,"end_line":19,"end_character":20},"updated":"2020-04-30 12:06:04.000000000","message":"It might be cleaner to add this to a new prepare_grub function.","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"eabfedd1a196517f701134ddf9e2f9a39e2bc4c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"function prepare_pxe {"},{"line_number":5,"context_line":"    chown -R ironic: /tftpboot"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    if [[ \"${ironic_arch}\" \u003d~ aarch64 ]]; then"},{"line_number":8,"context_line":"        modules\u003d\"boot chain configfile efinet ext2 fat gettext help hfsplus \\"},{"line_number":9,"context_line":"            loadenv lsefi normal part_gpt part_msdos read search search_fs_file \\"},{"line_number":10,"context_line":"            search_fs_uuidi search_label terminal terminfo tftp linux\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":13,"context_line":"            grub_mkimage\u003dgrub-mkimage"},{"line_number":14,"context_line":"        elif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ centos|rhel ]]; then"},{"line_number":15,"context_line":"            grub_mkimage\u003dgrub2-mkimage"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"},{"line_number":22,"context_line":"                        /usr/lib/syslinux/chain.c32 \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_b6a0da43","line":19,"range":{"start_line":7,"start_character":0,"end_line":19,"end_character":20},"in_reply_to":"1f493fa4_c7333a61","updated":"2020-04-30 14:55:16.000000000","message":"Yeah, will update the patch.","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab90cd240a49bb0066e04dc5d54166a0785a364c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"},{"line_number":22,"context_line":"                        /usr/lib/syslinux/chain.c32 \\"},{"line_number":23,"context_line":"                        /usr/lib/syslinux/modules/bios/chain.c32 \\"},{"line_number":24,"context_line":"                        /usr/lib/syslinux/modules/bios/ldlinux.c32 \\"},{"line_number":25,"context_line":"                        /usr/lib/syslinux/pxelinux.0 \\"},{"line_number":26,"context_line":"                        /var/lib/tftpboot/chain.c32 \\"},{"line_number":27,"context_line":"                        /var/lib/tftpboot/pxelinux.0; do"},{"line_number":28,"context_line":"            if [[ -e \"$pxe_file\" ]]; then"},{"line_number":29,"context_line":"                cp \"$pxe_file\" /tftpboot"},{"line_number":30,"context_line":"            fi"},{"line_number":31,"context_line":"        done"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_e724760f","line":31,"range":{"start_line":21,"start_character":0,"end_line":31,"end_character":12},"updated":"2020-04-30 12:06:04.000000000","message":"We should consider mixed arch environments too. Do these files exist in an AARCH64 install? If so, keeping them would allow us to PXE boot x86 machines.","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f38d6cbdf4fdf004fc23da8464004d3608367307","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"},{"line_number":22,"context_line":"                        /usr/lib/syslinux/chain.c32 \\"},{"line_number":23,"context_line":"                        /usr/lib/syslinux/modules/bios/chain.c32 \\"},{"line_number":24,"context_line":"                        /usr/lib/syslinux/modules/bios/ldlinux.c32 \\"},{"line_number":25,"context_line":"                        /usr/lib/syslinux/pxelinux.0 \\"},{"line_number":26,"context_line":"                        /var/lib/tftpboot/chain.c32 \\"},{"line_number":27,"context_line":"                        /var/lib/tftpboot/pxelinux.0; do"},{"line_number":28,"context_line":"            if [[ -e \"$pxe_file\" ]]; then"},{"line_number":29,"context_line":"                cp \"$pxe_file\" /tftpboot"},{"line_number":30,"context_line":"            fi"},{"line_number":31,"context_line":"        done"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_cb72b8ad","line":31,"range":{"start_line":21,"start_character":0,"end_line":31,"end_character":12},"in_reply_to":"1f493fa4_a101b607","updated":"2020-05-06 18:11:42.000000000","message":"Then can we create a universal image able to boot any supported arch? It should make it nicer to handle multiarch while being simpler at the same time. :-)","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"faf346560d7de71653d591df33f6de92f519e804","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"},{"line_number":22,"context_line":"                        /usr/lib/syslinux/chain.c32 \\"},{"line_number":23,"context_line":"                        /usr/lib/syslinux/modules/bios/chain.c32 \\"},{"line_number":24,"context_line":"                        /usr/lib/syslinux/modules/bios/ldlinux.c32 \\"},{"line_number":25,"context_line":"                        /usr/lib/syslinux/pxelinux.0 \\"},{"line_number":26,"context_line":"                        /var/lib/tftpboot/chain.c32 \\"},{"line_number":27,"context_line":"                        /var/lib/tftpboot/pxelinux.0; do"},{"line_number":28,"context_line":"            if [[ -e \"$pxe_file\" ]]; then"},{"line_number":29,"context_line":"                cp \"$pxe_file\" /tftpboot"},{"line_number":30,"context_line":"            fi"},{"line_number":31,"context_line":"        done"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_d930b2a1","line":31,"range":{"start_line":21,"start_character":0,"end_line":31,"end_character":12},"in_reply_to":"1f493fa4_cb72b8ad","updated":"2020-05-08 01:28:43.000000000","message":"No, we can\u0027t. Different arch has different efi executable format[1]. Syslinux only support x86 legacy BIOS boot mode. And for UEFI grub boot mode, current ironic supports multiarch bare metal provisioning via options \"xxx_by_arch\"[2] if we use neutron dhcp provider, e.g.:\n\npxe_bootfile_name_by_arch\u003daarch64:grubaa64.efi,ppc64:bootppc64\npxe_config_template_by_arch\u003daarch64:pxe_grubaa64_config.template,ppc64:pxe_ppc64_config.template\n \n\n[1]: see --format option, https://www.systutorials.com/docs/linux/man/1-grub2-mkimage/\n[2]: https://docs.openstack.org/ironic/latest/install/configure-pxe.html#pxe-multi-architecture-setup","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"eabfedd1a196517f701134ddf9e2f9a39e2bc4c5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $grub_mkimage -v -o /tftpboot/grubaa64.efi -O arm64-efi -p \"grub\" \\"},{"line_number":19,"context_line":"            $modules"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        for pxe_file in /usr/lib/PXELINUX/pxelinux.0 \\"},{"line_number":22,"context_line":"                        /usr/lib/syslinux/chain.c32 \\"},{"line_number":23,"context_line":"                        /usr/lib/syslinux/modules/bios/chain.c32 \\"},{"line_number":24,"context_line":"                        /usr/lib/syslinux/modules/bios/ldlinux.c32 \\"},{"line_number":25,"context_line":"                        /usr/lib/syslinux/pxelinux.0 \\"},{"line_number":26,"context_line":"                        /var/lib/tftpboot/chain.c32 \\"},{"line_number":27,"context_line":"                        /var/lib/tftpboot/pxelinux.0; do"},{"line_number":28,"context_line":"            if [[ -e \"$pxe_file\" ]]; then"},{"line_number":29,"context_line":"                cp \"$pxe_file\" /tftpboot"},{"line_number":30,"context_line":"            fi"},{"line_number":31,"context_line":"        done"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f493fa4_a101b607","line":31,"range":{"start_line":21,"start_character":0,"end_line":31,"end_character":12},"in_reply_to":"1f493fa4_e724760f","updated":"2020-04-30 14:55:16.000000000","message":"You are right, we should consider mixed arch bare metal node deployment. these files exist in AArch64 install. We should keep these files.","commit_id":"2478c9fbf5532f03ec719223830cabb15342fc89"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e87360670b3a04df64ef320be745e785b5e849e0","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        grub_src_file\u003d\"/boot/efi/EFI/centos/grub*64.efi\""},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ \"${KOLLA_BASE_ARCH}\" \u003d\u003d \"x86_64\" ]]; then"},{"line_number":27,"context_line":"        shim_dst_file\u003d\"bootx64.efi\""},{"line_number":28,"context_line":"        grub_dst_file\u003d\"grubx64.efi\""},{"line_number":29,"context_line":"    elif [[ \"${KOLLA_BASE_ARCH}\" \u003d\u003d \"aarch64\" ]]; then"},{"line_number":30,"context_line":"        shim_dst_file\u003d\"bootaa64.efi\""},{"line_number":31,"context_line":"        grub_dst_file\u003d\"grubaa64.efi\""},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    cp $shim_src_file /tftpboot/$shim_dst_file"},{"line_number":35,"context_line":"    cp $grub_src_file /tftpboot/$grub_dst_file"}],"source_content_type":"text/x-sh","patch_set":7,"id":"bd51fc29_da69630e","line":32,"range":{"start_line":26,"start_character":0,"end_line":32,"end_character":6},"updated":"2022-01-21 08:53:55.000000000","message":"Should we copy both sets of files on both arches? That would in theory allow x86 to boot aarch64 and vice versa","commit_id":"5bf101e932a3203f340d0cffbe078554c9594b81"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"a58f2cc527a140c62ecbe5b5a26eb8f6d75467a5","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        grub_src_file\u003d\"/boot/efi/EFI/centos/grub*64.efi\""},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ \"${KOLLA_BASE_ARCH}\" \u003d\u003d \"x86_64\" ]]; then"},{"line_number":27,"context_line":"        shim_dst_file\u003d\"bootx64.efi\""},{"line_number":28,"context_line":"        grub_dst_file\u003d\"grubx64.efi\""},{"line_number":29,"context_line":"    elif [[ \"${KOLLA_BASE_ARCH}\" \u003d\u003d \"aarch64\" ]]; then"},{"line_number":30,"context_line":"        shim_dst_file\u003d\"bootaa64.efi\""},{"line_number":31,"context_line":"        grub_dst_file\u003d\"grubaa64.efi\""},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    cp $shim_src_file /tftpboot/$shim_dst_file"},{"line_number":35,"context_line":"    cp $grub_src_file /tftpboot/$grub_dst_file"}],"source_content_type":"text/x-sh","patch_set":7,"id":"b53a062f_9954ac0c","line":32,"range":{"start_line":26,"start_character":0,"end_line":32,"end_character":6},"in_reply_to":"bd51fc29_da69630e","updated":"2022-01-21 09:12:56.000000000","message":"But, usually, in container it can only install one arch binary at a time. Supporting multi-arch UEFI booting might need to copy other arch grub bins manually. See https://docs.openstack.org/ironic/latest/install/configure-pxe.html#pxe-multi-architecture-setup","commit_id":"5bf101e932a3203f340d0cffbe078554c9594b81"}]}