)]}'
{"docker/cyborg/cyborg-base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4f0909e3c896756c4726af19e5c48c8ec7101cdb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"RUN ln -s cyborg-base-source/* cyborg \\"},{"line_number":26,"context_line":"    \u0026\u0026 {{ macros.install_pip(cyborg_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":27,"context_line":"    \u0026\u0026 mkdir -p /etc/cyborg/ \\"},{"line_number":28,"context_line":"    \u0026\u0026 cp -r /cyborg/etc/cyborg/* /etc/cyborg/ \\"},{"line_number":29,"context_line":"    \u0026\u0026 chown -R cyborg: /etc/cyborg/"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_0ef2a270","line":29,"range":{"start_line":28,"start_character":46,"end_line":29,"end_character":36},"updated":"2020-05-18 06:32:51.000000000","message":"this should not be required (cyborg should not need to modify its config files)","commit_id":"7d5ecf93efa9248e02570a64d72f0918931d05c8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5c3b033e010db6c1f1525b8b049bc46febbefc6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"RUN ln -s cyborg-base-source/* cyborg \\"},{"line_number":26,"context_line":"    \u0026\u0026 {{ macros.install_pip(cyborg_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":27,"context_line":"    \u0026\u0026 mkdir -p /etc/cyborg/ \\"},{"line_number":28,"context_line":"    \u0026\u0026 cp -r /cyborg/etc/cyborg/* /etc/cyborg/ \\"},{"line_number":29,"context_line":"    \u0026\u0026 chown -R cyborg: /etc/cyborg/"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_c6f7e358","line":29,"range":{"start_line":28,"start_character":46,"end_line":29,"end_character":36},"in_reply_to":"ff570b3c_038a6d68","updated":"2020-05-18 17:00:41.000000000","message":"Yeah, I think this might be confusing but we are looking forward to removing these stances, see [1].\n\n[1] https://review.opendev.org/722102","commit_id":"7d5ecf93efa9248e02570a64d72f0918931d05c8"},{"author":{"_account_id":30356,"name":"gugug","email":"gu.jin@99cloud.net","username":"gujin"},"change_message_id":"0fc1f9c86e784c06720bf3ad3429b910ed8492f3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"RUN ln -s cyborg-base-source/* cyborg \\"},{"line_number":26,"context_line":"    \u0026\u0026 {{ macros.install_pip(cyborg_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":27,"context_line":"    \u0026\u0026 mkdir -p /etc/cyborg/ \\"},{"line_number":28,"context_line":"    \u0026\u0026 cp -r /cyborg/etc/cyborg/* /etc/cyborg/ \\"},{"line_number":29,"context_line":"    \u0026\u0026 chown -R cyborg: /etc/cyborg/"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_038a6d68","line":29,"range":{"start_line":28,"start_character":46,"end_line":29,"end_character":36},"in_reply_to":"ff570b3c_0ef2a270","updated":"2020-05-18 16:01:33.000000000","message":"thanks for your review\nbut I think the chown is needed, kolla-ansible will set the permissions[1] when copy configs and the other images chowned too, such as nova or cinder [2]\n\n[1]: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/cyborg/templates/cyborg-api.json.j2#L26\n\n[2]: https://github.com/openstack/kolla/blob/master/docker/cinder/cinder-base/Dockerfile.j2#L68","commit_id":"7d5ecf93efa9248e02570a64d72f0918931d05c8"},{"author":{"_account_id":30356,"name":"gugug","email":"gu.jin@99cloud.net","username":"gujin"},"change_message_id":"4312b734f132174d83f32a22e1f2a45207bda9bc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"RUN ln -s cyborg-base-source/* cyborg \\"},{"line_number":26,"context_line":"    \u0026\u0026 {{ macros.install_pip(cyborg_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":27,"context_line":"    \u0026\u0026 mkdir -p /etc/cyborg/ \\"},{"line_number":28,"context_line":"    \u0026\u0026 cp -r /cyborg/etc/cyborg/* /etc/cyborg/ \\"},{"line_number":29,"context_line":"    \u0026\u0026 chown -R cyborg: /etc/cyborg/"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_c8fd296f","line":29,"range":{"start_line":28,"start_character":46,"end_line":29,"end_character":36},"in_reply_to":"ff570b3c_c6f7e358","updated":"2020-05-19 01:52:54.000000000","message":"ok, updated will be later","commit_id":"7d5ecf93efa9248e02570a64d72f0918931d05c8"}]}