)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6a73ab4dce1679f3546de12775c1a4e554bf27ab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gaël THEROND \u003cgael.therond@bitswalk.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-12 16:27:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lang package block order."},{"line_number":8,"context_line":"Base image lang pack installation block need to be reordered for offline installation."},{"line_number":9,"context_line":"Closes-bug: 1883233"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_e1ce9f59","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"updated":"2020-06-12 14:43:25.000000000","message":"In this context, it would be more useful to describe what issue the commit fixes rather than how it does it.\n\nWhat about \"Fix offline installation of language pack\"?\n\nNote: no need for a period at the end. Add an empty line after.","commit_id":"3aba79103c8286f1ec01dcd11274d203ef128142"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b9f45024a59d77855812f49e6754993c04893f5d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gaël THEROND \u003cgael.therond@bitswalk.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-12 16:27:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lang package block order."},{"line_number":8,"context_line":"Base image lang pack installation block need to be reordered for offline installation."},{"line_number":9,"context_line":"Closes-bug: 1883233"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_841b6e1a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"in_reply_to":"ff570b3c_7c851807","updated":"2020-06-12 20:08:58.000000000","message":"I meant \"Fix offline installation...\" for the first line. Then the rest of the commit message can explain how it\u0027s done (changing the order).\n\nIs it fixed this way because it needs to come after custom yum repo configuration?","commit_id":"3aba79103c8286f1ec01dcd11274d203ef128142"},{"author":{"_account_id":31763,"name":"Gaël THEROND","username":"gtherond","inactive":true},"change_message_id":"650fc27a561f1f2e9a7b6c2f1f6fcbd1172f8227","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gaël THEROND \u003cgael.therond@bitswalk.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-12 16:27:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lang package block order."},{"line_number":8,"context_line":"Base image lang pack installation block need to be reordered for offline installation."},{"line_number":9,"context_line":"Closes-bug: 1883233"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df5c0766_197a8b87","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"in_reply_to":"ff570b3c_841b6e1a","updated":"2020-06-12 21:30:32.000000000","message":"yes, that\u0027s fixed once it comes after custom yum repo configuration.\n\nAnd if ever wondering, using dnf/yum.conf block as the placeholder for our repositories isn\u0027t the correct/clean way to make it happen as we have a long list of repositories (Default CentOS/Elastic/FluentD etc) to add and as it\u0027s better to understand what we override from our ops too, explicit is always better ;-)","commit_id":"3aba79103c8286f1ec01dcd11274d203ef128142"},{"author":{"_account_id":31763,"name":"Gaël THEROND","username":"gtherond","inactive":true},"change_message_id":"809c61b43ae0aaaf788c7d6128de093f7b62c10b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gaël THEROND \u003cgael.therond@bitswalk.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-12 16:27:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lang package block order."},{"line_number":8,"context_line":"Base image lang pack installation block need to be reordered for offline installation."},{"line_number":9,"context_line":"Closes-bug: 1883233"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_7c851807","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"in_reply_to":"ff570b3c_e1ce9f59","updated":"2020-06-12 15:40:12.000000000","message":"I\u0027m fine with your suggestion, gonna edit it.","commit_id":"3aba79103c8286f1ec01dcd11274d203ef128142"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6a73ab4dce1679f3546de12775c1a4e554bf27ab","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-06-12 16:27:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lang package block order."},{"line_number":8,"context_line":"Base image lang pack installation block need to be reordered for offline installation."},{"line_number":9,"context_line":"Closes-bug: 1883233"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9f4a21bbf1c8383e21e59350206aba3424602270"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_01d473e8","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":86},"updated":"2020-06-12 14:43:25.000000000","message":"Please wrap those lines at 72 characters when possible, it makes it easier to read in Gerrit without scrolling.","commit_id":"3aba79103c8286f1ec01dcd11274d203ef128142"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6a73ab4dce1679f3546de12775c1a4e554bf27ab","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-06-12 16:27:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lang package block order."},{"line_number":8,"context_line":"Base image lang pack installation block need to be reordered for offline installation."},{"line_number":9,"context_line":"Closes-bug: 1883233"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9f4a21bbf1c8383e21e59350206aba3424602270"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_01ed93b6","line":8,"range":{"start_line":8,"start_character":40,"end_line":8,"end_character":44},"updated":"2020-06-12 14:43:25.000000000","message":"needs","commit_id":"3aba79103c8286f1ec01dcd11274d203ef128142"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6a73ab4dce1679f3546de12775c1a4e554bf27ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lang package block order."},{"line_number":8,"context_line":"Base image lang pack installation block need to be reordered for offline installation."},{"line_number":9,"context_line":"Closes-bug: 1883233"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9f4a21bbf1c8383e21e59350206aba3424602270"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_c1f27b9b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":19},"updated":"2020-06-12 14:43:25.000000000","message":"We generally use the following style:\n\nCloses-Bug: #1883233\n\nand group it together with Change-Id (generally sorted alphabetically, so Closes-Bug comes second).","commit_id":"3aba79103c8286f1ec01dcd11274d203ef128142"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b06c2dd2f31a7be812104071f8a33412a1e2c845","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"{{ macros.install_packages(base_yum_url_packages | customizable(\"yum_url_packages\")) }}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"{% for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":161,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":162,"context_line":"    rpm --import {{ key }}"},{"line_number":163,"context_line":"{%- if not loop.last %} \\{% endif %}"},{"line_number":164,"context_line":"{% endfor -%}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_698e4a28","line":164,"range":{"start_line":160,"start_character":0,"end_line":164,"end_character":13},"updated":"2020-06-15 13:31:35.000000000","message":"Should it also be after RPM key imports?","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"},{"author":{"_account_id":31763,"name":"Gaël THEROND","username":"gtherond","inactive":true},"change_message_id":"d3917f1fbece78ac6641dc9f2cf1221b1d94c467","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"{{ macros.install_packages(base_yum_url_packages | customizable(\"yum_url_packages\")) }}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"{% for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":161,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":162,"context_line":"    rpm --import {{ key }}"},{"line_number":163,"context_line":"{%- if not loop.last %} \\{% endif %}"},{"line_number":164,"context_line":"{% endfor -%}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_90949aea","line":164,"range":{"start_line":160,"start_character":0,"end_line":164,"end_character":13},"in_reply_to":"bf51134e_698e4a28","updated":"2020-06-15 16:49:59.000000000","message":"Nope, that\u0027s fine as default repositories already imported a correct GPG Key within the database.","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b06c2dd2f31a7be812104071f8a33412a1e2c845","unresolved":false,"context_lines":[{"line_number":164,"context_line":"{% endfor -%}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"{% for cmd in rpm_setup %}"},{"line_number":169,"context_line":"{{ cmd }}"},{"line_number":170,"context_line":"{% endfor %}"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"{% block base_centos_repo_overrides_post_rpm %}{% endblock %}"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_49938650","line":170,"range":{"start_line":167,"start_character":0,"end_line":170,"end_character":12},"updated":"2020-06-15 13:31:35.000000000","message":"And custom repo setup?","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"},{"author":{"_account_id":31763,"name":"Gaël THEROND","username":"gtherond","inactive":true},"change_message_id":"d3917f1fbece78ac6641dc9f2cf1221b1d94c467","unresolved":false,"context_lines":[{"line_number":164,"context_line":"{% endfor -%}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"{% for cmd in rpm_setup %}"},{"line_number":169,"context_line":"{{ cmd }}"},{"line_number":170,"context_line":"{% endfor %}"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"{% block base_centos_repo_overrides_post_rpm %}{% endblock %}"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_308f8ecd","line":170,"range":{"start_line":167,"start_character":0,"end_line":170,"end_character":12},"in_reply_to":"bf51134e_49938650","updated":"2020-06-15 16:49:59.000000000","message":"Could be, but it work even if called before the rpm_setup.","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b06c2dd2f31a7be812104071f8a33412a1e2c845","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    {% if base_distro \u003d\u003d \u0027centos\u0027 %}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"{% block base_centos_gpg_key_import %}"},{"line_number":186,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial"},{"line_number":187,"context_line":"{% endblock %}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"{% set base_centos_yum_repo_keys \u003d ["},{"line_number":190,"context_line":"    \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-OpsTools\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_e9a1ba97","line":187,"range":{"start_line":185,"start_character":0,"end_line":187,"end_character":14},"updated":"2020-06-15 13:31:35.000000000","message":"Maybe this too?","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"},{"author":{"_account_id":31763,"name":"Gaël THEROND","username":"gtherond","inactive":true},"change_message_id":"d3917f1fbece78ac6641dc9f2cf1221b1d94c467","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    {% if base_distro \u003d\u003d \u0027centos\u0027 %}"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"{% block base_centos_gpg_key_import %}"},{"line_number":186,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial"},{"line_number":187,"context_line":"{% endblock %}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"{% set base_centos_yum_repo_keys \u003d ["},{"line_number":190,"context_line":"    \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-OpsTools\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_1076cad9","line":187,"range":{"start_line":185,"start_character":0,"end_line":187,"end_character":14},"in_reply_to":"bf51134e_e9a1ba97","updated":"2020-06-15 16:49:59.000000000","message":"This is fine as the official image already import it.","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b06c2dd2f31a7be812104071f8a33412a1e2c845","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    {% endif %}"},{"line_number":245,"context_line":"    {# Endif for base_distro RHEL #}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"#### END REPO ENABLEMENT"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"{# We are back to the basic if conditional here which is:"},{"line_number":250,"context_line":"    if base_package_type \u003d\u003d \u0027rpm\u0027 #}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_09a98e7a","line":247,"range":{"start_line":247,"start_character":0,"end_line":247,"end_character":24},"updated":"2020-06-15 13:31:35.000000000","message":"In fact we\u0027re still enabling repos down to here.","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"},{"author":{"_account_id":31763,"name":"Gaël THEROND","username":"gtherond","inactive":true},"change_message_id":"d3917f1fbece78ac6641dc9f2cf1221b1d94c467","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    {% endif %}"},{"line_number":245,"context_line":"    {# Endif for base_distro RHEL #}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"#### END REPO ENABLEMENT"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"{# We are back to the basic if conditional here which is:"},{"line_number":250,"context_line":"    if base_package_type \u003d\u003d \u0027rpm\u0027 #}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf51134e_d308dc29","line":247,"range":{"start_line":247,"start_character":0,"end_line":247,"end_character":24},"in_reply_to":"bf51134e_09a98e7a","updated":"2020-06-15 16:49:59.000000000","message":"Yep, it\u0027s just that installing the package is actually working as soon as you override or append the following block:\n\nbase_yum_repo_files: https://opendev.org/openstack/kolla/src/branch/master/docker/base/Dockerfile.j2#L86","commit_id":"f9def021d86caecfd57018f41792f8a7c6bc6a80"}]}