)]}'
{"docker/logstash/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c87b6390bcbc9397d0ca00d06cf579b5b082c06b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    {% set logstash_packages \u003d ["},{"line_number":28,"context_line":"        \u0027openjdk-\u0027 + java_version + \u0027-jre-headless\u0027,"},{"line_number":29,"context_line":"        \u0027logrotate\u0027"},{"line_number":30,"context_line":"    ] %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-{{java_version}}-openjdk-{{debian_arch}}/"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bf51134e_ec7b93bb","side":"PARENT","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":18},"updated":"2020-06-30 09:43:36.000000000","message":"hmm, weird that it included logrotate","commit_id":"9fc8f3e9872c4a9c5fca8419979be3a254dd893a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c87b6390bcbc9397d0ca00d06cf579b5b082c06b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"    {% set logstash_packages \u003d ["},{"line_number":24,"context_line":"        \u0027default-jre-headless\u0027,"},{"line_number":25,"context_line":"        \u0027logstash-oss\u0027,"},{"line_number":26,"context_line":"    ] %}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bf51134e_0caa4718","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":16},"updated":"2020-06-30 09:43:36.000000000","message":"sounds wrong to rely on though","commit_id":"722f8eaad4d6b112d1c3d393d06c42efd8de062d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ff87446fd1540bc2a2170eb5f393c425bd21b7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.enable_extra_repos([\u0027logstash\u0027]) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":15,"context_line":"    {% set elk_java_package \u003d \u0027java-11-openjdk-headless\u0027 %}"},{"line_number":16,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-11-openjdk/"},{"line_number":17,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":18,"context_line":"    {% set elk_java_package \u003d \u0027openjdk-11-jre-headless\u0027 %}"},{"line_number":19,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-11-openjdk-{{debian_arch}}/"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set logstash_packages \u003d ["},{"line_number":23,"context_line":"    elk_java_package,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_a70d3437","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":11},"updated":"2020-06-30 09:52:43.000000000","message":"I think I went overcreative with that but it seems nice to refactor even further as the whole ELK stack relies on installing the same, proper JRE. Similar case is with the repos - it\u0027s actually one ELK repo. WDYT about refactoring it such?","commit_id":"44898eea18378c234af61754d5f7f79c9b6415ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"febb5aef3347085913857ad37816a50704a1fd62","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.enable_extra_repos([\u0027logstash\u0027]) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":15,"context_line":"    {% set elk_java_package \u003d \u0027java-11-openjdk-headless\u0027 %}"},{"line_number":16,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-11-openjdk/"},{"line_number":17,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":18,"context_line":"    {% set elk_java_package \u003d \u0027openjdk-11-jre-headless\u0027 %}"},{"line_number":19,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-11-openjdk-{{debian_arch}}/"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set logstash_packages \u003d ["},{"line_number":23,"context_line":"    elk_java_package,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_473538a8","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"bf51134e_67815c4b","updated":"2020-06-30 10:03:13.000000000","message":"Let\u0027s do the refactoring in a separate commit since we need to touch 3 different images. We could macro-out the highlighted part and merge the repo as elk and then just use it everywhere.","commit_id":"44898eea18378c234af61754d5f7f79c9b6415ff"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"dea632c059d36ec545e78ba377b61c302bf83281","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.enable_extra_repos([\u0027logstash\u0027]) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":15,"context_line":"    {% set elk_java_package \u003d \u0027java-11-openjdk-headless\u0027 %}"},{"line_number":16,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-11-openjdk/"},{"line_number":17,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":18,"context_line":"    {% set elk_java_package \u003d \u0027openjdk-11-jre-headless\u0027 %}"},{"line_number":19,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-11-openjdk-{{debian_arch}}/"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set logstash_packages \u003d ["},{"line_number":23,"context_line":"    elk_java_package,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bf51134e_67815c4b","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"bf51134e_a70d3437","updated":"2020-06-30 10:00:09.000000000","message":"Thanks Radek, yeah, I resisted the temptation to merge the ELK repos in this commit, but I agree that it is the logical next step. It\u0027s only in exceptional cases that you don\u0027t want them in sync. I could add it as a follow up unless you\u0027re happy with it in this commit.","commit_id":"44898eea18378c234af61754d5f7f79c9b6415ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"aa22cf53db3b08f876e192172bb32bcefb118166","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Post-install script of Logstash fails when trying to install Logstash and"},{"line_number":27,"context_line":"# Java together."},{"line_number":28,"context_line":"{{ macros.install_packages([elk_java_package]) }}"},{"line_number":29,"context_line":"{{ macros.install_packages(logstash_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bf51134e_8211fbaf","line":29,"range":{"start_line":29,"start_character":47,"end_line":29,"end_character":72},"updated":"2020-06-30 13:48:16.000000000","message":"unfortunately we have to accommodate for the customization to java as well; maybe mix in with the elk standardization (as they all should really use the same one)","commit_id":"dcc1ef2262a0487790d0c09a15c0235786805e1f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c48761865d897f7a619f50cf7601e172d27feeee","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Post-install script of Logstash fails when trying to install Logstash and"},{"line_number":27,"context_line":"# Java together."},{"line_number":28,"context_line":"{{ macros.install_packages([elk_java_package]) }}"},{"line_number":29,"context_line":"{{ macros.install_packages(logstash_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bf51134e_6e2650bd","line":29,"range":{"start_line":29,"start_character":47,"end_line":29,"end_character":72},"in_reply_to":"bf51134e_53f33374","updated":"2020-06-30 16:14:18.000000000","message":"Mhm, that makes sense. Java is quite bulky compared to regular packages. Let\u0027s keep this patch simple though and let it have this irregularity for now.","commit_id":"dcc1ef2262a0487790d0c09a15c0235786805e1f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0925c24283e769f7b2168712f17d83f6aa4c45c3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Post-install script of Logstash fails when trying to install Logstash and"},{"line_number":27,"context_line":"# Java together."},{"line_number":28,"context_line":"{{ macros.install_packages([elk_java_package]) }}"},{"line_number":29,"context_line":"{{ macros.install_packages(logstash_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bf51134e_53f33374","line":29,"range":{"start_line":29,"start_character":47,"end_line":29,"end_character":72},"in_reply_to":"bf51134e_8211fbaf","updated":"2020-06-30 16:09:31.000000000","message":"Yeah, not ideal I know. It mirrors Elastic right now. Do you think we should have a common ELK base image with Java installed that these inherit from?","commit_id":"dcc1ef2262a0487790d0c09a15c0235786805e1f"}],"releasenotes/notes/add-logstash6-everywhere-7f9027ff17c6022d.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e94e67f0a7690c3138eaf0b467a4fdf96467e4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Any images still using Logstash 2 have been upgraded to use Logstash 6."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_8262d4d6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":37},"updated":"2020-06-25 13:52:08.000000000","message":"Isn\u0027t this just the logstash image?","commit_id":"fc506107b4d42aca9197ec6a28a85cbad3073ca2"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2151ef855ac09fc83a3367100ce79ae07f4d6b9f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Any images still using Logstash 2 have been upgraded to use Logstash 6."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_48629d0b","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":37},"in_reply_to":"bf51134e_8262d4d6","updated":"2020-06-25 16:06:21.000000000","message":"You\u0027re right - I think I meant services, but that belongs in Kolla Ansible.","commit_id":"fc506107b4d42aca9197ec6a28a85cbad3073ca2"}]}