)]}'
{"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a4b26a06a6898c73a3bf4897b0e6dc89ca0ce9ec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":10,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":11,"context_line":"{% else %}"},{"line_number":12,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":13,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_8871b10f","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":28},"updated":"2020-07-08 09:21:46.000000000","message":"I am not sure is this version valid anymore","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8f8f78fcf2d8a888b8e6603c38b4ee6df164b0e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":10,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":11,"context_line":"{% else %}"},{"line_number":12,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":13,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_68da5de9","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":28},"in_reply_to":"bf51134e_8871b10f","updated":"2020-07-08 09:27:13.000000000","message":"It was only there for the fluentd 0.12 to 0.14 (or if you prefer 1.x) migration - we could get rid of that in kolla-ansible and then remove it here.","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a4b26a06a6898c73a3bf4897b0e6dc89ca0ce9ec","unresolved":false,"context_lines":[{"line_number":64,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Distro specific files and operations"},{"line_number":67,"context_line":"# Fluentd on rpm-based non-x86_64 is installed from rpm"},{"line_number":68,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 and fluentd_binary \u003d\u003d \u0027fluentd\u0027 %}"},{"line_number":69,"context_line":"RUN /usr/bin/gem install fluentd --no-rdoc --no-ri"},{"line_number":70,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_686c1d36","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":55},"updated":"2020-07-08 09:21:46.000000000","message":"this comment needs to go","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8f8f78fcf2d8a888b8e6603c38b4ee6df164b0e","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Distro specific files and operations"},{"line_number":67,"context_line":"# Fluentd on rpm-based non-x86_64 is installed from rpm"},{"line_number":68,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 and fluentd_binary \u003d\u003d \u0027fluentd\u0027 %}"},{"line_number":69,"context_line":"RUN /usr/bin/gem install fluentd --no-rdoc --no-ri"},{"line_number":70,"context_line":"{% endif %}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_e894adea","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":11},"updated":"2020-07-08 09:27:13.000000000","message":"I guess we could get rid of that and install td-agent everywhere from deb/rpm","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a4b26a06a6898c73a3bf4897b0e6dc89ca0ce9ec","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":85,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":86,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":87,"context_line":"        \u0027fluent-plugin-grep\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_e8614d3b","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":67},"updated":"2020-07-08 09:21:46.000000000","message":"this check needs checking","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8f8f78fcf2d8a888b8e6603c38b4ee6df164b0e","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":85,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":86,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":87,"context_line":"        \u0027fluent-plugin-grep\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_e8302d0a","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":67},"in_reply_to":"bf51134e_e8614d3b","updated":"2020-07-08 09:27:13.000000000","message":"I think td-agent 3 was not there on centos aarch64 - so if it\u0027s there for td4 - we can get rid of this check.","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a4b26a06a6898c73a3bf4897b0e6dc89ca0ce9ec","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    ] %}"},{"line_number":93,"context_line":"{% endif %}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# NOTE(hrw): one of plugins fetches \u0027string-scrub\u0027 which tries to use"},{"line_number":96,"context_line":"# /usr/bin/mkdir directly while in Debian it is in /bin"},{"line_number":97,"context_line":"{% if base_distro \u003d\u003d \u0027debian\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":98,"context_line":"RUN ln -s /bin/mkdir /usr/bin/mkdir"},{"line_number":99,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_c864494c","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":55},"updated":"2020-07-08 09:21:46.000000000","message":"I wonder is this still valid","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8f8f78fcf2d8a888b8e6603c38b4ee6df164b0e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    ] %}"},{"line_number":93,"context_line":"{% endif %}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# NOTE(hrw): one of plugins fetches \u0027string-scrub\u0027 which tries to use"},{"line_number":96,"context_line":"# /usr/bin/mkdir directly while in Debian it is in /bin"},{"line_number":97,"context_line":"{% if base_distro \u003d\u003d \u0027debian\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":98,"context_line":"RUN ln -s /bin/mkdir /usr/bin/mkdir"},{"line_number":99,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_6876ddda","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":55},"in_reply_to":"bf51134e_c864494c","updated":"2020-07-08 09:27:13.000000000","message":"if we install td-agent from a deb package, not using gem - it might not be needed - but you\u0027re the Debian expert ;-)","commit_id":"9bfb4e192494e4ec4b3f2657267ecf78602b60af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"497b12b5b202e2951b37eaac91fff3fa733576d0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% block labels %}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch not in [\u0027aarch64\u0027, \u0027x86_64\u0027] %}"},{"line_number":6,"context_line":"LABEL fluentd_version\u003d\"0.12\" fluentd_binary\u003d\"fluentd\""},{"line_number":7,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":8,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 and base_arch not in [\u0027aarch64\u0027, \u0027x86_64\u0027] %}"},{"line_number":9,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":10,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":11,"context_line":"{% else %}"},{"line_number":12,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":13,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% block fluentd_header %}{% endblock %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bf51134e_6eafe9e2","line":14,"range":{"start_line":5,"start_character":0,"end_line":14,"end_character":11},"updated":"2020-07-09 14:46:55.000000000","message":"I think it\u0027s time to sort out this mess, but we first need to straighten it out in kolla-ansible - will follow up then.","commit_id":"641855f4c55a6ccec0b0afc3b08adaec49145318"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"497b12b5b202e2951b37eaac91fff3fa733576d0","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":25,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":26,"context_line":"        \u0027make\u0027"},{"line_number":27,"context_line":"    ] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    {% if base_arch in [\u0027aarch64\u0027, \u0027x86_64\u0027] %}"},{"line_number":30,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bf51134e_cea0b5f7","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":8},"updated":"2020-07-09 14:46:55.000000000","message":"do we still need this when we install td-agent?","commit_id":"641855f4c55a6ccec0b0afc3b08adaec49145318"}]}