)]}'
{"docker/ironic/ironic-pxe/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4839b6749b59b21e79073d1a00355ff5e7ed4023","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"},{"line_number":23,"context_line":"        {% set ironic_pxe_packages \u003d ironic_pxe_packages + ["},{"line_number":24,"context_line":"            \u0027grub2-tools\u0027,"},{"line_number":25,"context_line":"            \u0027grub2-efi-aa64-modules\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_bb1693f0","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":29},"updated":"2020-08-18 17:44:48.000000000","message":"are we supporting this at all?","commit_id":"38e2421a1de1259d751d0074bdb762c39dbb986c"},{"author":{"_account_id":32322,"name":"Yaakov Selkowitz","email":"yselkowi@redhat.com","username":"yselkowitz"},"change_message_id":"b012897d19081be75942890290bb9c223c5e6f8d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"},{"line_number":23,"context_line":"        {% set ironic_pxe_packages \u003d ironic_pxe_packages + ["},{"line_number":24,"context_line":"            \u0027grub2-tools\u0027,"},{"line_number":25,"context_line":"            \u0027grub2-efi-aa64-modules\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_db77073a","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":29},"in_reply_to":"9f560f44_bb1693f0","updated":"2020-08-20 17:40:47.000000000","message":"No, but it is future-proof.  s390x is the only RHEL architecture on which grub2 is not shipped.","commit_id":"38e2421a1de1259d751d0074bdb762c39dbb986c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"276b9e94925a3490087919cb5ee5fd2d052bccf4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"},{"line_number":23,"context_line":"        {% set ironic_pxe_packages \u003d ironic_pxe_packages + ["},{"line_number":24,"context_line":"            \u0027grub2-tools\u0027,"},{"line_number":25,"context_line":"            \u0027grub2-efi-aa64-modules\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_bb364150","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":29},"in_reply_to":"9f560f44_db77073a","updated":"2020-08-24 07:28:54.000000000","message":"OK, makes sense this way. Need to clarify the below then.","commit_id":"38e2421a1de1259d751d0074bdb762c39dbb986c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"276b9e94925a3490087919cb5ee5fd2d052bccf4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"},{"line_number":23,"context_line":"        {% set ironic_pxe_packages \u003d ironic_pxe_packages + ["},{"line_number":24,"context_line":"            \u0027grub2-tools\u0027,"},{"line_number":25,"context_line":"            \u0027grub2-efi-aa64-modules\u0027"},{"line_number":26,"context_line":"        ] %}"},{"line_number":27,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_1b3f6d25","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":24},"updated":"2020-08-24 07:28:54.000000000","message":"Why did it change?","commit_id":"38e2421a1de1259d751d0074bdb762c39dbb986c"},{"author":{"_account_id":32322,"name":"Yaakov Selkowitz","email":"yselkowi@redhat.com","username":"yselkowitz"},"change_message_id":"4499b463dac4f6485abe8ce4f4a247dd1d863d71","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"},{"line_number":23,"context_line":"        {% set ironic_pxe_packages \u003d ironic_pxe_packages + ["},{"line_number":24,"context_line":"            \u0027grub2-tools\u0027,"},{"line_number":25,"context_line":"            \u0027grub2-efi-aa64-modules\u0027"},{"line_number":26,"context_line":"        ] %}"},{"line_number":27,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_9ee886b3","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":24},"in_reply_to":"9f560f44_1b3f6d25","updated":"2020-08-24 13:29:01.000000000","message":"Because this is actually what is used (grub2-mkimage), and ppc64le does not have grub2-efi.","commit_id":"38e2421a1de1259d751d0074bdb762c39dbb986c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4d642521fc38ee2a4e65d1d80cde0c685a37c639","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"},{"line_number":23,"context_line":"        {% set ironic_pxe_packages \u003d ironic_pxe_packages + ["},{"line_number":24,"context_line":"            \u0027grub2-tools\u0027,"},{"line_number":25,"context_line":"            \u0027grub2-efi-aa64-modules\u0027"},{"line_number":26,"context_line":"        ] %}"},{"line_number":27,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_69ccd188","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":24},"in_reply_to":"9f560f44_9ee886b3","updated":"2020-08-25 08:26:08.000000000","message":"It\u0027s oh-so-complicated! :D I\u0027d like these details in the commit message next time but fine to get them her at least in these comments.","commit_id":"38e2421a1de1259d751d0074bdb762c39dbb986c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"826ddd081970ad1e8acdeefede383b4b4d20afb4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"},{"line_number":23,"context_line":"        {% set ironic_pxe_packages \u003d ironic_pxe_packages + ["},{"line_number":24,"context_line":"            \u0027grub2-tools\u0027,"},{"line_number":25,"context_line":"            \u0027grub2-efi-aa64-modules\u0027"},{"line_number":26,"context_line":"        ] %}"},{"line_number":27,"context_line":"    {% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(ironic_pxe_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_c69f8c4f","line":27,"range":{"start_line":22,"start_character":0,"end_line":27,"end_character":15},"updated":"2020-08-28 08:14:38.000000000","message":"Either we need a proper comment here that s390x (do we even support this arch?) doesn\u0027t have those packages, or in the commit message.","commit_id":"b3c8e42ac2bc0392efe992f4329bb481633b72f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bd2f698b660d73bdfdfb962458ba71e74fd439ae","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # NOTE(hrw): RHEL and CentOS whip those packages on all grub architectures"},{"line_number":23,"context_line":"    # (x86_64, ppc64le, aarch64, but not s390x), and therefore can be used on"},{"line_number":24,"context_line":"    # any of them to support heterogeneous clusters with AArch64."},{"line_number":25,"context_line":"    {% if base_arch !\u003d \u0027s390x\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_9cc30539","line":22,"range":{"start_line":22,"start_character":33,"end_line":22,"end_character":37},"updated":"2020-08-31 09:36:19.000000000","message":"rotfl, made my day! We must merge this.","commit_id":"f5d1caed9d714a65bc865f32efaf5a7f52a26676"}]}