)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"e64c7d02fc0664427ff7dd45f35d356520b83984","unresolved":false,"context_lines":[{"line_number":330,"context_line":"   \u0027open-iscsi\u0027,"},{"line_number":331,"context_line":"   \u0027procps\u0027,"},{"line_number":332,"context_line":"   \u0027python3\u0027,"},{"line_number":333,"context_line":"   \u0027python3-pip\u0027,"},{"line_number":334,"context_line":"   \u0027socat\u0027,"},{"line_number":335,"context_line":"   \u0027sudo\u0027,"},{"line_number":336,"context_line":"   \u0027tgt\u0027]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_f37af922","line":333,"updated":"2020-09-18 02:48:40.000000000","message":"and i think we don\u0027t need this package.","commit_id":"b93c40a3635fbce72e48dc29120e50484cba36ca"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ccb6c0de6427305cf9c33be9ed8034dc4a0ea0d7","unresolved":false,"context_lines":[{"line_number":330,"context_line":"   \u0027open-iscsi\u0027,"},{"line_number":331,"context_line":"   \u0027procps\u0027,"},{"line_number":332,"context_line":"   \u0027python3\u0027,"},{"line_number":333,"context_line":"   \u0027python3-pip\u0027,"},{"line_number":334,"context_line":"   \u0027socat\u0027,"},{"line_number":335,"context_line":"   \u0027sudo\u0027,"},{"line_number":336,"context_line":"   \u0027tgt\u0027]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_dbe267a0","line":333,"in_reply_to":"9f560f44_1fee8cec","updated":"2020-09-18 10:18:06.000000000","message":"I beg to differ, this package seems to provide pip module: https://packages.ubuntu.com/focal/all/python3-pip/filelist","commit_id":"b93c40a3635fbce72e48dc29120e50484cba36ca"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"a07a6eb788c4505bb9c55e07101fe328363ce4b8","unresolved":false,"context_lines":[{"line_number":330,"context_line":"   \u0027open-iscsi\u0027,"},{"line_number":331,"context_line":"   \u0027procps\u0027,"},{"line_number":332,"context_line":"   \u0027python3\u0027,"},{"line_number":333,"context_line":"   \u0027python3-pip\u0027,"},{"line_number":334,"context_line":"   \u0027socat\u0027,"},{"line_number":335,"context_line":"   \u0027sudo\u0027,"},{"line_number":336,"context_line":"   \u0027tgt\u0027]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_1fee8cec","line":333,"in_reply_to":"9f560f44_bf6160d7","updated":"2020-09-18 09:21:08.000000000","message":"if we don\u0027t use python3 -m pip instead pip3, then this is needed.","commit_id":"b93c40a3635fbce72e48dc29120e50484cba36ca"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"a0f88f7cf70e3a36efd8008c99f534e0be34292b","unresolved":false,"context_lines":[{"line_number":330,"context_line":"   \u0027open-iscsi\u0027,"},{"line_number":331,"context_line":"   \u0027procps\u0027,"},{"line_number":332,"context_line":"   \u0027python3\u0027,"},{"line_number":333,"context_line":"   \u0027python3-pip\u0027,"},{"line_number":334,"context_line":"   \u0027socat\u0027,"},{"line_number":335,"context_line":"   \u0027sudo\u0027,"},{"line_number":336,"context_line":"   \u0027tgt\u0027]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_bf6160d7","line":333,"in_reply_to":"9f560f44_f37af922","updated":"2020-09-18 08:51:03.000000000","message":"It\u0027s required on at least CentOS distribution, pip doesn\u0027t come installed along python packages.","commit_id":"b93c40a3635fbce72e48dc29120e50484cba36ca"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7c18e978404b3b3f8e5156340a33d0b9049631dd","unresolved":false,"context_lines":[{"line_number":330,"context_line":"   \u0027open-iscsi\u0027,"},{"line_number":331,"context_line":"   \u0027procps\u0027,"},{"line_number":332,"context_line":"   \u0027python3\u0027,"},{"line_number":333,"context_line":"   \u0027python3-pip\u0027,"},{"line_number":334,"context_line":"   \u0027socat\u0027,"},{"line_number":335,"context_line":"   \u0027sudo\u0027,"},{"line_number":336,"context_line":"   \u0027tgt\u0027]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f560f44_5f73e4b4","line":333,"in_reply_to":"9f560f44_f37af922","updated":"2020-09-18 08:50:17.000000000","message":"Why? We need pip.","commit_id":"b93c40a3635fbce72e48dc29120e50484cba36ca"}],"docker/macros.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4b546d732a427030e9bd45e7a3b99113707114f9","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% macro install_pip(packages, constraints \u003d true, pip_version \u003d pip) %}"},{"line_number":36,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"},{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_7484265e","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":36},"updated":"2020-09-17 08:52:36.000000000","message":"it\u0027s always 3","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"f6c24769e46627ddfe50b47ffafec3efe9b6e61f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% macro install_pip(packages, constraints \u003d true, pip_version \u003d pip) %}"},{"line_number":36,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"},{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_5ee49c3c","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":36},"in_reply_to":"9f560f44_54bda200","updated":"2020-09-17 10:25:15.000000000","message":"Since the introduction of PY3 version as the main version on CentOS/Ubuntu, they distinctly install them using python3.X release and named pip with a version in order to avoid collision on systems still using PY2.7 such as CentOS 7.x and at least until 1 january 2021.\n\nSo I just decided to keep the pip_version and call that one as someone can decide (for whatever obscure reason) to stick with a specific 3.6 or 3.7.3 for instance.","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"f6c24769e46627ddfe50b47ffafec3efe9b6e61f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% macro install_pip(packages, constraints \u003d true, pip_version \u003d pip) %}"},{"line_number":36,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"},{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_3e8a8863","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":36},"in_reply_to":"9f560f44_7484265e","updated":"2020-09-17 10:25:15.000000000","message":"Yep for now, but I do prefer to get a way for the futur to quickly update if we ever have specifics such as 4.x or 3.Y fixed etc.","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"64b82a7f11c58ae8525d5fe436eb5117f05ee79d","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% macro install_pip(packages, constraints \u003d true, pip_version \u003d pip) %}"},{"line_number":36,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"},{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_54bda200","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":36},"in_reply_to":"9f560f44_7484265e","updated":"2020-09-17 08:53:53.000000000","message":"anyways, interesting that there was no pip link - we are using virtualenv so there should be one","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4b546d732a427030e9bd45e7a3b99113707114f9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"},{"line_number":42,"context_line":"    {{ packages | join(\u0027 \u0027) }}"},{"line_number":43,"context_line":"{%- else -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_1495ea88","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":18},"updated":"2020-09-17 08:52:36.000000000","message":"it should call the desired python with `-m pip` rather than this","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"f6c24769e46627ddfe50b47ffafec3efe9b6e61f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"},{"line_number":42,"context_line":"    {{ packages | join(\u0027 \u0027) }}"},{"line_number":43,"context_line":"{%- else -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_5e52dcdf","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":18},"in_reply_to":"9f560f44_1495ea88","updated":"2020-09-17 10:25:15.000000000","message":"I\u0027ve just keep what was used before in previous release and didn\u0027t changed that for a direct module call because I didn\u0027t wanted to have a long change discussion over this patch that rather focus on the python/pip installation process.\n\nOf course I could propose a second change later on but I think that if we force the module usage it will imply a lot of pain for those that want to stick with a specific version.","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"0107b8d273261ae7f4c83fa174ab151d75ebd237","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"},{"line_number":42,"context_line":"    {{ packages | join(\u0027 \u0027) }}"},{"line_number":43,"context_line":"{%- else -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_bc7340b4","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":18},"in_reply_to":"9f560f44_1495ea88","updated":"2020-09-17 11:24:06.000000000","message":"agree, in a python3 world , we can use python3 -m pip directly. just replace {{ pip_version }} to python3 -m pip. and remove the installation of python-pip3","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"65f10473eadc6775a2efaaff9259b97c0c7d6981","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"},{"line_number":42,"context_line":"    {{ packages | join(\u0027 \u0027) }}"},{"line_number":43,"context_line":"{%- else -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_93b61df9","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":18},"in_reply_to":"9f560f44_5c52e436","updated":"2020-09-18 02:40:49.000000000","message":"kolla seems doesn\u0027t support customize versions of python now. this value used at kolla-ansible  https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L1092 \n\nat train we support py27 and python3, but this patchset apply on master branch only, not train， on train branch we might need add a check for py2 or py3","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"a0f88f7cf70e3a36efd8008c99f534e0be34292b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"},{"line_number":42,"context_line":"    {{ packages | join(\u0027 \u0027) }}"},{"line_number":43,"context_line":"{%- else -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_ffb0f842","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":18},"in_reply_to":"9f560f44_93b61df9","updated":"2020-09-18 08:51:03.000000000","message":"I\u0027ve initially created this patch to be backward compatible with train, I\u0027m creating a generic bug to be merged on master, then backport to required branches.\n\nI\u0027ve made the appropriate changes on the current patch set to only support PY3.x serie tho.","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"5eca94c17657f75026fbb2f6e3a247c8d55b20e9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{%- if not pip_version and distro_python_version.startswith(\u00273\u0027) -%}"},{"line_number":38,"context_line":"    {%- set pip_version \u003d \u0027pip3\u0027 -%}"},{"line_number":39,"context_line":"{%- endif -%}"},{"line_number":40,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":41,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"},{"line_number":42,"context_line":"    {{ packages | join(\u0027 \u0027) }}"},{"line_number":43,"context_line":"{%- else -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_5c52e436","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":18},"in_reply_to":"9f560f44_bc7340b4","updated":"2020-09-17 12:12:25.000000000","message":"What about people willing to use a specific python 3.x version? You\u0027ll need to call {{ distro_python_version }} -m pip which is really the same than having a pip variable.\n\nIf you don\u0027t install python3-pip the python pip module won\u0027t be available with CentOS release, so it won\u0027t work.\n\nJust stick with what distribution provides and let people have their custom versions if they want, it\u0027s just a matter of a variable that already exist.\n\nWith the current notation, both, customers with specific version and us as a generic solution are happy.\n\nDon\u0027t forget that we still have train supported that use both, PY27 and PY3X.","commit_id":"1b18476ce01ce5822ac47ed01844a59df8804bc5"}]}