)]}'
{"kolla/common/config.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d1193882a9880a442b139d33983704d39d11a88c","unresolved":true,"context_lines":[{"line_number":279,"context_line":"               help\u003d\u0027Temporary directory to be used during squashing\u0027),"},{"line_number":280,"context_line":"    cfg.BoolOpt(\u0027clean_package_cache\u0027, default\u003dTrue,"},{"line_number":281,"context_line":"                help\u003d\u0027Clean all package cache.\u0027),"},{"line_number":282,"context_line":"    cfg.StrOpt(\u0027allowed-to-fail\u0027,"},{"line_number":283,"context_line":"               help\u003d\u0027Images which are allowed to fail\u0027),"},{"line_number":284,"context_line":"]"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"0ebd139b_8e58e55d","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":14},"updated":"2021-01-13 11:05:27.000000000","message":"ListOpt?","commit_id":"caed14d238ca1c7bfadb0de60191dcc064340272"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ad44192161136e1f1837ae480a803d114051afdf","unresolved":false,"context_lines":[{"line_number":279,"context_line":"               help\u003d\u0027Temporary directory to be used during squashing\u0027),"},{"line_number":280,"context_line":"    cfg.BoolOpt(\u0027clean_package_cache\u0027, default\u003dTrue,"},{"line_number":281,"context_line":"                help\u003d\u0027Clean all package cache.\u0027),"},{"line_number":282,"context_line":"    cfg.StrOpt(\u0027allowed-to-fail\u0027,"},{"line_number":283,"context_line":"               help\u003d\u0027Images which are allowed to fail\u0027),"},{"line_number":284,"context_line":"]"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"f4c831eb_01155279","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":14},"in_reply_to":"0ebd139b_8e58e55d","updated":"2021-01-14 12:34:27.000000000","message":"Ack","commit_id":"caed14d238ca1c7bfadb0de60191dcc064340272"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8f6938603b02abf8b9c88449594469c378796acf","unresolved":false,"context_lines":[{"line_number":274,"context_line":"               help\u003d\u0027Temporary directory to be used during squashing\u0027),"},{"line_number":275,"context_line":"    cfg.BoolOpt(\u0027clean_package_cache\u0027, default\u003dTrue,"},{"line_number":276,"context_line":"                help\u003d\u0027Clean all package cache.\u0027),"},{"line_number":277,"context_line":"    cfg.ListOpt(\u0027allowed-to-fail\u0027, default\u003d[],"},{"line_number":278,"context_line":"                help\u003d\u0027Images which are allowed to fail\u0027),"},{"line_number":279,"context_line":"]"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"77225bff_44def06f","line":277,"range":{"start_line":277,"start_character":35,"end_line":277,"end_character":46},"updated":"2021-01-16 11:58:09.000000000","message":"default added because of this:\n\n  File \"/home/hrw/devel/linaro/kolla/kolla/image/build.py\", line 1243, in get_image_statuses\n    if image.name in self.conf.allowed_to_fail:\nTypeError: argument of type \u0027NoneType\u0027 is not iterable","commit_id":"7f699540a37e3dcbac4b187cd72cb30b7da5cca0"}],"kolla/image/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ef870d9aaacfa7526a6ef7f19b2a2f0f89c3342f","unresolved":true,"context_lines":[{"line_number":1132,"context_line":"                LOG.debug(\u0027Skipping parent image %s\u0027, image.name)"},{"line_number":1133,"context_line":"                image.status \u003d Status.SKIPPED"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"    def summary(self, conf):"},{"line_number":1136,"context_line":"        \"\"\"Walk the dictionary of images statuses and print results.\"\"\""},{"line_number":1137,"context_line":"        # For debug we print the logs again if the image error\u0027d. This is to"},{"line_number":1138,"context_line":"        # help us debug and it will be extra helpful in the gate."}],"source_content_type":"text/x-python","patch_set":7,"id":"cc452945_5d932204","line":1135,"range":{"start_line":1135,"start_character":22,"end_line":1135,"end_character":26},"updated":"2021-01-13 09:42:13.000000000","message":"nit: self.conf","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eb0e877c1d4686fa4123e3eccba6bef0194cae41","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"                LOG.debug(\u0027Skipping parent image %s\u0027, image.name)"},{"line_number":1133,"context_line":"                image.status \u003d Status.SKIPPED"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"    def summary(self, conf):"},{"line_number":1136,"context_line":"        \"\"\"Walk the dictionary of images statuses and print results.\"\"\""},{"line_number":1137,"context_line":"        # For debug we print the logs again if the image error\u0027d. This is to"},{"line_number":1138,"context_line":"        # help us debug and it will be extra helpful in the gate."}],"source_content_type":"text/x-python","patch_set":7,"id":"8392d525_d09cec4f","line":1135,"range":{"start_line":1135,"start_character":22,"end_line":1135,"end_character":26},"in_reply_to":"cc452945_5d932204","updated":"2021-01-13 09:48:05.000000000","message":"Ack","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ef870d9aaacfa7526a6ef7f19b2a2f0f89c3342f","unresolved":true,"context_lines":[{"line_number":1167,"context_line":"            all_bad_statuses.update(self.image_statuses_allowed_to_fail)"},{"line_number":1168,"context_line":"            for name, status in sorted(all_bad_statuses.items()):"},{"line_number":1169,"context_line":"                if name in self.image_statuses_allowed_to_fail:"},{"line_number":1170,"context_line":"                    LOG.error(\u0027%s Failed with status: %s (safe to ignore)\u0027,"},{"line_number":1171,"context_line":"                              name, status.value)"},{"line_number":1172,"context_line":"                else:"},{"line_number":1173,"context_line":"                    LOG.error(\u0027%s Failed with status: %s\u0027, name, status.value)"}],"source_content_type":"text/x-python","patch_set":7,"id":"10ae0019_48b7a694","line":1170,"range":{"start_line":1170,"start_character":58,"end_line":1170,"end_character":72},"updated":"2021-01-13 09:42:13.000000000","message":"\u0027allowed to fail\u0027 would be more consistent","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eb0e877c1d4686fa4123e3eccba6bef0194cae41","unresolved":false,"context_lines":[{"line_number":1167,"context_line":"            all_bad_statuses.update(self.image_statuses_allowed_to_fail)"},{"line_number":1168,"context_line":"            for name, status in sorted(all_bad_statuses.items()):"},{"line_number":1169,"context_line":"                if name in self.image_statuses_allowed_to_fail:"},{"line_number":1170,"context_line":"                    LOG.error(\u0027%s Failed with status: %s (safe to ignore)\u0027,"},{"line_number":1171,"context_line":"                              name, status.value)"},{"line_number":1172,"context_line":"                else:"},{"line_number":1173,"context_line":"                    LOG.error(\u0027%s Failed with status: %s\u0027, name, status.value)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9d6e8b9e_d254fd29","line":1170,"range":{"start_line":1170,"start_character":58,"end_line":1170,"end_character":72},"in_reply_to":"10ae0019_48b7a694","updated":"2021-01-13 09:48:05.000000000","message":"Ack","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ef870d9aaacfa7526a6ef7f19b2a2f0f89c3342f","unresolved":true,"context_lines":[{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        return results"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"    def get_image_statuses(self, conf):"},{"line_number":1223,"context_line":"        if any([self.image_statuses_bad,"},{"line_number":1224,"context_line":"                self.image_statuses_good,"},{"line_number":1225,"context_line":"                self.image_statuses_unmatched,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ec4ab9aa_2b33e543","line":1222,"range":{"start_line":1222,"start_character":33,"end_line":1222,"end_character":37},"updated":"2021-01-13 09:42:13.000000000","message":"nit: self.conf","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eb0e877c1d4686fa4123e3eccba6bef0194cae41","unresolved":false,"context_lines":[{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        return results"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"    def get_image_statuses(self, conf):"},{"line_number":1223,"context_line":"        if any([self.image_statuses_bad,"},{"line_number":1224,"context_line":"                self.image_statuses_good,"},{"line_number":1225,"context_line":"                self.image_statuses_unmatched,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ab764e56_ad70cb1c","line":1222,"range":{"start_line":1222,"start_character":33,"end_line":1222,"end_character":37},"in_reply_to":"ec4ab9aa_2b33e543","updated":"2021-01-13 09:48:05.000000000","message":"Ack","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"}],"kolla/tests/test_build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ef870d9aaacfa7526a6ef7f19b2a2f0f89c3342f","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        kolla.image_statuses_allowed_to_fail[\u0027bad2\u0027] \u003d build.Status.ERROR"},{"line_number":652,"context_line":"        kolla.image_statuses_unmatched[\u0027unmatched\u0027] \u003d build.Status.UNMATCHED"},{"line_number":653,"context_line":"        results \u003d kolla.summary(self.conf)"},{"line_number":654,"context_line":"        self.assertEqual(\u0027error\u0027, results[\u0027failed\u0027][0][\u0027status\u0027])"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    @mock.patch(\u0027shutil.copytree\u0027)"},{"line_number":657,"context_line":"    def test_work_dir(self, copytree_mock):"}],"source_content_type":"text/x-python","patch_set":7,"id":"81903f56_ccfb77f9","line":654,"updated":"2021-01-13 09:42:13.000000000","message":"We could check that bad and bad2 are both in the failed results.","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eb0e877c1d4686fa4123e3eccba6bef0194cae41","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        kolla.image_statuses_allowed_to_fail[\u0027bad2\u0027] \u003d build.Status.ERROR"},{"line_number":652,"context_line":"        kolla.image_statuses_unmatched[\u0027unmatched\u0027] \u003d build.Status.UNMATCHED"},{"line_number":653,"context_line":"        results \u003d kolla.summary(self.conf)"},{"line_number":654,"context_line":"        self.assertEqual(\u0027error\u0027, results[\u0027failed\u0027][0][\u0027status\u0027])"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    @mock.patch(\u0027shutil.copytree\u0027)"},{"line_number":657,"context_line":"    def test_work_dir(self, copytree_mock):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ace7b0e0_cdeb4805","line":654,"in_reply_to":"81903f56_ccfb77f9","updated":"2021-01-13 09:48:05.000000000","message":"Ack","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"828ceaad2ae5d4f442889cdb1851ec7fa4e0f9b9","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        kolla.image_statuses_allowed_to_fail[\u0027bad2\u0027] \u003d build.Status.ERROR"},{"line_number":652,"context_line":"        kolla.image_statuses_unmatched[\u0027unmatched\u0027] \u003d build.Status.UNMATCHED"},{"line_number":653,"context_line":"        results \u003d kolla.summary(self.conf)"},{"line_number":654,"context_line":"        self.assertEqual(\u0027error\u0027, results[\u0027failed\u0027][0][\u0027status\u0027])"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    @mock.patch(\u0027shutil.copytree\u0027)"},{"line_number":657,"context_line":"    def test_work_dir(self, copytree_mock):"}],"source_content_type":"text/x-python","patch_set":7,"id":"76e73c56_8917e9dd","line":654,"in_reply_to":"ace7b0e0_cdeb4805","updated":"2021-01-13 10:04:39.000000000","message":"Ack","commit_id":"859a85c0eee4be29de5aaf2ed82ad1e334207bc4"}],"tests/playbooks/run.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8985eba3f4081650c9df331774bc4704d87ea77b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"        # and since we don\u0027t need isolated networks here, use host networking"},{"line_number":16,"context_line":"        network_mode: host"},{"line_number":17,"context_line":"        work_dir: \"{{ kolla_work_dir }}\""},{"line_number":18,"context_line":"        allowed_to_fail: monasca-thresh, test"},{"line_number":19,"context_line":"  tasks:"},{"line_number":20,"context_line":"    - name: Ensure /etc/kolla exists"},{"line_number":21,"context_line":"      file:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f149efe_d0d1297f","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":45},"updated":"2021-01-20 09:53:11.000000000","message":"Let\u0027s use another patch to define which images we allow to fail in CI. And test doesn\u0027t exist.","commit_id":"92ed215d52c6c4d62074a2561a45a8abd2b039d6"}]}