)]}'
{"id":"openstack%2Fkolla~766413","triplet_id":"openstack%2Fkolla~master~Id70771333b6241a45e8b94a2e25ded403975b298","project":"openstack/kolla","branch":"master","hashtags":[],"change_id":"Id70771333b6241a45e8b94a2e25ded403975b298","subject":"keepalived: Remove pid files for keepalived","status":"ABANDONED","created":"2020-12-10 08:35:20.000000000","updated":"2021-12-30 14:29:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6f4fb0dd22bfd71f20b04a04063c8ee19b5d3bb9","_number":766413,"virtual_id_number":766413,"owner":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-12-10 10:56:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-10 09:17:55.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"CC"},{"updated":"2020-12-10 09:39:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-12-10 10:05:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c205a1b4c012fec623e3d30ed376a36e412ac659","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"date":"2020-12-10 08:35:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2c209e9b60539866de1e3dc355b47faf39427d0e","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-12-10 09:17:55.000000000","message":"Patch Set 1:\n\nhmm, another pid file in keepalived? Is not it supposed to be the same?\nBTW, we can just use `rm -f` and avoid the `if`","accounts_in_message":[],"_revision_number":1},{"id":"e5c9bd20133942ac9c0cf6b2fcf391b117775832","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-10 09:39:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- kolla-build-centos8-source-aarch64 https://zuul.opendev.org/t/openstack/build/9dc78e59881542ad9976766d45278fca : FAILURE in 13m 27s (non-voting)\n- kolla-build-debian-source-aarch64 https://zuul.opendev.org/t/openstack/build/2b3c32272e12473bb1b3c3cdd30aaa7a : FAILURE in 49m 20s (non-voting)\n- kolla-ansible-debian-source-aarch64 https://zuul.opendev.org/t/openstack/build/ee5fdacbe54c4846a8743a73bfa5c2e1 : FAILURE in 37m 03s (non-voting)\n- kolla-build-ubuntu-source-aarch64 https://zuul.opendev.org/t/openstack/build/5d1dd70d0014410da26d954c37dae654 : FAILURE in 52m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8db2854361be98d18a5e7a5c2350a195c88148ad","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-10 10:05:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- kolla-build-centos8-binary https://zuul.opendev.org/t/openstack/build/1bb3717a21a94f7180db8af801dee733 : FAILURE in 7m 16s (non-voting)\n- kolla-build-centos8-source https://zuul.opendev.org/t/openstack/build/998893e50dfe4ae0b4b203e29eb1d509 : FAILURE in 6m 57s\n- kolla-ansible-centos8-source https://zuul.opendev.org/t/openstack/build/1d28f34de7fd41b1ae2c1024c8cd3df6 : FAILURE in 11m 53s\n- kolla-ansible-centos8-binary https://zuul.opendev.org/t/openstack/build/4b2e3556944d4491975c89bbc7336701 : FAILURE in 11m 15s (non-voting)\n- kolla-ansible-centos8-source-upgrade https://zuul.opendev.org/t/openstack/build/92ccabaeae844fc493263eec643d1af3 : FAILURE in 11m 50s\n- kolla-build-debian-source https://zuul.opendev.org/t/openstack/build/d9a066a9c221408392846527453e29fb : SUCCESS in 30m 33s (non-voting)\n- kolla-build-debian-binary https://zuul.opendev.org/t/openstack/build/153c21da8f3f48ac90d241b37db3179a : FAILURE in 21m 20s (non-voting)\n- kolla-ansible-debian-source https://zuul.opendev.org/t/openstack/build/752ce6349dbf456b9dcfa092e2e567f4 : FAILURE in 22m 08s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a377b51c0a224db6806e90686231b059 : SUCCESS in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/08025e03b911471f8505853813ba2db9 : SUCCESS in 3m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/122df4a67eb347748da27c4fbb5ac94b : SUCCESS in 3m 45s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/abbc8505bc08423dba34e3df7a8affd9 : SUCCESS in 3m 58s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b991c8b6d7f4b4eaea1aeff7c8002a8 : SUCCESS in 5m 32s\n- kolla-build-ubuntu-binary https://zuul.opendev.org/t/openstack/build/0d52f3f39b6145148af8077c5fca0141 : FAILURE in 21m 00s (non-voting)\n- kolla-build-ubuntu-source https://zuul.opendev.org/t/openstack/build/05e1b635834441248775679c1f17d8d9 : FAILURE in 33m 27s\n- kolla-ansible-ubuntu-source https://zuul.opendev.org/t/openstack/build/71484fbb39e4480ba2257878764a3da3 : FAILURE in 19m 56s\n- kolla-ansible-ubuntu-binary https://zuul.opendev.org/t/openstack/build/132bbcd479c04ca7bafaa6cb615ef23b : FAILURE in 19m 33s (non-voting)\n- kolla-ansible-ubuntu-source-upgrade https://zuul.opendev.org/t/openstack/build/e4a752a6527740009c19647e144e521a : FAILURE in 19m 46s","accounts_in_message":[],"_revision_number":1},{"id":"7e9f5168e12cb31b209bd43e178b6f676b692ccf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"date":"2020-12-10 10:12:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bb30055980a53e886a35a4a2b09af2f12efd94cc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"date":"2020-12-10 10:16:51.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"18d003da965419d75a9e4ed1d90894ca13d12448","author":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"date":"2020-12-10 10:20:41.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 1:\n\u003e \n\u003e hmm, another pid file in keepalived? Is not it supposed to be the same?\n\u003e BTW, we can just use `rm -f` and avoid the `if`\n\nKeepalived will generate 2 child processes, there will be a total of 3 pid files.\nkeepalived.pid, checkers.pid, vrrp.pid.","accounts_in_message":[],"_revision_number":2},{"id":"60ed4f8d1b0e4834a6487b8386b7085d637014cd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-10 10:56:19.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- kolla-build-centos8-binary https://zuul.opendev.org/t/openstack/build/b69d119193dc475c836aad94649b1f87 : FAILURE in 7m 14s (non-voting)\n- kolla-build-centos8-source https://zuul.opendev.org/t/openstack/build/b0509245f93d483e92ae3919f0b1f7c6 : FAILURE in 7m 40s\n- kolla-ansible-centos8-source https://zuul.opendev.org/t/openstack/build/d508d336b6bc4ba385ec177a49c0df2d : FAILURE in 10m 57s\n- kolla-ansible-centos8-binary https://zuul.opendev.org/t/openstack/build/a9192273cafd4288a6ef7549faeb3e85 : FAILURE in 11m 30s (non-voting)\n- kolla-ansible-centos8-source-upgrade https://zuul.opendev.org/t/openstack/build/74908bf51e19470380b6e9c512c9de42 : FAILURE in 11m 00s\n- kolla-build-debian-source https://zuul.opendev.org/t/openstack/build/02052ed4cd124abdabc8f9aa78672c99 : SUCCESS in 33m 29s (non-voting)\n- kolla-build-debian-binary https://zuul.opendev.org/t/openstack/build/712119259e154de98e54b877812f0943 : SUCCESS in 17m 44s (non-voting)\n- kolla-ansible-debian-source https://zuul.opendev.org/t/openstack/build/acf4b4817ce4405fa96b0b0ca698f8a5 : FAILURE in 18m 38s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2fbd7312c8544f7a8781910b4fdb047e : SUCCESS in 4m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/93608a9d7cba493fa1b2db284f83f19d : SUCCESS in 4m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fd46a4112d034e29a66951345383ea92 : SUCCESS in 4m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b19a3256d2e742348ec89c7a93156342 : SUCCESS in 3m 46s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e447e8ab046f4cd4948e0f889ab9d84d : SUCCESS in 7m 17s\n- kolla-build-ubuntu-binary https://zuul.opendev.org/t/openstack/build/1bb7348707ac49d2ad83d87486f25baa : SUCCESS in 26m 43s (non-voting)\n- kolla-build-ubuntu-source https://zuul.opendev.org/t/openstack/build/9748ce3f95564369aa44f1598a084609 : SUCCESS in 35m 09s\n- kolla-ansible-ubuntu-source https://zuul.opendev.org/t/openstack/build/c2082b4cc956490cb6fccfc226173518 : FAILURE in 17m 29s\n- kolla-ansible-ubuntu-binary https://zuul.opendev.org/t/openstack/build/6bdb7ac3c68d4c03ae08d77c626e8ac3 : FAILURE in 18m 22s (non-voting)\n- kolla-ansible-ubuntu-source-upgrade https://zuul.opendev.org/t/openstack/build/255b073e66ea4d7caab297b2d8de0e41 : FAILURE in 16m 45s","accounts_in_message":[],"_revision_number":3},{"id":"5f43eb6f8db767abc73233e8d1930fc12bdca0f7","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-10 11:10:07.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- kolla-build-centos8-source-aarch64 https://zuul.opendev.org/t/openstack/build/5bc65aa3febe4f839933898040016fe4 : FAILURE in 9m 44s (non-voting)\n- kolla-build-debian-source-aarch64 https://zuul.opendev.org/t/openstack/build/23b623052da7425f8b4651b867183981 : SUCCESS in 40m 11s (non-voting)\n- kolla-ansible-debian-source-aarch64 https://zuul.opendev.org/t/openstack/build/886c883347564d95b2dcda107b9c14c8 : FAILURE in 32m 27s (non-voting)\n- kolla-build-ubuntu-source-aarch64 https://zuul.opendev.org/t/openstack/build/97085576fa774cf7b49f2fc1c786c735 : SUCCESS in 43m 06s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6f4fb0dd22bfd71f20b04a04063c8ee19b5d3bb9","tag":"autogenerated:gerrit:abandon","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-12-30 14:29:22.000000000","message":"Abandoned\n\nno update for more than a year, abandoning","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"dc7e9fef8ba50ea4c109db5be7f992b0f7045ec5","revisions":{"1fc817cb5af9a0b2d5b37d68cbf0638e4e35d569":{"kind":"REWORK","_number":1,"created":"2020-12-10 08:35:20.000000000","uploader":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"ref":"refs/changes/13/766413/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/13/766413/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/13/766413/1"}}},"commit":{"parents":[{"commit":"c682a0fe84d28f9b5d01c6c6c90ae0338ff331f0","subject":"Merge \"docs: add code reviews to contributor guide\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/c682a0fe84d28f9b5d01c6c6c90ae0338ff331f0"}]}],"author":{"name":"wanghongxu","email":"wanghongxu@t2cloud.net","date":"2020-12-10 08:11:08.000000000","tz":480},"committer":{"name":"wanghongxu","email":"wanghongxu@t2cloud.net","date":"2020-12-10 08:34:29.000000000","tz":480},"subject":"keepalived: Remove checkers.pid file for keepalived","message":"keepalived: Remove checkers.pid file for keepalived\n\nRemove the checkers.pid file for keepalived. We don\u0027t really need it.\n\nCloses-Bug: #1907543\nChange-Id: Id70771333b6241a45e8b94a2e25ded403975b298\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1fc817cb5af9a0b2d5b37d68cbf0638e4e35d569"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1fc817cb5af9a0b2d5b37d68cbf0638e4e35d569"}]},"branch":"refs/heads/master"},"0a5c615a18f7f4ead5c94c2cc0c11b1cd6c98f45":{"kind":"REWORK","_number":2,"created":"2020-12-10 10:12:48.000000000","uploader":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"ref":"refs/changes/13/766413/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/13/766413/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/13/766413/2"}}},"commit":{"parents":[{"commit":"c682a0fe84d28f9b5d01c6c6c90ae0338ff331f0","subject":"Merge \"docs: add code reviews to contributor guide\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/c682a0fe84d28f9b5d01c6c6c90ae0338ff331f0"}]}],"author":{"name":"wanghongxu","email":"wanghongxu@t2cloud.net","date":"2020-12-10 08:11:08.000000000","tz":480},"committer":{"name":"wanghongxu","email":"wanghongxu@t2cloud.net","date":"2020-12-10 10:12:19.000000000","tz":480},"subject":"keepalived: Remove pid files for keepalived","message":"keepalived: Remove pid files for keepalived\n\nRemove the checkers.pid file for keepalived. We don\u0027t really need it.\n\nCloses-Bug: #1907543\nChange-Id: Id70771333b6241a45e8b94a2e25ded403975b298\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/0a5c615a18f7f4ead5c94c2cc0c11b1cd6c98f45"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/0a5c615a18f7f4ead5c94c2cc0c11b1cd6c98f45"}]},"branch":"refs/heads/master"},"dc7e9fef8ba50ea4c109db5be7f992b0f7045ec5":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-12-10 10:16:51.000000000","uploader":{"_account_id":22905,"name":"wanghongxu","email":"wang19930902@gmail.com","username":"wanghongxu"},"ref":"refs/changes/13/766413/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/13/766413/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/13/766413/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/13/766413/3"}}},"commit":{"parents":[{"commit":"c682a0fe84d28f9b5d01c6c6c90ae0338ff331f0","subject":"Merge \"docs: add code reviews to contributor guide\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/c682a0fe84d28f9b5d01c6c6c90ae0338ff331f0"}]}],"author":{"name":"wanghongxu","email":"wanghongxu@t2cloud.net","date":"2020-12-10 08:11:08.000000000","tz":480},"committer":{"name":"wanghongxu","email":"wanghongxu@t2cloud.net","date":"2020-12-10 10:15:13.000000000","tz":480},"subject":"keepalived: Remove pid files for keepalived","message":"keepalived: Remove pid files for keepalived\n\nRemove multiple pid files when the container starts.\nWe don\u0027t really need it.\n\nCloses-Bug: #1907543\nChange-Id: Id70771333b6241a45e8b94a2e25ded403975b298\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/dc7e9fef8ba50ea4c109db5be7f992b0f7045ec5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/dc7e9fef8ba50ea4c109db5be7f992b0f7045ec5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}