)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cfe5ff1652e773ddd843e80b7b4c87a944863657","unresolved":true,"context_lines":[{"line_number":12,"context_line":"When installing from PyPI, as we do in source images, running"},{"line_number":13,"context_line":"the latest pip+setuptools+wheel is recommended."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Coauthored-by: Marcin Juszkiewicz \u003cmarcin.juszkiewicz@linaro.org\u003e"},{"line_number":16,"context_line":"Change-Id: I4ae3a82cc796a60450c2a35beba32972964bc5d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baa64165_a0e169fe","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"updated":"2021-11-25 10:20:38.000000000","message":"co-authored","commit_id":"6a0deb8491f892335ed7965ac542e86be1a5efcb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f23f5fe893213cd1e29a494e9b29694c7282962f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db34e96f_2fe1cd38","updated":"2021-11-23 11:54:06.000000000","message":"\u003e Patch Set 3: Code-Review-1\n\u003e \n\u003e (2 comments)\n\u003e \n\u003e Do we also need to change kolla-toolbox?\n\ndone","commit_id":"5ece97a27ce69be96fb921c6060a16e0b9f040b1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"61873b681775ce3fd606088c97c9c743174d0829","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"553862ca_edaab4fa","updated":"2021-11-25 15:06:36.000000000","message":"+ Maybe it would be nice to let users know that now kolla images are upgrading pip and friends to last version through reno, wouldn\u0027t be ? ","commit_id":"27a0609ab98c80fec4cf3ffab63261f5f00dbf1b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f87a9f8ac1ce7d901284ec38732aa1be4f4ebc53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"452ce519_b78ee98e","updated":"2021-11-25 15:03:07.000000000","message":"Current patchset covers everything except docker/openvswitch/openvswitch-netcontrold/Dockerfile.j2. Can you add same patch also for this image ? Openvswitch-netcontrold inherits from openvswitch-base and openvswitch-base inherits from base, and this chain doesn\u0027t include patch for upgrade pip and friends.\n\nI\u0027m just wondering, wouldn\u0027t be fine to add this installation (pip, wheel, setuptools) to base image to have it on one place ?  For me it makes sense, what do you think ? \n\n","commit_id":"27a0609ab98c80fec4cf3ffab63261f5f00dbf1b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8e9adaf5ecdf8074f16d1e407a7caa8a6330543c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f624b5c7_044a1fa4","updated":"2021-11-25 11:08:34.000000000","message":"I mean, I shouldn\u0027t +2 my own change.","commit_id":"27a0609ab98c80fec4cf3ffab63261f5f00dbf1b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a03fc78ff84e05049b51c2ff18f89484904189a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f7a56e4c_57e30b32","in_reply_to":"452ce519_b78ee98e","updated":"2021-11-25 15:22:17.000000000","message":"\u003e Current patchset covers everything except docker/openvswitch/openvswitch-netcontrold/Dockerfile.j2. Can you add same patch also for this image ? Openvswitch-netcontrold inherits from openvswitch-base and openvswitch-base inherits from base, and this chain doesn\u0027t include patch for upgrade pip and friends.\n\nnetcontrold is installed into system Python and I do not change system pip/wheel/setuptools. Kolla-toolbox and everything derived from openstack-base use virtualenv.\n\n\u003e I\u0027m just wondering, wouldn\u0027t be fine to add this installation (pip, wheel, setuptools) to base image to have it on one place ?  For me it makes sense, what do you think ? \n\nNo - infra images do not need to take extra storage space.","commit_id":"27a0609ab98c80fec4cf3ffab63261f5f00dbf1b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cdcac5ca562b186b56955b1cc88e8f963a285837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f0007317_8f029204","in_reply_to":"4cc366be_bc26b877","updated":"2021-11-25 15:28:13.000000000","message":"\u003e Will write one.\n\nThanks","commit_id":"27a0609ab98c80fec4cf3ffab63261f5f00dbf1b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a03fc78ff84e05049b51c2ff18f89484904189a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4cc366be_bc26b877","in_reply_to":"553862ca_edaab4fa","updated":"2021-11-25 15:22:17.000000000","message":"Will write one.","commit_id":"27a0609ab98c80fec4cf3ffab63261f5f00dbf1b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cdcac5ca562b186b56955b1cc88e8f963a285837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"78063edb_49066df9","in_reply_to":"f7a56e4c_57e30b32","updated":"2021-11-25 15:28:13.000000000","message":"\u003e \u003e Current patchset covers everything except docker/openvswitch/openvswitch-netcontrold/Dockerfile.j2. Can you add same patch also for this image ? Openvswitch-netcontrold inherits from openvswitch-base and openvswitch-base inherits from base, and this chain doesn\u0027t include patch for upgrade pip and friends.\n\u003e \n\u003e netcontrold is installed into system Python and I do not change system pip/wheel/setuptools. Kolla-toolbox and everything derived from openstack-base use virtualenv.\nOk, makes sense.\n\u003e \n\u003e \u003e I\u0027m just wondering, wouldn\u0027t be fine to add this installation (pip, wheel, setuptools) to base image to have it on one place ?  For me it makes sense, what do you think ? \n\u003e \n\u003e No - infra images do not need to take extra storage space.\nOk,","commit_id":"27a0609ab98c80fec4cf3ffab63261f5f00dbf1b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"30fbd81e8f686d666684905fff1c5a0b03799cc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6d400bcd_aad91a42","updated":"2021-12-04 19:56:43.000000000","message":"ping cores","commit_id":"a41001f7143a1a60f0334f20206481335b14141a"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"83ffc82812f971c37f96ba336155b6471f56c365","unresolved":true,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"RUN pip install --upgrade pip \u0026\u0026 pip install --upgrade setuptools wheel"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"RUN {{ macros.install_pip(openstack_base_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bdafc773_69f0004c","line":325,"updated":"2021-07-29 10:11:08.000000000","message":"merge into one RUN?","commit_id":"afbd99de86b54746f88b633f90c8a4ee576efc8d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cdaa3142e7b1edab75e59566221448877e14bc66","unresolved":true,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"RUN pip install --upgrade pip \u0026\u0026 pip install --upgrade setuptools wheel"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"RUN {{ macros.install_pip(openstack_base_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"31cf81e2_b62f67a2","line":333,"range":{"start_line":333,"start_character":0,"end_line":333,"end_character":71},"updated":"2021-10-05 08:40:58.000000000","message":"Should use install_pip macro","commit_id":"87db942abe343da7747a9a45fa2607312bf5248c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f23f5fe893213cd1e29a494e9b29694c7282962f","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"RUN pip install --upgrade pip \u0026\u0026 pip install --upgrade setuptools wheel"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"RUN {{ macros.install_pip(openstack_base_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b21eae67_637451b8","line":333,"range":{"start_line":333,"start_character":0,"end_line":333,"end_character":71},"in_reply_to":"31cf81e2_b62f67a2","updated":"2021-11-23 11:54:06.000000000","message":"Done","commit_id":"87db942abe343da7747a9a45fa2607312bf5248c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cdaa3142e7b1edab75e59566221448877e14bc66","unresolved":true,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"RUN pip install --upgrade pip \u0026\u0026 pip install --upgrade setuptools wheel"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"RUN {{ macros.install_pip(openstack_base_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"{% endif %}"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"19dd525d_fb2978e0","line":335,"range":{"start_line":333,"start_character":0,"end_line":335,"end_character":3},"updated":"2021-10-05 08:40:58.000000000","message":"Would be nice to combine layers.","commit_id":"87db942abe343da7747a9a45fa2607312bf5248c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f23f5fe893213cd1e29a494e9b29694c7282962f","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"RUN pip install --upgrade pip \u0026\u0026 pip install --upgrade setuptools wheel"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"RUN {{ macros.install_pip(openstack_base_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"{% endif %}"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"92dc1085_ee992b2b","line":335,"range":{"start_line":333,"start_character":0,"end_line":335,"end_character":3},"in_reply_to":"19dd525d_fb2978e0","updated":"2021-11-23 11:54:06.000000000","message":"Done","commit_id":"87db942abe343da7747a9a45fa2607312bf5248c"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"44e9d690f254f4a99012f2104026d82a91e6bd06","unresolved":true,"context_lines":[{"line_number":325,"context_line":"    \u0026\u0026 mkdir -p /var/lib/kolla \\"},{"line_number":326,"context_line":"    \u0026\u0026 {{ macros.install_pip([\u0027virtualenv\u0027])}} \\"},{"line_number":327,"context_line":"    \u0026\u0026 virtualenv --system-site-packages /var/lib/kolla/venv \\"},{"line_number":328,"context_line":"    \u0026\u0026 {{ macros.install_pip([\u0027pip\u0027, \u0027wheel\u0027, \u0027setuptools\u0027]) }}"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"e2d3117a_5d159f56","line":328,"updated":"2021-11-23 12:04:22.000000000","message":"The intention here is to install/upgrade global packages and not the ones in venv?","commit_id":"5ece97a27ce69be96fb921c6060a16e0b9f040b1"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8c4187e65c0a0077bfbcc30635b76c22b3b3e23","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    \u0026\u0026 mkdir -p /var/lib/kolla \\"},{"line_number":326,"context_line":"    \u0026\u0026 {{ macros.install_pip([\u0027virtualenv\u0027])}} \\"},{"line_number":327,"context_line":"    \u0026\u0026 virtualenv --system-site-packages /var/lib/kolla/venv \\"},{"line_number":328,"context_line":"    \u0026\u0026 {{ macros.install_pip([\u0027pip\u0027, \u0027wheel\u0027, \u0027setuptools\u0027]) }}"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"18d5907e_390d1da8","line":328,"in_reply_to":"e2d3117a_5d159f56","updated":"2021-11-23 12:45:09.000000000","message":"Right!\n\nFixed.","commit_id":"5ece97a27ce69be96fb921c6060a16e0b9f040b1"}],"releasenotes/notes/upgrade-pip-44352805d60bbf7f.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c7f072bc3d96450a0c4d9f9d6f3983268e32ee41","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \u0027kolla-toolbox\u0027 and all images derived from \u0027openstack-base\u0027 one have"},{"line_number":5,"context_line":"    basic Python packages (\u0027pip\u0027, \u0027wheel\u0027, \u0027setuptools\u0027) upgraded to latest"},{"line_number":6,"context_line":"    versions."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"14bbbca8_41a6b9c1","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":5},"updated":"2021-11-25 16:03:55.000000000","message":"use `","commit_id":"03ef81f8cad1ac6d81bc45c910a01eb2667a1948"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7001c557a267017147145b312c08b783faa4f834","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    \u0027kolla-toolbox\u0027 and all images derived from \u0027openstack-base\u0027 one have"},{"line_number":5,"context_line":"    basic Python packages (\u0027pip\u0027, \u0027wheel\u0027, \u0027setuptools\u0027) upgraded to latest"},{"line_number":6,"context_line":"    versions."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"221954a8_57242dae","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":5},"in_reply_to":"14bbbca8_41a6b9c1","updated":"2021-11-26 07:42:29.000000000","message":"I would actually suggest ``kolla-toolbox`` etc., so this renders as nice monospace font.","commit_id":"03ef81f8cad1ac6d81bc45c910a01eb2667a1948"}]}