)]}'
{"docker/octavia/octavia-base/extend_start.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c37a2c783db908dc14d91dcbdcd854968cdfc94c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":"if [[ $(stat -c %U:%G ${OCTAVIA_LOG_DIR}) !\u003d \"octavia:kolla\" ]]; then"},{"line_number":11,"context_line":"    chown -R octavia:kolla /var/log/kolla/octavia"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":"if [[ $(stat -c %a ${OCTAVIA_LOG_DIR}) !\u003d \"755\" ]]; then"},{"line_number":14,"context_line":"    chmod 755 ${OCTAVIA_LOG_DIR}"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a1cd516a_8b56b6e2","line":12,"updated":"2021-03-30 15:13:49.000000000","message":"Unsure why we need to do it in both config.json and extend_start.sh?","commit_id":"ad9edf8a54a902e50385e4455431594379a34523"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc2c3b8d720b29c3a58926c9f9daa0a4ced007f7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":"if [[ $(stat -c %U:%G ${OCTAVIA_LOG_DIR}) !\u003d \"octavia:kolla\" ]]; then"},{"line_number":11,"context_line":"    chown -R octavia:kolla /var/log/kolla/octavia"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":"if [[ $(stat -c %a ${OCTAVIA_LOG_DIR}) !\u003d \"755\" ]]; then"},{"line_number":14,"context_line":"    chmod 755 ${OCTAVIA_LOG_DIR}"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a90cc566_20606e20","line":12,"in_reply_to":"a1cd516a_8b56b6e2","updated":"2021-03-30 16:49:27.000000000","message":"For consistency. Workflow is as follows:\n1. First start of octavia_api:\n - set_configs doesn\u0027t set permissions for /var/log/kolla/octavia because it doesn\u0027t exist.\n - extend_start creates /var/log/kolla/octavia and sets permissions for octavia:kolla\n2. Restart of octavia_api:\n - set_configs sets octavia:octavia permissions recursively for /var/log/kolla/octavia\n - extend_start sets octavia:kolla permissions\nAnd so on, and so on.\n\nWe could probably just set to octavia:octavia - but I found that in most of the places we do $USER:kolla probably for fluentd logs access?","commit_id":"ad9edf8a54a902e50385e4455431594379a34523"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cae4f31e9671e03f37f0132be3c917d812fb4753","unresolved":true,"context_lines":[{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":"if [[ $(stat -c %U:%G ${OCTAVIA_LOG_DIR}) !\u003d \"octavia:kolla\" ]]; then"},{"line_number":11,"context_line":"    chown -R octavia:kolla /var/log/kolla/octavia"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":"if [[ $(stat -c %a ${OCTAVIA_LOG_DIR}) !\u003d \"755\" ]]; then"},{"line_number":14,"context_line":"    chmod 755 ${OCTAVIA_LOG_DIR}"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"42b9cbe4_7bf2d2ee","line":12,"in_reply_to":"a90cc566_20606e20","updated":"2021-03-31 08:31:25.000000000","message":"I can see why it needs to be consistent if it\u0027s in both places, but why does it need to be in both places? I guess it doesn\u0027t matter too much.","commit_id":"ad9edf8a54a902e50385e4455431594379a34523"}]}
