)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7fbd762b1e45ba215b77d688ebdc768341daa576","unresolved":true,"context_lines":[{"line_number":13,"context_line":"each repo source file, point to proper key. And this is what this patch"},{"line_number":14,"context_line":"does."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Both distros use the same lists now."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"More info: https://michael-prokop.at/blog/2021/02/16/how-to-properly-use-3rd-party-debian-repository-signing-keys-with-apt/"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"e938137d_d631037c","line":16,"range":{"start_line":16,"start_character":26,"end_line":16,"end_character":32},"updated":"2021-08-04 13:07:12.000000000","message":"key list","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f03a1f48eca6d053ad7e93a4066731dbd1556590","unresolved":true,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"},{"line_number":352,"context_line":"{% set remote_apt_keys \u003d ["},{"line_number":353,"context_line":"   {\u0027name\u0027: \u0027debian-openstack\u0027, \u0027url\u0027: \u0027http://buster-victoria.debian.net/debian/dists/pubkey.gpg\u0027},"},{"line_number":354,"context_line":"   {\u0027name\u0027: \u0027elasticsearch\u0027, \u0027url\u0027: \u0027https://artifacts.elastic.co/GPG-KEY-elasticsearch\u0027},"},{"line_number":355,"context_line":"   {\u0027name\u0027: \u0027grafana\u0027, \u0027url\u0027: \u0027https://packages.grafana.com/gpg.key\u0027},"},{"line_number":356,"context_line":"   {\u0027name\u0027: \u0027influxdb\u0027, \u0027url\u0027: \u0027https://repos.influxdata.com/influxdb.key\u0027},"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"66c43c95_0f335ee3","line":353,"range":{"start_line":353,"start_character":0,"end_line":353,"end_character":5},"updated":"2021-04-06 11:28:12.000000000","message":"http://bullseye-wallaby.debian.net/debian/dists/pubkey.gpg will need to be here later","commit_id":"54d5991db141b8f25072069edacfb27a9a05a908"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3ed7c93dc7618ee42c2a72d1da4b3e4dd1bf2ab1","unresolved":true,"context_lines":[{"line_number":351,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"},{"line_number":352,"context_line":"{% set remote_apt_keys \u003d ["},{"line_number":353,"context_line":"   {\u0027name\u0027: \u0027debian-openstack\u0027, \u0027url\u0027: \u0027http://buster-victoria.debian.net/debian/dists/pubkey.gpg\u0027},"},{"line_number":354,"context_line":"   {\u0027name\u0027: \u0027elasticsearch\u0027, \u0027url\u0027: \u0027https://artifacts.elastic.co/GPG-KEY-elasticsearch\u0027},"},{"line_number":355,"context_line":"   {\u0027name\u0027: \u0027grafana\u0027, \u0027url\u0027: \u0027https://packages.grafana.com/gpg.key\u0027},"},{"line_number":356,"context_line":"   {\u0027name\u0027: \u0027influxdb\u0027, \u0027url\u0027: \u0027https://repos.influxdata.com/influxdb.key\u0027},"},{"line_number":357,"context_line":"   {\u0027name\u0027: \u0027linaro\u0027, \u0027url\u0027: \u0027https://obs.linaro.org/repos/home:/marcin.juszkiewicz/debian-buster/Release.key\u0027},"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6fcab395_5d00e302","line":354,"updated":"2021-04-06 12:37:03.000000000","message":"Wouldn\u0027t it be better to define the type for all keys ?\nMaybe it is only my opinion .. but for me it is nicer to iterate through this dict and render key.name , key.type ..and not default(\u0027asc\u0027) as it is on L371.\n\nBut as I said ..maybe it is only my opinion.","commit_id":"54d5991db141b8f25072069edacfb27a9a05a908"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e761f0068a3fa41175fad889afc507353bb90a3b","unresolved":true,"context_lines":[{"line_number":351,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"},{"line_number":352,"context_line":"{% set remote_apt_keys \u003d ["},{"line_number":353,"context_line":"   {\u0027name\u0027: \u0027debian-openstack\u0027, \u0027url\u0027: \u0027http://buster-victoria.debian.net/debian/dists/pubkey.gpg\u0027},"},{"line_number":354,"context_line":"   {\u0027name\u0027: \u0027elasticsearch\u0027, \u0027url\u0027: \u0027https://artifacts.elastic.co/GPG-KEY-elasticsearch\u0027},"},{"line_number":355,"context_line":"   {\u0027name\u0027: \u0027grafana\u0027, \u0027url\u0027: \u0027https://packages.grafana.com/gpg.key\u0027},"},{"line_number":356,"context_line":"   {\u0027name\u0027: \u0027influxdb\u0027, \u0027url\u0027: \u0027https://repos.influxdata.com/influxdb.key\u0027},"},{"line_number":357,"context_line":"   {\u0027name\u0027: \u0027linaro\u0027, \u0027url\u0027: \u0027https://obs.linaro.org/repos/home:/marcin.juszkiewicz/debian-buster/Release.key\u0027},"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"87ba5fb4_d5469e3d","line":354,"in_reply_to":"6fcab395_5d00e302","updated":"2021-04-06 12:41:31.000000000","message":"I had to add \u0027type\u0027 after having all working fine for Debian. Mariadb key is used in Ubuntu only. Going that way was imho clearer.","commit_id":"54d5991db141b8f25072069edacfb27a9a05a908"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3ed7c93dc7618ee42c2a72d1da4b3e4dd1bf2ab1","unresolved":true,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"{% block base_ubuntu_package_installation %}"},{"line_number":364,"context_line":"    {%- block base_ubuntu_package_key_installation %}"},{"line_number":365,"context_line":"        {% for key in base_apt_keys | customizable(\u0027apt_keys\u0027) %}"},{"line_number":366,"context_line":"            {%- if loop.first %}RUN {% else %} \u0026\u0026 {% endif %}apt-key adv --no-tty --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 {{ key }}"},{"line_number":367,"context_line":"            {%- if not loop.last %} \\"},{"line_number":368,"context_line":"            {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f627ecb_e087b528","line":365,"updated":"2021-04-06 12:37:03.000000000","message":"Shouldn\u0027t be also rewrited ?","commit_id":"54d5991db141b8f25072069edacfb27a9a05a908"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e761f0068a3fa41175fad889afc507353bb90a3b","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"{% block base_ubuntu_package_installation %}"},{"line_number":364,"context_line":"    {%- block base_ubuntu_package_key_installation %}"},{"line_number":365,"context_line":"        {% for key in base_apt_keys | customizable(\u0027apt_keys\u0027) %}"},{"line_number":366,"context_line":"            {%- if loop.first %}RUN {% else %} \u0026\u0026 {% endif %}apt-key adv --no-tty --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 {{ key }}"},{"line_number":367,"context_line":"            {%- if not loop.last %} \\"},{"line_number":368,"context_line":"            {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"8c627326_92391293","line":365,"in_reply_to":"3f627ecb_e087b528","updated":"2021-04-06 12:41:31.000000000","message":"This part I want to deprecate in separate patch and then drop in next release.\n\nNow it is for those potential users who has \u0027apt_keys\u0027 in their template overrides.","commit_id":"54d5991db141b8f25072069edacfb27a9a05a908"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5f189bc8e59371d839cf34f386af679c3056d5d9","unresolved":true,"context_lines":[{"line_number":349,"context_line":"] %}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"},{"line_number":352,"context_line":"{% set remote_apt_keys \u003d ["},{"line_number":353,"context_line":"   {\u0027name\u0027: \u0027elasticsearch\u0027, \u0027url\u0027: \u0027https://artifacts.elastic.co/GPG-KEY-elasticsearch\u0027},"},{"line_number":354,"context_line":"   {\u0027name\u0027: \u0027grafana\u0027, \u0027url\u0027: \u0027https://packages.grafana.com/gpg.key\u0027},"},{"line_number":355,"context_line":"   {\u0027name\u0027: \u0027influxdb\u0027, \u0027url\u0027: \u0027https://repos.influxdata.com/influxdb.key\u0027},"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1b197905_67901098","line":352,"range":{"start_line":352,"start_character":7,"end_line":352,"end_character":22},"updated":"2021-04-07 08:33:38.000000000","message":"This changes the format, which could trip up operators who are overriding this list.","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"664142cc82c502d12bccf368fe8e92d69c15d365","unresolved":true,"context_lines":[{"line_number":349,"context_line":"] %}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"},{"line_number":352,"context_line":"{% set remote_apt_keys \u003d ["},{"line_number":353,"context_line":"   {\u0027name\u0027: \u0027elasticsearch\u0027, \u0027url\u0027: \u0027https://artifacts.elastic.co/GPG-KEY-elasticsearch\u0027},"},{"line_number":354,"context_line":"   {\u0027name\u0027: \u0027grafana\u0027, \u0027url\u0027: \u0027https://packages.grafana.com/gpg.key\u0027},"},{"line_number":355,"context_line":"   {\u0027name\u0027: \u0027influxdb\u0027, \u0027url\u0027: \u0027https://repos.influxdata.com/influxdb.key\u0027},"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"01600fe6_cc2d3c15","line":352,"range":{"start_line":352,"start_character":7,"end_line":352,"end_character":22},"in_reply_to":"1b197905_67901098","updated":"2021-04-07 08:47:49.000000000","message":"This way they will be noticed by failed build. If we just rename then their override will be ignored.","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5f189bc8e59371d839cf34f386af679c3056d5d9","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            {% endif -%}"},{"line_number":368,"context_line":"        {% endfor %}"},{"line_number":369,"context_line":"        {% for key in remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":370,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \u0026\u0026 curl {{ key.url }} -s -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":371,"context_line":"            {%- if not loop.last %} \\"},{"line_number":372,"context_line":"            {% endif -%}"},{"line_number":373,"context_line":"        {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"c36e241a_bc692542","line":370,"range":{"start_line":370,"start_character":46,"end_line":370,"end_character":56},"updated":"2021-04-07 08:33:38.000000000","message":"Is there a more \u0027standard\u0027 directory we should use? The blog post suggests /usr/share/keyrings.","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b575b92585260ccdbdca5d0c53beae72dd98ee15","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            {% endif -%}"},{"line_number":368,"context_line":"        {% endfor %}"},{"line_number":369,"context_line":"        {% for key in remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":370,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \u0026\u0026 curl {{ key.url }} -s -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":371,"context_line":"            {%- if not loop.last %} \\"},{"line_number":372,"context_line":"            {% endif -%}"},{"line_number":373,"context_line":"        {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b5d95bd6_e00d6239","line":370,"range":{"start_line":370,"start_character":101,"end_line":370,"end_character":103},"updated":"2021-04-07 07:50:20.000000000","message":"drop it, we control with curlrc","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c56cc04bcb4bd1cb144babadf7d274505c07586c","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            {% endif -%}"},{"line_number":368,"context_line":"        {% endfor %}"},{"line_number":369,"context_line":"        {% for key in remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":370,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \u0026\u0026 curl {{ key.url }} -s -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":371,"context_line":"            {%- if not loop.last %} \\"},{"line_number":372,"context_line":"            {% endif -%}"},{"line_number":373,"context_line":"        {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e2b46289_02e87133","line":370,"range":{"start_line":370,"start_character":101,"end_line":370,"end_character":103},"in_reply_to":"11f833b5_d89a32d9","updated":"2021-04-07 07:59:34.000000000","message":"Oh shoot! We should fix that. We were relying on all curl executions following that config.","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"096d7f7593e2af962506d6dc187375defcdf3970","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            {% endif -%}"},{"line_number":368,"context_line":"        {% endfor %}"},{"line_number":369,"context_line":"        {% for key in remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":370,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \u0026\u0026 curl {{ key.url }} -s -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":371,"context_line":"            {%- if not loop.last %} \\"},{"line_number":372,"context_line":"            {% endif -%}"},{"line_number":373,"context_line":"        {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"11f833b5_d89a32d9","line":370,"range":{"start_line":370,"start_character":101,"end_line":370,"end_character":103},"in_reply_to":"b5d95bd6_e00d6239","updated":"2021-04-07 07:55:31.000000000","message":"Our curlrc is later - here curl output is visible without that \"-s\".","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"664142cc82c502d12bccf368fe8e92d69c15d365","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            {% endif -%}"},{"line_number":368,"context_line":"        {% endfor %}"},{"line_number":369,"context_line":"        {% for key in remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":370,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \u0026\u0026 curl {{ key.url }} -s -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":371,"context_line":"            {%- if not loop.last %} \\"},{"line_number":372,"context_line":"            {% endif -%}"},{"line_number":373,"context_line":"        {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"76b04794_c15b04cc","line":370,"range":{"start_line":370,"start_character":46,"end_line":370,"end_character":56},"in_reply_to":"c36e241a_bc692542","updated":"2021-04-07 08:47:49.000000000","message":"We can use any directory - /etc/kolla/ was in one local version of patch and stayed.\n\nIMHO it is as good as any other one - at least it is visible who added those keys.","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e29928b4bdb7979e6d95e0b86e664e2e9c8699a6","unresolved":true,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"{#"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"NOTE(hrw): please use fingerprints of gnupg key id in base_apt_keys"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"F77F1EDA57EBB1CC -- Erlang PPA key"},{"line_number":334,"context_line":"F6609E60DC62814E -- RabbitMQ Signing Key \u003cinfo@rabbitmq.com\u003e"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"af2b585e_089d81d8","line":331,"range":{"start_line":331,"start_character":11,"end_line":331,"end_character":67},"updated":"2021-05-17 13:35:08.000000000","message":"why not short ids? (that seem to be more popular)","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f4e0f0e500973c5124ee99964b62cc6f7b1b36b2","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"{#"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"NOTE(hrw): please use fingerprints of gnupg key id in base_apt_keys"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"F77F1EDA57EBB1CC -- Erlang PPA key"},{"line_number":334,"context_line":"F6609E60DC62814E -- RabbitMQ Signing Key \u003cinfo@rabbitmq.com\u003e"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"45ccb8c8_c3a839d4","line":331,"range":{"start_line":331,"start_character":11,"end_line":331,"end_character":67},"in_reply_to":"af2b585e_089d81d8","updated":"2021-05-17 16:31:30.000000000","message":"Done","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e29928b4bdb7979e6d95e0b86e664e2e9c8699a6","unresolved":true,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"NOTE(hrw): please use fingerprints of gnupg key id in base_apt_keys"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"F77F1EDA57EBB1CC -- Erlang PPA key"},{"line_number":334,"context_line":"F6609E60DC62814E -- RabbitMQ Signing Key \u003cinfo@rabbitmq.com\u003e"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"#}"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"d0b0ce53_08afb749","line":334,"range":{"start_line":333,"start_character":0,"end_line":334,"end_character":60},"updated":"2021-05-17 13:35:08.000000000","message":"this is no longer useful if we change below","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f4e0f0e500973c5124ee99964b62cc6f7b1b36b2","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"NOTE(hrw): please use fingerprints of gnupg key id in base_apt_keys"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"F77F1EDA57EBB1CC -- Erlang PPA key"},{"line_number":334,"context_line":"F6609E60DC62814E -- RabbitMQ Signing Key \u003cinfo@rabbitmq.com\u003e"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"#}"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"6a174a38_d1a1ebe3","line":334,"range":{"start_line":333,"start_character":0,"end_line":334,"end_character":60},"in_reply_to":"d0b0ce53_08afb749","updated":"2021-05-17 16:31:30.000000000","message":"Done","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e29928b4bdb7979e6d95e0b86e664e2e9c8699a6","unresolved":true,"context_lines":[{"line_number":336,"context_line":"#}"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":339,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027B279943D2A549531E144B875F77F1EDA57EBB1CC\u0027},"},{"line_number":340,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027, \u0027keyid\u0027: \u00278C695B0219AFDEB04A058ED8F4E789204D206F89\u0027},"},{"line_number":341,"context_line":"] %}"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"d45281b0_d7261183","line":339,"range":{"start_line":339,"start_character":34,"end_line":339,"end_character":74},"updated":"2021-05-17 13:35:08.000000000","message":"why not use the short ones? (the ones rabbitmq docs talk about, the ones just above)","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f4e0f0e500973c5124ee99964b62cc6f7b1b36b2","unresolved":false,"context_lines":[{"line_number":336,"context_line":"#}"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":339,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027B279943D2A549531E144B875F77F1EDA57EBB1CC\u0027},"},{"line_number":340,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027, \u0027keyid\u0027: \u00278C695B0219AFDEB04A058ED8F4E789204D206F89\u0027},"},{"line_number":341,"context_line":"] %}"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"eff9f8e7_5ee97f23","line":339,"range":{"start_line":339,"start_character":34,"end_line":339,"end_character":74},"in_reply_to":"d45281b0_d7261183","updated":"2021-05-17 16:31:30.000000000","message":"Done","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e29928b4bdb7979e6d95e0b86e664e2e9c8699a6","unresolved":true,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":339,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027B279943D2A549531E144B875F77F1EDA57EBB1CC\u0027},"},{"line_number":340,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027, \u0027keyid\u0027: \u00278C695B0219AFDEB04A058ED8F4E789204D206F89\u0027},"},{"line_number":341,"context_line":"] %}"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"44fd5b94_49677896","line":340,"range":{"start_line":340,"start_character":34,"end_line":340,"end_character":74},"updated":"2021-05-17 13:35:08.000000000","message":"ditto above","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f4e0f0e500973c5124ee99964b62cc6f7b1b36b2","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":339,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027B279943D2A549531E144B875F77F1EDA57EBB1CC\u0027},"},{"line_number":340,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027, \u0027keyid\u0027: \u00278C695B0219AFDEB04A058ED8F4E789204D206F89\u0027},"},{"line_number":341,"context_line":"] %}"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"8650b9e4_add9425f","line":340,"range":{"start_line":340,"start_character":34,"end_line":340,"end_character":74},"in_reply_to":"44fd5b94_49677896","updated":"2021-05-17 16:31:30.000000000","message":"Done","commit_id":"11a60e438af93ecce75aa19eb2e722fa5ebe1809"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7fbd762b1e45ba215b77d688ebdc768341daa576","unresolved":true,"context_lines":[{"line_number":266,"context_line":"COPY dpkg_reducing_disk_footprint /etc/dpkg/dpkg.cfg.d/dpkg_reducing_disk_footprint"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"{% block base_ubuntu_package_pre %}"},{"line_number":269,"context_line":"# curl and ca-certificates to fetch remote keys via http"},{"line_number":270,"context_line":"# gnupg to fetch keys directly from keyserver"},{"line_number":271,"context_line":"{% set base_ubuntu_package_pre_packages \u003d ["},{"line_number":272,"context_line":"    \u0027ca-certificates\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"e9a86164_eaf95d88","line":269,"range":{"start_line":269,"start_character":52,"end_line":269,"end_character":56},"updated":"2021-08-04 13:07:12.000000000","message":"https I hope :-)","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"76958e22c30ecfafda7aa53be1727c4aa0e9b277","unresolved":true,"context_lines":[{"line_number":266,"context_line":"COPY dpkg_reducing_disk_footprint /etc/dpkg/dpkg.cfg.d/dpkg_reducing_disk_footprint"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"{% block base_ubuntu_package_pre %}"},{"line_number":269,"context_line":"# curl and ca-certificates to fetch remote keys via http"},{"line_number":270,"context_line":"# gnupg to fetch keys directly from keyserver"},{"line_number":271,"context_line":"{% set base_ubuntu_package_pre_packages \u003d ["},{"line_number":272,"context_line":"    \u0027ca-certificates\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"a8779383_39db6563","line":269,"range":{"start_line":269,"start_character":52,"end_line":269,"end_character":56},"in_reply_to":"ae9ab9b4_3cb4f76d","updated":"2021-08-04 14:28:47.000000000","message":"😄","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5888e2b0a52112b9d41d709595916b326212270c","unresolved":true,"context_lines":[{"line_number":266,"context_line":"COPY dpkg_reducing_disk_footprint /etc/dpkg/dpkg.cfg.d/dpkg_reducing_disk_footprint"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"{% block base_ubuntu_package_pre %}"},{"line_number":269,"context_line":"# curl and ca-certificates to fetch remote keys via http"},{"line_number":270,"context_line":"# gnupg to fetch keys directly from keyserver"},{"line_number":271,"context_line":"{% set base_ubuntu_package_pre_packages \u003d ["},{"line_number":272,"context_line":"    \u0027ca-certificates\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"ae9ab9b4_3cb4f76d","line":269,"range":{"start_line":269,"start_character":52,"end_line":269,"end_character":56},"in_reply_to":"e9a86164_eaf95d88","updated":"2021-08-04 13:27:00.000000000","message":"If someone needs to use plain http then feel free. We do not judge. Just do not send such ones for merging.","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7fbd762b1e45ba215b77d688ebdc768341daa576","unresolved":true,"context_lines":[{"line_number":322,"context_line":"   \u0027tgt\u0027"},{"line_number":323,"context_line":"] %}"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"{#"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"F77F1EDA57EBB1CC -- Erlang PPA key"},{"line_number":328,"context_line":"F6609E60DC62814E -- RabbitMQ Signing Key \u003cinfo@rabbitmq.com\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"#}"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":333,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027F77F1EDA57EBB1CC\u0027},"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"9a0ea31d_a0f1fdd8","line":330,"range":{"start_line":325,"start_character":0,"end_line":330,"end_character":2},"updated":"2021-08-04 13:07:12.000000000","message":"this is not so useful now we have a dict below, I suggest removing","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5888e2b0a52112b9d41d709595916b326212270c","unresolved":false,"context_lines":[{"line_number":322,"context_line":"   \u0027tgt\u0027"},{"line_number":323,"context_line":"] %}"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"{#"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"F77F1EDA57EBB1CC -- Erlang PPA key"},{"line_number":328,"context_line":"F6609E60DC62814E -- RabbitMQ Signing Key \u003cinfo@rabbitmq.com\u003e"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"#}"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":333,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027F77F1EDA57EBB1CC\u0027},"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"c635e155_a4f0d460","line":330,"range":{"start_line":325,"start_character":0,"end_line":330,"end_character":2},"in_reply_to":"9a0ea31d_a0f1fdd8","updated":"2021-08-04 13:27:00.000000000","message":"Ack","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7fbd762b1e45ba215b77d688ebdc768341daa576","unresolved":true,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"#}"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":333,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027F77F1EDA57EBB1CC\u0027},"},{"line_number":334,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027, \u0027keyid\u0027: \u0027F6609E60DC62814E\u0027},"},{"line_number":335,"context_line":"] %}"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"},{"line_number":338,"context_line":"{% set remote_apt_keys \u003d ["},{"line_number":339,"context_line":"   {\u0027name\u0027: \u0027elasticsearch\u0027, \u0027url\u0027: \u0027https://artifacts.elastic.co/GPG-KEY-elasticsearch\u0027},"},{"line_number":340,"context_line":"   {\u0027name\u0027: \u0027grafana\u0027, \u0027url\u0027: \u0027https://packages.grafana.com/gpg.key\u0027},"},{"line_number":341,"context_line":"   {\u0027name\u0027: \u0027influxdb\u0027, \u0027url\u0027: \u0027https://repos.influxdata.com/influxdb.key\u0027},"},{"line_number":342,"context_line":"   {\u0027name\u0027: \u0027mariadb\u0027, \u0027url\u0027: \u0027https://downloads.mariadb.com/MariaDB/mariadb-keyring-2019.gpg\u0027, \u0027type\u0027: \u0027gpg\u0027},"},{"line_number":343,"context_line":"   {\u0027name\u0027: \u0027treasuredata\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-td-agent\u0027},"},{"line_number":344,"context_line":"] %}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"{% block base_ubuntu_package_installation %}"},{"line_number":347,"context_line":"    {%- block base_ubuntu_package_key_installation %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"c155b6fe_3d57cc07","line":344,"range":{"start_line":332,"start_character":0,"end_line":344,"end_character":4},"updated":"2021-08-04 13:07:12.000000000","message":"since we are breaking the promise anyway - why not use a new name for the variable keeping all our keys - either via url or keyid? we could also deprecate the previous variables and keep their logic for this release AND for us only use the new common variable - wdyt?","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5888e2b0a52112b9d41d709595916b326212270c","unresolved":true,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"#}"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":333,"context_line":"   {\u0027name\u0027: \u0027erlang\u0027,   \u0027keyid\u0027: \u0027F77F1EDA57EBB1CC\u0027},"},{"line_number":334,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027, \u0027keyid\u0027: \u0027F6609E60DC62814E\u0027},"},{"line_number":335,"context_line":"] %}"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"{# NOTE(hrw): type field defaults to \u0027asc\u0027 which is used for single keys #}"},{"line_number":338,"context_line":"{% set remote_apt_keys \u003d ["},{"line_number":339,"context_line":"   {\u0027name\u0027: \u0027elasticsearch\u0027, \u0027url\u0027: \u0027https://artifacts.elastic.co/GPG-KEY-elasticsearch\u0027},"},{"line_number":340,"context_line":"   {\u0027name\u0027: \u0027grafana\u0027, \u0027url\u0027: \u0027https://packages.grafana.com/gpg.key\u0027},"},{"line_number":341,"context_line":"   {\u0027name\u0027: \u0027influxdb\u0027, \u0027url\u0027: \u0027https://repos.influxdata.com/influxdb.key\u0027},"},{"line_number":342,"context_line":"   {\u0027name\u0027: \u0027mariadb\u0027, \u0027url\u0027: \u0027https://downloads.mariadb.com/MariaDB/mariadb-keyring-2019.gpg\u0027, \u0027type\u0027: \u0027gpg\u0027},"},{"line_number":343,"context_line":"   {\u0027name\u0027: \u0027treasuredata\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-td-agent\u0027},"},{"line_number":344,"context_line":"] %}"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"{% block base_ubuntu_package_installation %}"},{"line_number":347,"context_line":"    {%- block base_ubuntu_package_key_installation %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"5b6228a9_d43a6a36","line":344,"range":{"start_line":332,"start_character":0,"end_line":344,"end_character":4},"in_reply_to":"c155b6fe_3d57cc07","updated":"2021-08-04 13:27:00.000000000","message":"With names reuse if someone override them in template-overrides then build will fail so they notice format change. Otherwise keys will be ignored.\n\nAnd I dislike content of next block enough to not going for making it more complicated by going into one list idea. Feel free to propose patch which will do it. But do it in separate one.","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"}],"kolla/template/methods.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b575b92585260ccdbdca5d0c53beae72dd98ee15","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                commands +\u003d \u0027 %s %s\u0027 % (rpm_switch, repo_list[repo])"},{"line_number":116,"context_line":"            elif base_package_type \u003d\u003d \u0027deb\u0027:"},{"line_number":117,"context_line":"                if mode \u003d\u003d \u0027enable\u0027:"},{"line_number":118,"context_line":"                    commands +\u003d f\"\"\"echo \u0027Uris: {repo_list[repo][\u0027url\u0027]}\u0027 \\"},{"line_number":119,"context_line":"\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":120,"context_line":"\u0026\u0026 echo \u0027Components: {repo_list[repo][\u0027component\u0027]}\u0027 \\"},{"line_number":121,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":122,"context_line":"\u0026\u0026 echo \u0027Types: deb\u0027 \u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":123,"context_line":"\u0026\u0026 echo \u0027Suites: {repo_list[repo][\u0027suite\u0027]}\u0027 \\"},{"line_number":124,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":125,"context_line":"\u0026\u0026 echo \u0027Signed-By: /etc/kolla/apt-keys/{repo_list[repo][\u0027gpg_key\u0027]}\u0027 \\"},{"line_number":126,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":127,"context_line":"\u0026\u0026 \"\"\""},{"line_number":128,"context_line":"        except KeyError:"},{"line_number":129,"context_line":"            # NOTE(hrw): we ignore missing repositories for a given"},{"line_number":130,"context_line":"            # distro/arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"4b71f5ea_729f33b7","line":127,"range":{"start_line":118,"start_character":32,"end_line":127,"end_character":6},"updated":"2021-04-07 07:50:20.000000000","message":"I cried just a little. It would probably be better off templated outside of dockerfile and copied.","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"096d7f7593e2af962506d6dc187375defcdf3970","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                commands +\u003d \u0027 %s %s\u0027 % (rpm_switch, repo_list[repo])"},{"line_number":116,"context_line":"            elif base_package_type \u003d\u003d \u0027deb\u0027:"},{"line_number":117,"context_line":"                if mode \u003d\u003d \u0027enable\u0027:"},{"line_number":118,"context_line":"                    commands +\u003d f\"\"\"echo \u0027Uris: {repo_list[repo][\u0027url\u0027]}\u0027 \\"},{"line_number":119,"context_line":"\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":120,"context_line":"\u0026\u0026 echo \u0027Components: {repo_list[repo][\u0027component\u0027]}\u0027 \\"},{"line_number":121,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":122,"context_line":"\u0026\u0026 echo \u0027Types: deb\u0027 \u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":123,"context_line":"\u0026\u0026 echo \u0027Suites: {repo_list[repo][\u0027suite\u0027]}\u0027 \\"},{"line_number":124,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":125,"context_line":"\u0026\u0026 echo \u0027Signed-By: /etc/kolla/apt-keys/{repo_list[repo][\u0027gpg_key\u0027]}\u0027 \\"},{"line_number":126,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":127,"context_line":"\u0026\u0026 \"\"\""},{"line_number":128,"context_line":"        except KeyError:"},{"line_number":129,"context_line":"            # NOTE(hrw): we ignore missing repositories for a given"},{"line_number":130,"context_line":"            # distro/arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"d03ac65c_2a0e11fa","line":127,"range":{"start_line":118,"start_character":32,"end_line":127,"end_character":6},"in_reply_to":"4b71f5ea_729f33b7","updated":"2021-04-07 07:55:31.000000000","message":"You cried just a little, I lost hairs writing it.\n\nany code improvements are welcome","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5f189bc8e59371d839cf34f386af679c3056d5d9","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                commands +\u003d \u0027 %s %s\u0027 % (rpm_switch, repo_list[repo])"},{"line_number":116,"context_line":"            elif base_package_type \u003d\u003d \u0027deb\u0027:"},{"line_number":117,"context_line":"                if mode \u003d\u003d \u0027enable\u0027:"},{"line_number":118,"context_line":"                    commands +\u003d f\"\"\"echo \u0027Uris: {repo_list[repo][\u0027url\u0027]}\u0027 \\"},{"line_number":119,"context_line":"\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":120,"context_line":"\u0026\u0026 echo \u0027Components: {repo_list[repo][\u0027component\u0027]}\u0027 \\"},{"line_number":121,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":122,"context_line":"\u0026\u0026 echo \u0027Types: deb\u0027 \u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":123,"context_line":"\u0026\u0026 echo \u0027Suites: {repo_list[repo][\u0027suite\u0027]}\u0027 \\"},{"line_number":124,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":125,"context_line":"\u0026\u0026 echo \u0027Signed-By: /etc/kolla/apt-keys/{repo_list[repo][\u0027gpg_key\u0027]}\u0027 \\"},{"line_number":126,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":127,"context_line":"\u0026\u0026 \"\"\""},{"line_number":128,"context_line":"        except KeyError:"},{"line_number":129,"context_line":"            # NOTE(hrw): we ignore missing repositories for a given"},{"line_number":130,"context_line":"            # distro/arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a77549e_2b771db8","line":127,"range":{"start_line":118,"start_character":32,"end_line":127,"end_character":6},"in_reply_to":"d03ac65c_2a0e11fa","updated":"2021-04-07 08:33:38.000000000","message":"Or implemented as a script","commit_id":"9d665dcbf21feea1789eaf45d1993593cf8f078e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c0cee6b6605b9deea49d0a04e9cc353a791ee9c5","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                commands +\u003d \u0027 %s %s\u0027 % (rpm_switch, repo_list[repo])"},{"line_number":116,"context_line":"            elif base_package_type \u003d\u003d \u0027deb\u0027:"},{"line_number":117,"context_line":"                if mode \u003d\u003d \u0027enable\u0027:"},{"line_number":118,"context_line":"                    commands +\u003d f\"\"\"echo \u0027Uris: {repo_list[repo][\u0027url\u0027]}\u0027 \\"},{"line_number":119,"context_line":"\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":120,"context_line":"\u0026\u0026 echo \u0027Components: {repo_list[repo][\u0027component\u0027]}\u0027 \\"},{"line_number":121,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":122,"context_line":"\u0026\u0026 echo \u0027Types: deb\u0027 \u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":123,"context_line":"\u0026\u0026 echo \u0027Suites: {repo_list[repo][\u0027suite\u0027]}\u0027 \\"},{"line_number":124,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":125,"context_line":"\u0026\u0026 echo \u0027Signed-By: /etc/kolla/apt-keys/{repo_list[repo][\u0027gpg_key\u0027]}\u0027 \\"},{"line_number":126,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":127,"context_line":"\u0026\u0026 \"\"\""},{"line_number":128,"context_line":"        except KeyError:"},{"line_number":129,"context_line":"            # NOTE(hrw): we ignore missing repositories for a given"},{"line_number":130,"context_line":"            # distro/arch"}],"source_content_type":"text/x-python","patch_set":12,"id":"963e6706_a07c4a4d","line":127,"range":{"start_line":118,"start_character":0,"end_line":127,"end_character":6},"updated":"2021-04-22 07:41:35.000000000","message":"This looks like hacker language ;-)","commit_id":"6d3bc9232bfdb6b504f149e95ac3884c547ffee1"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e81fcce30cf0776d4a39998631261e3322af3c50","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                commands +\u003d \u0027 %s %s\u0027 % (rpm_switch, repo_list[repo])"},{"line_number":116,"context_line":"            elif base_package_type \u003d\u003d \u0027deb\u0027:"},{"line_number":117,"context_line":"                if mode \u003d\u003d \u0027enable\u0027:"},{"line_number":118,"context_line":"                    commands +\u003d f\"\"\"echo \u0027Uris: {repo_list[repo][\u0027url\u0027]}\u0027 \\"},{"line_number":119,"context_line":"\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":120,"context_line":"\u0026\u0026 echo \u0027Components: {repo_list[repo][\u0027component\u0027]}\u0027 \\"},{"line_number":121,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":122,"context_line":"\u0026\u0026 echo \u0027Types: deb\u0027 \u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":123,"context_line":"\u0026\u0026 echo \u0027Suites: {repo_list[repo][\u0027suite\u0027]}\u0027 \\"},{"line_number":124,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":125,"context_line":"\u0026\u0026 echo \u0027Signed-By: /etc/kolla/apt-keys/{repo_list[repo][\u0027gpg_key\u0027]}\u0027 \\"},{"line_number":126,"context_line":"\u003e\u003e/etc/apt/sources.list.d/{repo}.sources \\"},{"line_number":127,"context_line":"\u0026\u0026 \"\"\""},{"line_number":128,"context_line":"        except KeyError:"},{"line_number":129,"context_line":"            # NOTE(hrw): we ignore missing repositories for a given"},{"line_number":130,"context_line":"            # distro/arch"}],"source_content_type":"text/x-python","patch_set":12,"id":"2f70b8da_19f85666","line":127,"range":{"start_line":118,"start_character":0,"end_line":127,"end_character":6},"in_reply_to":"963e6706_a07c4a4d","updated":"2021-04-22 07:44:58.000000000","message":"patches welcome ;D\n\nTBH I had no idea how to write it nicer","commit_id":"6d3bc9232bfdb6b504f149e95ac3884c547ffee1"}],"kolla/template/repos.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c0cee6b6605b9deea49d0a04e9cc353a791ee9c5","unresolved":true,"context_lines":[{"line_number":60,"context_line":"debian:"},{"line_number":61,"context_line":"  elasticsearch:"},{"line_number":62,"context_line":"    url: \"https://artifacts.elastic.co/packages/oss-7.x/apt\""},{"line_number":63,"context_line":"    suite: \"stable\""},{"line_number":64,"context_line":"    component: \"main\""},{"line_number":65,"context_line":"    gpg_key: \"elasticsearch.asc\""},{"line_number":66,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bd119052_980f1bdd","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":9},"updated":"2021-04-22 07:41:35.000000000","message":"I think it\u0027s called distribution in APT?","commit_id":"6d3bc9232bfdb6b504f149e95ac3884c547ffee1"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e81fcce30cf0776d4a39998631261e3322af3c50","unresolved":false,"context_lines":[{"line_number":60,"context_line":"debian:"},{"line_number":61,"context_line":"  elasticsearch:"},{"line_number":62,"context_line":"    url: \"https://artifacts.elastic.co/packages/oss-7.x/apt\""},{"line_number":63,"context_line":"    suite: \"stable\""},{"line_number":64,"context_line":"    component: \"main\""},{"line_number":65,"context_line":"    gpg_key: \"elasticsearch.asc\""},{"line_number":66,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"be5ceebe_5722973a","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":9},"in_reply_to":"bd119052_980f1bdd","updated":"2021-04-22 07:44:58.000000000","message":"No. Suite.","commit_id":"6d3bc9232bfdb6b504f149e95ac3884c547ffee1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f0f0323b70ac898977947e42a5e4a29583977d7b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"debian:"},{"line_number":61,"context_line":"  elasticsearch:"},{"line_number":62,"context_line":"    url: \"https://artifacts.elastic.co/packages/oss-7.x/apt\""},{"line_number":63,"context_line":"    suite: \"stable\""},{"line_number":64,"context_line":"    component: \"main\""},{"line_number":65,"context_line":"    gpg_key: \"elasticsearch.asc\""},{"line_number":66,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e2b3bc78_f385c2cd","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":9},"in_reply_to":"be5ceebe_5722973a","updated":"2021-04-22 07:50:59.000000000","message":"suite is stable/unstable/etc, codename is buster/focal/etc, and Debian says you put either suite or codename into distrbution field 😄\n\nThe distribution part (stable in this case) specifies a subdirectory in $ARCHIVE_ROOT/dists. It can contain additional slashes to specify subdirectories nested deeper, eg. stable/updates. distribution typically corresponds to Suite or Codename specified in the Release files.\nhttps://wiki.debian.org/SourcesList\n\nBut whatever ;)","commit_id":"6d3bc9232bfdb6b504f149e95ac3884c547ffee1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7fbd762b1e45ba215b77d688ebdc768341daa576","unresolved":true,"context_lines":[{"line_number":60,"context_line":"  grafana: \"deb https://packages.grafana.com/oss/deb stable main\""},{"line_number":61,"context_line":"  influxdb: \"deb https://repos.influxdata.com/debian buster stable\""},{"line_number":62,"context_line":"  logstash: \"deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main\""},{"line_number":63,"context_line":"  kibana: \"deb [arch\u003damd64] https://artifacts.elastic.co/packages/oss-7.x/apt stable main\""},{"line_number":64,"context_line":"  rabbitmq: \"deb https://packagecloud.io/rabbitmq/rabbitmq-server/debian/ buster main\""},{"line_number":65,"context_line":"  td-agent: \"deb http://packages.treasuredata.com/4/debian/buster buster contrib\""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"8e3fa159_28533c74","side":"PARENT","line":63,"range":{"start_line":63,"start_character":15,"end_line":63,"end_character":27},"updated":"2021-08-04 13:07:12.000000000","message":"this part was lost in translation; not needed?","commit_id":"53b391d3612a322ad13e1ec65e2ed9ba7e94a3c1"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5888e2b0a52112b9d41d709595916b326212270c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  grafana: \"deb https://packages.grafana.com/oss/deb stable main\""},{"line_number":61,"context_line":"  influxdb: \"deb https://repos.influxdata.com/debian buster stable\""},{"line_number":62,"context_line":"  logstash: \"deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main\""},{"line_number":63,"context_line":"  kibana: \"deb [arch\u003damd64] https://artifacts.elastic.co/packages/oss-7.x/apt stable main\""},{"line_number":64,"context_line":"  rabbitmq: \"deb https://packagecloud.io/rabbitmq/rabbitmq-server/debian/ buster main\""},{"line_number":65,"context_line":"  td-agent: \"deb http://packages.treasuredata.com/4/debian/buster buster contrib\""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"249e4841_65107242","side":"PARENT","line":63,"range":{"start_line":63,"start_character":15,"end_line":63,"end_character":27},"in_reply_to":"8e3fa159_28533c74","updated":"2021-08-04 13:27:00.000000000","message":"not needed - we handle that in other way inside of kibana/Dockerfile.js","commit_id":"53b391d3612a322ad13e1ec65e2ed9ba7e94a3c1"}],"releasenotes/notes/apt-keys-bb7c8678fc6d908b.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7fbd762b1e45ba215b77d688ebdc768341daa576","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    names and URLs."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    If you override ``base_apt_keys`` or ``remote_apt_keys`` then please adapt"},{"line_number":9,"context_line":"    to the new format. Note that while using short id for GPG keys still works"},{"line_number":10,"context_line":"    use of fingerprints or long ids is recommended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This allows to instruct APT to use those keys only for their repositories"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"8045b64c_7c1cfb33","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":78},"updated":"2021-08-04 13:07:12.000000000","message":"nit: put commas around, hard to read otherwise","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5888e2b0a52112b9d41d709595916b326212270c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    names and URLs."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    If you override ``base_apt_keys`` or ``remote_apt_keys`` then please adapt"},{"line_number":9,"context_line":"    to the new format. Note that while using short id for GPG keys still works"},{"line_number":10,"context_line":"    use of fingerprints or long ids is recommended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This allows to instruct APT to use those keys only for their repositories"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"f1338de8_400e6340","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":78},"in_reply_to":"8045b64c_7c1cfb33","updated":"2021-08-04 13:27:00.000000000","message":"Ack","commit_id":"92d5c2850da48f63faf709069f42ba34d0dd6fa8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2b45827b4589ce6d362234f27f4a4a2418a1b51f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format of APT keys has changed from simple list into dictionary. For"},{"line_number":5,"context_line":"    ``base_apt_keys`` we now use name and key ids and for ``remote_apt_keys``"},{"line_number":6,"context_line":"    names and URLs."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    If you override ``base_apt_keys`` or ``remote_apt_keys`` then please adapt"},{"line_number":9,"context_line":"    to the new format. Note that, while using short id for GPG keys still works,"},{"line_number":10,"context_line":"    use of fingerprints or long ids is recommended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This allows to instruct APT to use those keys only for their repositories"},{"line_number":13,"context_line":"    instead of trusting them for all possible packages."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"7588177c_d2cad3b6","line":10,"range":{"start_line":4,"start_character":4,"end_line":10,"end_character":51},"updated":"2021-08-06 10:15:57.000000000","message":"do we have any docs around that? It seems complicated and no example given.","commit_id":"12c3754687aff3d9a70ba2290c91bbcfa0321762"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"83c419e7ecca7bbe2921e01d9cce4e6c8db2f116","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format of APT keys has changed from simple list into dictionary. For"},{"line_number":5,"context_line":"    ``base_apt_keys`` we now use name and key ids and for ``remote_apt_keys``"},{"line_number":6,"context_line":"    names and URLs."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    If you override ``base_apt_keys`` or ``remote_apt_keys`` then please adapt"},{"line_number":9,"context_line":"    to the new format. Note that, while using short id for GPG keys still works,"},{"line_number":10,"context_line":"    use of fingerprints or long ids is recommended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This allows to instruct APT to use those keys only for their repositories"},{"line_number":13,"context_line":"    instead of trusting them for all possible packages."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5936b1b6_99a201d2","line":10,"range":{"start_line":4,"start_character":4,"end_line":10,"end_character":51},"in_reply_to":"7588177c_d2cad3b6","updated":"2021-08-06 10:50:06.000000000","message":"Types of key IDs:\n\nfingerprint: 0D69 E11F 12BD BA07 7B37  26AB 4E1F 799A A4FF 2279\nlong id:                                    4E1F 799A A4FF 2279\nshort id:                                             A4FF 2279\n\nI think that whole sense can be removed. We used long ids in past and hope that people will follow.","commit_id":"12c3754687aff3d9a70ba2290c91bbcfa0321762"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a1aec4aec28bfe1849f5af5715015845f9b53c2a","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    This allows to instruct APT to use those keys only for their repositories"},{"line_number":9,"context_line":"    instead of trusting them for all possible packages."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    If you override ``base_apt_keys`` or ``remote_apt_keys`` then please adapt"},{"line_number":12,"context_line":"    to the new format."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"b75bb627_b8128c32","line":11,"range":{"start_line":11,"start_character":60,"end_line":11,"end_character":61},"updated":"2021-08-25 15:51:35.000000000","message":"nit: comma","commit_id":"ffaf102fecc20510513de4898ce85b5b119e1795"}],"releasenotes/notes/deprecate-apt-keys-eff6e68272923b6b.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8f4253407312d9c14eab391a1ecddd6f25e0f4e7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Using APT keys as list of GnuPG ids (via ``apt_keys`` template override) is"},{"line_number":5,"context_line":"    deprecated since Wallaby release and support for them will be dropped in"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6086d773_fe77b5ef","side":"PARENT","line":2,"updated":"2021-04-25 08:42:23.000000000","message":"we might want to revert this reno independently","commit_id":"ac8c82b43a696a5dbef61cf12391a10f9f8e07bb"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"0499cfcf76dfb9513c57ede3e28791b836403c9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Using APT keys as list of GnuPG ids (via ``apt_keys`` template override) is"},{"line_number":5,"context_line":"    deprecated since Wallaby release and support for them will be dropped in"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e95bd737_a9782a88","side":"PARENT","line":2,"in_reply_to":"6086d773_fe77b5ef","updated":"2021-04-26 09:27:42.000000000","message":"It is different way.\n\nI wanted to deprecate use of ``apt_keys`` as a APT trusted keys in a way it is in present code. Then use of PPA for Erlang and packagecloud for RabbitMQ forced us to use it anyway. So I changed them to follow \"new\" APT way.\n\nThat\u0027s why one release note gets dropped and other gets written.","commit_id":"ac8c82b43a696a5dbef61cf12391a10f9f8e07bb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7b088b24fef4e67090c4b9af4c349453d0bc87b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Using APT keys as list of GnuPG ids (via ``apt_keys`` template override) is"},{"line_number":5,"context_line":"    deprecated since Wallaby release and support for them will be dropped in"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6ec7aa88_bf2f8dab","side":"PARENT","line":2,"in_reply_to":"e95bd737_a9782a88","updated":"2021-04-26 09:32:52.000000000","message":"Ah, you want to backport this, I see.","commit_id":"ac8c82b43a696a5dbef61cf12391a10f9f8e07bb"}]}