)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2bf6e498ae5e9f5c62ce3c987a87f8e4996f1aaa","unresolved":true,"context_lines":[{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN /bin/bash -c \u0027source /etc/os-release;\\"},{"line_number":7,"context_line":"    if ! [[ \"$PRETTY_NAME\" \u003d\u003d \"{{ supported_distro_name }}\"* ]]; then \\"},{"line_number":8,"context_line":"        echo \"Only releases \\\"{{ supported_distro_name }}\\\" are supported on {{ base_distro }}\"; false; \\"},{"line_number":9,"context_line":"    fi \u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f5ca78d1_804d0cbe","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":14},"updated":"2021-05-04 16:56:59.000000000","message":"bash *might* be missing from base images - can we avoid bashisms here?","commit_id":"887a4042d8d3929af435453a3affc7bd77cc4728"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"709b038641b0548883f5daeaf719af4c404c5e02","unresolved":true,"context_lines":[{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN /bin/bash -c \u0027source /etc/os-release;\\"},{"line_number":7,"context_line":"    if ! [[ \"$PRETTY_NAME\" \u003d\u003d \"{{ supported_distro_name }}\"* ]]; then \\"},{"line_number":8,"context_line":"        echo \"Only releases \\\"{{ supported_distro_name }}\\\" are supported on {{ base_distro }}\"; false; \\"},{"line_number":9,"context_line":"    fi \u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"22c5ce79_36d12963","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":14},"in_reply_to":"f5ca78d1_804d0cbe","updated":"2021-05-04 17:04:42.000000000","message":"So far it is present in all our images.\n\nIf you know better way of comparing strings in shell I am all ears.","commit_id":"887a4042d8d3929af435453a3affc7bd77cc4728"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2988f463973dc865b203e4b4fae5977087e27b28","unresolved":true,"context_lines":[{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN . /etc/os-release;\\"},{"line_number":7,"context_line":"    if [ \"{$PRETTY_NAME#{{ supported_distro_name }}}\" \u003d \"$PRETTY_NAME\" ]; then \\"},{"line_number":8,"context_line":"        echo \"Only releases \\\"{{ supported_distro_name }}\\\" are supported on {{ base_distro }}\"; false; \\"},{"line_number":9,"context_line":"    fi"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba2850fc_b4ccb895","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":70},"updated":"2021-05-06 04:06:01.000000000","message":"seems not work here. i don\u0027t know what\u0027s the meaning of \u0027#{{supported_distro_name }}\u0027 and \u0027\u003d\u0027(maybe \u003d\u003d?), but i do a simple test though, the result is following:\n\n\ndocker run --rm -it ubuntu:20.04 bash\n\nroot@c587e9f38f34:/# bash -x a.sh\n+ . /etc/os-release\n++ NAME\u003dUbuntu\n++ VERSION\u003d\u002720.04.2 LTS (Focal Fossa)\u0027\n++ ID\u003dubuntu\n++ ID_LIKE\u003ddebian\n++ PRETTY_NAME\u003d\u0027Ubuntu 20.04.2 LTS\u0027\n++ VERSION_ID\u003d20.04\n++ HOME_URL\u003dhttps://www.ubuntu.com/\n++ SUPPORT_URL\u003dhttps://help.ubuntu.com/\n++ BUG_REPORT_URL\u003dhttps://bugs.launchpad.net/ubuntu/\n++ PRIVACY_POLICY_URL\u003dhttps://www.ubuntu.com/legal/terms-and-policies/privacy-policy\n++ VERSION_CODENAME\u003dfocal\n++ UBUNTU_CODENAME\u003dfocal\n+ \u0027[\u0027 \u0027{Ubuntu 20.04.2 LTS#Ubuntu 20.04}\u0027 \u003d \u0027Ubuntu 20.04.2 LTS\u0027 \u0027]\u0027\nroot@c587e9f38f34:/# vim a.sh\nroot@c587e9f38f34:/# bash -x a.sh\n+ \u0027[\u0027 \u0027{Ubuntu 18.04.1 LTS#Ubuntu 20.04}\u0027 \u003d \u0027Ubuntu 18.04.1 LTS\u0027 \u0027]\u0027\n\nwhatever the Pretty_NAME is, this condition always pass.","commit_id":"d2620db1f28109ba1ed9fe237ca55cf5ab084c3c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8efa1bc95a705460eaa4ab91884d92ae56edb647","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN . /etc/os-release;\\"},{"line_number":7,"context_line":"    if [ \"{$PRETTY_NAME#{{ supported_distro_name }}}\" \u003d \"$PRETTY_NAME\" ]; then \\"},{"line_number":8,"context_line":"        echo \"Only releases \\\"{{ supported_distro_name }}\\\" are supported on {{ base_distro }}\"; false; \\"},{"line_number":9,"context_line":"    fi"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"549f6056_1616b4e4","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":70},"in_reply_to":"ba2850fc_b4ccb895","updated":"2021-05-06 06:31:17.000000000","message":"Thanks - looks like I sent wrong version. Should be fixed now.","commit_id":"d2620db1f28109ba1ed9fe237ca55cf5ab084c3c"}],"kolla/common/config.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2bf6e498ae5e9f5c62ce3c987a87f8e4996f1aaa","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    \u0027debian\u0027: \u002710\u0027,"},{"line_number":34,"context_line":"    \u0027ubuntu\u0027: \u002720.04\u0027,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":"# NOTE(hrw): has to fit PRETTY_NAME in /etc/os-release"},{"line_number":37,"context_line":"DISTRO_PRETTY_NAME \u003d {"},{"line_number":38,"context_line":"    \u0027centos\u0027: \u0027CentOS Stream 8\u0027,"},{"line_number":39,"context_line":"    \u0027rhel\u0027: \u0027Red Hat Enterprise Linux 8\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d68537bd_f7f6c1a0","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":24},"updated":"2021-05-04 16:56:59.000000000","message":"match","commit_id":"887a4042d8d3929af435453a3affc7bd77cc4728"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"709b038641b0548883f5daeaf719af4c404c5e02","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \u0027debian\u0027: \u002710\u0027,"},{"line_number":34,"context_line":"    \u0027ubuntu\u0027: \u002720.04\u0027,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":"# NOTE(hrw): has to fit PRETTY_NAME in /etc/os-release"},{"line_number":37,"context_line":"DISTRO_PRETTY_NAME \u003d {"},{"line_number":38,"context_line":"    \u0027centos\u0027: \u0027CentOS Stream 8\u0027,"},{"line_number":39,"context_line":"    \u0027rhel\u0027: \u0027Red Hat Enterprise Linux 8\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4e4f4c41_7b28ceea","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":24},"in_reply_to":"d68537bd_f7f6c1a0","updated":"2021-05-04 17:04:42.000000000","message":"Ack","commit_id":"887a4042d8d3929af435453a3affc7bd77cc4728"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67b38a514dace30e7f9370f9f6a536bdcf070e9a","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    \u0027debian\u0027: {\u0027name\u0027: \u0027debian\u0027, \u0027tag\u0027: \u0027bullseye\u0027},"},{"line_number":28,"context_line":"    \u0027ubuntu\u0027: {\u0027name\u0027: \u0027ubuntu\u0027, \u0027tag\u0027: \u002720.04\u0027},"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":"DISTRO_RELEASE \u003d {"},{"line_number":31,"context_line":"    \u0027centos\u0027: \u00278\u0027,"},{"line_number":32,"context_line":"    \u0027rhel\u0027: \u00278\u0027,"},{"line_number":33,"context_line":"    \u0027debian\u0027: \u0027testing/unstable\u0027,"},{"line_number":34,"context_line":"    \u0027ubuntu\u0027: \u002720.04\u0027,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":"# NOTE(hrw): has to fit PRETTY_NAME in /etc/os-release"},{"line_number":37,"context_line":"DISTRO_PRETTY_NAME \u003d {"},{"line_number":38,"context_line":"    \u0027centos\u0027: \u0027CentOS Stream 8\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"085b8769_3a680b6a","line":35,"range":{"start_line":30,"start_character":0,"end_line":35,"end_character":1},"updated":"2021-05-04 17:35:16.000000000","message":"wdyt about dropping this? (no longer used)","commit_id":"ff03a0ac30b0c7ef3af65863f5843441dea3b56a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67b38a514dace30e7f9370f9f6a536bdcf070e9a","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    \u0027debian\u0027: \u0027testing/unstable\u0027,"},{"line_number":34,"context_line":"    \u0027ubuntu\u0027: \u002720.04\u0027,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":"# NOTE(hrw): has to fit PRETTY_NAME in /etc/os-release"},{"line_number":37,"context_line":"DISTRO_PRETTY_NAME \u003d {"},{"line_number":38,"context_line":"    \u0027centos\u0027: \u0027CentOS Stream 8\u0027,"},{"line_number":39,"context_line":"    \u0027rhel\u0027: \u0027Red Hat Enterprise Linux 8\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7671d6df_11bcc8c0","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":24},"updated":"2021-05-04 17:35:16.000000000","message":"match LOL","commit_id":"ff03a0ac30b0c7ef3af65863f5843441dea3b56a"}],"kolla/image/build.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67b38a514dace30e7f9370f9f6a536bdcf070e9a","unresolved":true,"context_lines":[{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    def create_dockerfiles(self):"},{"line_number":916,"context_line":"        kolla_version \u003d version.version_info.cached_version_string()"},{"line_number":917,"context_line":"        supported_distro_release \u003d common_config.DISTRO_RELEASE.get("},{"line_number":918,"context_line":"            self.base)"},{"line_number":919,"context_line":"        supported_distro_name \u003d common_config.DISTRO_PRETTY_NAME.get("},{"line_number":920,"context_line":"            self.base)"},{"line_number":921,"context_line":"        for path in self.docker_build_paths:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f291f59f_8920b2c7","line":918,"range":{"start_line":917,"start_character":8,"end_line":918,"end_character":22},"updated":"2021-05-04 17:35:16.000000000","message":"wdyt about dropping this? (no longer used)","commit_id":"ff03a0ac30b0c7ef3af65863f5843441dea3b56a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67b38a514dace30e7f9370f9f6a536bdcf070e9a","unresolved":true,"context_lines":[{"line_number":932,"context_line":"                      \u0027base_package_type\u0027: self.base_package_type,"},{"line_number":933,"context_line":"                      \u0027debian_arch\u0027: self.debian_arch,"},{"line_number":934,"context_line":"                      \u0027docker_healthchecks\u0027: self.docker_healthchecks,"},{"line_number":935,"context_line":"                      \u0027supported_distro_release\u0027: supported_distro_release,"},{"line_number":936,"context_line":"                      \u0027supported_distro_name\u0027: supported_distro_name,"},{"line_number":937,"context_line":"                      \u0027install_metatype\u0027: self.install_metatype,"},{"line_number":938,"context_line":"                      \u0027image_prefix\u0027: self.image_prefix,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b62ec12f_9e494ebe","line":935,"range":{"start_line":935,"start_character":22,"end_line":935,"end_character":75},"updated":"2021-05-04 17:35:16.000000000","message":"wdyt about dropping this? (no longer used)","commit_id":"ff03a0ac30b0c7ef3af65863f5843441dea3b56a"}]}