)]}'
{"docker/macros.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"52ff6b844f35d9385f296d646138a9f3aa4e850e","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":87,"context_line":"{% endmacro %}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{% macro github_download_tarball(repo, release, output, sha512sum) %}"},{"line_number":90,"context_line":"url\u003d$(curl https://api.github.com/repos/{{ repo }}/releases/{{ release }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027) \\"},{"line_number":91,"context_line":"    curl -o {{ output }} ${url} \u0026\u0026 sha512sum -c \"{{ sha512sum }} {{ output }}\""},{"line_number":92,"context_line":"{% endmacro %}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"{% macro github_download_asset(repo, release, file, output, sha512sum) %}"},{"line_number":95,"context_line":"url\u003d$(curl https://api.github.com/repos/{{ repo }}/releases/{{ release }} | grep -Po \u0027\"browser_download_url\": \"\\K.*{{ file }}?(?\u003d\")\u0027) \\"},{"line_number":96,"context_line":"    curl -o {{ output }} ${url} \u0026\u0026 sha512sum -c \"{{ sha512sum }} {{ output }}\""},{"line_number":97,"context_line":"{% endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"eb9ca2f8_36efd282","line":97,"range":{"start_line":89,"start_character":0,"end_line":97,"end_character":14},"updated":"2021-05-25 16:36:21.000000000","message":"You\u0027ll probably hate me for saying this but I prefer this approach","commit_id":"05c93ef00c030657c3140a9cc5ff3dfc6468fd73"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a3b022cd668ac9d19aead376fcfa5776c2514656","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":87,"context_line":"{% endmacro %}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{% macro github_download_tarball(repo, release, output, sha512sum) %}"},{"line_number":90,"context_line":"url\u003d$(curl https://api.github.com/repos/{{ repo }}/releases/{{ release }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027) \\"},{"line_number":91,"context_line":"    curl -o {{ output }} ${url} \u0026\u0026 sha512sum -c \"{{ sha512sum }} {{ output }}\""},{"line_number":92,"context_line":"{% endmacro %}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"{% macro github_download_asset(repo, release, file, output, sha512sum) %}"},{"line_number":95,"context_line":"url\u003d$(curl https://api.github.com/repos/{{ repo }}/releases/{{ release }} | grep -Po \u0027\"browser_download_url\": \"\\K.*{{ file }}?(?\u003d\")\u0027) \\"},{"line_number":96,"context_line":"    curl -o {{ output }} ${url} \u0026\u0026 sha512sum -c \"{{ sha512sum }} {{ output }}\""},{"line_number":97,"context_line":"{% endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b4bb6173_17512f75","line":97,"range":{"start_line":89,"start_character":0,"end_line":97,"end_character":14},"in_reply_to":"eb9ca2f8_36efd282","updated":"2021-05-26 09:20:33.000000000","message":"Naah, no hate needed, that\u0027s why I asked for reviews - it makes sense to use two macros, but I\u0027ll use a dict as passed variable, passing N strings is not my preference.","commit_id":"05c93ef00c030657c3140a9cc5ff3dfc6468fd73"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c833d5d75ec5036e5d00aa1cda7d0953e9e4a029","unresolved":true,"context_lines":[{"line_number":87,"context_line":"{% endmacro %}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{% macro github_download(source) -%}"},{"line_number":90,"context_line":"{%- if source[\u0027type\u0027] \u003d\u003d \u0027tarball\u0027 -%}"},{"line_number":91,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release\u0027] }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027); \\"},{"line_number":92,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":93,"context_line":"{%- elif source[\u0027type\u0027] \u003d\u003d \u0027asset\u0027 -%}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"874c61cb_d4b196bf","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":33},"updated":"2021-05-25 13:36:33.000000000","message":"perhaps tag_tarball?","commit_id":"d57ae473384f216b26b018690177774a12d3e1d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c833d5d75ec5036e5d00aa1cda7d0953e9e4a029","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{% macro github_download(source) -%}"},{"line_number":90,"context_line":"{%- if source[\u0027type\u0027] \u003d\u003d \u0027tarball\u0027 -%}"},{"line_number":91,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release\u0027] }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027); \\"},{"line_number":92,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":93,"context_line":"{%- elif source[\u0027type\u0027] \u003d\u003d \u0027asset\u0027 -%}"},{"line_number":94,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release\u0027] }} | grep -Po \u0027\"browser_download_url\": \"\\K.*{{ source[\u0027file\u0027] }}?(?\u003d\")\u0027); \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"255af34f_75a00266","line":91,"range":{"start_line":91,"start_character":97,"end_line":91,"end_character":104},"updated":"2021-05-25 13:36:33.000000000","message":"what about release_tag?","commit_id":"d57ae473384f216b26b018690177774a12d3e1d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c833d5d75ec5036e5d00aa1cda7d0953e9e4a029","unresolved":true,"context_lines":[{"line_number":90,"context_line":"{%- if source[\u0027type\u0027] \u003d\u003d \u0027tarball\u0027 -%}"},{"line_number":91,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release\u0027] }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027); \\"},{"line_number":92,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":93,"context_line":"{%- elif source[\u0027type\u0027] \u003d\u003d \u0027asset\u0027 -%}"},{"line_number":94,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release\u0027] }} | grep -Po \u0027\"browser_download_url\": \"\\K.*{{ source[\u0027file\u0027] }}?(?\u003d\")\u0027); \\"},{"line_number":95,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":96,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"b8028b02_bb336ecb","line":93,"range":{"start_line":93,"start_character":28,"end_line":93,"end_character":33},"updated":"2021-05-25 13:36:33.000000000","message":"could we call it a release? or release_asset?","commit_id":"d57ae473384f216b26b018690177774a12d3e1d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c833d5d75ec5036e5d00aa1cda7d0953e9e4a029","unresolved":true,"context_lines":[{"line_number":91,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release\u0027] }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027); \\"},{"line_number":92,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":93,"context_line":"{%- elif source[\u0027type\u0027] \u003d\u003d \u0027asset\u0027 -%}"},{"line_number":94,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release\u0027] }} | grep -Po \u0027\"browser_download_url\": \"\\K.*{{ source[\u0027file\u0027] }}?(?\u003d\")\u0027); \\"},{"line_number":95,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":96,"context_line":"{%- endif %}"},{"line_number":97,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"62d4df60_079b8482","line":94,"range":{"start_line":94,"start_character":97,"end_line":94,"end_character":104},"updated":"2021-05-25 13:36:33.000000000","message":"ditto","commit_id":"d57ae473384f216b26b018690177774a12d3e1d8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"52ff6b844f35d9385f296d646138a9f3aa4e850e","unresolved":true,"context_lines":[{"line_number":87,"context_line":"{% endmacro %}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{% macro github_download(source) -%}"},{"line_number":90,"context_line":"{%- if source[\u0027type\u0027] \u003d\u003d \u0027tag_tarball\u0027 -%}"},{"line_number":91,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release_tag\u0027] }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027); \\"},{"line_number":92,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":93,"context_line":"{%- elif source[\u0027type\u0027] \u003d\u003d \u0027release_asset\u0027 -%}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ef383e6c_0ec88479","line":90,"updated":"2021-05-25 16:36:21.000000000","message":"This would be a lot easier to grok as two macros, and would mean I don\u0027t have to ask what happens if you pass an invalid \u0027type\u0027.","commit_id":"c5450ccc57db06b262afcf482945f7d2530e417c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"52ff6b844f35d9385f296d646138a9f3aa4e850e","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{% macro github_download(source) -%}"},{"line_number":90,"context_line":"{%- if source[\u0027type\u0027] \u003d\u003d \u0027tag_tarball\u0027 -%}"},{"line_number":91,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release_tag\u0027] }} | grep -Po \u0027\"tarball_url\": \"\\K.*?(?\u003d\")\u0027); \\"},{"line_number":92,"context_line":"    curl -o {{ source[\u0027output\u0027] }} ${url} \u0026\u0026 echo \"{{ source[\u0027sha512sum\u0027] }} {{ source[\u0027output\u0027] }}\" | sha512sum -c"},{"line_number":93,"context_line":"{%- elif source[\u0027type\u0027] \u003d\u003d \u0027release_asset\u0027 -%}"},{"line_number":94,"context_line":"RUN export url\u003d$(curl https://api.github.com/repos/{{ source[\u0027repo\u0027] }}/releases/tags/{{ source[\u0027release_tag\u0027] }} | grep -Po \u0027\"browser_download_url\": \"\\K.*{{ source[\u0027file\u0027] }}?(?\u003d\")\u0027); \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c0910a65_131609a3","line":91,"range":{"start_line":91,"start_character":154,"end_line":91,"end_character":155},"updated":"2021-05-25 16:36:21.000000000","message":"will ignore failures","commit_id":"c5450ccc57db06b262afcf482945f7d2530e417c"}],"docker/skydive/skydive-base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c833d5d75ec5036e5d00aa1cda7d0953e9e4a029","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    \u0027release\u0027: \u0027v0.27.0\u0027,"},{"line_number":23,"context_line":"    \u0027type\u0027: \u0027asset\u0027,"},{"line_number":24,"context_line":"    \u0027file\u0027: \u0027skydive\u0027,"},{"line_number":25,"context_line":"    \u0027output\u0027: \u0027/usr/bin/skydive\u0027,"},{"line_number":26,"context_line":"    \u0027sha512sum\u0027: \u00276304104ec6fa033bab9effccca229cb9a084ce965ca1f2e0edfc3196fb259c0cc0cdb67d0bac685adc7ed9f2ebd8cd46284c210d41e0c2b1d1b86ef80a5287bb\u0027"},{"line_number":27,"context_line":"    } %}"},{"line_number":28,"context_line":"{{ macros.github_download(skydive_github) }} \u0026\u0026 chmod +x /usr/bin/skydive"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e4ebc5ac_c9928db7","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":31},"updated":"2021-05-25 13:36:33.000000000","message":"you could refactor this as a var","commit_id":"d57ae473384f216b26b018690177774a12d3e1d8"}]}