)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0a6a68f20b18dde2e0f0b1de5dceecc47efa6777","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix crmadmin not working on masakari Debuntu images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As Masaari-hostmonitor is accessing /dev/shm/*, it"},{"line_number":10,"context_line":"really needs to have same permissions as hacluster-pacemaker"},{"line_number":11,"context_line":"container has (where crmadmin is working normally)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d05a7dc0_b500b50d","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":10},"updated":"2021-07-08 09:03:00.000000000","message":"nit: Masakari","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2302026925b14861d21863cbe62307ebd94bfece","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix crmadmin not working on masakari Debuntu images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As Masaari-hostmonitor is accessing /dev/shm/*, it"},{"line_number":10,"context_line":"really needs to have same permissions as hacluster-pacemaker"},{"line_number":11,"context_line":"container has (where crmadmin is working normally)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2a0d1ed4_c3b8bd03","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":10},"in_reply_to":"d05a7dc0_b500b50d","updated":"2021-07-08 11:23:05.000000000","message":"Done","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"}],"docker/hacluster/hacluster-base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c761fcafb8e817707584bbaf0bc7cf06bd1850e3","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN groupadd --system haclient --gid 189 \\"},{"line_number":17,"context_line":"    \u0026\u0026 useradd --system --gid 189 --uid 189 \\"},{"line_number":18,"context_line":"       --shell {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/usr/sbin/nologin{% else %}/sbin/nologin{% endif %}{% endif %} \\"},{"line_number":19,"context_line":"       --comment \"Cluster user\" \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"75b8fb31_1b5d5c55","line":16,"updated":"2021-07-07 10:50:46.000000000","message":"Have you considered turning it into macro so it will be defined in just one place?\n\nAlso check before RUN, set nologin_path, homedir_path variables and use them in RUN call? Will be easier to read.","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"053a500ca0bef9e1a9d156016aed17d56f97f531","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN groupadd --system haclient --gid 189 \\"},{"line_number":17,"context_line":"    \u0026\u0026 useradd --system --gid 189 --uid 189 \\"},{"line_number":18,"context_line":"       --shell {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/usr/sbin/nologin{% else %}/sbin/nologin{% endif %}{% endif %} \\"},{"line_number":19,"context_line":"       --comment \"Cluster user\" \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c9b859cb_69aea762","line":16,"in_reply_to":"75b8fb31_1b5d5c55","updated":"2021-07-07 13:40:54.000000000","message":"Do you mean new jinja macro ? Or edit users mechanism in kolla/common/config.py to support more variables like home directory, nologin executable, --sytem flag ..","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ad0cb0861e41616128d18d0b65ded7e1b95eef3b","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN groupadd --system haclient --gid 189 \\"},{"line_number":17,"context_line":"    \u0026\u0026 useradd --system --gid 189 --uid 189 \\"},{"line_number":18,"context_line":"       --shell {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/usr/sbin/nologin{% else %}/sbin/nologin{% endif %}{% endif %} \\"},{"line_number":19,"context_line":"       --comment \"Cluster user\" \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba0d7b6e_59a83ef1","line":16,"in_reply_to":"c9b859cb_69aea762","updated":"2021-07-08 12:07:46.000000000","message":"Well, I considered, but I don\u0027t assume that this macro will be used somewhere else, so do you think this should be macro if it will be used only on this two places ? \n\nLet me know.","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0a6a68f20b18dde2e0f0b1de5dceecc47efa6777","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN groupadd --system haclient --gid 189 \\"},{"line_number":17,"context_line":"    \u0026\u0026 useradd --system --gid 189 --uid 189 \\"},{"line_number":18,"context_line":"       --shell {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/usr/sbin/nologin{% else %}/sbin/nologin{% endif %}{% endif %} \\"},{"line_number":19,"context_line":"       --comment \"Cluster user\" \\"},{"line_number":20,"context_line":"       --home {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/var/lib/pacemaker{% else %}/home/hacluster{% endif %}{% endif %} hacluster"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ec470566_cfdee986","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":45},"updated":"2021-07-08 09:03:00.000000000","message":"Why only binary?","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2302026925b14861d21863cbe62307ebd94bfece","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN groupadd --system haclient --gid 189 \\"},{"line_number":17,"context_line":"    \u0026\u0026 useradd --system --gid 189 --uid 189 \\"},{"line_number":18,"context_line":"       --shell {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/usr/sbin/nologin{% else %}/sbin/nologin{% endif %}{% endif %} \\"},{"line_number":19,"context_line":"       --comment \"Cluster user\" \\"},{"line_number":20,"context_line":"       --home {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/var/lib/pacemaker{% else %}/home/hacluster{% endif %}{% endif %} hacluster"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"02ee4495_6a96ff80","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":45},"in_reply_to":"ec470566_cfdee986","updated":"2021-07-08 11:23:05.000000000","message":"Done","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0a6a68f20b18dde2e0f0b1de5dceecc47efa6777","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    \u0026\u0026 useradd --system --gid 189 --uid 189 \\"},{"line_number":18,"context_line":"       --shell {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/usr/sbin/nologin{% else %}/sbin/nologin{% endif %}{% endif %} \\"},{"line_number":19,"context_line":"       --comment \"Cluster user\" \\"},{"line_number":20,"context_line":"       --home {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/var/lib/pacemaker{% else %}/home/hacluster{% endif %}{% endif %} hacluster"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block hacluster_base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"45feddad_a90d127d","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":44},"updated":"2021-07-08 09:03:00.000000000","message":"ditto","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2302026925b14861d21863cbe62307ebd94bfece","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u0026\u0026 useradd --system --gid 189 --uid 189 \\"},{"line_number":18,"context_line":"       --shell {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/usr/sbin/nologin{% else %}/sbin/nologin{% endif %}{% endif %} \\"},{"line_number":19,"context_line":"       --comment \"Cluster user\" \\"},{"line_number":20,"context_line":"       --home {% if install_type \u003d\u003d \u0027binary\u0027 %}{% if base_package_type \u003d\u003d \u0027deb\u0027 %}/var/lib/pacemaker{% else %}/home/hacluster{% endif %}{% endif %} hacluster"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block hacluster_base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"18157fbf_3a6011dc","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":44},"in_reply_to":"45feddad_a90d127d","updated":"2021-07-08 11:23:05.000000000","message":"Done","commit_id":"12fb589354ac2cf799b764098973b295e5290c8f"}]}