)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"679a7675af0400c4f2226edd0e1a9ff996b3b568","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{%- for name, user in users | dictsort() %}"},{"line_number":23,"context_line":"{% if loop.first -%}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":24,"context_line":"    groupadd --gid {{ user.gid }} {{ user.group }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 useradd -l -M --shell /usr/sbin/nologin --uid {{ user.uid }} --gid {{ user.gid }} --home-dir /var/lib/{{ name }} {{ name }}"},{"line_number":26,"context_line":"        {%- if not loop.last %} \\{% endif -%}"},{"line_number":27,"context_line":"{%- endfor %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"e70ea7b2_e8c39ddd","line":25,"range":{"start_line":25,"start_character":89,"end_line":25,"end_character":120},"updated":"2021-09-27 15:39:09.000000000","message":"hmm, that\u0027s not quite right","commit_id":"219766e58fe2e5202291ddb5c2ee9c891057bdfa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"159c7ce774c76101ae79a248c81a769b3ccdca3e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{%- for name, user in users | dictsort() %}"},{"line_number":23,"context_line":"{% if loop.first -%}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":24,"context_line":"    groupadd --gid {{ user.gid }} {{ user.group }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 useradd -l -M --shell /usr/sbin/nologin --uid {{ user.uid }} --gid {{ user.gid }} --home-dir /var/lib/{{ name }} {{ name }}"},{"line_number":26,"context_line":"        {%- if not loop.last %} \\{% endif -%}"},{"line_number":27,"context_line":"{%- endfor %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"c907f199_0f755744","line":25,"range":{"start_line":25,"start_character":89,"end_line":25,"end_character":120},"in_reply_to":"44c0d16a_92959a09","updated":"2021-09-27 17:24:08.000000000","message":"1) It does not belong in this change (see the commit message).\n2) It has already been proven to break bifrost.","commit_id":"219766e58fe2e5202291ddb5c2ee9c891057bdfa"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"db771e0fb9b04d0b53c50fd577bebde83e396a12","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{%- for name, user in users | dictsort() %}"},{"line_number":23,"context_line":"{% if loop.first -%}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":24,"context_line":"    groupadd --gid {{ user.gid }} {{ user.group }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 useradd -l -M --shell /usr/sbin/nologin --uid {{ user.uid }} --gid {{ user.gid }} --home-dir /var/lib/{{ name }} {{ name }}"},{"line_number":26,"context_line":"        {%- if not loop.last %} \\{% endif -%}"},{"line_number":27,"context_line":"{%- endfor %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"44c0d16a_92959a09","line":25,"range":{"start_line":25,"start_character":89,"end_line":25,"end_character":120},"in_reply_to":"e70ea7b2_e8c39ddd","updated":"2021-09-27 17:01:33.000000000","message":"Hmm, why not ? Most (all) kolla images using path /var/lib/{{ name }} as home folder, both source and binary. Is this breaking something ?","commit_id":"219766e58fe2e5202291ddb5c2ee9c891057bdfa"}]}
