)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9cf0d9da86f3f1807e8796f30f3cea6660a4810d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Unify curl use (customisation options)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds and unifies an ability to override hardcoded URLs for"},{"line_number":10,"context_line":"air-gapped environments via the usual blocks mechanism. Also, this"},{"line_number":11,"context_line":"change cleanup variables expansion where it is realy not needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I46b77978926fc2b578a68d1aaa944b2198af0685"},{"line_number":14,"context_line":"Change-Id: I1fbad333b1bc95484e6f4c5145d5936a0e2db84f"},{"line_number":15,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4618e7d4_f64e0d17","line":12,"range":{"start_line":10,"start_character":56,"end_line":12,"end_character":0},"updated":"2021-08-24 13:23:31.000000000","message":"I don\u0027t get this part. I see lots of reverts of good practice of using { and }.","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b91c50f579fd82067e4f1df7e094864517886a4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unify curl use (customisation options)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds and unifies an ability to override hardcoded URLs for"},{"line_number":10,"context_line":"air-gapped environments via the usual blocks mechanism. Also, this"},{"line_number":11,"context_line":"change cleanup variables expansion where it is realy not needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I46b77978926fc2b578a68d1aaa944b2198af0685"},{"line_number":14,"context_line":"Change-Id: I1fbad333b1bc95484e6f4c5145d5936a0e2db84f"},{"line_number":15,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a044ee0c_58089c5b","line":12,"range":{"start_line":10,"start_character":56,"end_line":12,"end_character":0},"in_reply_to":"45c0fab4_0cd07012","updated":"2021-08-24 14:32:34.000000000","message":"This is only valid if your containers are based on bash as shell terminals, for instance official Prometheus container use a binary endpoint directly leading to braces madness on vars substitution.\n\nThere is a visual benefit to get expansion used everywhere and as it doesn\u0027t bring any pitfall we should keep it.","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2f6472b39fc6b7f7fb5d989e5bf5dc78c25031a0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unify curl use (customisation options)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds and unifies an ability to override hardcoded URLs for"},{"line_number":10,"context_line":"air-gapped environments via the usual blocks mechanism. Also, this"},{"line_number":11,"context_line":"change cleanup variables expansion where it is realy not needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I46b77978926fc2b578a68d1aaa944b2198af0685"},{"line_number":14,"context_line":"Change-Id: I1fbad333b1bc95484e6f4c5145d5936a0e2db84f"},{"line_number":15,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"45c0fab4_0cd07012","line":12,"range":{"start_line":10,"start_character":56,"end_line":12,"end_character":0},"in_reply_to":"4618e7d4_f64e0d17","updated":"2021-08-24 13:43:55.000000000","message":"this is not a good practice use expansion everywhere! as the bash manual says: \"The parameter name or symbol to be expanded MAY BE enclosed in  braces,...\" and \"The braces are REQUIRED WHEN parameter is a positional parameter with more than one digit, or when parameter is followed by a character which is not to be interpreted as part of its name.\"","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"db2bfb2a0eea041a8bcfe855f5c19ce91ed34eac","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Unify curl use (customisation options)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds and unifies an ability to override hardcoded URLs for"},{"line_number":10,"context_line":"air-gapped environments via the usual blocks mechanism. Also, this"},{"line_number":11,"context_line":"change cleanup variables expansion where it is realy not needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I46b77978926fc2b578a68d1aaa944b2198af0685"},{"line_number":14,"context_line":"Change-Id: I1fbad333b1bc95484e6f4c5145d5936a0e2db84f"},{"line_number":15,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b23e2203_c6ac62f7","line":12,"range":{"start_line":10,"start_character":56,"end_line":12,"end_character":0},"in_reply_to":"a044ee0c_58089c5b","updated":"2021-08-24 14:46:16.000000000","message":"Following on this, this is actually considered as good practice for two reasons. One was already mentioned by Fl1nt - being better for human eyes. The other reason is related and it\u0027s that they make it easier to avoid mistakes due to human miscalculating the boundary of variable name, e.g., trying to add _BLAH to something like FOO_$HELLO ends up being FOO_$HELLO_BLAH which is not correct.","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f458db010ff2b0cdcefbe200ec933469eaf2db9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unify curl use (customisation options)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds and unifies an ability to override hardcoded URLs for"},{"line_number":10,"context_line":"air-gapped environments via the usual blocks mechanism. Also, this"},{"line_number":11,"context_line":"change cleanup variables expansion where it is realy not needed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I46b77978926fc2b578a68d1aaa944b2198af0685"},{"line_number":14,"context_line":"Change-Id: I1fbad333b1bc95484e6f4c5145d5936a0e2db84f"},{"line_number":15,"context_line":"Signed-off-by: Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e8fd463e_75143f31","line":12,"range":{"start_line":10,"start_character":56,"end_line":12,"end_character":0},"in_reply_to":"b23e2203_c6ac62f7","updated":"2021-10-15 09:44:09.000000000","message":"Done","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"645a20ebefb0578dfd2311772c05274f964b978d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5d6e974c_2c06acc2","updated":"2021-10-13 07:46:12.000000000","message":"Let\u0027s wait with this after branching Xena.","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"02c43691856e18b68e60e960e23728c4313345ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a027209b_6c428a9f","updated":"2021-10-28 11:06:15.000000000","message":"NOTE: Alternative approach (than using ARG) in here: https://review.opendev.org/c/openstack/kolla/+/792833\n","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7167186d6ec52e14e2dc42bfadeb5c98d8e93f13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2da63182_88c1cc78","in_reply_to":"5d6e974c_2c06acc2","updated":"2021-10-13 07:54:09.000000000","message":"I\u0027m ok, this needed in Ussuri for a long time","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"af8b322b5dbad368a8839438aa6d510bf93993f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c5e503a0_8aec198d","in_reply_to":"a027209b_6c428a9f","updated":"2021-11-03 09:23:30.000000000","message":"yep, interesting and useful, but not work with all releases right now.\nbtw, this is not alternate approach for my change, but a part of it.\nthe main idea of this change is add everywhere the ability to override the releases to download them from any location, and remove hardcoded urls from templates.","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"}],"doc/source/admin/image-building.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"929d957bc18993ed97494ec47f92155247223378","unresolved":true,"context_lines":[{"line_number":291,"context_line":"like ``PIP_INDEX_URL``, ``PIP_TRUSTED_HOST``, etc. Also here can be provided"},{"line_number":292,"context_line":"the standard enironment variable ``UPPER_CONSTRAINTS_FILE`` used for building"},{"line_number":293,"context_line":"the ``bifrost_deploy`` container when PyPI upper-constraints needs to be"},{"line_number":294,"context_line":"overriden. Also this variable would be used in the ``kolla-toolbox`` if"},{"line_number":295,"context_line":"provided instead of the defaults."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Plugin functionality"}],"source_content_type":"text/x-rst","patch_set":14,"id":"872ff3e9_fae8abc8","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":9},"updated":"2021-10-12 19:14:50.000000000","message":"nit: \"overridden\"","commit_id":"c5fb2ac23a97ba7587f3479040c67fb3ddfcea81"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"60f8b9d359ebcf7a0e3d6a53c71444910c861c64","unresolved":false,"context_lines":[{"line_number":291,"context_line":"like ``PIP_INDEX_URL``, ``PIP_TRUSTED_HOST``, etc. Also here can be provided"},{"line_number":292,"context_line":"the standard enironment variable ``UPPER_CONSTRAINTS_FILE`` used for building"},{"line_number":293,"context_line":"the ``bifrost_deploy`` container when PyPI upper-constraints needs to be"},{"line_number":294,"context_line":"overriden. Also this variable would be used in the ``kolla-toolbox`` if"},{"line_number":295,"context_line":"provided instead of the defaults."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Plugin functionality"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7cf7af96_de17822a","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":9},"in_reply_to":"872ff3e9_fae8abc8","updated":"2021-10-12 19:41:51.000000000","message":"Done","commit_id":"c5fb2ac23a97ba7587f3479040c67fb3ddfcea81"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a1cebaa32dfcb8a96c139cc8f4e32f04b1086dfe","unresolved":true,"context_lines":[{"line_number":289,"context_line":"The block ``base_pip_conf`` in the ``base`` Dockerfile can be used to provide"},{"line_number":290,"context_line":"the PyPI build customisation options via the standard environment variables"},{"line_number":291,"context_line":"like ``PIP_INDEX_URL``, ``PIP_TRUSTED_HOST``, etc. Also here can be provided"},{"line_number":292,"context_line":"the standard enironment variable ``UPPER_CONSTRAINTS_FILE`` used for building"},{"line_number":293,"context_line":"the ``bifrost_deploy`` container when PyPI upper-constraints needs to be"},{"line_number":294,"context_line":"overridden. Also this variable would be used in the ``kolla-toolbox`` if"},{"line_number":295,"context_line":"provided instead of the defaults."}],"source_content_type":"text/x-rst","patch_set":15,"id":"b3c6e39e_a7092dcc","line":292,"range":{"start_line":292,"start_character":13,"end_line":292,"end_character":23},"updated":"2021-10-28 11:12:23.000000000","message":"environment (typo)","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"af8b322b5dbad368a8839438aa6d510bf93993f3","unresolved":false,"context_lines":[{"line_number":289,"context_line":"The block ``base_pip_conf`` in the ``base`` Dockerfile can be used to provide"},{"line_number":290,"context_line":"the PyPI build customisation options via the standard environment variables"},{"line_number":291,"context_line":"like ``PIP_INDEX_URL``, ``PIP_TRUSTED_HOST``, etc. Also here can be provided"},{"line_number":292,"context_line":"the standard enironment variable ``UPPER_CONSTRAINTS_FILE`` used for building"},{"line_number":293,"context_line":"the ``bifrost_deploy`` container when PyPI upper-constraints needs to be"},{"line_number":294,"context_line":"overridden. Also this variable would be used in the ``kolla-toolbox`` if"},{"line_number":295,"context_line":"provided instead of the defaults."}],"source_content_type":"text/x-rst","patch_set":15,"id":"291c1099_402c7f85","line":292,"range":{"start_line":292,"start_character":13,"end_line":292,"end_character":23},"in_reply_to":"b3c6e39e_a7092dcc","updated":"2021-11-03 09:23:30.000000000","message":"thanks","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"4c6fd8fbf44db777cec1903aa7aa0bab13c69aff","unresolved":true,"context_lines":[{"line_number":393,"context_line":"# NB: this is the constant variable name used in the installation scripts in the"},{"line_number":394,"context_line":"# parent images (bifrost-* for example) and some Dockerfiles (kolla-toolbox)."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"ENV UPPER_CONSTRAINTS_FILE\u003dhttps://releases.openstack.org/constraints/upper/{{ openstack_release }}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# the variables like PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, PIP_TRUSTED_HOST and"},{"line_number":399,"context_line":"# all other PIP_* should be also defined here."}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"153d62ec_af336c1e","line":396,"updated":"2021-09-02 10:50:16.000000000","message":"This isn\u0027t required outside of kolla-toolbox.","commit_id":"2c5c3d0ab3e5b92c4c11d0713e0546b57f8edfce"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"53786e232908e9dfc7ff0f6207265d8fe1760bd2","unresolved":true,"context_lines":[{"line_number":393,"context_line":"# NB: this is the constant variable name used in the installation scripts in the"},{"line_number":394,"context_line":"# parent images (bifrost-* for example) and some Dockerfiles (kolla-toolbox)."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"ENV UPPER_CONSTRAINTS_FILE\u003dhttps://releases.openstack.org/constraints/upper/{{ openstack_release }}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# the variables like PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, PIP_TRUSTED_HOST and"},{"line_number":399,"context_line":"# all other PIP_* should be also defined here."}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ad6564d6_2307d7f7","line":396,"in_reply_to":"153d62ec_af336c1e","updated":"2021-09-02 12:23:14.000000000","message":"This is required for bifrost kolla images, and since I57ef2944f4c2b643d240f30cac46ad91662ff538 this is the one and only way to override requirements!","commit_id":"2c5c3d0ab3e5b92c4c11d0713e0546b57f8edfce"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b356d28b6c53d4813cd05e2208322d0e71d9681e","unresolved":false,"context_lines":[{"line_number":393,"context_line":"# NB: this is the constant variable name used in the installation scripts in the"},{"line_number":394,"context_line":"# parent images (bifrost-* for example) and some Dockerfiles (kolla-toolbox)."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"ENV UPPER_CONSTRAINTS_FILE\u003dhttps://releases.openstack.org/constraints/upper/{{ openstack_release }}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# the variables like PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, PIP_TRUSTED_HOST and"},{"line_number":399,"context_line":"# all other PIP_* should be also defined here."}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"72ae2185_863997b0","line":396,"in_reply_to":"ad6564d6_2307d7f7","updated":"2021-09-03 04:40:40.000000000","message":"Done","commit_id":"2c5c3d0ab3e5b92c4c11d0713e0546b57f8edfce"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"52f86b45db93980df6af17ac4d6d579ed2f228c5","unresolved":true,"context_lines":[{"line_number":390,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"{% block base_pip_conf %}"},{"line_number":393,"context_line":"# the variables like PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, PIP_TRUSTED_HOST etc. should be defined here."},{"line_number":394,"context_line":"# ENV PIP_INDEX_URL\u003dhttps://pypi.python.org/simple"},{"line_number":395,"context_line":"# ENV PIP_TRUSTED_HOST\u003dpypi.python.org"},{"line_number":396,"context_line":"# ENV UPPER_CONSTRAINTS_FILE\u003dhttps://releases.openstack.org/constraints/upper/{{ openstack_release }}"},{"line_number":397,"context_line":"{% endblock %}"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"{% block base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7b1f00e4_e9c87e87","line":396,"range":{"start_line":393,"start_character":0,"end_line":396,"end_character":101},"updated":"2021-09-08 13:34:57.000000000","message":"Can we get this in the docs instead of here?","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9df0cfdfd8f2e5023db7fa70756d15f73a46388c","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"{% block base_pip_conf %}"},{"line_number":393,"context_line":"# the variables like PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, PIP_TRUSTED_HOST etc. should be defined here."},{"line_number":394,"context_line":"# ENV PIP_INDEX_URL\u003dhttps://pypi.python.org/simple"},{"line_number":395,"context_line":"# ENV PIP_TRUSTED_HOST\u003dpypi.python.org"},{"line_number":396,"context_line":"# ENV UPPER_CONSTRAINTS_FILE\u003dhttps://releases.openstack.org/constraints/upper/{{ openstack_release }}"},{"line_number":397,"context_line":"{% endblock %}"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"{% block base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"199a257a_058636cf","line":396,"range":{"start_line":393,"start_character":0,"end_line":396,"end_character":101},"in_reply_to":"7b1f00e4_e9c87e87","updated":"2021-09-09 19:41:03.000000000","message":"Good point. Will add the documentation too.","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"df68016bc89bdc7aefdaba9029b901afaa55ba06","unresolved":true,"context_lines":[{"line_number":404,"context_line":"    \u0026\u0026 chmod 2775 /var/log/kolla \\"},{"line_number":405,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"{% block base_pip_conf %}"},{"line_number":408,"context_line":"# the variables like PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, PIP_TRUSTED_HOST etc. should be defined here."},{"line_number":409,"context_line":"# ENV PIP_INDEX_URL\u003dhttps://pypi.python.org/simple"},{"line_number":410,"context_line":"# ENV PIP_TRUSTED_HOST\u003dpypi.python.org"},{"line_number":411,"context_line":"# ENV UPPER_CONSTRAINTS_FILE\u003dhttps://releases.openstack.org/constraints/upper/{{ openstack_release }}"},{"line_number":412,"context_line":"{% endblock %}"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":415,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"082fb26d_d6352fae","line":412,"range":{"start_line":407,"start_character":0,"end_line":412,"end_character":14},"updated":"2022-03-10 07:53:46.000000000","message":"update tests/templates/template_overrides.j2 to use this.","commit_id":"f4820b11ab811ee5f597b0cde9162aff40299ab4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f20a58706d6b9a6d9da8a6fb8376fd22226a73d3","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    \u0026\u0026 chmod 2775 /var/log/kolla \\"},{"line_number":405,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"{% block base_pip_conf %}"},{"line_number":408,"context_line":"# the variables like PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, PIP_TRUSTED_HOST etc. should be defined here."},{"line_number":409,"context_line":"# ENV PIP_INDEX_URL\u003dhttps://pypi.python.org/simple"},{"line_number":410,"context_line":"# ENV PIP_TRUSTED_HOST\u003dpypi.python.org"},{"line_number":411,"context_line":"# ENV UPPER_CONSTRAINTS_FILE\u003dhttps://releases.openstack.org/constraints/upper/{{ openstack_release }}"},{"line_number":412,"context_line":"{% endblock %}"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":415,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5a217900_e964d514","line":412,"range":{"start_line":407,"start_character":0,"end_line":412,"end_character":14},"in_reply_to":"082fb26d_d6352fae","updated":"2022-03-10 08:16:01.000000000","message":"Done","commit_id":"f4820b11ab811ee5f597b0cde9162aff40299ab4"}],"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e18d191d559378fb79dff882c24d032fc2c61901","unresolved":true,"context_lines":[{"line_number":104,"context_line":"{% endblock %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"{% block fluentd_monasca_plugin_version %}"},{"line_number":107,"context_line":"ENV monasca_output_plugin_version\u003d1.0.2"},{"line_number":108,"context_line":"ENV monasca_output_plugin_url\u003dhttps://github.com/monasca/fluentd-monasca/archive/$monasca_output_plugin_version.tar.gz"},{"line_number":109,"context_line":"{% endblock %}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% block fluentd_monasca_plugin_install %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1b980ac5_60f342c8","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":118},"updated":"2021-08-24 13:48:35.000000000","message":"What is the rationale for changing from ARG to ENV? ENV is preserved in a running container, which doesn\u0027t make sense for variables we only use during build time.","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"76a01e87b97c5de425d8a0b47d3f478556864501","unresolved":false,"context_lines":[{"line_number":104,"context_line":"{% endblock %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"{% block fluentd_monasca_plugin_version %}"},{"line_number":107,"context_line":"ENV monasca_output_plugin_version\u003d1.0.2"},{"line_number":108,"context_line":"ENV monasca_output_plugin_url\u003dhttps://github.com/monasca/fluentd-monasca/archive/$monasca_output_plugin_version.tar.gz"},{"line_number":109,"context_line":"{% endblock %}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% block fluentd_monasca_plugin_install %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ebebc4f0_a7663d98","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":118},"in_reply_to":"1b980ac5_60f342c8","updated":"2021-08-24 14:03:00.000000000","message":"this is needed for support at least, the engineer can see the version of the plugin and the url  in runtime. BTW, the another one and the only one place where ARG is used - the prometheus-mtail container. all the other containers, for example zookeeper, kafka and all the prometheus uses ENV already.","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b91c50f579fd82067e4f1df7e094864517886a4f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"{% endblock %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"{% block fluentd_monasca_plugin_version %}"},{"line_number":107,"context_line":"ENV monasca_output_plugin_version\u003d1.0.2"},{"line_number":108,"context_line":"ENV monasca_output_plugin_url\u003dhttps://github.com/monasca/fluentd-monasca/archive/$monasca_output_plugin_version.tar.gz"},{"line_number":109,"context_line":"{% endblock %}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"{% block fluentd_monasca_plugin_install %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e2b28d48_dd58b242","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":118},"in_reply_to":"ebebc4f0_a7663d98","updated":"2021-08-24 14:32:34.000000000","message":"ARG should be used everywhere instead of ENV, we shouldn\u0027t keep useless variables at runtime, even for engineers.\n\nIf your engineers want to get the info they can have it from opendev repos.","commit_id":"c25a49cd393709f3fa70d883974a780f14900b10"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"85baf32d15686c7bf1d0d56f1775b47dbfeedd02","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ca798839_20381f7e","line":77,"range":{"start_line":77,"start_character":50,"end_line":77,"end_character":150},"updated":"2021-09-06 08:11:04.000000000","message":"It is defined in base image so why \u0027use default\u0027 here?","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9df0cfdfd8f2e5023db7fa70756d15f73a46388c","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"615bc2aa_51f15a97","line":77,"range":{"start_line":77,"start_character":50,"end_line":77,"end_character":150},"in_reply_to":"473aaa5f_f5493c90","updated":"2021-09-09 19:41:03.000000000","message":"This is not an example. This is variable expansion, so if the variable UPPER_CONSTRAINTS_FILE is defined (in the base image for example) it used here, otherwise the default URL provided here used.","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"21d15a73d61fff1386ca4632c2405d0a141fa1fb","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"a1c51e50_e53b1e57","line":77,"range":{"start_line":77,"start_character":50,"end_line":77,"end_character":150},"in_reply_to":"615bc2aa_51f15a97","updated":"2021-11-16 09:36:12.000000000","message":"You set that in base image so just use it without doing fallbacks.","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8fdb1ce0d0ea5f13eea68e8452156ee11b9638cd","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"8bed013b_56e9f3a8","line":77,"range":{"start_line":77,"start_character":50,"end_line":77,"end_character":150},"in_reply_to":"a1c51e50_e53b1e57","updated":"2021-11-24 17:42:45.000000000","message":"no! the change on this line means: if env variable exists use it, otherwise use default (which I didn\u0027t change).","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"45e8a1373dcaf2e0a084356d50ee1b42fbe3fe44","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"e70e5592_675be78e","line":77,"range":{"start_line":77,"start_character":50,"end_line":77,"end_character":150},"in_reply_to":"ca798839_20381f7e","updated":"2021-09-06 08:13:33.000000000","message":"it\u0027s a comment with example","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"52f86b45db93980df6af17ac4d6d579ed2f228c5","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"473aaa5f_f5493c90","line":77,"range":{"start_line":77,"start_character":50,"end_line":77,"end_character":150},"in_reply_to":"e70e5592_675be78e","updated":"2021-09-08 13:34:57.000000000","message":"Doesn\u0027t look like a comment.","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a1cebaa32dfcb8a96c139cc8f4e32f04b1086dfe","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"13f752b7_4d915dfe","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":150},"updated":"2021-10-28 11:12:23.000000000","message":"Can this default be set in base image?\n\nSo it will be set in all images - will make life easier.","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"af8b322b5dbad368a8839438aa6d510bf93993f3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block kolla_toolbox_upper_constraints %}"},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages | customizable(\"pip_virtualenv_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":80,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"4768ab62_1dde2f61","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":150},"in_reply_to":"13f752b7_4d915dfe","updated":"2021-11-03 09:23:30.000000000","message":"yep! the idea exactly the same. this is variable expansion. you could set the variable UPPER_CONSTRAINTS_FILE anywhere you wish (for example in base image) and the value will be used here instead of default url.","commit_id":"d3babc17762f1bfdee29202ee00d87dd6f6edef8"}],"releasenotes/notes/generic-customisation-b2d431caa2fc5c10.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"eaa581ea4cf662f77f7a03b75c12b8eb05c70e11","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    at build time for offline build scenario. We need some required environment"},{"line_number":6,"context_line":"    variables configured at the top level for all containers, for example the"},{"line_number":7,"context_line":"    variable UPPER_CONSTRAINTS_FILE used by the bifrost-deploy installation"},{"line_number":8,"context_line":"    scripts. Also here we can override the address of the PyPi repository via"},{"line_number":9,"context_line":"    PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, and PIP_TRUSTED_HOST variables."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ee0e3e5_5e0db155","line":8,"range":{"start_line":8,"start_character":58,"end_line":8,"end_character":63},"updated":"2021-09-03 14:41:03.000000000","message":"nit: PyPI","commit_id":"1740a1f6c0f890020a49f422c8d3c2e883f0c0ab"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c202217107fbf88a6c82f18e601d249c15220817","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    at build time for offline build scenario. We need some required environment"},{"line_number":6,"context_line":"    variables configured at the top level for all containers, for example the"},{"line_number":7,"context_line":"    variable UPPER_CONSTRAINTS_FILE used by the bifrost-deploy installation"},{"line_number":8,"context_line":"    scripts. Also here we can override the address of the PyPi repository via"},{"line_number":9,"context_line":"    PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, and PIP_TRUSTED_HOST variables."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"8fc3faf1_ab295a95","line":8,"range":{"start_line":8,"start_character":58,"end_line":8,"end_character":63},"in_reply_to":"5ee0e3e5_5e0db155","updated":"2021-09-03 21:11:50.000000000","message":"Done","commit_id":"1740a1f6c0f890020a49f422c8d3c2e883f0c0ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"eaa581ea4cf662f77f7a03b75c12b8eb05c70e11","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    All Dockerfile files which uses curl to download any external files from the"},{"line_number":13,"context_line":"    Internet URLs now have the corresponding version templating block which can"},{"line_number":14,"context_line":"    be used to override them. Also all the ENV instructions inside these blocks"},{"line_number":15,"context_line":"    converted to the ARG instructions to minimize the unneeded variabless."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"599c23b9_70355bec","line":15,"range":{"start_line":15,"start_character":63,"end_line":15,"end_character":73},"updated":"2021-09-03 14:41:03.000000000","message":"nit: variables","commit_id":"1740a1f6c0f890020a49f422c8d3c2e883f0c0ab"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c202217107fbf88a6c82f18e601d249c15220817","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    All Dockerfile files which uses curl to download any external files from the"},{"line_number":13,"context_line":"    Internet URLs now have the corresponding version templating block which can"},{"line_number":14,"context_line":"    be used to override them. Also all the ENV instructions inside these blocks"},{"line_number":15,"context_line":"    converted to the ARG instructions to minimize the unneeded variabless."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b9c3deb3_34d8cbe1","line":15,"range":{"start_line":15,"start_character":63,"end_line":15,"end_character":73},"in_reply_to":"599c23b9_70355bec","updated":"2021-09-03 21:11:50.000000000","message":"Done","commit_id":"1740a1f6c0f890020a49f422c8d3c2e883f0c0ab"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"52f86b45db93980df6af17ac4d6d579ed2f228c5","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    All Dockerfile files which uses curl to download any external files from the"},{"line_number":13,"context_line":"    Internet URLs now have the corresponding version templating block which can"},{"line_number":14,"context_line":"    be used to override them. Also all the ENV instructions inside these blocks"},{"line_number":15,"context_line":"    converted to the ARG instructions to minimize the unneeded variables."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"73fad155_45d8d640","line":14,"range":{"start_line":14,"start_character":15,"end_line":14,"end_character":28},"updated":"2021-09-08 13:34:57.000000000","message":"Examples in docs would be really helpful for users here.","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9df0cfdfd8f2e5023db7fa70756d15f73a46388c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    All Dockerfile files which uses curl to download any external files from the"},{"line_number":13,"context_line":"    Internet URLs now have the corresponding version templating block which can"},{"line_number":14,"context_line":"    be used to override them. Also all the ENV instructions inside these blocks"},{"line_number":15,"context_line":"    converted to the ARG instructions to minimize the unneeded variables."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"641edff3_03ae4a06","line":14,"range":{"start_line":14,"start_character":15,"end_line":14,"end_character":28},"in_reply_to":"73fad155_45d8d640","updated":"2021-09-09 19:41:03.000000000","message":"This is already described here: https://docs.openstack.org/kolla/latest/admin/image-building.html#generic-customisation","commit_id":"371b4d6d978134f76e010cae9d793f9c16864d04"}]}