)]}'
{"docker/elasticsearch/elasticsearch-curator/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f9c3273f149db55edba253102c40b71e6dfef4b9","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":28,"context_line":"    \u0027elasticsearch\u003d\u003d7.12.0\u0027,"},{"line_number":29,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":30,"context_line":"] %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"554b7f83_c470572a","line":28,"updated":"2021-08-26 08:44:26.000000000","message":"Would probably prefer to see this as \u003e\u003d7.12.0,\u003c8.0.0.","commit_id":"4be766a78083236a7766b0c174d370b4f08a8ba9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5bd81ca2969c7d1a617f604eef88daf8f73e2a7e","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":28,"context_line":"    \u0027elasticsearch\u003d\u003d7.12.0\u0027,"},{"line_number":29,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":30,"context_line":"] %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a1c1f154_7903f3c9","line":28,"in_reply_to":"220155cb_8a3d2b68","updated":"2021-08-26 10:12:34.000000000","message":"Ah, ok. Let\u0027s go with \u003c7.14 then, in case there are bug fix releases. Could you also add a comment explaining the pin.","commit_id":"4be766a78083236a7766b0c174d370b4f08a8ba9"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"038cfe1e2ccff78cb0d326df27d32bf12ebac63e","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":28,"context_line":"    \u0027elasticsearch\u003d\u003d7.12.0\u0027,"},{"line_number":29,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":30,"context_line":"] %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"220155cb_8a3d2b68","line":28,"in_reply_to":"554b7f83_c470572a","updated":"2021-08-26 08:49:55.000000000","message":"The point is - 7.14.0 does not work. I need to re-word the commit message","commit_id":"4be766a78083236a7766b0c174d370b4f08a8ba9"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"049b03c900b7f2f4393f2594c74b1f8eadd857c7","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":28,"context_line":"    \u0027elasticsearch\u003d\u003d7.12.0\u0027,"},{"line_number":29,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":30,"context_line":"] %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5abd0a04_d4ba463f","line":28,"in_reply_to":"a1c1f154_7903f3c9","updated":"2021-08-26 12:08:04.000000000","message":"I did that in patchset 1, pip install failed miserably due to lack of quoting - unsure how to solve this https://zuul.opendev.org/t/openstack/build/11a9fc9f58394dbd88c72b80f9f1e950/log/kolla/build/elasticsearch-curator.log","commit_id":"4be766a78083236a7766b0c174d370b4f08a8ba9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2bff261996f25e8a3760d1326cccc0312bb4de72","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(parallax): pin elasticsearch due to bug https://bugs.launchpad.net/kolla/+bug/1941073"},{"line_number":28,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027elasticsearch\u003d\u003d7.13.4\u0027,"},{"line_number":30,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":31,"context_line":"] %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"8d429008_42b480e0","line":29,"updated":"2021-08-30 14:32:16.000000000","message":"Is it good idea to pin to specific version ? I am asking because 7.14.0 has in release note this: \n\n\"Added check that client is connected to an Elasticsearch cluster. If the client isn’t connected to a supported Elasticsearch cluster the UnsupportedProductError exception will be raised.\"\n\nWhen I check a code (https://github.com/elastic/elasticsearch-py/blob/v7.14.0/elasticsearch/transport.py#L677) there is 7.14.0+ supported (and there are some more checks)\n\nVersion, build_flavor, x-elastic-product etc ... :\n\nhttps://github.com/elastic/elasticsearch-py/blob/v7.14.0/elasticsearch/transport.py#L633-L681\n\nKolla image reporting \n\n* Connected to 192.168.205.11 (192.168.205.11) port 9200 (#0)\n\u003e GET / HTTP/1.1\n\u003e Host: 192.168.205.11:9200\n\u003e User-Agent: curl/7.68.0\n\u003e Accept: */*\n\u003e \n* Mark bundle as not supporting multiuse\n\u003c HTTP/1.1 200 OK\n\u003c content-type: application/json; charset\u003dUTF-8\n\u003c content-length: 536\n\u003c \n{\n  \"name\" : \"192.168.205.11\",\n  \"cluster_name\" : \"kolla_logging\",\n  \"cluster_uuid\" : \"mg0k-R6LQGGhlovgrbTRMA\",\n  \"version\" : {\n    \"number\" : \"7.10.2\",\n    \"build_flavor\" : \"oss\",\n    \"build_type\" : \"deb\",\n    \"build_hash\" : \"747e1cc71def077253878a59143c1f785afa92b9\",\n    \"build_date\" : \"2021-01-13T00:42:12.435326Z\",\n    \"build_snapshot\" : false,\n    \"lucene_version\" : \"8.7.0\",\n    \"minimum_wire_compatibility_version\" : \"6.8.0\",\n    \"minimum_index_compatibility_version\" : \"6.0.0-beta1\"\n  },\n  \"tagline\" : \"You Know, for Search\"\n}\n\n\n\nI\u0027m not saying this is bad ..I am just confused, because don\u0027t know how to solve this to future \nDoes it mean that we will have to use old library ? Until they will support oss version (If they will of course) ?\n\nFor now this makes sense for me and giving +1.","commit_id":"041da935292472adcd1a1343d9c282e27bdc9b5d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0543c26cad7358b2baf37d68a4c7647d01b2a2e4","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(parallax): pin elasticsearch due to bug https://bugs.launchpad.net/kolla/+bug/1941073"},{"line_number":28,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027elasticsearch\u003d\u003d7.13.4\u0027,"},{"line_number":30,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":31,"context_line":"] %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ca7219af_5d7d17f6","line":29,"in_reply_to":"8d429008_42b480e0","updated":"2021-08-31 09:23:33.000000000","message":"Elsewhere (e.g. kolla-toolbox) we use 7.13.*","commit_id":"041da935292472adcd1a1343d9c282e27bdc9b5d"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"5ef27716b0df3f317bd7636eccb9a736a7ff77af","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(parallax): pin elasticsearch due to bug https://bugs.launchpad.net/kolla/+bug/1941073"},{"line_number":28,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027elasticsearch\u003d\u003d7.13.4\u0027,"},{"line_number":30,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":31,"context_line":"] %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"b653aad4_9505e04d","line":29,"in_reply_to":"ca7219af_5d7d17f6","updated":"2021-08-31 11:01:50.000000000","message":"Ack","commit_id":"041da935292472adcd1a1343d9c282e27bdc9b5d"}],"releasenotes/notes/fix-elasticsearch-curator-7876896ebbd41ad3.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e71ab7e8322d299bdfe010eada246894dd048b23","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with Elasticsearch curator not working due to too new"},{"line_number":5,"context_line":"    python elasticsearch library. See `bug 1941073"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1941073\u003e`__ for details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c48a5eb3_b9c1f9b8","line":6,"range":{"start_line":5,"start_character":34,"end_line":6,"end_character":75},"updated":"2021-08-27 18:02:49.000000000","message":"LP#... syntax is much less verbose.","commit_id":"041da935292472adcd1a1343d9c282e27bdc9b5d"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"5ef27716b0df3f317bd7636eccb9a736a7ff77af","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with Elasticsearch curator not working due to too new"},{"line_number":5,"context_line":"    python elasticsearch library. See `bug 1941073"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1941073\u003e`__ for details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d6c05d26_39355948","line":6,"range":{"start_line":5,"start_character":34,"end_line":6,"end_character":75},"in_reply_to":"c48a5eb3_b9c1f9b8","updated":"2021-08-31 11:01:50.000000000","message":"Ack","commit_id":"041da935292472adcd1a1343d9c282e27bdc9b5d"}]}