)]}'
{"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"17698a3987d2efc6dc3c711b85d7a5b85ca7bbc7","unresolved":true,"context_lines":[{"line_number":106,"context_line":"COPY ansible.cfg /etc/ansible/kolla.cfg"},{"line_number":107,"context_line":"RUN chmod 644 /usr/share/ansible/find_disks.py \\"},{"line_number":108,"context_line":"              /etc/ansible/kolla.cfg"},{"line_number":109,"context_line":"ENV ANSIBLE_CONFIG /etc/ansible/kolla.cfg"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"COPY ansible_sudoers /etc/sudoers.d/kolla_ansible_sudoers"},{"line_number":112,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_ansible_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"98414356_67a41f34","line":109,"range":{"start_line":109,"start_character":32,"end_line":109,"end_character":37},"updated":"2021-09-07 08:33:16.000000000","message":"any reason not to use the default ansible.cfg?","commit_id":"6103790d5b03e04e3b14a309903e7ef800c52818"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b7e11d28aaec6be0017585f59b5d4709c6a83406","unresolved":true,"context_lines":[{"line_number":106,"context_line":"COPY ansible.cfg /etc/ansible/kolla.cfg"},{"line_number":107,"context_line":"RUN chmod 644 /usr/share/ansible/find_disks.py \\"},{"line_number":108,"context_line":"              /etc/ansible/kolla.cfg"},{"line_number":109,"context_line":"ENV ANSIBLE_CONFIG /etc/ansible/kolla.cfg"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"COPY ansible_sudoers /etc/sudoers.d/kolla_ansible_sudoers"},{"line_number":112,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_ansible_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"405e723e_4d39855a","line":109,"range":{"start_line":109,"start_character":32,"end_line":109,"end_character":37},"in_reply_to":"98414356_67a41f34","updated":"2021-09-07 12:09:40.000000000","message":"Actually we can and it will be more straighforward.","commit_id":"6103790d5b03e04e3b14a309903e7ef800c52818"}],"docker/kolla-toolbox/extend_start.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e7ff6c724aa413f8d78108f113d2ec78dcf69d9c","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [[ $(stat -c %a /var/log/kolla/ansible.log) !\u003d \"664\" ]]; then"},{"line_number":12,"context_line":"    chmod 664 /var/log/kolla/ansible.log"},{"line_number":13,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"e94f6108_278086b4","line":13,"updated":"2021-09-08 09:01:14.000000000","message":"Is it really required here and in config.json?","commit_id":"88f1e32aa997b2b8c3627cd4b2128402262fdef4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"bf8035d7c04e3e7acea1c0b7861d050cf70066cc","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [[ $(stat -c %a /var/log/kolla/ansible.log) !\u003d \"664\" ]]; then"},{"line_number":12,"context_line":"    chmod 664 /var/log/kolla/ansible.log"},{"line_number":13,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"55d32e40_1f0ab3ef","line":13,"in_reply_to":"25a51253_3f3bd879","updated":"2021-09-08 12:28:21.000000000","message":"I guess it\u0027s not required in kolla-ansible then.","commit_id":"88f1e32aa997b2b8c3627cd4b2128402262fdef4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d2c8cd04a0321b8cff1ee5c06e5d3b795650a509","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [[ $(stat -c %a /var/log/kolla/ansible.log) !\u003d \"664\" ]]; then"},{"line_number":12,"context_line":"    chmod 664 /var/log/kolla/ansible.log"},{"line_number":13,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3168dfa8_7609645f","line":13,"in_reply_to":"55d32e40_1f0ab3ef","updated":"2021-09-08 13:26:02.000000000","message":"Not required, only useful if those permissions change over time for some reason ;-)","commit_id":"88f1e32aa997b2b8c3627cd4b2128402262fdef4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ba839a66a23c397dc6aaa81103878c1625805b6f","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [[ $(stat -c %a /var/log/kolla/ansible.log) !\u003d \"664\" ]]; then"},{"line_number":12,"context_line":"    chmod 664 /var/log/kolla/ansible.log"},{"line_number":13,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"25a51253_3f3bd879","line":13,"in_reply_to":"e94f6108_278086b4","updated":"2021-09-08 09:08:11.000000000","message":"Yes it is, config.json only changes permissions of files on startup, on first startup - the file is not there. So first kolla_toolbox module invocation creates ansible.log using ansible user as owner and 644, and then rabbitmq-service roles uses rabbitmq user - and it fails ;-)\nWe could make a change in the kolla startup scripts to create an empty file if it doesn\u0027t exist and set proper permissions - we could get rid of this type of scripts baked in the images.","commit_id":"88f1e32aa997b2b8c3627cd4b2128402262fdef4"}]}
