)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03dfaf1dca7886f2c5822328870ad445dd880d17","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-05 08:51:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder-volume: Install binary libraries only in binary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iee451db823a15b40f9e893c1febfd910c336ddec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0b23db30_a3e0f618","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":30},"updated":"2021-10-05 08:54:06.000000000","message":"python","commit_id":"23a498a2f85d3082eedeb76c0080d30ced1bc470"}],"docker/cinder/cinder-volume/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"158579ebf4c15f6d760106b429c9fbb8e73ac802","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    {% set cinder_volume_packages \u003d ["},{"line_number":12,"context_line":"            \u0027nfs-utils\u0027,"},{"line_number":13,"context_line":"            \u0027nvmetcli\u0027,"},{"line_number":14,"context_line":"            \u0027python3-rtslib\u0027,"},{"line_number":15,"context_line":"            \u0027python3-cinderlib\u0027,"},{"line_number":16,"context_line":"            \u0027sysfsutils\u0027,"},{"line_number":17,"context_line":"            \u0027targetcli\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"eed942b5_3d7bcd8d","side":"PARENT","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":27},"updated":"2021-09-21 06:20:20.000000000","message":"that should come from pypi too, no?","commit_id":"e998831b9bbcb808effb0c92be5568cbcaf6142f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"158579ebf4c15f6d760106b429c9fbb8e73ac802","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"{% set cinder_volume_pip_packages \u003d ["},{"line_number":57,"context_line":"    \u0027/cinderlib\u0027"},{"line_number":58,"context_line":"] %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"ADD cinder-volume-archive /cinder-volume-source"},{"line_number":61,"context_line":"RUN ln -s cinder-volume-source/* cinderlib \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2d7aebd1_17e07bdd","line":58,"range":{"start_line":56,"start_character":0,"end_line":58,"end_character":4},"updated":"2021-09-21 06:20:20.000000000","message":"is the one in PyPI not fine? for other projects we get this from PyPI","commit_id":"0538c35027a443f1de3835190e584408863b3b8b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c656c8170d7334a9be6fcb760999d09f435de4f6","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        {% set cinder_volume_packages \u003d ["},{"line_number":42,"context_line":"            \u0027python3-cinderlib\u0027,"},{"line_number":43,"context_line":"            \u0027python3-rtslib\u0027"},{"line_number":44,"context_line":"        ] %}"},{"line_number":45,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":46,"context_line":"        {% set cinder_volume_packages \u003d ["},{"line_number":47,"context_line":"            \u0027cinder-volume\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8bfcb512_ffc1a492","line":44,"updated":"2021-10-04 15:04:26.000000000","message":"this branch is missing installation macro; we need to fix this file entirely - for binary extend package list before the first installation as it\u0027s done in other images and only then call the macro once (as for the packages - we only need rtslib; see the general comment)","commit_id":"581570620a9894a2575747861e927adadebeba64"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c656c8170d7334a9be6fcb760999d09f435de4f6","unresolved":true,"context_lines":[{"line_number":51,"context_line":"{{ macros.install_packages(cinder_volume_packages | customizable(\"packages\")) }}"},{"line_number":52,"context_line":"    {% endif %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"{% set cinder_volume_pip_packages \u003d ["},{"line_number":57,"context_line":"    \u0027cinderlib\u0027"},{"line_number":58,"context_line":"] %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"RUN {{ macros.install_pip(cinder_volume_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"COPY cinder_sudoers /etc/sudoers.d/kolla_cinder_volume_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"524dfdfd_4770e72c","line":61,"range":{"start_line":54,"start_character":0,"end_line":61,"end_character":0},"updated":"2021-10-04 15:04:26.000000000","message":"can be dropped entirely","commit_id":"581570620a9894a2575747861e927adadebeba64"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03dfaf1dca7886f2c5822328870ad445dd880d17","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            \u0027targetcli\u0027"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block cinder_volume_redhat_setup %}"},{"line_number":19,"context_line":"{% endblock %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":22,"context_line":"    {% set cinder_volume_packages \u003d ["},{"line_number":23,"context_line":"            \u0027nfs-common\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"2ffe0d10_3a11f53c","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":0},"updated":"2021-10-05 08:54:06.000000000","message":"this can\u0027t work here","commit_id":"23a498a2f85d3082eedeb76c0080d30ced1bc470"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03dfaf1dca7886f2c5822328870ad445dd880d17","unresolved":true,"context_lines":[{"line_number":27,"context_line":"            \u0027tgt\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block cinder_volume_ubuntu_setup %}"},{"line_number":31,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"},{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa965756_bc27dc72","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":14},"updated":"2021-10-05 08:54:06.000000000","message":"this can\u0027t work here","commit_id":"23a498a2f85d3082eedeb76c0080d30ced1bc470"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03dfaf1dca7886f2c5822328870ad445dd880d17","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            \u0027cinder-volume\u0027,"},{"line_number":45,"context_line":"            \u0027python3-rtslib-fb\u0027"},{"line_number":46,"context_line":"        ] %}"},{"line_number":47,"context_line":"{% endif %}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{{ macros.install_packages(cinder_volume_packages | customizable(\"packages\")) }}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a60cd678_6de5f493","line":47,"updated":"2021-10-05 08:54:06.000000000","message":"one endif missing","commit_id":"23a498a2f85d3082eedeb76c0080d30ced1bc470"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a2b07e25053e0eba020ec7320d321bc043c9f6de","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":18,"context_line":"        {% set cinder_volume_packages \u003d cinder_volume_packages + ["},{"line_number":19,"context_line":"            \u0027python3-cinderlib\u0027,"},{"line_number":20,"context_line":"            \u0027python3-rtslib\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"867b55e6_1cc967ba","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":30},"updated":"2021-10-11 09:27:38.000000000","message":"Seems we lose this one in source mode. Shouldn\u0027t we be consistent - keep it or not?","commit_id":"eb2d4ccac636543aaa28c7cbbe7de9bcca968ac2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b40604de764703c366bb9a9f78b16811374bafd9","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":18,"context_line":"        {% set cinder_volume_packages \u003d cinder_volume_packages + ["},{"line_number":19,"context_line":"            \u0027python3-cinderlib\u0027,"},{"line_number":20,"context_line":"            \u0027python3-rtslib\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"0f885d2d_1d61ec25","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":30},"in_reply_to":"867b55e6_1cc967ba","updated":"2021-10-11 13:01:14.000000000","message":"I would drop it. It\u0027s not the place for it.","commit_id":"eb2d4ccac636543aaa28c7cbbe7de9bcca968ac2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a2b07e25053e0eba020ec7320d321bc043c9f6de","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":18,"context_line":"        {% set cinder_volume_packages \u003d cinder_volume_packages + ["},{"line_number":19,"context_line":"            \u0027python3-cinderlib\u0027,"},{"line_number":20,"context_line":"            \u0027python3-rtslib\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"    {% endif %}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"00c0801c_7d63bad7","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":27},"updated":"2021-10-11 09:27:38.000000000","message":"What happens with this?","commit_id":"eb2d4ccac636543aaa28c7cbbe7de9bcca968ac2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f9a0188052521da83601456ac9a26f325fba60d4","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":18,"context_line":"        {% set cinder_volume_packages \u003d cinder_volume_packages + ["},{"line_number":19,"context_line":"            \u0027python3-cinderlib\u0027,"},{"line_number":20,"context_line":"            \u0027python3-rtslib\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"    {% endif %}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"72dfe054_96cc385c","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":27},"in_reply_to":"00c0801c_7d63bad7","updated":"2021-10-11 09:31:21.000000000","message":"ok, see it in requirements.txt.","commit_id":"eb2d4ccac636543aaa28c7cbbe7de9bcca968ac2"}],"kolla/common/config.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c656c8170d7334a9be6fcb760999d09f435de4f6","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":305,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/cinder/\u0027"},{"line_number":306,"context_line":"                     \u0027cinder-${openstack_branch}.tar.gz\u0027)},"},{"line_number":307,"context_line":"    \u0027cinder-volume\u0027: {"},{"line_number":308,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":309,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/cinderlib/\u0027"},{"line_number":310,"context_line":"                     \u0027cinderlib-${openstack_branch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":2,"id":"be916bca_5bf43784","line":307,"updated":"2021-10-04 15:04:26.000000000","message":"drop this","commit_id":"581570620a9894a2575747861e927adadebeba64"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d51d571aac4bdf77409c13c7a7cfad8d6b9842a0","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":305,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/cinder/\u0027"},{"line_number":306,"context_line":"                     \u0027cinder-${openstack_branch}.tar.gz\u0027)},"},{"line_number":307,"context_line":"    \u0027cinder-volume\u0027: {"},{"line_number":308,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":309,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/cinderlib/\u0027"},{"line_number":310,"context_line":"                     \u0027cinderlib-${openstack_branch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":4,"id":"547b070b_faffbfad","line":307,"updated":"2021-10-05 09:18:43.000000000","message":"drop it","commit_id":"1e0f8c67e80d1f6e0a4d1255159e23aaaab4d365"}]}