)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2f6402a25d328c6692eb1f6bb0a24ca0dd1f086e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e0dac2aa_bd9263c6","updated":"2021-11-12 09:12:04.000000000","message":"Someone to review this ? It\u0027s quite trivial change - and usefull ","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"203aefa562e2f5b8916998c8fa560ab8cb47a8bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e2f1944d_51ceafa4","updated":"2021-11-13 07:05:02.000000000","message":"I like this better than the earlier versions, but not sure I\u0027d give it a +1, waiting for other reviews.","commit_id":"f229eb7e06173649974376cf689d676c673f4988"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"43cec314dcb44613fd19e87b8f75ac115d2289ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"abf5fac2_63573c7e","updated":"2021-11-12 16:33:52.000000000","message":"I\u0027ve also changed kolla_extend_start to extend_start.sh as other kolla images do.","commit_id":"f229eb7e06173649974376cf689d676c673f4988"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cf85ebb9dc68968a9893cc5ebb54643c7bfcf49c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d29a8082_b9bd715c","updated":"2021-12-20 16:29:22.000000000","message":"My only counter argument would have been regarding added complexity, but after I saw the stack of logrotate configs in kolla-ansible, I guess this no longer matters much.","commit_id":"f229eb7e06173649974376cf689d676c673f4988"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a06e5141edbc0114e55ee2470bcff4c5fc18e0f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ffce4bb7_84a74c89","updated":"2021-12-06 14:30:29.000000000","message":"Ping cores.","commit_id":"f229eb7e06173649974376cf689d676c673f4988"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"65a3a7f68d1540fcb60f5c2bd33d1acc8364e1a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"37367999_dadf84a2","updated":"2021-12-08 07:23:59.000000000","message":"Thanks!","commit_id":"f229eb7e06173649974376cf689d676c673f4988"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5e8134b7ccf239dd2a4d66cf3bda67026d0b4d58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7cec3f82_4f7faf80","updated":"2021-11-21 09:40:32.000000000","message":"ping","commit_id":"f229eb7e06173649974376cf689d676c673f4988"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"052c44b2bba4dff3722eca12616c4d8c826d61ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"838af862_5a9d733f","in_reply_to":"e2f1944d_51ceafa4","updated":"2021-11-13 08:06:47.000000000","message":"What is the thing you don\u0027t like ?","commit_id":"f229eb7e06173649974376cf689d676c673f4988"}],"docker/cron/Dockerfile.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"119ff9435c5cecc9ef7307cedeadc417ada6e18c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{{ macros.install_packages(cron_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"COPY kolla_extend_start /usr/local/bin/"},{"line_number":25,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% block cron_footer %}{% endblock %}"},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"768aefe8_f30ad966","line":25,"updated":"2021-11-12 12:16:32.000000000","message":"Is this really needed or could we just have the file with the correct permissions in git directly?","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8efbca130b4683c8896338df83d7884d5fc6675","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{{ macros.install_packages(cron_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"COPY kolla_extend_start /usr/local/bin/"},{"line_number":25,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% block cron_footer %}{% endblock %}"},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"680b9c7c_8ed6779a","line":25,"in_reply_to":"7333d473_5e2378b9","updated":"2021-11-12 14:13:21.000000000","message":"That\u0027s a valid argument indeed.","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7bc28d51e0a508b0f07aef2e3429ae8cdf1155cb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{{ macros.install_packages(cron_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"COPY kolla_extend_start /usr/local/bin/"},{"line_number":25,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% block cron_footer %}{% endblock %}"},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"7333d473_5e2378b9","line":25,"in_reply_to":"768aefe8_f30ad966","updated":"2021-11-12 13:50:17.000000000","message":"I\u0027m a big fan of doing it the way it\u0027s done elsewhere :) \n\ndocker/aodh/aodh-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_aodh_extend_start\ndocker/barbican/barbican-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_barbican_extend_start\ndocker/blazar/blazar-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_blazar_extend_start\ndocker/ceilometer/ceilometer-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_ceilometer_extend_start\ndocker/cinder/cinder-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_cinder_extend_start\ndocker/cloudkitty/cloudkitty-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_cloudkitty_extend_start\ndocker/collectd/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start \\\ndocker/cron/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/cyborg/cyborg-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_cyborg_extend_start\ndocker/designate/designate-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_designate_extend_start\ndocker/elasticsearch/elasticsearch-curator/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/elasticsearch/elasticsearch/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/etcd/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start \\\ndocker/fluentd/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/freezer/freezer-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_freezer_extend_start\ndocker/glance/glance-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_glance_extend_start\ndocker/gnocchi/gnocchi-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_gnocchi_extend_start\ndocker/grafana/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start\ndocker/hacluster/hacluster-base/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/heat/heat-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_heat_extend_start\ndocker/horizon/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/influxdb/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start\ndocker/ironic-inspector/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start \\\ndocker/ironic/ironic-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_ironic_extend_start \\\ndocker/iscsid/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start \\\ndocker/kafka/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/keepalived/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start /check_alive.sh\ndocker/keystone/keystone-fernet/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_keystone_bootstrap /usr/bin/fetch_fernet_tokens.py\ndocker/keystone/keystone-ssh/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/keystone/keystone/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_keystone_bootstrap\ndocker/kibana/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/kuryr/kuryr-base/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/logstash/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/magnum/magnum-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_magnum_extend_start\ndocker/manila/manila-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_manila_extend_start\ndocker/mariadb/mariadb-server/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start \\\ndocker/masakari/masakari-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_masakari_extend_start\ndocker/mistral/mistral-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_mistral_extend_start\ndocker/monasca/monasca-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_monasca_extend_start\ndocker/monasca/monasca-thresh/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\\ndocker/murano/murano-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_murano_extend_start\ndocker/neutron/neutron-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_neutron_extend_start\ndocker/nova/nova-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_nova_extend_start\ndocker/nova/nova-libvirt/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/nova/nova-ssh/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/octavia/octavia-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_octavia_extend_start\ndocker/openvswitch/openvswitch-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_openvswitch_extend_start\ndocker/ovn/ovn-base/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/ovsdpdk/ovsdpdk/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/placement/placement-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_placement_extend_start\ndocker/prometheus/prometheus-base/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/proxysql/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start\ndocker/qdrouterd/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start \\\ndocker/rabbitmq/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/redis/redis-base/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/sahara/sahara-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_sahara_extend_start\ndocker/senlin/senlin-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_senlin_extend_start\ndocker/skydive/skydive-base/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/solum/solum-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_solum_extend_start\ndocker/storm/storm-base/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/swift/swift-rsyncd/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/tacker/tacker-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_tacker_extend_start\ndocker/telegraf/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start\ndocker/trove/trove-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_trove_extend_start\ndocker/vitrage/vitrage-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_vitrage_extend_start\ndocker/watcher/watcher-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_watcher_extend_start\ndocker/zookeeper/Dockerfile.j2:RUN chmod 755 /usr/local/bin/kolla_extend_start\ndocker/zun/zun-base/Dockerfile.j2:    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_zun_extend_start","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"}],"docker/cron/kolla_extend_start":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32d7c514f039f1016e750d4307cf0b00941f06ea","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"43694519_6402bcce","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":123},"updated":"2021-11-12 09:48:04.000000000","message":"it would actually be easier to do it the other way around - construct the desired path first and then change it if it differs","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7bc28d51e0a508b0f07aef2e3429ae8cdf1155cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"d53362f9_7709cf82","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":123},"in_reply_to":"06553435_67b35cb7","updated":"2021-11-12 13:50:17.000000000","message":"Don\u0027t agree, this is as simple as it can be, normally you don\u0027t want to run logrotate\u0027s cron less then one hour. Even if you want to rotate logs every minute, this can be configured in logrotate itself, but cron will run every hour and split logs every minute.","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"640f5ab0f478d8349015eb3285627d29175af40a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"83b80785_1241cdb8","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":123},"in_reply_to":"43694519_6402bcce","updated":"2021-11-12 10:23:33.000000000","message":"If I\u0027m setting ENV to hourly|daily|weekly|monthly - so i wanted to compare to same list of hourly|daily|weekly|monthly. So comparing KOLLA_LOGROTATE_SCHEDULE and current_logrotate_schedule below.\n\nConstructed desired path is below and it is /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/. \nSo, it\u0027s is as you mentioned - but othervise.\n\nNow I\u0027m doing:\n                                                               no - move current to desired\nSearch for current -\u003e check if current is same as desired -\u003e /\n                                                             \\\n                                                               yes - nothing\n\nSo should I rework to as you suggested ? Is it real needed ? :\n\n                            no - search for current, move current to desired\nCheck if desired exist -\u003e /\n                          \\\n                             yes - do nothing\n\nSame idea will be used, same bash code blocks, just little bit different ifs... Is it necessary ?","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"119ff9435c5cecc9ef7307cedeadc417ada6e18c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"06553435_67b35cb7","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":123},"in_reply_to":"83b80785_1241cdb8","updated":"2021-11-12 12:16:32.000000000","message":"To me, this whole solution feels very fragile. Maybe refactor this at a higher level and move the job into /etc/cron.d and give it some explicit schedule which could then be anything?","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8efbca130b4683c8896338df83d7884d5fc6675","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"92ea7c95_b869b062","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":123},"in_reply_to":"d53362f9_7709cf82","updated":"2021-11-12 14:13:21.000000000","message":"o.k.","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32d7c514f039f1016e750d4307cf0b00941f06ea","unresolved":true,"context_lines":[{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"},{"line_number":8,"context_line":"        mv $current_logrotate_cron_path /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/"},{"line_number":9,"context_line":"        echo \"[i] Cron file for logrotate was moved to /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/logrotate.\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"387a69c8_0349b26c","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":35},"updated":"2021-11-12 09:48:04.000000000","message":"-","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"640f5ab0f478d8349015eb3285627d29175af40a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"},{"line_number":8,"context_line":"        mv $current_logrotate_cron_path /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/"},{"line_number":9,"context_line":"        echo \"[i] Cron file for logrotate was moved to /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/logrotate.\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf366488_4b236545","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":35},"in_reply_to":"387a69c8_0349b26c","updated":"2021-11-12 10:23:33.000000000","message":"correct, will fix.","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8efbca130b4683c8896338df83d7884d5fc6675","unresolved":false,"context_lines":[{"line_number":3,"context_line":"current_logrotate_cron_path\u003d$(find /etc/cron* -name logrotate)"},{"line_number":4,"context_line":"current_logrotate_schedule\u003d$(echo \"${current_logrotate_cron_path}\" | sed -r \u0027s/(.*)(hourly|daily|weekly|monthly)(.*)/\\2/g\u0027)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:\u003dundefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":7,"context_line":"    if [[ \"${KOLLA_LOGROTATE_SCHEDULE}\" !\u003d \"${current_logrotate_schedule}\" ]]; then"},{"line_number":8,"context_line":"        mv $current_logrotate_cron_path /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/"},{"line_number":9,"context_line":"        echo \"[i] Cron file for logrotate was moved to /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/logrotate.\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5b22d330_6bba83f3","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":35},"in_reply_to":"bf366488_4b236545","updated":"2021-11-12 14:13:21.000000000","message":"Done","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"119ff9435c5cecc9ef7307cedeadc417ada6e18c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"        echo \"[i] Cron file for logrotate was moved to /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/logrotate.\""},{"line_number":10,"context_line":"    fi"},{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"    echo \"[i] Cron for logrotate is currently set to: ${current_logrotate_schedule}.\""},{"line_number":13,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"8196ef56_a68db424","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":19},"updated":"2021-11-12 12:16:32.000000000","message":"If you make this \"Cron schedule\" it might be more clear.","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8efbca130b4683c8896338df83d7884d5fc6675","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        echo \"[i] Cron file for logrotate was moved to /etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/logrotate.\""},{"line_number":10,"context_line":"    fi"},{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"    echo \"[i] Cron for logrotate is currently set to: ${current_logrotate_schedule}.\""},{"line_number":13,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"e876557a_f2cf96b5","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":19},"in_reply_to":"8196ef56_a68db424","updated":"2021-11-12 14:13:21.000000000","message":"Done","commit_id":"4bcd95dbf7507bbfc6582d63eb8854d1dca94a50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8efbca130b4683c8896338df83d7884d5fc6675","unresolved":true,"context_lines":[{"line_number":6,"context_line":"# Pass only for hourly|daily|weekly|monthly"},{"line_number":7,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:-undefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"     CRON_LOGROTATE_DESIRED_PATH\u003d\"/etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/logrotate\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [[ \"${CRON_LOGROTATE_CURRENT_PATH}\" !\u003d \"${CRON_LOGROTATE_DESIRED_PATH}\" ]]; then"},{"line_number":12,"context_line":"        mv ${CRON_LOGROTATE_CURRENT_PATH} ${CRON_LOGROTATE_DESIRED_PATH}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1869f37e_a723db47","line":9,"updated":"2021-11-12 14:13:21.000000000","message":"not sure how strict rules in kolla are, but this is indented 5 spaces instead of 4","commit_id":"8c062e467987411e13d1a96b7846d8824e400b88"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ab45314c0744b996fa1aae0195e46dcaeb135c2b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Pass only for hourly|daily|weekly|monthly"},{"line_number":7,"context_line":"if [[ \"${KOLLA_LOGROTATE_SCHEDULE:-undefined}\" \u003d~ hourly|daily|weekly|monthly ]]; then"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"     CRON_LOGROTATE_DESIRED_PATH\u003d\"/etc/cron.${KOLLA_LOGROTATE_SCHEDULE}/logrotate\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [[ \"${CRON_LOGROTATE_CURRENT_PATH}\" !\u003d \"${CRON_LOGROTATE_DESIRED_PATH}\" ]]; then"},{"line_number":12,"context_line":"        mv ${CRON_LOGROTATE_CURRENT_PATH} ${CRON_LOGROTATE_DESIRED_PATH}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"d23920f6_62c7ee05","line":9,"in_reply_to":"1869f37e_a723db47","updated":"2021-11-12 16:30:42.000000000","message":"nice catch :) \n\nmichalarbet@pixla:~/AtomProjects/upstream/kolla$ for i in $(find . -name \u0027*extend*\u0027 );do if grep -qP \u0027^\\t\u0027 $i; then echo \"$i: Tab used.\"; fi; if grep -q \u0027^\\ \u0027 $i; then grep \u0027^\\ \u0027 $i \u003e/tmp/count_spaces ; sed -e \u0027s/\\(^\\ *\\)\\(.*\\)/\\1/g\u0027 /tmp/count_spaces \u003e /tmp/count_spaces_only_spaces; spaces\u003d$(tr -cd \u0027 \u0027 \u003c/tmp/count_spaces_only_spaces | wc -c); spaces_used\u003d$(($spaces % 4)); spaces_real\u003d$(($spaces_used+4));echo \"$i: $spaces_real spaces used.\";fi;done\n./docker/aodh/aodh-api/extend_start.sh: 4 spaces used.\n./docker/aodh/aodh-base/extend_start.sh: 4 spaces used.\n./docker/barbican/barbican-api/extend_start.sh: 4 spaces used.\n./docker/barbican/barbican-base/extend_start.sh: 4 spaces used.\n./docker/blazar/blazar-api/extend_start.sh: 4 spaces used.\n./docker/blazar/blazar-base/extend_start.sh: 4 spaces used.\n./docker/ceilometer/ceilometer-base/extend_start.sh: 4 spaces used.\n./docker/ceilometer/ceilometer-notification/extend_start.sh: 4 spaces used.\n./docker/cinder/cinder-api/extend_start.sh: 4 spaces used.\n./docker/cinder/cinder-base/extend_start.sh: 4 spaces used.\n./docker/cinder/cinder-volume/extend_start.sh: 4 spaces used.\n./docker/cloudkitty/cloudkitty-api/extend_start.sh: 4 spaces used.\n./docker/cloudkitty/cloudkitty-base/extend_start.sh: 4 spaces used.\n./docker/collectd/extend_start.sh: 4 spaces used.\n./docker/cron/kolla_extend_start: Tab used.\n./docker/cron/kolla_extend_start: 5 spaces used.\n./docker/cyborg/cyborg-api/extend_start.sh: 4 spaces used.\n./docker/cyborg/cyborg-base/extend_start.sh: 4 spaces used.\n./docker/designate/designate-base/extend_start.sh: 4 spaces used.\n./docker/designate/designate-central/extend_start.sh: 4 spaces used.\n./docker/elasticsearch/elasticsearch-curator/extend_start.sh: 4 spaces used.\n./docker/elasticsearch/elasticsearch/extend_start.sh: 4 spaces used.\n./docker/etcd/extend_start.sh: 4 spaces used.\n./docker/fluentd/extend_start.sh: 4 spaces used.\n./docker/freezer/freezer-api/extend_start.sh: 4 spaces used.\n./docker/freezer/freezer-base/extend_start.sh: 4 spaces used.\n./docker/glance/glance-api/extend_start.sh: 4 spaces used.\n./docker/glance/glance-base/extend_start.sh: 4 spaces used.\n./docker/gnocchi/gnocchi-api/extend_start.sh: 4 spaces used.\n./docker/gnocchi/gnocchi-base/extend_start.sh: 4 spaces used.\n./docker/grafana/extend_start.sh: 4 spaces used.\n./docker/hacluster/hacluster-base/extend_start.sh: 4 spaces used.\n./docker/heat/heat-api/extend_start.sh: 4 spaces used.\n./docker/heat/heat-base/extend_start.sh: 4 spaces used.\n./docker/horizon/extend_start.sh: 4 spaces used.\n./docker/influxdb/extend_start.sh: 4 spaces used.\n./docker/ironic-inspector/extend_start.sh: 4 spaces used.\n./docker/ironic/ironic-api/extend_start.sh: 4 spaces used.\n./docker/ironic/ironic-base/extend_start.sh: 4 spaces used.\n./docker/ironic/ironic-pxe/extend_start.sh: 4 spaces used.\n./docker/iscsid/extend_start.sh: 4 spaces used.\n./docker/kafka/extend_start.sh: 4 spaces used.\n./docker/keepalived/extend_start.sh: 4 spaces used.\n./docker/keystone/keystone-fernet/extend_start.sh: 4 spaces used.\n./docker/keystone/keystone-ssh/extend_start.sh: 4 spaces used.\n./docker/keystone/keystone/extend_start.sh: 4 spaces used.\n./docker/kibana/extend_start.sh: 4 spaces used.\n./docker/kolla-toolbox/extend_start.sh: 4 spaces used.\n./docker/kuryr/kuryr-base/extend_start.sh: 4 spaces used.\n./docker/logstash/extend_start.sh: 4 spaces used.\n./docker/magnum/magnum-api/extend_start.sh: 4 spaces used.\n./docker/magnum/magnum-base/extend_start.sh: 4 spaces used.\n./docker/manila/manila-api/extend_start.sh: 4 spaces used.\n./docker/manila/manila-base/extend_start.sh: 4 spaces used.\n./docker/mariadb/mariadb-server/extend_start.sh: 4 spaces used.\n./docker/masakari/masakari-api/extend_start.sh: 4 spaces used.\n./docker/masakari/masakari-base/extend_start.sh: 4 spaces used.\n./docker/mistral/mistral-api/extend_start.sh: 4 spaces used.\n./docker/mistral/mistral-base/extend_start.sh: 4 spaces used.\n./docker/monasca/monasca-api/extend_start.sh: 4 spaces used.\n./docker/monasca/monasca-base/extend_start.sh: 4 spaces used.\n./docker/monasca/monasca-thresh/extend_start.sh: 4 spaces used.\n./docker/murano/murano-api/extend_start.sh: 4 spaces used.\n./docker/murano/murano-base/extend_start.sh: 4 spaces used.\n./docker/neutron/neutron-base/extend_start.sh: 4 spaces used.\n./docker/neutron/neutron-server/extend_start.sh: 4 spaces used.\n./docker/nova/nova-api/extend_start.sh: 4 spaces used.\n./docker/nova/nova-base/extend_start.sh: 4 spaces used.\n./docker/nova/nova-compute/extend_start.sh: 4 spaces used.\n./docker/nova/nova-conductor/extend_start.sh: 4 spaces used.\n./docker/nova/nova-libvirt/extend_start.sh: 4 spaces used.\n./docker/nova/nova-ssh/extend_start.sh: 4 spaces used.\n./docker/octavia/octavia-api/extend_start.sh: 4 spaces used.\n./docker/octavia/octavia-base/extend_start.sh: 4 spaces used.\n./docker/openvswitch/openvswitch-base/extend_start.sh: 4 spaces used.\n./docker/openvswitch/openvswitch-db-server/extend_start.sh: 4 spaces used.\n./docker/openvswitch/openvswitch-netcontrold/extend_start.sh: 4 spaces used.\n./docker/ovn/ovn-base/extend_start.sh: 4 spaces used.\n./docker/ovsdpdk/ovsdpdk-db/extend_start.sh: 4 spaces used.\n./docker/ovsdpdk/ovsdpdk/extend_start.sh: 4 spaces used.\n./docker/placement/placement-api/extend_start.sh: 4 spaces used.\n./docker/placement/placement-base/extend_start.sh: 4 spaces used.\n./docker/prometheus/prometheus-base/extend_start.sh: 4 spaces used.\n./docker/proxysql/kolla_extend_start: 4 spaces used.\n./docker/qdrouterd/extend_start.sh: 4 spaces used.\n./docker/rabbitmq/extend_start.sh: 4 spaces used.\n./docker/redis/redis-base/extend_start.sh: 4 spaces used.\n./docker/sahara/sahara-api/extend_start.sh: 4 spaces used.\n./docker/sahara/sahara-base/extend_start.sh: 4 spaces used.\n./docker/senlin/senlin-api/extend_start.sh: 4 spaces used.\n./docker/senlin/senlin-base/extend_start.sh: 4 spaces used.\n./docker/skydive/skydive-base/extend_start.sh: 4 spaces used.\n./docker/solum/solum-api/extend_start.sh: 4 spaces used.\n./docker/solum/solum-base/extend_start.sh: 4 spaces used.\n./docker/storm/storm-base/extend_start.sh: 4 spaces used.\n./docker/tacker/tacker-base/extend_start.sh: 4 spaces used.\n./docker/tacker/tacker-server/extend_start.sh: 4 spaces used.\n./docker/telegraf/extend_start.sh: 4 spaces used.\n./docker/trove/trove-api/extend_start.sh: 4 spaces used.\n./docker/trove/trove-base/extend_start.sh: 4 spaces used.\n./docker/vitrage/vitrage-api/extend_start.sh: 4 spaces used.\n./docker/vitrage/vitrage-base/extend_start.sh: 4 spaces used.\n./docker/watcher/watcher-api/extend_start.sh: 4 spaces used.\n./docker/watcher/watcher-base/extend_start.sh: 4 spaces used.\n./docker/zookeeper/extend_start.sh: 4 spaces used.\n./docker/zun/zun-api/extend_start.sh: 4 spaces used.\n./docker/zun/zun-base/extend_start.sh: 4 spaces used.\n\n\nmichalarbet@pixla:~/AtomProjects/upstream/kolla$ for i in $(find . -name \u0027*extend*\u0027 );do if grep -qP \u0027^\\t\u0027 $i; then echo \"$i: Tab used.\"; fi; if grep -q \u0027^\\ \u0027 $i; then grep \u0027^\\ \u0027 $i \u003e/tmp/count_spaces ; sed -e \u0027s/\\(^\\ *\\)\\(.*\\)/\\1/g\u0027 /tmp/count_spaces \u003e /tmp/count_spaces_only_spaces; spaces\u003d$(tr -cd \u0027 \u0027 \u003c/tmp/count_spaces_only_spaces | wc -c); spaces_used\u003d$(($spaces % 4)); spaces_real\u003d$(($spaces_used+4));echo \"$i: $spaces_real spaces used.\";fi;done | grep -v \u00274 spaces used.\u0027\n\n./docker/cron/kolla_extend_start: Tab used.\n./docker/cron/kolla_extend_start: 5 spaces used.","commit_id":"8c062e467987411e13d1a96b7846d8824e400b88"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8efbca130b4683c8896338df83d7884d5fc6675","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [[ \"${CRON_LOGROTATE_CURRENT_PATH}\" !\u003d \"${CRON_LOGROTATE_DESIRED_PATH}\" ]]; then"},{"line_number":12,"context_line":"        mv ${CRON_LOGROTATE_CURRENT_PATH} ${CRON_LOGROTATE_DESIRED_PATH}"},{"line_number":13,"context_line":"\tCRON_LOGROTATE_CURRENT_SCHEDULE\u003d\"${KOLLA_LOGROTATE_SCHEDULE}\""},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1fdc4ce3_d1120243","line":13,"updated":"2021-11-12 14:13:21.000000000","message":"and this is indented with a tab instead of spaces","commit_id":"8c062e467987411e13d1a96b7846d8824e400b88"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ab45314c0744b996fa1aae0195e46dcaeb135c2b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [[ \"${CRON_LOGROTATE_CURRENT_PATH}\" !\u003d \"${CRON_LOGROTATE_DESIRED_PATH}\" ]]; then"},{"line_number":12,"context_line":"        mv ${CRON_LOGROTATE_CURRENT_PATH} ${CRON_LOGROTATE_DESIRED_PATH}"},{"line_number":13,"context_line":"\tCRON_LOGROTATE_CURRENT_SCHEDULE\u003d\"${KOLLA_LOGROTATE_SCHEDULE}\""},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"c6cb4c08_51c7c9ae","line":13,"in_reply_to":"1fdc4ce3_d1120243","updated":"2021-11-12 16:30:42.000000000","message":"nice catch, will fix","commit_id":"8c062e467987411e13d1a96b7846d8824e400b88"}]}