)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"eaa38e0edebbb9941f7b1b33337e6c40024132c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5181135d_68820ab4","updated":"2021-10-11 10:28:11.000000000","message":"reno missing","commit_id":"5aa44e30a9eb5d220e21e788d9fb7d8353f855b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0975cdf497ee4a01a82bc649ce5c496b243a954e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2874fdb1_9792284a","updated":"2021-10-11 11:03:32.000000000","message":"Well, reno for","commit_id":"28cc1f61123522de9e72b3379e5180fe5c87121a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c09a9bcaec5497a0050c918ad5fad586c1b2e9fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8be4d2b9_6c39317f","updated":"2021-10-12 13:51:36.000000000","message":"are you kidding me? this is for a year-old change; this reno does more harm than good, lol","commit_id":"1b6d1bf16215f7a166b6b6578ddd9ca242751d3e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"900e07413c5d0ee6088e196f2a45224bbc7545e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"83f5747b_1b4995df","in_reply_to":"8be4d2b9_6c39317f","updated":"2021-10-12 15:13:52.000000000","message":"Just checking if you\u0027re paying attention 😂","commit_id":"1b6d1bf16215f7a166b6b6578ddd9ca242751d3e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fe59521e6e8c76ada88c8908d06675491302ea78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cc42e088_e154fbd4","in_reply_to":"8be4d2b9_6c39317f","updated":"2021-10-12 15:15:08.000000000","message":"cores kidding on me? ask write a reno, then merge, then revert?)","commit_id":"1b6d1bf16215f7a166b6b6578ddd9ca242751d3e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7f6cb722d2bfa81822d0a123f61a54a5d0b27748","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"447293ea_b0a1df31","in_reply_to":"96272828_f54e3e49","updated":"2021-10-12 15:51:06.000000000","message":"Yeah, it\u0027s merging.","commit_id":"1b6d1bf16215f7a166b6b6578ddd9ca242751d3e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"59848d6a0061a3c7b4ff5b136e7d0e0f9f603624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ede80f6b_24dbe308","in_reply_to":"cc42e088_e154fbd4","updated":"2021-10-12 15:18:27.000000000","message":"@Mark Sure. 😂\n\n@Maksim I am sorry it has happened to you. I know it was not me who told you to do that reno. Mistakes happen. Miscommunication happens.","commit_id":"1b6d1bf16215f7a166b6b6578ddd9ca242751d3e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dd589cfe88c28a92eeab4a5d4124eea375d7908b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96272828_f54e3e49","in_reply_to":"ede80f6b_24dbe308","updated":"2021-10-12 15:22:45.000000000","message":"Radosław no problem) will abandon backports when cores synced and merge revert? it will be merged?) not kidding?)","commit_id":"1b6d1bf16215f7a166b6b6578ddd9ca242751d3e"}],"docker/neutron/neutron-base/extend_start.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4d89f8822bb9e7c2828b82fe75192b6baff958c0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES:-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":3,"id":"67d5f6d4_8fb85988","line":20,"updated":"2021-10-11 12:52:26.000000000","message":"it was already properly set to false if KOLLA_LEGACY_IPTABLES is not defined","commit_id":"4a540e865fc4d0599ae697aed8f4b6fa1bf7ad77"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"626ee60d8395042d9f41c9e3617b94310456dae1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES:-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":3,"id":"a21ce5bf_b89b904e","line":20,"in_reply_to":"67d5f6d4_8fb85988","updated":"2021-10-11 13:05:46.000000000","message":"man bash: ...omitting the colon results in a test only for a parameter that is unset\n${parameter:-word}\n              Use Default Values.  If parameter is unset or null, the expansion of word is substituted.  Otherwise, the value of parameter is substituted.","commit_id":"4a540e865fc4d0599ae697aed8f4b6fa1bf7ad77"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f465aed148e97fb3b71859ca644c08a8c3e00d88","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES:-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":3,"id":"31f51a47_a0390c6f","line":20,"in_reply_to":"84462900_4a1a50c0","updated":"2021-10-11 13:14:59.000000000","message":"fine. corner case)","commit_id":"4a540e865fc4d0599ae697aed8f4b6fa1bf7ad77"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"08150eac52eeb3d98c5b7f6a69389ce778025a62","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES:-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":3,"id":"84462900_4a1a50c0","line":20,"in_reply_to":"a21ce5bf_b89b904e","updated":"2021-10-11 13:06:53.000000000","message":"Yup, that\u0027s precisely what is needed. \"not defined\" \u003d \"unset\"","commit_id":"4a540e865fc4d0599ae697aed8f4b6fa1bf7ad77"}],"releasenotes/notes/fix-kolla-legacy-iptables-workaround-348314e8cd24bffb.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0975cdf497ee4a01a82bc649ce5c496b243a954e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the workaround with ``KOLLA_LEGACY_IPTABLES`` in ``extend_start.sh``"},{"line_number":5,"context_line":"    for neutron containers which never set to \u0027false\u0027 because of missing colon."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"583c0b02_9a49912b","line":5,"range":{"start_line":4,"start_character":3,"end_line":5,"end_character":79},"updated":"2021-10-11 11:03:32.000000000","message":"I think you\u0027re still missing a note about fixing bug from https://review.opendev.org/c/openstack/kolla/+/761182 - you can include it here.","commit_id":"28cc1f61123522de9e72b3379e5180fe5c87121a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fd9236a35242a576a217a1959ead3057d768752f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the workaround with ``KOLLA_LEGACY_IPTABLES`` in ``extend_start.sh``"},{"line_number":5,"context_line":"    for neutron containers which never set to \u0027false\u0027 because of missing colon."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6e008731_b30f46a9","line":5,"range":{"start_line":4,"start_character":3,"end_line":5,"end_character":79},"in_reply_to":"583c0b02_9a49912b","updated":"2021-10-11 11:25:18.000000000","message":"Done","commit_id":"28cc1f61123522de9e72b3379e5180fe5c87121a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4d89f8822bb9e7c2828b82fe75192b6baff958c0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the workaround with ``KOLLA_LEGACY_IPTABLES`` in ``extend_start.sh``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"eac31590_7ad67907","line":1,"updated":"2021-10-11 12:52:26.000000000","message":"the colon is not missing; it works without the colon for our case","commit_id":"4a540e865fc4d0599ae697aed8f4b6fa1bf7ad77"}],"releasenotes/notes/fix-update-alternatives-centos-68294e3d3570ade4.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4d89f8822bb9e7c2828b82fe75192b6baff958c0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``No such file or directory`` for ``update-alternatives`` on CentOS."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d8e76a29_543a817f","line":1,"updated":"2021-10-11 12:52:26.000000000","message":"it does not fix this here","commit_id":"4a540e865fc4d0599ae697aed8f4b6fa1bf7ad77"}]}