)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"460b54767c1d051717b26b108f7e10ea94985c62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73bc506d_b67527bb","updated":"2021-10-11 10:27:54.000000000","message":"And the master change is not merged yet, fantastic - can you post back ports after something gets merged in master?","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5ff6084880542d8ce282b2f633a1f0f8c8d3f34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"acd0181a_8ebb5bac","updated":"2021-10-11 10:28:38.000000000","message":"Ehh, my bad, clicked same topic ;-)","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"942d2a7e1a6e46fdc9179f3862febccf6b973920","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"72cf947e_6d08024d","updated":"2021-10-11 10:25:34.000000000","message":"That\u0027s fine it\u0027s a backport, but somebody missed reno in the master change - please followup in master, and then include it in here.","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a495fc0bd79d3c09083e21f6271cfe3bb6ec263d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d441eed_5c5014ed","updated":"2021-10-11 12:56:08.000000000","message":"best backport both fixes independently and base one off the other","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f086fa7c351c6572139782cf95bdb95e1f2b9267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb6c1834_5e84e385","updated":"2021-10-11 12:54:49.000000000","message":"it\u0027s a backport of https://review.opendev.org/c/openstack/kolla/+/761841; it has long merged; however, the issue was only cosmetic","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a21ee0bd599a7c1d67c7694c755396795f2204a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05e55962_665d0d6e","updated":"2021-10-11 10:08:20.000000000","message":"reno missing","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cb06f7acd8c394d7f4d328898a854f074730c0fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a92845d_fa279d02","in_reply_to":"05e55962_665d0d6e","updated":"2021-10-11 10:21:56.000000000","message":"this is backport","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"87afeed2353d55e453da225c1fe532ede44813fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c6226f6_6c1b0b79","in_reply_to":"1d441eed_5c5014ed","updated":"2021-10-11 13:07:58.000000000","message":"ok, did it","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dc5af5a0fc83b952f971f3e24d506b255a98253e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad54bc1d_0370e72d","in_reply_to":"73bc506d_b67527bb","updated":"2021-10-11 10:31:36.000000000","message":"is it fine to add reno here: https://review.opendev.org/c/openstack/kolla/+/813304\nand backport it to this change too?","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f6a124098e5736057a37f1ff804aafa1c6171826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"17f5f418_35aecc2d","updated":"2021-10-12 18:58:22.000000000","message":"ok, it\u0027s a proper backport now (do note this is only cosmetic as this code is irrelevant on centos)","commit_id":"f179f8383bec039bd82670217faa7e16ef17fcfa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d56be01a22f839bd617374ac3d0efaa1f3a33a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82476681_7c51cacf","updated":"2021-10-13 12:43:02.000000000","message":"recheck\n","commit_id":"f179f8383bec039bd82670217faa7e16ef17fcfa"}],"docker/neutron/neutron-base/extend_start.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a21ee0bd599a7c1d67c7694c755396795f2204a4","unresolved":true,"context_lines":[{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# set legacy iptables to allow kernels not supporting iptables-nft"},{"line_number":16,"context_line":"if $UPDATE_ALTERNATIVES --query iptables; then"},{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."}],"source_content_type":"text/x-sh","patch_set":1,"id":"a69b902e_27bbadde","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":23},"updated":"2021-10-11 10:08:20.000000000","message":"${UPDATE_ALTERNATIVES} ?","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cb06f7acd8c394d7f4d328898a854f074730c0fd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# set legacy iptables to allow kernels not supporting iptables-nft"},{"line_number":16,"context_line":"if $UPDATE_ALTERNATIVES --query iptables; then"},{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."}],"source_content_type":"text/x-sh","patch_set":1,"id":"20e87c1b_b2c39d83","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":23},"in_reply_to":"a69b902e_27bbadde","updated":"2021-10-11 10:21:56.000000000","message":"not needed here","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7ae293831a58d822952fbcdd0df2bafac8b679af","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES:-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":1,"id":"0c3527e9_52aaac8f","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":50},"updated":"2021-10-11 12:55:35.000000000","message":"the colon is not required; best backport like it is on newer branches than diverge","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a315a6ad6d8395aecd326d2d99941f397496ac60","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# set legacy iptables to allow kernels not supporting iptables-nft"},{"line_number":16,"context_line":"if $UPDATE_ALTERNATIVES --query iptables; then"},{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ada17619_f2194e5a","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":56},"updated":"2021-10-11 13:08:01.000000000","message":"I meant this is a backport of another fix","commit_id":"a80f314011f5035b29feb473e7ea7b4f36e65c1a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"237def39a89a4d3f9efdb2b03c6e30be52aad1c1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# set legacy iptables to allow kernels not supporting iptables-nft"},{"line_number":16,"context_line":"if $UPDATE_ALTERNATIVES --query iptables; then"},{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":2,"id":"b92ff5c8_41461aba","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":56},"in_reply_to":"ada17619_f2194e5a","updated":"2021-10-11 13:17:47.000000000","message":"nevermind. splitted anyway. we need this in ussuri. another fix changed too.","commit_id":"a80f314011f5035b29feb473e7ea7b4f36e65c1a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4c6421068444100cf2af70a5c5ac59eced51ea6e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# set legacy iptables to allow kernels not supporting iptables-nft"},{"line_number":16,"context_line":"if $UPDATE_ALTERNATIVES --query iptables; then"},{"line_number":17,"context_line":"    # NOTE(yoctozepto): Kolla-Ansible does not always set KOLLA_LEGACY_IPTABLES;"},{"line_number":18,"context_line":"    # the workaround below ensures it gets set to `false` in such cases to fix"},{"line_number":19,"context_line":"    # this code under `set -o nounset`."},{"line_number":20,"context_line":"    KOLLA_LEGACY_IPTABLES\u003d${KOLLA_LEGACY_IPTABLES-false}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ $KOLLA_LEGACY_IPTABLES \u003d\u003d \"true\" ]]; then"},{"line_number":23,"context_line":"        sudo $UPDATE_ALTERNATIVES --set iptables /usr/sbin/iptables-legacy"}],"source_content_type":"text/x-sh","patch_set":2,"id":"6b85e939_56776aae","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":56},"in_reply_to":"b92ff5c8_41461aba","updated":"2021-10-12 09:06:11.000000000","message":"Radosław Piliszek, mention of the another fix was removed from this backport.","commit_id":"a80f314011f5035b29feb473e7ea7b4f36e65c1a"}],"docker/neutron/neutron-base/neutron_sudoers":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a21ee0bd599a7c1d67c7694c755396795f2204a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04d61b3c_0ca4fcc4","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":0},"updated":"2021-10-11 10:08:20.000000000","message":"we could get better with Cmnd_Alias, but maybe not this time.","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cb06f7acd8c394d7f4d328898a854f074730c0fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bfb046bf_ed2af4ff","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"04d61b3c_0ca4fcc4","updated":"2021-10-11 10:21:56.000000000","message":"good catch, but this is still backport.","commit_id":"84c27a50e6ea97121ad8c222f635efab4b2a02f0"}]}