)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"24036626341593a4a514bd758cd596b08f70097b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd9c93f9_de730705","updated":"2022-01-20 17:46:41.000000000","message":"User can use tag and/or namespace to store whatever data they want. Storing additional info in images is not required.","commit_id":"bae304ae2fc6401893e825531f3373ba02389f07"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"60057758a7e124791b7418dc3880bdee11726f42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9cceded_81edd428","in_reply_to":"fd9c93f9_de730705","updated":"2022-05-18 13:37:50.000000000","message":"Ok, so you will probably agree that we can remove labels \n\nbuild-date\nkolla_version\n\nAs you said \"Storing additional info in images is not required.\"\n\nMoreover kolla_version can be several commits if you are building from a git, but version will be still same.\nBuild-date is also not usefull as I can build several images daily but not additional info after the date (build no.).\n\nIn my proposal there can be one commit label ..and you can check exact commit upstream od downstream git:\n - Author\n - Date\n - Kolla-version\n - Description \n - Whatever\n\nSo let\u0027s replace it by commit, or remove if \"Storing additional info in images is not required.\"","commit_id":"bae304ae2fc6401893e825531f3373ba02389f07"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1803eff59d15b21a23b0aff20b3c2a78413b82ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"887730fe_317236a9","updated":"2022-05-19 13:25:18.000000000","message":"Agree with Michal and also can see your point, but if you really need to have the commit id in your images you can just extend the labels code block with any other label you need https://github.com/openstack/kolla/blob/master/docker/base/Dockerfile.j2#L2","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3a43fe237b92bf5921405a708948dd5c9adee9c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e66b3566_40f3b18e","updated":"2022-05-19 15:09:22.000000000","message":"Basically - kolla_version is there, for users to understand what version of Kolla has been used to build that image, right? Can\u0027t we just update that (to include both version and git commit sha) - since we already encourage users to stop using tagged versions and fetch git branch code?","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6d69862782d24259932d81b335a60feeca6bd88f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c1dcdb6_6259fda1","updated":"2022-05-18 13:38:35.000000000","message":"Guys, please, could you share your opinion ? Thanks.","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e3985db631fbed4bc711af0b4a635c24bbd5f4f4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05319e0d_7c5c4cb2","updated":"2022-05-19 14:38:39.000000000","message":"git log -1 \u003e file, merge that file into template_overrides where it will be present in some block in every image\n\nthen use generated template_overrides during build.","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a8762c2985e98325bf85598474ce47d5166860f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d6cf435_196a4418","in_reply_to":"04f10def_ba2e1ffc","updated":"2022-05-19 15:13:07.000000000","message":"So just update the kolla_version tag (instead of introducing new one) and let\u0027s get over with it?","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1012451ee186d7eda814733f9da62162c1bc0124","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9186ad8_c573d698","in_reply_to":"05319e0d_7c5c4cb2","updated":"2022-05-19 14:42:50.000000000","message":"or nothing and just run ./tools/build.py","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b4b8d498609078d1c86d113a7bdea1f628c50c98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9d0b81d_490d56ea","in_reply_to":"1d6cf435_196a4418","updated":"2022-05-19 15:15:31.000000000","message":"Ah, no that\u0027s not possible .. kolla_version is used in bash scripts of kolla-ansible to for example cleanup old images.\n\n./tools/cleanup-images:43:            KOLLA_IMAGES\u003d\"$(sudo docker images -a --filter \"label\u003dkolla_version\" --format \"{{.ID}}\")\"\n./tools/cleanup-images:53:            KOLLA_IMAGES\u003d\"$(sudo docker images -a --filter \"label\u003dkolla_version\" --format \"{{.Repository}}\\t{{.ID}}\" | grep -E \"$2\" | awk \u0027{print $2}\u0027)\"\n./tools/cleanup-images:58:            KOLLA_IMAGES\u003d\"$(sudo docker images -a --filter \"label\u003dkolla_version\u003d${2}\" --format \"{{.ID}}\")\"\n./tools/cleanup-containers:3:containers_running\u003d$(sudo docker ps --filter \"label\u003dkolla_version\" --format \"{{.Names}}\")\n./tools/cleanup-containers:14:    containers_to_kill\u003d$(sudo docker ps --filter \"label\u003dkolla_version\" --format \"{{.Names}}\" -a | grep -E \"$1\" | awk \u0027{print $1}\u0027)\n./tools/cleanup-containers:18:    containers_to_kill\u003d$(sudo docker ps --filter \"label\u003dkolla_version\" --format \"{{.Names}}\" -a)\n./ansible/roles/prune-images/tasks/prune_images.yml:7:      label: kolla_version","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8e12147d26c4087509e36b9da1f1c7ea830fce7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96e1962b_ba967df9","in_reply_to":"887730fe_317236a9","updated":"2022-05-19 13:54:53.000000000","message":"BTW, removing kolla_version or other labels cannot be done that easily because it will modify the ABI of the images and possibly break some user tasks such as cleaning images or filtering during upgrades\n\nI totally understand your issue and have mixed feelings about the change, If kolla_version is empty on source builds, you could try to extend the behavior of version.py to apply the commit into the kolla_version label without creating new labels. Just an idea...","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4303d5b34d1753312fa910a7ab4bdb0f420550b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f836a019_44f39d39","in_reply_to":"887730fe_317236a9","updated":"2022-05-19 13:35:17.000000000","message":"Point is that we have downstream branches where we are commiting our changes. In case we don\u0027t want to merge always some bugfix or feature from upstream, we are rebasing against upstream to have commits on top of the upstream branch - so we can\u0027t push normally because of rebase.\n\nSo on the end we are tagging every rebase we\u0027ve done (commit is de facto same reference). From this tags we are building images and tag it by openstack version and commit.\n\nThis change just do this automatically (now we have pipelines which is doing also - but it\u0027s not kolish).\n\nSo, my idea was that if there is kolla version ..which is not describing anything ..because images are generated from git) ..commit label from which is image built can be also present, and as I said, it is more specific than kolla version and build date.","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"57a7c368c07e6ae343167f705ff56067b7da2fd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e36da267_c8ab0377","in_reply_to":"91a7f3cf_b1d58b9d","updated":"2022-05-19 15:53:12.000000000","message":"Here it is, done.","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"310e2bbbc48e82998416ef4b38eb339ac75b414b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91a7f3cf_b1d58b9d","in_reply_to":"957c6822_b5835836","updated":"2022-05-19 15:27:16.000000000","message":"Ah, yeah you are right ... just kolla_version name of label is  little misleading.","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5b3b7f9b9222976ff4cf03057c9f55a5f6934aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb949017_38fabb32","in_reply_to":"96e1962b_ba967df9","updated":"2022-05-19 14:01:24.000000000","message":"nvm, just checked and source builds also have kolla_version data","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a2c32d3330de93dd9a4a7e51509ace6b1b542860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7854857e_8921e9ff","in_reply_to":"e36da267_c8ab0377","updated":"2022-05-23 09:15:51.000000000","message":"So, what now, better ? It\u0027s not breaking nothing","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b3017669e394b475e3bfa7f753b59c12fa51567b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04f10def_ba2e1ffc","in_reply_to":"e66b3566_40f3b18e","updated":"2022-05-19 15:12:11.000000000","message":"Exactly this is my point ! I don\u0027t know why it\u0027s so awful and unwanted :/","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1e7c845ea42186db0eaedb6efa4458c555f942d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d3909b2_100dd481","in_reply_to":"eb949017_38fabb32","updated":"2022-05-19 14:11:32.000000000","message":"I am not saying that it is not present ..just saying that kolla_version is not changing after every commit ...so the version will be same as for image which is built one hour later from different commit which is fixing some issue .. (as recent sasl binaries missing) ..\n\nSo, it means I will build several images from several git commits in branch for example yoga and if I will not tag images..I am not able to know from which commit I\u0027ve built. Moreover it\u0027s useful to ask customer. Hey could you inspect container and tell me the commit which is defined as a label ? \n\nkolla_version is bumped only sometimes.\n\ndo not pretend that it\u0027s a big problem to add one label is too hard and breaking something.","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a1b1c15f3b588b627f11b5c4abd40793e6f80fed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"84324c3a_a0a0b19e","in_reply_to":"f836a019_44f39d39","updated":"2022-05-19 13:37:30.000000000","message":"I know that this can be configured ..but that\u0027s the thing ... simple change in a code is nicer.\n\nAnd easy backportable even if downstream users as we are do this manually.\n\nAnd it\u0027s nice also for upstream...every time I can checkout commit and see from which commit it was built.","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f4f4c4a873bf080e3507f4bf81187df14de5fc3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"957c6822_b5835836","in_reply_to":"f9d0b81d_490d56ea","updated":"2022-05-19 15:22:46.000000000","message":"It\u0027s only listing images that have this label, that should be all right?","commit_id":"3623ea1515bd9d9d52632573ea3a3ab1e3201bc0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"754f75d55a1f5f9fe1ac4ddfee6e5fe960259a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"29ab4dd5_ec2fd49e","updated":"2022-05-25 08:16:15.000000000","message":"Any comment ? Review ? ","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"793c269c9752916c09a95ee2e58bafc1d3dca73d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"93220f3f_9463c5fa","updated":"2022-06-21 09:25:48.000000000","message":"recheck","commit_id":"ad7b9054ca5ebc53031a10dc3f03675c88845b11"}],"kolla/image/build.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00ffccd6b83bfd7fe23ef2b00dd9efc14bd6568c","unresolved":true,"context_lines":[{"line_number":819,"context_line":"        return ret"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def create_dockerfiles(self):"},{"line_number":822,"context_line":"        kolla_version \u003d version.git_info if version.git_info else \\"},{"line_number":823,"context_line":"            version.version_info.cached_version_string()"},{"line_number":824,"context_line":"        supported_distro_name \u003d common_config.DISTRO_PRETTY_NAME.get("},{"line_number":825,"context_line":"            self.base)"}],"source_content_type":"text/x-python","patch_set":4,"id":"54391aba_8208de81","line":822,"range":{"start_line":822,"start_character":60,"end_line":822,"end_character":61},"updated":"2022-05-26 12:57:34.000000000","message":"is not None","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"44d0a6e72d542dfa3dd6a80686fc0962de437e4d","unresolved":false,"context_lines":[{"line_number":819,"context_line":"        return ret"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def create_dockerfiles(self):"},{"line_number":822,"context_line":"        kolla_version \u003d version.git_info if version.git_info else \\"},{"line_number":823,"context_line":"            version.version_info.cached_version_string()"},{"line_number":824,"context_line":"        supported_distro_name \u003d common_config.DISTRO_PRETTY_NAME.get("},{"line_number":825,"context_line":"            self.base)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4375f359_5cec957e","line":822,"range":{"start_line":822,"start_character":60,"end_line":822,"end_character":61},"in_reply_to":"54391aba_8208de81","updated":"2022-06-13 13:05:40.000000000","message":"changed to len(version.git_info) !\u003d 0 as pbr.git.get_git_short_sha() returning str with lenth 0 if it\u0027s called not in git directory.","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"}],"kolla/version.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00ffccd6b83bfd7fe23ef2b00dd9efc14bd6568c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"import pbr.version"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":19,"context_line":"kolla_path \u003d os.getcwd()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    _ \u003d git.Repo(kolla_path).git_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"91376833_63a6f1e0","line":19,"updated":"2022-05-26 12:57:34.000000000","message":"it\u0027s certainly possible to run kolla-build from somewhere else than the base source directory - this should look at the path of this file, not cwd","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"44d0a6e72d542dfa3dd6a80686fc0962de437e4d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import pbr.version"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":19,"context_line":"kolla_path \u003d os.getcwd()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    _ \u003d git.Repo(kolla_path).git_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"56c6209d_ab7855a5","line":19,"in_reply_to":"91376833_63a6f1e0","updated":"2022-06-13 13:05:40.000000000","message":"Done","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00ffccd6b83bfd7fe23ef2b00dd9efc14bd6568c","unresolved":true,"context_lines":[{"line_number":19,"context_line":"kolla_path \u003d os.getcwd()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    _ \u003d git.Repo(kolla_path).git_dir"},{"line_number":23,"context_line":"    git_info \u003d pbr.git.get_git_short_sha(git_dir\u003d\"{}/.git\".format(kolla_path))"},{"line_number":24,"context_line":"except git.exc.InvalidGitRepositoryError:"},{"line_number":25,"context_line":"    git_info \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"8884edf5_bfef240b","line":22,"updated":"2022-05-26 12:57:34.000000000","message":"do we need this? what does pbr.git... return?","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"44d0a6e72d542dfa3dd6a80686fc0962de437e4d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"kolla_path \u003d os.getcwd()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    _ \u003d git.Repo(kolla_path).git_dir"},{"line_number":23,"context_line":"    git_info \u003d pbr.git.get_git_short_sha(git_dir\u003d\"{}/.git\".format(kolla_path))"},{"line_number":24,"context_line":"except git.exc.InvalidGitRepositoryError:"},{"line_number":25,"context_line":"    git_info \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"556dfe3a_f59f0ae1","line":22,"in_reply_to":"8884edf5_bfef240b","updated":"2022-06-13 13:05:40.000000000","message":"Short sha1 commit if it is in git tree, and str with length 0 if not.","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d119b959331d88438c1a32e709a51036df9511f3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"import pbr.git"},{"line_number":15,"context_line":"import pbr.version"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.split(os.path.abspath(__file__))[0])"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003d\"{}/.git\".format(kolla_path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"01f69dd1_95d7550f","line":17,"range":{"start_line":17,"start_character":29,"end_line":17,"end_character":42},"updated":"2022-06-20 09:44:50.000000000","message":"should just be dirname twice, no need for split if we are immediately taking [0]","commit_id":"e169cf7a4040c9881e0ba63f20edc67bdb34b43b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"98ec04f1f023fdfc08022f0780e24820467731b2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import pbr.git"},{"line_number":15,"context_line":"import pbr.version"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.split(os.path.abspath(__file__))[0])"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003d\"{}/.git\".format(kolla_path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"e794b3ba_83f296cb","line":17,"range":{"start_line":17,"start_character":29,"end_line":17,"end_character":42},"in_reply_to":"01f69dd1_95d7550f","updated":"2022-06-20 13:02:20.000000000","message":"Done","commit_id":"e169cf7a4040c9881e0ba63f20edc67bdb34b43b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"13b683dbd3d8cb3982250947c04419a135089459","unresolved":true,"context_lines":[{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.dirname(os.path.abspath(__file__)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003d\"{}/.git\".format(kolla_path))"}],"source_content_type":"text/x-python","patch_set":7,"id":"4119af4d_0160bbdd","line":20,"range":{"start_line":20,"start_character":45,"end_line":20,"end_character":73},"updated":"2022-06-20 13:40:56.000000000","message":"should use path.join (I missed this comment last time, sorry!)","commit_id":"be482663ebbb0a58ff902fd287c1909f618f6e4a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b05b758ea6c2059d029422608b8533c2617c827c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.dirname(os.path.abspath(__file__)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003d\"{}/.git\".format(kolla_path))"}],"source_content_type":"text/x-python","patch_set":7,"id":"aa4a3a93_d7bed053","line":20,"range":{"start_line":20,"start_character":45,"end_line":20,"end_character":73},"in_reply_to":"4119af4d_0160bbdd","updated":"2022-06-21 06:54:18.000000000","message":"Done","commit_id":"be482663ebbb0a58ff902fd287c1909f618f6e4a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"793c269c9752916c09a95ee2e58bafc1d3dca73d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.dirname(os.path.abspath(__file__)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003dos.path.join(kolla_path, \".git\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"1d530929_760e3d58","line":20,"updated":"2022-06-21 09:25:48.000000000","message":"Just wondering - will it signal that the checkout was dirty?","commit_id":"ad7b9054ca5ebc53031a10dc3f03675c88845b11"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0fc85ec621f714a485ea882a283c5dd43312bc7c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.dirname(os.path.abspath(__file__)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003dos.path.join(kolla_path, \".git\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"8bdf6e4b_02a9005d","line":20,"in_reply_to":"1d530929_760e3d58","updated":"2022-06-22 08:05:11.000000000","message":"Probably not, I didn\u0027t try ..but even if you modify kolla code on the disk and not building from git, you have also \"dirty\" workspace :/","commit_id":"ad7b9054ca5ebc53031a10dc3f03675c88845b11"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"42f3766ee63a5140318b88430741243734bb359b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.dirname(os.path.abspath(__file__)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003dos.path.join(kolla_path, \".git\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"d1bb3f7e_5e5d2295","line":20,"in_reply_to":"3c532e54_6d0c4ebe","updated":"2022-06-23 09:32:53.000000000","message":"I tested it and it does not show dirty state. I also wonder whether just the pure sha is useful as a reference, as one cannot tell whether this was based on e.g. 14.1.0 or some other release. Maybe have a version string that combines both values?","commit_id":"ad7b9054ca5ebc53031a10dc3f03675c88845b11"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6fa5311e100d729fda8caa29a46c61055fc135b3","unresolved":true,"context_lines":[{"line_number":17,"context_line":"kolla_path \u003d os.path.dirname(os.path.dirname(os.path.abspath(__file__)))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"version_info \u003d pbr.version.VersionInfo(\u0027kolla\u0027)"},{"line_number":20,"context_line":"git_info \u003d pbr.git.get_git_short_sha(git_dir\u003dos.path.join(kolla_path, \".git\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"3c532e54_6d0c4ebe","line":20,"in_reply_to":"8bdf6e4b_02a9005d","updated":"2022-06-22 08:32:07.000000000","message":"Yeah, I meant it would be better if it discerned between pure and impure state (as to report the fact properly in the images).","commit_id":"ad7b9054ca5ebc53031a10dc3f03675c88845b11"}],"releasenotes/notes/add-kolla-git-commit-label-aab06fb8c8df1873.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00ffccd6b83bfd7fe23ef2b00dd9efc14bd6568c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change ``kolla_version`` label to git sha-1 if images"},{"line_number":5,"context_line":"    are built from git."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"385bef6c_8f3eff58","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2022-05-26 12:57:34.000000000","message":"upgrade","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f8bc86b49779d1d4492409e5b9e62d32c2dcc121","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change ``kolla_version`` label to git sha-1 if images"},{"line_number":5,"context_line":"    are built from git."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1b5325d4_1637472e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"385bef6c_8f3eff58","updated":"2022-06-13 13:06:52.000000000","message":"Done","commit_id":"d73cdea31b32b422edd8981a0f72cb6efb46f603"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9745ae4665e39b8768797d772910344c1ec3bedc","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change ``kolla_version`` label to git sha-1 if images"},{"line_number":5,"context_line":"    are built from git."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b5745a6a_cb2af61e","line":5,"updated":"2022-06-16 09:47:15.000000000","message":"\"... built with kolla from git.\" would be a bit clearer?","commit_id":"e169cf7a4040c9881e0ba63f20edc67bdb34b43b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"98ec04f1f023fdfc08022f0780e24820467731b2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change ``kolla_version`` label to git sha-1 if images"},{"line_number":5,"context_line":"    are built from git."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f6addcb_b09b1062","line":5,"in_reply_to":"b5745a6a_cb2af61e","updated":"2022-06-20 13:02:20.000000000","message":"Done","commit_id":"e169cf7a4040c9881e0ba63f20edc67bdb34b43b"}]}