)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d0af03a93ce01ba41dad81690d97d4205a5c9197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a787c8a7_c3b779d8","updated":"2021-12-16 17:34:46.000000000","message":"otherwise fine","commit_id":"7ac219cb8d941b62e309765d033261a9060b3239"},{"author":{"_account_id":33712,"name":"Daniel Meyerholt","email":"dxm523@gmail.com","username":"dxm523"},"change_message_id":"ab57f2474f40ab878878defcf35ca8129a6fec8f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9637131e_432f5d43","updated":"2021-12-20 17:37:42.000000000","message":"Hi again,\nsorry for potential spamming. i think adding\n RUN td-agent-gem uninstall --force \u0027elasticsearch-api:\u003e7.13\u0027 \u0027elasticsearch-transport:\u003e7.13\u0027 \u0027elasticsearch:\u003e7.13\u0027\n\njust inside the same conditional block where you define the fluent plugins would be appropriate. force is needed, as the installation of the plugins takes place later on and uninstall bails out otherwise.\ntested successfully on xena stable branch.\nbest\nDaniel","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d36bf002fad571f94c08959003f62eedf260f610","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db52615a_5f7e3dd9","updated":"2021-12-28 07:07:30.000000000","message":"The patch solves the issue in my downstream deployments. I haven\u0027t found out yet why the issue isn\u0027t seen in kolla CI, but I don\u0027t think that that is necessary for this patch to be merged, is it?\n\nRegarding arm64, I\u0027m not sure we have enough CI coverage to judge, so I would defer anything to be changed in that context to a possible followup patch.","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d304c8fc037983bcb5cfa03b6674e9e48f963ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a62e6ce8_a397d31d","updated":"2021-12-28 10:15:15.000000000","message":"Will include the unpinning of td-agent here.","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0dfed6337ccb4c809e1e0a53cbe0c01775d00008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7dc46c22_ecf042f1","updated":"2021-12-18 09:44:06.000000000","message":"Would be nice if our tests caught this.","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":33712,"name":"Daniel Meyerholt","email":"dxm523@gmail.com","username":"dxm523"},"change_message_id":"1fa1282f9b43ecd3bdf4ac875616c051800ce20a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d90fece5_5be8e9a5","updated":"2021-12-20 16:47:08.000000000","message":"executing \n td-agent-gem uninstall \u0027elasticsearch-api:\u003e7.13\u0027 \u0027elasticsearch-transport:\u003e7.13\u0027 \u0027elasticsearch:\u003e7.13\u0027\ninside a running container / adding this to Dockerfile after the install_fluent_plugins macro fixes the issue of multiple gem version","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":33712,"name":"Daniel Meyerholt","email":"dxm523@gmail.com","username":"dxm523"},"change_message_id":"15b82f490e0ebcd905317e58b19fb8629ae919e7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa58bd3a_5b253645","updated":"2021-12-20 15:28:30.000000000","message":"hi, \ni am not sure if i\u0027m doing it wrong but cherry-picking the fixes onto the stable xena branch (debian-source amd64 images) it seems like the bad behavior is still present.\nit seems like the 7.13 gem is installed alongside the 7.15 gem as seen by \n td-agent-gem list | grep elas\n elasticsearch (7.15.0, 7.13.0)\n\nand both gems are present on the filesystem.\n\nhowever td-agent then uses the 7.15.0 and fails connecting to kolla-provisioned es.\n\nbest,\ndaniel","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b7602a5e84c82b96561a667ce22c6aa476363c98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ab33a03_da5f2584","updated":"2021-12-17 10:45:38.000000000","message":"recheck pypi caches","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"408b2b7ae89ea2f07ebfcecb50f30343f6e30ccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4afdd3bd_2b87ed43","updated":"2021-12-28 09:36:04.000000000","message":"with this patch we end up with two elasticsearch plugin versions: 7.8.1 and 7.13.0","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7d46cc75_83396fcf","in_reply_to":"010ec193_761be95a","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fca4e9546ec44431ee72a37f12ecd669b0a2a5e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"010ec193_761be95a","in_reply_to":"10ddfaf8_e1e6bfe1","updated":"2021-12-28 09:45:35.000000000","message":"Yes, in the CI we install \"td-agent amd64 4.0.1-1\", see https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_688/821695/4/check/kolla-build-ubuntu-source/6880634/kolla/build/fluentd.log\n\nIn the downstream build, we are getting 4.3.0-1 from exactly the same repo, and I don\u0027t see where this difference comes from https://github.com/osism/container-images-kolla/runs/4647704890?check_suite_focus\u003dtrue","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fca4e9546ec44431ee72a37f12ecd669b0a2a5e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e8600ee0_704a580f","in_reply_to":"4afdd3bd_2b87ed43","updated":"2021-12-28 09:45:35.000000000","message":"Yes, I finally found that td-agent is pinned by https://bugs.launchpad.net/kolla/+bug/1930867 , which doesn\u0027t seem to be a very sustainable solution. Will propose a revert and see if we can fix that issue properly. In the meantime I\u0027ll try to figure out why we don\u0027t have that pin downstream.","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae0da95e_3c1b975d","in_reply_to":"56911e96_55dd1cf1","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2607725c8a14b0e5c98496bc51126eb51bdbc0d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56911e96_55dd1cf1","in_reply_to":"56b1b433_deeb2391","updated":"2021-12-27 13:24:29.000000000","message":"Uhm, so is this actually a non-issue? What\u0027s the verdict?","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"413d29ba1eb14ded364a074b39b168a9dacd10cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"92f61cae_7b9719bb","in_reply_to":"66a71e47_c419ce1f","updated":"2021-12-20 12:20:47.000000000","message":"The prometheus-efk job deploys the central logging feature.","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c608e55fcf366c8ebdfb4fabd94220265c3f24b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"66a71e47_c419ce1f","in_reply_to":"7dc46c22_ecf042f1","updated":"2021-12-20 12:11:47.000000000","message":"Seems currently we don\u0027t deploy elasticsearch in the CI, do we? Does it make sense to extend some existing job? I\u0027d be afraid of reaching the limit of the smallish CI VMs. Or make a dedicated monitoring-heavy job?","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":33712,"name":"Daniel Meyerholt","email":"dxm523@gmail.com","username":"dxm523"},"change_message_id":"b1b73bbdbc5251b9e80187920ece09ada24f1e41","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5ffb853_287a924e","in_reply_to":"85c5c07b_ec48c69a","updated":"2021-12-23 16:32:02.000000000","message":"Hi Jens, patch (with the additional uninstalls) is building fine on arm64 as well. checked with debian/arm64/xena","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"586c579836ceddbd24eb62904bdc6598903bfe47","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56b1b433_deeb2391","in_reply_to":"92f61cae_7b9719bb","updated":"2021-12-21 12:16:54.000000000","message":"Thanks for the pointer, it seems we are using different versions of td-agent in CI vs. downstream, will need to debug further.","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"586c579836ceddbd24eb62904bdc6598903bfe47","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"85c5c07b_ec48c69a","in_reply_to":"9637131e_432f5d43","updated":"2021-12-21 12:16:54.000000000","message":"The current patch admittedly only is targeted for the amd64 builds. Maybe you can submit a followup for arm64 images?","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c49a04bc55a500b2603a1a04ee77013fd198ce53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"041b6c36_911755e4","in_reply_to":"9c6aa376_642f0820","updated":"2021-12-28 10:20:55.000000000","message":"Adding more mess does not sound like the right solution, nonetheless. 😂","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e84d7d60_1bd73063","in_reply_to":"c5ffb853_287a924e","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"05efc84060072c5390dde7447cbf89af3eca9cf5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"10ddfaf8_e1e6bfe1","in_reply_to":"db52615a_5f7e3dd9","updated":"2021-12-28 07:41:32.000000000","message":"It seems the images we publish have elasticsearch gem version 7.8.1.","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d304c8fc037983bcb5cfa03b6674e9e48f963ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c6aa376_642f0820","in_reply_to":"e8600ee0_704a580f","updated":"2021-12-28 10:15:15.000000000","message":"Having two elasticsearch gems installed shouldn\u0027t be a blocker, too, since we have multiple versions of fluentd and plugins installed as well:\n\nfluent-plugin-elasticsearch (5.1.4, 4.1.1)\n...\nfluent-plugin-prometheus (2.0.2, 1.8.2)\n...\nfluent-plugin-rewrite-tag-filter (2.4.0, 2.3.0)\n...\nfluentd (1.11.2, 0.12.43)","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25f24b8b_5132ca29","in_reply_to":"fa58bd3a_5b253645","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"71098afc1a527619d244f77d223b602ac2f971ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b36848db32c343aca400d9f2e09c23710b5e4a6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"918d5003_4ac668b2","updated":"2021-12-28 10:40:44.000000000","message":"check experimental","commit_id":"efe8fdb9ac47c7c8b8a57824d742415767d11536"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2da313a14850eff2cc30d0b82781164142cf6f31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4972862f_c5711d2b","updated":"2021-12-29 09:09:08.000000000","message":"O.k., so the gem comes preinstalled in the td-agent omnibus bundle. I was hoping to be able to avoid the nastier step of adding a delete-gem step, but it seems I can\u0027t. At least it is good to see the same issue I\u0027m having downstream in this patch now.","commit_id":"64b6bb9bde1afb6b2091633011a8f8904bb01874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1467e0d3cb68dcacb15e72c445032e2a7367bf3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"508400be_7bab49a9","updated":"2021-12-28 19:52:37.000000000","message":"as for the issue - we need to uninstall the newer version","commit_id":"64b6bb9bde1afb6b2091633011a8f8904bb01874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"718dffb2defb0a5f5f6f1a05339c277bb7a96a67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"35eeee81_83be3020","updated":"2021-12-28 18:10:26.000000000","message":"check experimental","commit_id":"64b6bb9bde1afb6b2091633011a8f8904bb01874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1eee1f9b78abba353bd033cf392b133d4b926afe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e9d6c1a0_de67de57","updated":"2021-12-28 19:52:13.000000000","message":"still 2021-12-28 18:44:53 +0000 [error]: #0 unexpected error error_class\u003dElasticsearch::UnsupportedProductError error\u003d\"The client noticed that the server is not a supported distribution of Elasticsearch.\"\n\nbut now we can make CI detect this issue","commit_id":"64b6bb9bde1afb6b2091633011a8f8904bb01874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0134c61525bf96749371f781a046b875ac9eb88f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"31c289f5_cb3f9f20","updated":"2021-12-29 10:25:16.000000000","message":"check experimental","commit_id":"4a4cbed75b60ba35c0f6d59a2dc8c5b24b5dc951"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab442cebfb3982d45236724d9c58791e16845b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0a8defb1_95b09d34","updated":"2021-12-29 10:25:49.000000000","message":"this should make the prometheus-efk scenario red","commit_id":"4a4cbed75b60ba35c0f6d59a2dc8c5b24b5dc951"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"563ea82ed33573362c922d56de07c57c152f1431","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0eb87be5_49feec51","updated":"2021-12-29 13:12:57.000000000","message":"check experimental","commit_id":"9d91dfdf373ca25663dce69690db37ee713226d9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ff0bdc04e63df12304310d81489e16a0bdec1ee9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"85084e35_1205c937","updated":"2021-12-29 14:35:08.000000000","message":"it seems to work (at least it gives no errors)","commit_id":"9d91dfdf373ca25663dce69690db37ee713226d9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"970b1560ff4f850c82c61624600ba4bc204dd191","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bceaea8a_d61c4a68","updated":"2022-01-27 09:34:59.000000000","message":"I don\u0027t like this variant, but if it is what you want to merge, go ahead.","commit_id":"78e1a195043302e8bda111e67a7ed6db9acaa564"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"89bad5d4_ddb74b28","updated":"2022-01-27 09:20:52.000000000","message":"closed all the comments as they were addressed; I amended the patch to apply mgoddard\u0027s and hrw\u0027s comments (I felt it was easier by showing than trying to explain)","commit_id":"78e1a195043302e8bda111e67a7ed6db9acaa564"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ff5e5b0c4982dd2ff643ed9724a161709c5c5607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a84b29fd_02cc448d","updated":"2022-01-27 09:51:07.000000000","message":"the only grudge I have against this is that the 7.15 might get outdated soon and we would be required to keep bumping this; any idea if we could uninstall any version and then install the desired one?","commit_id":"a8e6924beaea3e268435156f6bbc34812a69a01c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"534165ceff129178a1e91d746f5323c91f7b01c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"95fe308c_0c509d07","in_reply_to":"1f9481a4_e24a9774","updated":"2022-01-27 10:45:52.000000000","message":"Nope, trying to remove the old gems first leads to an error:\n\nINFO:kolla.common.utils.fluentd:ERROR:  While executing gem ... (Gem::DependencyRemovalException)                                                                                     INFO:kolla.common.utils.fluentd:    Uninstallation aborted due to dependent gem(s)","commit_id":"a8e6924beaea3e268435156f6bbc34812a69a01c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8afcc54f3020dab260001356844b1e93456dbf77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2afd4674_944c383f","in_reply_to":"95fe308c_0c509d07","updated":"2022-01-27 10:59:45.000000000","message":"I\u0027m trying out this: https://review.opendev.org/c/openstack/kolla/+/826631","commit_id":"a8e6924beaea3e268435156f6bbc34812a69a01c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3691616c52c8ed5554e3ab0e3df9f03f43a501f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1f9481a4_e24a9774","in_reply_to":"a84b29fd_02cc448d","updated":"2022-01-27 09:51:23.000000000","message":"(marking as not resolved)","commit_id":"a8e6924beaea3e268435156f6bbc34812a69a01c"}],"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ac4d21d6097df88e9c3384256df3ce2e66e554bd","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":86,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":87,"context_line":"        \u0027elasticsearch:7.13.0\u0027,"},{"line_number":88,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5907f074_d5e8859d","line":85,"updated":"2021-12-16 11:17:21.000000000","message":"spotted now - this conditional possibly does not make sense as the installation itself is unconditional (I believe it would fail if it was actually tried)","commit_id":"3adf2e9bd3963c7c2006cf6564e4fbafe221f3a1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03627a571276085b27749f55378df4cb94e43811","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":86,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":87,"context_line":"        \u0027elasticsearch:7.13.0\u0027,"},{"line_number":88,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"8b3e584a_2cb07ccd","line":85,"in_reply_to":"446a1ca6_3ea19240","updated":"2021-12-16 18:27:55.000000000","message":"Just a random note that this conditional probably could go away. I have a tendency to comment on code around the change. You don\u0027t have to do anything with that.","commit_id":"3adf2e9bd3963c7c2006cf6564e4fbafe221f3a1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c2f43a54abd0824e6af068259af74c633bba2b4","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":86,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":87,"context_line":"        \u0027elasticsearch:7.13.0\u0027,"},{"line_number":88,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"446a1ca6_3ea19240","line":85,"in_reply_to":"5907f074_d5e8859d","updated":"2021-12-16 13:19:53.000000000","message":"Not sure what you mean here","commit_id":"3adf2e9bd3963c7c2006cf6564e4fbafe221f3a1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ac4d21d6097df88e9c3384256df3ce2e66e554bd","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":86,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":87,"context_line":"        \u0027elasticsearch:7.13.0\u0027,"},{"line_number":88,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":89,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":90,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b00d6e7d_74aefb8f","line":87,"updated":"2021-12-16 11:17:21.000000000","message":"could use an inline comment","commit_id":"3adf2e9bd3963c7c2006cf6564e4fbafe221f3a1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c2f43a54abd0824e6af068259af74c633bba2b4","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":86,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":87,"context_line":"        \u0027elasticsearch:7.13.0\u0027,"},{"line_number":88,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":89,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":90,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1fcf10dc_9ce2503c","line":87,"in_reply_to":"b00d6e7d_74aefb8f","updated":"2021-12-16 13:19:53.000000000","message":"Done","commit_id":"3adf2e9bd3963c7c2006cf6564e4fbafe221f3a1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d0af03a93ce01ba41dad81690d97d4205a5c9197","unresolved":true,"context_lines":[{"line_number":83,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":86,"context_line":"    {# NOTE(frickler): Need to cap the version of the elasticsearch gems "},{"line_number":87,"context_line":"       in order for them to work with OSS elasticsearch #}"},{"line_number":88,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":89,"context_line":"        \u0027elasticsearch:7.13.0\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"be4baf9c_dd631e5f","line":86,"range":{"start_line":86,"start_character":72,"end_line":86,"end_character":73},"updated":"2021-12-16 17:34:46.000000000","message":"nit: ws","commit_id":"7ac219cb8d941b62e309765d033261a9060b3239"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if not (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":86,"context_line":"    {# NOTE(frickler): Need to cap the version of the elasticsearch gems "},{"line_number":87,"context_line":"       in order for them to work with OSS elasticsearch #}"},{"line_number":88,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":89,"context_line":"        \u0027elasticsearch:7.13.0\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4f912825_366c0b9e","line":86,"range":{"start_line":86,"start_character":72,"end_line":86,"end_character":73},"in_reply_to":"be4baf9c_dd631e5f","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"7ac219cb8d941b62e309765d033261a9060b3239"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2da313a14850eff2cc30d0b82781164142cf6f31","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% block labels %}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":6,"context_line":"{% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block fluentd_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"cadee385_23b1a418","line":5,"updated":"2021-12-29 09:09:08.000000000","message":"Should we update this verion, too? Seems we are actually at 1.14.3 now.","commit_id":"64b6bb9bde1afb6b2091633011a8f8904bb01874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% block labels %}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":6,"context_line":"{% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block fluentd_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"b8ad47cc_f2fa0b08","line":5,"in_reply_to":"0011ade4_eb6c00b0","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"64b6bb9bde1afb6b2091633011a8f8904bb01874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5a2ee1d2d44f5266c9c02bc22dc5b033e7f80536","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% block labels %}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":6,"context_line":"{% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block fluentd_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"0011ade4_eb6c00b0","line":5,"in_reply_to":"cadee385_23b1a418","updated":"2021-12-29 09:12:09.000000000","message":"We can drop these after https://review.opendev.org/c/openstack/kolla-ansible/+/823094","commit_id":"64b6bb9bde1afb6b2091633011a8f8904bb01874"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"84254eb2f648c1e779b9b17fe9b3b411c1a8785d","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7cdad181_c8371174","line":54,"updated":"2022-01-25 09:28:07.000000000","message":"Can we do it in one step?","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0855948dc9899cdcc6dd3435fbff0f49b6d9c9ae","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"5a6c567f_709fa06c","line":54,"in_reply_to":"390cb03e_9e700537","updated":"2022-01-26 09:47:14.000000000","message":"I should have been clearer - one dockerfile RUN command:\n\nRUN install \\\n    \u0026\u0026 td-agent-gem uninstall ...\n\nIt will make the image more space-efficient.","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4efb5b44d4983910bf290c03cfd0556ba48b387b","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"88842a6d_2bb0bf0f","line":54,"in_reply_to":"5a6c567f_709fa06c","updated":"2022-01-26 20:18:55.000000000","message":"Sorry I still don\u0027t get your idea, so you want to replace this macro call by an explicit RUN call? Wouldn\u0027t we loose the customization part then?","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"84431e8557616d5d9f8d39b800f9a1a6210c0aa9","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"390cb03e_9e700537","line":54,"in_reply_to":"77b1ece8_69b93145","updated":"2022-01-25 12:16:36.000000000","message":"Maybe I should be more verbose with my explanation: Unlike with pip, there can be multiple versions of a gem installed at the same time, so just installing the version that we want isn\u0027t enough, since the newer version will continue to be installed in parallel and continue to be used, that\u0027s why the explicit uninstall step is needed.","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c95baf314974b08cb0baea58d547589174c3f44e","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"77b1ece8_69b93145","line":54,"in_reply_to":"7cdad181_c8371174","updated":"2022-01-25 10:39:49.000000000","message":"We could add elasticsearch:7.13.0 to the list above, but I don\u0027t think we could do the uninstall easily here. Leaving both installing the older version and removing the newer one together in one step seemed clearer to me, though.","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9205bc4e_03b74b2c","line":54,"in_reply_to":"88842a6d_2bb0bf0f","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2a6c8b614a41d7d861b8955a6de2e65bed24dde5","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"},{"line_number":58,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch:7.15.0 \\"},{"line_number":59,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch-api:7.15.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"e8c61366_8dd755f9","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":1},"updated":"2022-01-20 17:50:30.000000000","message":"Downgrade Elasticsearch gems for compatibility with OSS version of ES.","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f9f09f46785eabee51396a3739c0c95d780be2e0","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Downgrade elasticsearch gems for OSS compatibility"},{"line_number":57,"context_line":"RUN td-agent-gem install elasticsearch:7.13.0 \\"},{"line_number":58,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch:7.15.0 \\"},{"line_number":59,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch-api:7.15.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"1da89ffe_f4c0214f","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":1},"in_reply_to":"e8c61366_8dd755f9","updated":"2022-01-27 09:20:52.000000000","message":"Done","commit_id":"4b6990699b6f5d6402348abd49c273490e87ae28"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"970b1560ff4f850c82c61624600ba4bc204dd191","unresolved":true,"context_lines":[{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# NOTE(frickler): Downgrading elasticsearch gems for compatibility with OSS versions of ES"},{"line_number":55,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }} \\"},{"line_number":56,"context_line":"    \u0026\u0026 td-agent-gem install elasticsearch:7.13.0 \\"},{"line_number":57,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch:7.15.0 \\"},{"line_number":58,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch-api:7.15.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"934ebc0a_317b9ec5","line":55,"updated":"2022-01-27 09:34:59.000000000","message":"Hmm, I\u0027m not convinced that depending on the macro implementation allowing it to be extended in this way is useful. It also has no effect on image size, the \"wrong\" gems come preinstalled with the td-agent binary afaict, they aren\u0027t installed in this step. Otherwise simply putting \"elasticsearch:7.13.0\" at the front of the plugin list would have been a solution.","commit_id":"78e1a195043302e8bda111e67a7ed6db9acaa564"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fc8e85c13d2ebf7669aa5cd3a796676e97eb395c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# NOTE(frickler): Downgrading elasticsearch gems for compatibility with OSS versions of ES"},{"line_number":55,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }} \\"},{"line_number":56,"context_line":"    \u0026\u0026 td-agent-gem install elasticsearch:7.13.0 \\"},{"line_number":57,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch:7.15.0 \\"},{"line_number":58,"context_line":"    \u0026\u0026 td-agent-gem uninstall elasticsearch-api:7.15.0 \\"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"566ff2f9_656b00f6","line":55,"in_reply_to":"934ebc0a_317b9ec5","updated":"2022-01-27 09:49:09.000000000","message":"Hmm, regarding the usefulness - we rely on this property of our macros already. Regarding the other issue, you are right - I appended to the wrong command, fixing.","commit_id":"78e1a195043302e8bda111e67a7ed6db9acaa564"}]}