)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"33a43cd737910c553933925c19c571b10771d1af","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-23 13:10:36 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix variable name because of customisation ignored"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7ad7b3e7_57c2edd1","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":50},"updated":"2021-12-28 09:21:55.000000000","message":"let\u0027s drop this part of the commit message then; the rest is fine","commit_id":"f62ece8f542c143252a5cd22d2171505ae4dc91c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cf239566fdf74a48a97d7136486d4ff58eadef3f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maksim Malchuk \u003cmaksim.malchuk@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-23 13:10:36 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix variable name because of customisation ignored"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3e80b36f_c24930c8","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":50},"in_reply_to":"7ad7b3e7_57c2edd1","updated":"2021-12-28 11:02:45.000000000","message":"Done","commit_id":"f62ece8f542c143252a5cd22d2171505ae4dc91c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4f21a12578753639da8dea0e7cf93c89653037d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e1987417_a7114f8a","updated":"2021-12-22 08:39:21.000000000","message":"There is a releasenotes/notes/apt-keys-bb7c8678fc6d908b.yaml released where it\u0027s mentioned : \n\nIf you override ``base_apt_keys`` or ``remote_apt_keys`` then please adapt .........\n\nSo, please, could you create LP bug and add reno to inform users there is a bug and variable was changed ? \n\nThanks","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"06387d55aace20b8b32649cf33b5a28d0bd18c22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14af9f34_bfbf4652","in_reply_to":"97deee45_8117fa42","updated":"2021-12-22 10:57:42.000000000","message":"done","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"06387d55aace20b8b32649cf33b5a28d0bd18c22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23db6899_214f14c0","in_reply_to":"97deee45_8117fa42","updated":"2021-12-22 10:57:42.000000000","message":"done","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"37aa003d9d09d470dd5ce3ea5a8c3dc59a1dc2ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97deee45_8117fa42","in_reply_to":"e1987417_a7114f8a","updated":"2021-12-22 08:40:11.000000000","message":"Also add Closes-Bug into this patch.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a7f23ff1d35cb4eb1c9aa8cf8e3e24de4406c872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2382c99b_aaa049f9","updated":"2021-12-22 12:43:34.000000000","message":"If we just change the wording of the release note, I will be happy with this change. Something like:\n\n\"Change ``remote_apt_keys`` variable in base image to ``base_remote_apt_keys`` for consistency. This makes it easier to determine override variable names.\"","commit_id":"b0a42bf9ac7b7225c1f617b6914a5e33ad02f5df"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8874ade8ac2551eba73efa0de37c35b2a3ee2bb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"371e854c_6745f148","updated":"2021-12-27 13:34:31.000000000","message":"Hi Maksim, the customisation should have worked nonetheless (this is just a variable name, in principle we could call it \"foo\" and it would work with the customizable filter properly applied).","commit_id":"f62ece8f542c143252a5cd22d2171505ae4dc91c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ccd0692ecb6191538fb2758c400b8535ca951645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"911c4f6a_33c2038c","updated":"2021-12-27 23:26:42.000000000","message":"I don\u0027t deny that it could have been my typo too. In comparison of apt_keys and remote_apt_keys.","commit_id":"f62ece8f542c143252a5cd22d2171505ae4dc91c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a0a334b6d91e09b54a0a1e6fe4144642a81059c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee0d0e3a_4e228547","updated":"2021-12-23 10:24:57.000000000","message":"Thanks","commit_id":"f62ece8f542c143252a5cd22d2171505ae4dc91c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"80338f677d472fc7f624c9d455c5cd4f882facde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74441fb2_82d3d86a","updated":"2021-12-23 11:38:06.000000000","message":"recheck\n","commit_id":"f62ece8f542c143252a5cd22d2171505ae4dc91c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9dede4f93ee426e5f93f4ea72471d58ef200cfbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e0b1e6e4_3474edb1","in_reply_to":"371e854c_6745f148","updated":"2021-12-27 23:08:34.000000000","message":"I understand, and we already discussed it. We can continue to investigate, spend even more time to reproduce the issue, or simply fix the name of the variable. This worked the way Mark show, but it didn\u0027t work from the Kayobe ansible task when configured kolla_build_customizations variable. The interesting moment was that the base_apt_keys_override worked as expected, but base_remote_apt_keys_override didn\u0027t.","commit_id":"f62ece8f542c143252a5cd22d2171505ae4dc91c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"57847a2c6aa56f351a41573260e816843fecb668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a1dd6edc_4a72cc1d","updated":"2021-12-28 13:35:52.000000000","message":"merging this as trivialfix, thanks","commit_id":"cb99f46929298f8e1d939cfca2a1d4831cd1efca"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"84698f2b63f5b30a925e4c1518a50b870dd14e2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"96877abb_2d86c158","updated":"2021-12-28 16:11:43.000000000","message":"recheck","commit_id":"cb99f46929298f8e1d939cfca2a1d4831cd1efca"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3e2ec14ee204e4788355014cd067dd3bae6e5aaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d8b88fc9_b23f6282","updated":"2021-12-28 15:08:22.000000000","message":"recheck","commit_id":"cb99f46929298f8e1d939cfca2a1d4831cd1efca"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7e2043250d3fc304a8c6fda9982f600245a75e17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c7f52c1_2112857d","in_reply_to":"96877abb_2d86c158","updated":"2021-12-28 16:22:35.000000000","message":"already did it) thanks, it still in progress","commit_id":"cb99f46929298f8e1d939cfca2a1d4831cd1efca"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eed1aace8a77973fbb4c2749512b6cd618b7e2b2","unresolved":true,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e1ccd754_43834589","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"updated":"2021-12-22 11:04:39.000000000","message":"Your proposal is more consistent, but I think it\u0027s this part that matters.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c5fb97cbdd9bec31b6e28718f6d7aea834c02a88","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2b193653_13485f2a","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"018c7c91_7713c24f","updated":"2021-12-22 13:38:54.000000000","message":"I just tested it without this patch.\n\n{% extends parent_template %}\n{% set base_remote_apt_keys_override \u003d [\u0027foo\u0027] %}\n\nkolla-build --template-override rk.j2 --base ubuntu --template-only","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8779fffaf8a7c765d4029f5467805b502c0ed32e","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c27a101c_47f1d3b9","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"1081700e_442cbb41","updated":"2021-12-23 09:57:57.000000000","message":"That\u0027s not in the dockerfile.\n\ncat \u003c\u003c EOF \u003e rk.j2\n{% extends parent_template %}\n{% set base_remote_apt_keys_override \u003d [\u0027foo\u0027] %}\nEOF\n\nkolla-build --template-override rk.j2 --base ubuntu --template-only\n\nThen check the content of the generated dockerfile.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b2a48c408d52fd1f6adef1c70019960ea30f57a5","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"018c7c91_7713c24f","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"16533ea4_30073288","updated":"2021-12-22 12:53:18.000000000","message":"\u003e You can still provide an override variable called \u0027base_remote_apt_keys_append\u0027, and the filter should work. The filter doesn\u0027t care about the name of the variable, only its value and the string passed to it.\n\nIt should, but don\u0027t!!! I mention this before. I use \u0027base_remote_apt_keys_override\u0027 but it silently ignored.\n\n\u003e I agree, it\u0027s confusing that the variable name is not prefixed correctly.\n\nbecause this is requirement!","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fa7d620222067b92b8e003731ae35de86db41184","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1081700e_442cbb41","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"2b193653_13485f2a","updated":"2021-12-22 13:48:33.000000000","message":"this should work because you set the variable inside the Dockerfile. this didn\u0027t work with externaly provided variable. because Dockerfile doesn\u0027t contain \u0027base_remote_apt_keys\u0027 and have only \u0027remote_apt_keys\u0027.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a56eda147d9f231e2fd857d4ae9234a409836cea","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"823ae19c_06ff630c","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"74ca8144_275aea98","updated":"2021-12-22 12:26:43.000000000","message":"this relevant. this filter used here: https://opendev.org/openstack/kolla/src/commit/c8da82967946d5252c557c20423684bed383c228/docker/base/Dockerfile.j2#L355\nfor the code I provided before the correctly to see all cases, not only return if variable not exists.\nhere: https://opendev.org/openstack/kolla/src/commit/c8da82967946d5252c557c20423684bed383c228/kolla/template/filters.py#L27\nwe append the \u0027image_name\u0027 to the variable to lookup in returns.\nThis filter works only with variable names correctly named in the templates.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ae754018fc470f14c5c6eaf28dd957b346b0ff39","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"16533ea4_30073288","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"823ae19c_06ff630c","updated":"2021-12-22 12:41:11.000000000","message":"You can still provide an override variable called \u0027base_remote_apt_keys_append\u0027, and the filter should work. The filter doesn\u0027t care about the name of the variable, only its value and the string passed to it.\n\nI agree, it\u0027s confusing that the variable name is not prefixed correctly.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"80f44a24d76da848fed04148eab61195781e0144","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"74ca8144_275aea98","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"8e044884_5f11855b","updated":"2021-12-22 12:00:05.000000000","message":"I\u0027m not sure how that code is relevant - it just checks for undefined variables. This ensures we don\u0027t fail if a variable isn\u0027t defined in every code path.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a76e6a845413e6a3e5083692ef4c7fbdd678002d","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e8960404_7f72e8de","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"c27a101c_47f1d3b9","updated":"2021-12-23 10:13:45.000000000","message":"ok, lets close discussion, and merge as a trivial fix, not bugfix.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8c5c04fe01fb760931df869d3100d163ddcf27fb","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f8ae3b6e_f9d69f90","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"e1ccd754_43834589","updated":"2021-12-22 11:08:36.000000000","message":"\u003e Your proposal is more consistent, but I think it\u0027s this part that matters.\nit should, but don\u0027t) may be the problem in the customizable macros.","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0195823d30e684c5a0654a2b7e1a58aa4a8cb089","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            {%- if not loop.last %} \\"},{"line_number":353,"context_line":"            {% endif -%}"},{"line_number":354,"context_line":"        {% endfor %}"},{"line_number":355,"context_line":"        {% for key in base_remote_apt_keys | customizable(\u0027remote_apt_keys\u0027) %}"},{"line_number":356,"context_line":"            {%- if loop.first %} RUN mkdir -p /etc/kolla/apt-keys/ {% endif %} \\"},{"line_number":357,"context_line":"            \u0026\u0026 curl {{ key.url }} -o /etc/kolla/apt-keys/{{ key.name }}.{{ key.type | default(\u0027asc\u0027) }}"},{"line_number":358,"context_line":"            {%- if not loop.last %} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"8e044884_5f11855b","line":355,"range":{"start_line":355,"start_character":59,"end_line":355,"end_character":74},"in_reply_to":"f8ae3b6e_f9d69f90","updated":"2021-12-22 11:22:29.000000000","message":"JFYI, the \u0027matters\u0027 ignored here: https://opendev.org/openstack/kolla/src/commit/c8da82967946d5252c557c20423684bed383c228/kolla/template/filters.py#L25-L26","commit_id":"fe65978aa15b6b406813b2e7eb706cff7c5cd94a"}],"releasenotes/notes/apt-keys-bb7c8678fc6d908b.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4f7487ef292c9f805ec7f1fdb4566fd192ecb2ba","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format of APT keys has changed from simple list into dictionary. For"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"94b269c3_b63c877a","line":1,"updated":"2021-12-22 11:06:08.000000000","message":"Unfortunately we can\u0027t change old release notes once they\u0027ve been released.","commit_id":"9480e34720ffe24bd9b064744dba9717e5b4cadc"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6c1d1d5cc44269ff7f6c9ef4bd203ab128e6f9c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format of APT keys has changed from simple list into dictionary. For"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ac76cbea_64233185","line":1,"in_reply_to":"94b269c3_b63c877a","updated":"2021-12-22 11:10:36.000000000","message":"ok, will create the new one","commit_id":"9480e34720ffe24bd9b064744dba9717e5b4cadc"}],"releasenotes/notes/customizable-variable-fix-56c8687b52d6134f.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f2b6680e56450a26c05659de17e03ba95c1b6718","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The name of the variable ``remote_apt_keys`` in the base Dockerfile renamed"},{"line_number":5,"context_line":"    to the ``base_remote_apt_keys`` because the customization ignored."},{"line_number":6,"context_line":"    `LP#1955565 \u003chttps://bugs.launchpad.net/kolla/+bug/1955565\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4b224769_97a5a0c3","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":66},"updated":"2021-12-22 11:58:17.000000000","message":"IIUC, this is incorrect. The variable name does not matter, only the string passed to the customize filter (which is prepended with the image name).\n\nPossibly it was confusing because the release note mentioned the variable name, which is inconsistent.\n\nI\u0027m ok with changing the variable name, I just don\u0027t think it fixes a bug.","commit_id":"b0a42bf9ac7b7225c1f617b6914a5e33ad02f5df"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4ca0e9bf4a943480a612fd6be05fae4a8fb17d36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The name of the variable ``remote_apt_keys`` in the base Dockerfile renamed"},{"line_number":5,"context_line":"    to the ``base_remote_apt_keys`` because the customization ignored."},{"line_number":6,"context_line":"    `LP#1955565 \u003chttps://bugs.launchpad.net/kolla/+bug/1955565\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"696f3e6c_f7045d3f","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":66},"in_reply_to":"4b224769_97a5a0c3","updated":"2021-12-22 12:27:48.000000000","message":"we should revert to the 1st patchset? please discus this with Michael.","commit_id":"b0a42bf9ac7b7225c1f617b6914a5e33ad02f5df"}]}