)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4f2b7eb1f2b930936c904bf4f2f2984a32252174","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-21 15:10:59 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring of the image module."},{"line_number":8,"context_line":"Adding engine adapter module."},{"line_number":9,"context_line":"Transitioning from docker.APIClient to docker.DockerClient."},{"line_number":10,"context_line":"Preparing for adding podman as container engine for building."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":13,"context_line":"Change-Id: I88842c17d8e6ddbe89b984c7b5e0367ed356fa50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bdb072eb_89196b28","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":61},"updated":"2022-01-21 14:30:11.000000000","message":"https://ruanbrandao.com.br/en/2020/02/04/how-to-make-good-git-commits/","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2ee145b9e2fc1fd9db8488569dd6bf5cd9c1f084","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-21 15:10:59 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring of the image module."},{"line_number":8,"context_line":"Adding engine adapter module."},{"line_number":9,"context_line":"Transitioning from docker.APIClient to docker.DockerClient."},{"line_number":10,"context_line":"Preparing for adding podman as container engine for building."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":13,"context_line":"Change-Id: I88842c17d8e6ddbe89b984c7b5e0367ed356fa50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b2ccc73b_7ae6c348","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":61},"in_reply_to":"44d25f61_5549321c","updated":"2023-04-12 15:02:03.000000000","message":"well I would like to expand on this, And actually say that the linked article is really missing some critical information.\n\nreasoning: what is done, is clearly explained by the code itself.\n\na commit message should always strive to inform the reader _why_ a change has been done, because that is often lost in history when revisiting old code.\n\na better guide, from the author of git himself can be found here:\n\nhttps://github.com/torvalds/subsurface-for-dirk/blob/master/README.md#contributing\n\nso please re-add, that this is in preparation for adding podman as container engine for building.\n\nbonus points if you can say, why these changes are needed for that.\n\nsee also our own contributor docs: https://docs.opendev.org/opendev/infra-manual/latest/developers.html#development-workflow\n\nyou should link to a bugreport or a blueprint; basically explain: why is this change needed? why is it implemented the way it is?\n\nsee also: https://docs.opendev.org/opendev/infra-manual/latest/developers.html#committing-changes\n\nI hope that helps!","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5bc51a09b2fe611e67feaa8a6850c18a87e3665f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-21 15:10:59 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring of the image module."},{"line_number":8,"context_line":"Adding engine adapter module."},{"line_number":9,"context_line":"Transitioning from docker.APIClient to docker.DockerClient."},{"line_number":10,"context_line":"Preparing for adding podman as container engine for building."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":13,"context_line":"Change-Id: I88842c17d8e6ddbe89b984c7b5e0367ed356fa50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1672e207_71eb8567","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":61},"in_reply_to":"b2ccc73b_7ae6c348","updated":"2023-05-17 13:27:07.000000000","message":"Done","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"96e5433fc47f858a07c2a774bd64358564d97838","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-21 15:10:59 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring of the image module."},{"line_number":8,"context_line":"Adding engine adapter module."},{"line_number":9,"context_line":"Transitioning from docker.APIClient to docker.DockerClient."},{"line_number":10,"context_line":"Preparing for adding podman as container engine for building."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":13,"context_line":"Change-Id: I88842c17d8e6ddbe89b984c7b5e0367ed356fa50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2421cbdd_881019cd","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":61},"in_reply_to":"b2ccc73b_7ae6c348","updated":"2023-05-17 13:54:47.000000000","message":"We don\u0027t do blueprints since some time, let\u0027s not make this patch review longer ;-)","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"f21a980771c9f28e7debf130aa17239be3f9ddd5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-21 15:10:59 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring of the image module."},{"line_number":8,"context_line":"Adding engine adapter module."},{"line_number":9,"context_line":"Transitioning from docker.APIClient to docker.DockerClient."},{"line_number":10,"context_line":"Preparing for adding podman as container engine for building."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":13,"context_line":"Change-Id: I88842c17d8e6ddbe89b984c7b5e0367ed356fa50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"44d25f61_5549321c","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":61},"in_reply_to":"bdb072eb_89196b28","updated":"2022-01-25 13:45:38.000000000","message":"Done","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66fb6b19408bdbf2d43dca7e224af42dbfbc372d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-28 09:55:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Transition to DockerClient and docker 3.0.0+"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change to use docker.DockerClient instead of the low level"},{"line_number":10,"context_line":"docker.APIClient."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"ebb55393_c0e3a4bb","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":44},"updated":"2023-08-28 10:03:03.000000000","message":"drop this","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"14ca95667e452a54bdfc7e1c15a273521ac12279","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-28 09:55:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Transition to DockerClient and docker 3.0.0+"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change to use docker.DockerClient instead of the low level"},{"line_number":10,"context_line":"docker.APIClient."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"82de77ba_7d394600","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":44},"in_reply_to":"ebb55393_c0e3a4bb","updated":"2023-08-28 13:12:21.000000000","message":"Done","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66fb6b19408bdbf2d43dca7e224af42dbfbc372d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Change to use docker.DockerClient instead of the low level"},{"line_number":10,"context_line":"docker.APIClient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Update minimal docker version to 3.0.0 so that we can"},{"line_number":13,"context_line":"remove \u003c3.0.0 handling next cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Signed-off-by: Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":16,"context_line":"Change-Id: I88842c17d8e6ddbe89b984c7b5e0367ed356fa50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"24113065_588e6d14","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":34},"updated":"2023-08-28 10:03:03.000000000","message":"drop this","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"14ca95667e452a54bdfc7e1c15a273521ac12279","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change to use docker.DockerClient instead of the low level"},{"line_number":10,"context_line":"docker.APIClient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Update minimal docker version to 3.0.0 so that we can"},{"line_number":13,"context_line":"remove \u003c3.0.0 handling next cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Signed-off-by: Konstantin Yarovoy \u003ckonstantin.yarovoy@tietoevry.com\u003e"},{"line_number":16,"context_line":"Change-Id: I88842c17d8e6ddbe89b984c7b5e0367ed356fa50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"d67c0ef4_c8ad1e06","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":34},"in_reply_to":"24113065_588e6d14","updated":"2023-08-28 13:12:21.000000000","message":"Done","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"1e76dbdbf33d31740d817b69e60968290c1e6dcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c3fe3a4a_78045120","updated":"2022-02-03 10:50:06.000000000","message":"recheck","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"fad889a4fdb30d2fc3d3da8e0a747f84e957e59c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fb224680_bce4c447","updated":"2022-02-01 14:55:04.000000000","message":"recheck - unclear failure","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"59daf1e01b33e48f2b922a8289674d4e8f0c4d11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"59648c64_d64b99ce","updated":"2022-02-08 07:15:51.000000000","message":"Missing reno for people upgrading, that we now require docker py 3.0.0+.","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7598ed7354e5300f3ec4500c92b5863eeccb86f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f7dbec6a_c09e677f","in_reply_to":"59648c64_d64b99ce","updated":"2022-02-08 08:14:53.000000000","message":"I doubt people care, tbh. 3.0.0 is from 2018, I bet everyone is using something newer....\n\nOTOH, I would like an explanation why we are touching requirements.txt and migrating to DockerClient in this patch. I would expect a refactor to be refactor and not a refactor plus \"let\u0027s add something random\". I will not accept this patch unless it is a clean refactor.","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"2313ac8ff0f23eed397be16196746665a52a671f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d4ac7a9c_8068da4a","in_reply_to":"607d2ac6_b3a83343","updated":"2022-02-10 14:32:23.000000000","message":"Adding engine adapter module is a part of the refactoring, it does not change any functionality, only moves interactions with docker library to separate module","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"9abe7d543f56cb255638e2def00524042a335d1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"607d2ac6_b3a83343","in_reply_to":"89077b16_1f728840","updated":"2022-02-10 14:15:52.000000000","message":"Done, https://review.opendev.org/c/openstack/kolla/+/828716","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5bc51a09b2fe611e67feaa8a6850c18a87e3665f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c1cd7f2d_d065be93","in_reply_to":"a320536a_48fb904f","updated":"2023-05-17 13:27:07.000000000","message":"Done","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"96e5433fc47f858a07c2a774bd64358564d97838","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"91663396_64ca0266","in_reply_to":"a320536a_48fb904f","updated":"2023-05-17 13:54:47.000000000","message":"Updated, let\u0027s do this, and then we can remove support for older than 3.0.0.","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"54098237a2e0b2e7cdb4d27f9ad03b85f0839568","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a320536a_48fb904f","in_reply_to":"d4ac7a9c_8068da4a","updated":"2023-04-19 14:28:18.000000000","message":"still, as agreed during kolla meeting today, please add relnotes.\n\nrefactoring or not, this is bumping the minimum docker version.\n\nas an old sysadmin I always curse at devs that don\u0027t mention changed requirements in relnotes, it really should not be debatable. One sentence suffices, like:\n\n\"bumped minimal supported docker version to 3.0.0 from 2018 as previous release are not tested and guaranteed to work\"\nif 3.0.0 is also not tested I\u0027d suggest to bump it to something that is tested or at least known to work. ;)","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b95b04f9d1c305ee6ac28b0227b4e21e65a4dd5e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"89077b16_1f728840","in_reply_to":"f7dbec6a_c09e677f","updated":"2022-02-08 08:43:54.000000000","message":"Care or not, a lot of people just use tools/build.py instead of installing Kolla via pip, so that\u0027s why we should at least state that we require a newer version.","commit_id":"32af1b4316522c581dda3a90ac29590cc2ca3890"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3dc03d392dceee73feb7b62dce88bab54a3bf551","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"921ac939_98e96fa3","updated":"2022-12-29 07:53:44.000000000","message":"Do we plan to rework https://github.com/openstack/kolla-ansible/blob/master/ansible/module_utils/kolla_docker_worker.py to DockerClient as well?","commit_id":"31ee7c64d3a3a1208e524c0fdffeddf6131d346c"},{"author":{"_account_id":35104,"name":"Konstantin Yarovoy","email":"k.yarovoy@partner.samsung.com","username":"k.yarovoy"},"change_message_id":"15f91dbf65e1b368f9d41a24792cf48092012884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f632eee3_075762eb","in_reply_to":"921ac939_98e96fa3","updated":"2022-12-30 09:27:30.000000000","message":"I\u0027m not sure, need to ask Martin Hiner and Ivan Halomi","commit_id":"31ee7c64d3a3a1208e524c0fdffeddf6131d346c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc5839f96e2f4f23c453f2ef0663eb75a0c1b8de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a8cfe4cd_956dafcd","in_reply_to":"974540ca_17baec40","updated":"2023-02-27 09:44:30.000000000","message":"Refactor is getting in, can you rebase that one?","commit_id":"31ee7c64d3a3a1208e524c0fdffeddf6131d346c"},{"author":{"_account_id":35104,"name":"Konstantin Yarovoy","email":"k.yarovoy@partner.samsung.com","username":"k.yarovoy"},"change_message_id":"4122d8e0e3154b6f989bcd97ad46f5b401ad614c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"dca041f5_2c79dd61","in_reply_to":"a8cfe4cd_956dafcd","updated":"2023-02-27 13:07:33.000000000","message":"Sure, will try to do rebase on this week","commit_id":"31ee7c64d3a3a1208e524c0fdffeddf6131d346c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1cf3b0701a030b16817ee8291d0ef426a522cabb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"39b81021_dec474da","in_reply_to":"dca041f5_2c79dd61","updated":"2023-02-28 13:17:45.000000000","message":"Done","commit_id":"31ee7c64d3a3a1208e524c0fdffeddf6131d346c"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"06144061a6eeb2e9786a42c57ac1cd497a5017f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"974540ca_17baec40","in_reply_to":"f632eee3_075762eb","updated":"2023-01-02 13:51:49.000000000","message":"Yes we can rework it after systemd patch is merged to avoid making the patch chain any longer.","commit_id":"31ee7c64d3a3a1208e524c0fdffeddf6131d346c"},{"author":{"_account_id":35104,"name":"Konstantin Yarovoy","email":"k.yarovoy@partner.samsung.com","username":"k.yarovoy"},"change_message_id":"4f07a51b6b6c37b452569ef1b456d34a11fa51aa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"a77c5391_20ea136d","updated":"2023-03-03 13:20:40.000000000","message":"I\u0027m not sure about how to address kolla-ansible-XXX zuul failures.\nIt doesn\u0027t seem to be an issue in kolla as other builds work fine.\nCan someone please take a look at it?","commit_id":"aa92bcf511f371c26d5df751785eec6169d2350e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"81a6db398014ef7f7e9ac4d20079c169a5979177","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d39a8e1b_61a9022d","in_reply_to":"a77c5391_20ea136d","updated":"2023-03-15 10:42:06.000000000","message":"It seems it has issues with pushing.","commit_id":"aa92bcf511f371c26d5df751785eec6169d2350e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"29775f3964ff34a0d6cba4e247f4baecf42b961d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"bfa2f72e_aa7e28ea","in_reply_to":"d39a8e1b_61a9022d","updated":"2023-05-04 12:09:34.000000000","message":"docker.version is a module and doesn\u0027t output a string, updated it to check for docker.__version__","commit_id":"aa92bcf511f371c26d5df751785eec6169d2350e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"525d8fadffe9be84bc77e7a57b68afb824f7b2de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1bcafafd_7fdb0236","updated":"2023-04-19 15:33:05.000000000","message":"one failure seems to be (https://b2d3e4ff63f43495fb6e-7130cff635b715a96cb8254a2740af6b.ssl.cf1.rackcdn.com/825786/22/check/kolla-ansible-ubuntu-upgrade/7b129fb/job-output.txt):\n\n2023-04-19 13:25:13.307012 | TASK [Run setup_gate.sh script]\n2023-04-19 13:36:12.537571 | primary | ERROR\n2023-04-19 13:36:12.538271 | primary | {\n2023-04-19 13:36:12.538365 | primary |   \"exception\": \"NoneType: None\\n\",\n2023-04-19 13:36:12.538450 | primary |   \"msg\": \"non-zero return code\",\n2023-04-19 13:36:12.538531 | primary |   \"rc\": 1\n2023-04-19 13:36:12.538612 | primary | }\n2023-04-19 13:36:12.554208 | \n\nstill investigating, but I didn\u0027t find logs from this script just yet.","commit_id":"aa3f1c86302ea75340f16eb1a2ac17bd2e87858f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1ab8ed79307df73104e083aa91d715e9ae2e30a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fbfb77d9_b11f6db0","updated":"2023-04-19 13:17:30.000000000","message":"recheck to get logs of failed jobs as currently they are missing","commit_id":"aa3f1c86302ea75340f16eb1a2ac17bd2e87858f"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ea95249e5f1297ea7f33f16a78378e00f30b6bc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"41ffc05c_a39fe108","updated":"2023-04-12 13:43:40.000000000","message":"stable/zed has docker\u003d\u003d\u003d6.0.0 in openstack/requirements so maybe instead of trying to handle \u003c3.0.0 we should just write \"update!\" and exit?","commit_id":"aa3f1c86302ea75340f16eb1a2ac17bd2e87858f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"167c8af82973d3994ba9e7d5165b3fc40b5a2bbb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"210055c2_76837af9","in_reply_to":"1bcafafd_7fdb0236","updated":"2023-04-19 15:46:00.000000000","message":"See https://zuul.opendev.org/t/openstack/build/7b129fb956d24076ace2d221b6180a44/console#2/1/28/primary","commit_id":"aa3f1c86302ea75340f16eb1a2ac17bd2e87858f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"96e5433fc47f858a07c2a774bd64358564d97838","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4d7a2568_15954fbf","in_reply_to":"210055c2_76837af9","updated":"2023-05-17 13:54:47.000000000","message":"Done","commit_id":"aa3f1c86302ea75340f16eb1a2ac17bd2e87858f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9e136247ef8dd5aa67565bec5a85bd918ea7dcf6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":24,"id":"4ce917dc_8a83ae77","updated":"2023-05-04 12:10:12.000000000","message":"Konstantin - if you\u0027ll add the release note and resolve other review comments - we could merge it this cycle.","commit_id":"ad6705c839bdd1c58b450fa9013fa776bb924817"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"96e5433fc47f858a07c2a774bd64358564d97838","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"30bc16c3_3ba4dce9","in_reply_to":"4ce917dc_8a83ae77","updated":"2023-05-17 13:54:47.000000000","message":"Done","commit_id":"ad6705c839bdd1c58b450fa9013fa776bb924817"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5bc51a09b2fe611e67feaa8a6850c18a87e3665f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"8e05f013_b925d9db","in_reply_to":"4ce917dc_8a83ae77","updated":"2023-05-17 13:27:07.000000000","message":"Done","commit_id":"ad6705c839bdd1c58b450fa9013fa776bb924817"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"37737a0b83357d3a9095af0f8f9e3f4dd2b09e3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"3311b029_7dde7f0a","updated":"2023-05-18 05:16:25.000000000","message":"We won\u0027t be able to get podman builds in, so not RP anymore.","commit_id":"10efe2a469e1941ed96ea08cfeef011af708cc6d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"da949181dc45ebad94d00cf8300b6e78bfaf2fa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"6f648b8c_ea821179","updated":"2023-08-24 20:03:09.000000000","message":"lgtm, but please address my last unresolved comment","commit_id":"20edebc636b46bb31ed63aeb998cd0a6c910892c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66fb6b19408bdbf2d43dca7e224af42dbfbc372d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"c185b57b_31fac583","updated":"2023-08-28 10:03:03.000000000","message":"more cleanup to do","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"}],"kolla/common/config.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"21e00e2c9ccee533a55d8e9cfb31625012ea8eff","unresolved":true,"context_lines":[{"line_number":228,"context_line":"    cfg.StrOpt(\u0027work-dir\u0027, help\u003d(\u0027Path to be used as working directory.\u0027"},{"line_number":229,"context_line":"                                 \u0027 By default, a temporary dir is created\u0027)),"},{"line_number":230,"context_line":"    cfg.BoolOpt(\u0027squash\u0027, default\u003dFalse,"},{"line_number":231,"context_line":"                help\u003d(\u0027Squash the image layers. WARNING: it will consume lots \u0027"},{"line_number":232,"context_line":"                      \u0027of disk IO. \"docker-squash\" tool is required for \u0027"},{"line_number":233,"context_line":"                      \u0027docker, install it by \"pip install docker-squash\"\u0027)),"},{"line_number":234,"context_line":"    cfg.StrOpt(\u0027openstack-release\u0027, default\u003dOPENSTACK_RELEASE,"},{"line_number":235,"context_line":"               help\u003d\u0027OpenStack release for building kolla source images and \u0027"},{"line_number":236,"context_line":"                    \u0027kolla-toolbox image\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9783c13c_aca2b92a","line":233,"range":{"start_line":231,"start_character":1,"end_line":233,"end_character":76},"updated":"2022-01-21 14:37:27.000000000","message":"drop that change","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"f21a980771c9f28e7debf130aa17239be3f9ddd5","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    cfg.StrOpt(\u0027work-dir\u0027, help\u003d(\u0027Path to be used as working directory.\u0027"},{"line_number":229,"context_line":"                                 \u0027 By default, a temporary dir is created\u0027)),"},{"line_number":230,"context_line":"    cfg.BoolOpt(\u0027squash\u0027, default\u003dFalse,"},{"line_number":231,"context_line":"                help\u003d(\u0027Squash the image layers. WARNING: it will consume lots \u0027"},{"line_number":232,"context_line":"                      \u0027of disk IO. \"docker-squash\" tool is required for \u0027"},{"line_number":233,"context_line":"                      \u0027docker, install it by \"pip install docker-squash\"\u0027)),"},{"line_number":234,"context_line":"    cfg.StrOpt(\u0027openstack-release\u0027, default\u003dOPENSTACK_RELEASE,"},{"line_number":235,"context_line":"               help\u003d\u0027OpenStack release for building kolla source images and \u0027"},{"line_number":236,"context_line":"                    \u0027kolla-toolbox image\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"789e17a2_5c3d053f","line":233,"range":{"start_line":231,"start_character":1,"end_line":233,"end_character":76},"in_reply_to":"9783c13c_aca2b92a","updated":"2022-01-25 13:45:38.000000000","message":"Done","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"21e00e2c9ccee533a55d8e9cfb31625012ea8eff","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                help\u003d\u0027Rename infrastructure images to infra\u0027),"},{"line_number":253,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027Engine to build images on. \u0027"},{"line_number":255,"context_line":"                    \u0027Options: docker; \u0027"},{"line_number":256,"context_line":"                    \u0027default is docker\u0027)"},{"line_number":257,"context_line":"]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"_BASE_OPTS \u003d ["},{"line_number":260,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"57b2d1a5_e79c4215","line":257,"range":{"start_line":255,"start_character":14,"end_line":257,"end_character":1},"updated":"2022-01-21 14:37:27.000000000","message":"we do not list options in help string","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"f21a980771c9f28e7debf130aa17239be3f9ddd5","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                help\u003d\u0027Rename infrastructure images to infra\u0027),"},{"line_number":253,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027Engine to build images on. \u0027"},{"line_number":255,"context_line":"                    \u0027Options: docker; \u0027"},{"line_number":256,"context_line":"                    \u0027default is docker\u0027)"},{"line_number":257,"context_line":"]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"_BASE_OPTS \u003d ["},{"line_number":260,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5ac93a8_26844632","line":257,"range":{"start_line":255,"start_character":14,"end_line":257,"end_character":1},"in_reply_to":"57b2d1a5_e79c4215","updated":"2022-01-25 13:45:38.000000000","message":"Done","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e6bc98b5f72775305dca5916a15294fd474a05fb","unresolved":true,"context_lines":[{"line_number":251,"context_line":"    cfg.BoolOpt(\u0027infra-rename\u0027, default\u003dFalse,"},{"line_number":252,"context_line":"                help\u003d\u0027Rename infrastructure images to infra\u0027),"},{"line_number":253,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027Engine to build images on. \u0027"},{"line_number":255,"context_line":"                    \u0027default is \"docker\"\u0027)"},{"line_number":256,"context_line":"]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"c89331d5_e9bb1dea","line":255,"range":{"start_line":254,"start_character":13,"end_line":255,"end_character":42},"updated":"2022-02-03 12:16:44.000000000","message":"This fits in 80 columns so make it one line. And capitalize \u0027default\u0027 as it starts new sentence.","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"86cfd686241f40256dac934cf3abd4a62b8fd042","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    cfg.BoolOpt(\u0027infra-rename\u0027, default\u003dFalse,"},{"line_number":252,"context_line":"                help\u003d\u0027Rename infrastructure images to infra\u0027),"},{"line_number":253,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027,"},{"line_number":254,"context_line":"               help\u003d\u0027Engine to build images on. \u0027"},{"line_number":255,"context_line":"                    \u0027default is \"docker\"\u0027)"},{"line_number":256,"context_line":"]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"a9a504c7_66ef4354","line":255,"range":{"start_line":254,"start_character":13,"end_line":255,"end_character":42},"in_reply_to":"c89331d5_e9bb1dea","updated":"2022-02-04 09:30:18.000000000","message":"Done","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"}],"kolla/engine_adapter/engine.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e6bc98b5f72775305dca5916a15294fd474a05fb","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        raise Exception(f\"Unsupported engine name given: {conf.engine}\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def isOldVersion():"},{"line_number":40,"context_line":"    # This function is only for docker"},{"line_number":41,"context_line":"    dc_running_ver \u003d StrictVersion(docker.version)"},{"line_number":42,"context_line":"    return dc_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5e715998_44a60761","line":42,"range":{"start_line":39,"start_character":1,"end_line":42,"end_character":50},"updated":"2022-02-03 12:16:44.000000000","message":"This patch bumps requirements to \"docker\u003e\u003d3.0.0\" so this function will not be needed.\n\nOn the other way - many people may have old enviroments with docker 2.4.2 installed which was fine for Kolla so far.","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"962b989206bc413459bc0388de3e405142785fa6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        raise Exception(f\"Unsupported engine name given: {conf.engine}\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def isOldVersion():"},{"line_number":40,"context_line":"    # This function is only for docker"},{"line_number":41,"context_line":"    dc_running_ver \u003d StrictVersion(docker.version)"},{"line_number":42,"context_line":"    return dc_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"e0d4e303_f8207d5f","line":42,"range":{"start_line":39,"start_character":1,"end_line":42,"end_character":50},"in_reply_to":"2b1f5297_d1377b82","updated":"2022-02-04 09:22:40.000000000","message":"git clone kolla\npip install docker\u003d\u003d2.4.2\nkolla-build  # works\ngit pull  # to get your change\nkolla-build  # works? probably yes, just isOldVersion returns True\n\nMost of people do not do \u0027pip install -U -r requirements.txt\u0027 after each git pull.","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"aac00f83ff7089b05f6d26cfd9e83d20e852b7b2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        raise Exception(f\"Unsupported engine name given: {conf.engine}\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def isOldVersion():"},{"line_number":40,"context_line":"    # This function is only for docker"},{"line_number":41,"context_line":"    dc_running_ver \u003d StrictVersion(docker.version)"},{"line_number":42,"context_line":"    return dc_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"2b1f5297_d1377b82","line":42,"range":{"start_line":39,"start_character":1,"end_line":42,"end_character":50},"in_reply_to":"4fd88faa_fb38c185","updated":"2022-02-04 09:16:18.000000000","message":"So that would be removing \"isOldVersion\"? If not - because of requirements bump - i see that function as useless (except maybe case when someone manually changes requirements and run kolla-build on lower docker versions)","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"d39d3b719a9c2956a4191d1ad617fdc5e0181812","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        raise Exception(f\"Unsupported engine name given: {conf.engine}\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def isOldVersion():"},{"line_number":40,"context_line":"    # This function is only for docker"},{"line_number":41,"context_line":"    dc_running_ver \u003d StrictVersion(docker.version)"},{"line_number":42,"context_line":"    return dc_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"c2f95339_4a5da651","line":42,"range":{"start_line":39,"start_character":1,"end_line":42,"end_character":50},"in_reply_to":"5e715998_44a60761","updated":"2022-02-04 08:22:37.000000000","message":"So, would it be better to return to lower requirements or to delete this function and its uses (and test for older version)?","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"06b09c27ebbab4803443fe16de33d8aa94d110c9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        raise Exception(f\"Unsupported engine name given: {conf.engine}\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def isOldVersion():"},{"line_number":40,"context_line":"    # This function is only for docker"},{"line_number":41,"context_line":"    dc_running_ver \u003d StrictVersion(docker.version)"},{"line_number":42,"context_line":"    return dc_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"4fd88faa_fb38c185","line":42,"range":{"start_line":39,"start_character":1,"end_line":42,"end_character":50},"in_reply_to":"c2f95339_4a5da651","updated":"2022-02-04 08:45:30.000000000","message":"Stay as patch does imho.","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19658196e31a5e4f36839d4579bea913921ddff2","unresolved":true,"context_lines":[{"line_number":53,"context_line":"def isOldVersion(conf):"},{"line_number":54,"context_line":"    # This function is only for docker"},{"line_number":55,"context_line":"    # Even through requirements demand docker\u003e\u003d3.0.0, kolla-build should be"},{"line_number":56,"context_line":"    # working on lower versions, so this function is kept."},{"line_number":57,"context_line":"    if conf.engine \u003d\u003d Engine.DOCKER.value:"},{"line_number":58,"context_line":"        engine_client_running_ver \u003d StrictVersion(docker.__version__)"},{"line_number":59,"context_line":"        return engine_client_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"d4428fdd_c0e8434f","line":56,"updated":"2023-08-28 08:58:00.000000000","message":"Do we really still need this? This patch would get a lot simpler if we simply drop support for \u003c3.","commit_id":"20edebc636b46bb31ed63aeb998cd0a6c910892c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"81787b40a9939732fe5bb9c087b459d4f1e19370","unresolved":false,"context_lines":[{"line_number":53,"context_line":"def isOldVersion(conf):"},{"line_number":54,"context_line":"    # This function is only for docker"},{"line_number":55,"context_line":"    # Even through requirements demand docker\u003e\u003d3.0.0, kolla-build should be"},{"line_number":56,"context_line":"    # working on lower versions, so this function is kept."},{"line_number":57,"context_line":"    if conf.engine \u003d\u003d Engine.DOCKER.value:"},{"line_number":58,"context_line":"        engine_client_running_ver \u003d StrictVersion(docker.__version__)"},{"line_number":59,"context_line":"        return engine_client_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"2d27a123_7afbb3ed","line":56,"in_reply_to":"724f2c1e_e982ef50","updated":"2023-08-28 10:08:29.000000000","message":"Done","commit_id":"20edebc636b46bb31ed63aeb998cd0a6c910892c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ca30b5f9e630cce1b8f468d4f646cb7bf2dc5066","unresolved":true,"context_lines":[{"line_number":53,"context_line":"def isOldVersion(conf):"},{"line_number":54,"context_line":"    # This function is only for docker"},{"line_number":55,"context_line":"    # Even through requirements demand docker\u003e\u003d3.0.0, kolla-build should be"},{"line_number":56,"context_line":"    # working on lower versions, so this function is kept."},{"line_number":57,"context_line":"    if conf.engine \u003d\u003d Engine.DOCKER.value:"},{"line_number":58,"context_line":"        engine_client_running_ver \u003d StrictVersion(docker.__version__)"},{"line_number":59,"context_line":"        return engine_client_running_ver \u003c StrictVersion(\u00273.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"724f2c1e_e982ef50","line":56,"in_reply_to":"d4428fdd_c0e8434f","updated":"2023-08-28 09:49:20.000000000","message":"3.0.0 was released on 1st Feb 2018. We should be free to abandon any older ones.","commit_id":"20edebc636b46bb31ed63aeb998cd0a6c910892c"}],"kolla/image/build.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"21e00e2c9ccee533a55d8e9cfb31625012ea8eff","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                      \"Try running pip install docker\")"},{"line_number":123,"context_line":"            exit(1)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    if conf.squash and conf.engine \u003d\u003d \u0027docker\u0027:"},{"line_number":126,"context_line":"        squash_version \u003d utils.get_docker_squash_version()"},{"line_number":127,"context_line":"        LOG.info(\u0027Image squash is enabled and \"docker-squash\" version is %s\u0027,"},{"line_number":128,"context_line":"                 squash_version)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    kolla \u003d KollaWorker(conf)"},{"line_number":131,"context_line":"    kolla.setup_working_dir()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1899649e_2eb8dd53","line":128,"range":{"start_line":125,"start_character":0,"end_line":128,"end_character":32},"updated":"2022-01-21 14:37:27.000000000","message":"indent and drop \u0027is docker\u0027 check.","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"f21a980771c9f28e7debf130aa17239be3f9ddd5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                      \"Try running pip install docker\")"},{"line_number":123,"context_line":"            exit(1)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    if conf.squash and conf.engine \u003d\u003d \u0027docker\u0027:"},{"line_number":126,"context_line":"        squash_version \u003d utils.get_docker_squash_version()"},{"line_number":127,"context_line":"        LOG.info(\u0027Image squash is enabled and \"docker-squash\" version is %s\u0027,"},{"line_number":128,"context_line":"                 squash_version)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    kolla \u003d KollaWorker(conf)"},{"line_number":131,"context_line":"    kolla.setup_working_dir()"}],"source_content_type":"text/x-python","patch_set":2,"id":"a4abb46f_20781c02","line":128,"range":{"start_line":125,"start_character":0,"end_line":128,"end_character":32},"in_reply_to":"1899649e_2eb8dd53","updated":"2022-01-25 13:45:38.000000000","message":"Done","commit_id":"34d57bcb537ed027c3e91b06230d61359fefeeea"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e6bc98b5f72775305dca5916a15294fd474a05fb","unresolved":true,"context_lines":[{"line_number":121,"context_line":"                      \"Try running pip install docker\")"},{"line_number":122,"context_line":"            exit(1)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    if conf.squash:"},{"line_number":125,"context_line":"        squash_version \u003d utils.get_docker_squash_version()"},{"line_number":126,"context_line":"        LOG.info(\u0027Image squash is enabled and \"docker-squash\" version is %s\u0027,"},{"line_number":127,"context_line":"                 squash_version)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    kolla \u003d KollaWorker(conf)"},{"line_number":130,"context_line":"    kolla.setup_working_dir()"}],"source_content_type":"text/x-python","patch_set":13,"id":"046ead3e_3652a72f","line":127,"range":{"start_line":124,"start_character":0,"end_line":127,"end_character":32},"updated":"2022-02-03 12:16:44.000000000","message":"Will need to remember to handle it for non-docker container engines so maybe move it to \"if conf.engine \u003d\u003d \u0027docker\u0027\" block?","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"86cfd686241f40256dac934cf3abd4a62b8fd042","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                      \"Try running pip install docker\")"},{"line_number":122,"context_line":"            exit(1)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    if conf.squash:"},{"line_number":125,"context_line":"        squash_version \u003d utils.get_docker_squash_version()"},{"line_number":126,"context_line":"        LOG.info(\u0027Image squash is enabled and \"docker-squash\" version is %s\u0027,"},{"line_number":127,"context_line":"                 squash_version)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    kolla \u003d KollaWorker(conf)"},{"line_number":130,"context_line":"    kolla.setup_working_dir()"}],"source_content_type":"text/x-python","patch_set":13,"id":"707fb5ec_e2015148","line":127,"range":{"start_line":124,"start_character":0,"end_line":127,"end_character":32},"in_reply_to":"046ead3e_3652a72f","updated":"2022-02-04 09:30:18.000000000","message":"Done","commit_id":"e6547bf46f17fe19ba2d078475870e58529a4420"}],"kolla/image/tasks.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9fb65d181296fb4b9a0d6b73945e71aec66a785c","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        # To be compatible, set \u0027insecure_registry\u003dTrue\u0027 for old releases."},{"line_number":113,"context_line":"        if self.conf.engine \u003d\u003d \u0027docker\u0027:"},{"line_number":114,"context_line":"            if engine.isOldVersion(self.conf):"},{"line_number":115,"context_line":"                kwargs[\u0027insecure_registry\u0027] \u003d True"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        for response in self.engine_client.images.push(image.canonical_name,"},{"line_number":118,"context_line":"                                                       **kwargs):"}],"source_content_type":"text/x-python","patch_set":29,"id":"f636b1c2_a866520f","line":115,"updated":"2023-05-17 13:32:15.000000000","message":"should we also display warning here?","commit_id":"ca62b9f5b723850f4f039a194877121637b28b1f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9a35f66e0ba7b8930e25579ce5a4d380c5ed1e5c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # To be compatible, set \u0027insecure_registry\u003dTrue\u0027 for old releases."},{"line_number":113,"context_line":"        if self.conf.engine \u003d\u003d \u0027docker\u0027:"},{"line_number":114,"context_line":"            if engine.isOldVersion(self.conf):"},{"line_number":115,"context_line":"                kwargs[\u0027insecure_registry\u0027] \u003d True"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        for response in self.engine_client.images.push(image.canonical_name,"},{"line_number":118,"context_line":"                                                       **kwargs):"}],"source_content_type":"text/x-python","patch_set":29,"id":"32908ae8_e36a6701","line":115,"in_reply_to":"f636b1c2_a866520f","updated":"2023-08-28 13:12:30.000000000","message":"Done","commit_id":"ca62b9f5b723850f4f039a194877121637b28b1f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"63e93066c9c01b1dfc364415a2324bd7615639d5","unresolved":true,"context_lines":[{"line_number":417,"context_line":"                parent_last_layer \u003d layer[\"Id\"]"},{"line_number":418,"context_line":"                break"},{"line_number":419,"context_line":"        if not parent_last_layer:"},{"line_number":420,"context_line":"            self.logger.error(\u0027Parent lastest layer is not found, \u0027"},{"line_number":421,"context_line":"                              \u0027cannot squash.\u0027)"},{"line_number":422,"context_line":"            self.image.status \u003d Status.ERROR"},{"line_number":423,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":36,"id":"3cb99f6f_45fffa9c","line":420,"range":{"start_line":420,"start_character":38,"end_line":420,"end_character":45},"updated":"2023-08-28 13:28:17.000000000","message":"nit: last","commit_id":"3b5cc22c6d275e48be68cbf23d8635c6659beacd"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3e3d1fbf47cc80899cb54f303f789d08c48b5689","unresolved":true,"context_lines":[{"line_number":417,"context_line":"                parent_last_layer \u003d layer[\"Id\"]"},{"line_number":418,"context_line":"                break"},{"line_number":419,"context_line":"        if not parent_last_layer:"},{"line_number":420,"context_line":"            self.logger.error(\u0027Parent lastest layer is not found, \u0027"},{"line_number":421,"context_line":"                              \u0027cannot squash.\u0027)"},{"line_number":422,"context_line":"            self.image.status \u003d Status.ERROR"},{"line_number":423,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":36,"id":"90690be9_b2edac72","line":420,"range":{"start_line":420,"start_character":38,"end_line":420,"end_character":45},"in_reply_to":"2aacad5e_fe921560","updated":"2023-08-28 13:54:49.000000000","message":"well, I thought about it for awhile before commenting, but if it is \"latest\" then `parent_last_layer`\u0027s name is wrong as well and should be `renamed parent_latest_layer`, thus I went with \"last\".\n\nin each case, \"lastest\" is wrong. This time I checked with Oxford dictionary and it doesn\u0027t know what \"lastest\" should be, also my browser spellchecker doesn\u0027t know it either. ;-)","commit_id":"3b5cc22c6d275e48be68cbf23d8635c6659beacd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e4ea43dfe35b5ab2291ee9ae98881146d5198d23","unresolved":true,"context_lines":[{"line_number":417,"context_line":"                parent_last_layer \u003d layer[\"Id\"]"},{"line_number":418,"context_line":"                break"},{"line_number":419,"context_line":"        if not parent_last_layer:"},{"line_number":420,"context_line":"            self.logger.error(\u0027Parent lastest layer is not found, \u0027"},{"line_number":421,"context_line":"                              \u0027cannot squash.\u0027)"},{"line_number":422,"context_line":"            self.image.status \u003d Status.ERROR"},{"line_number":423,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":36,"id":"2aacad5e_fe921560","line":420,"range":{"start_line":420,"start_character":38,"end_line":420,"end_character":45},"in_reply_to":"3cb99f6f_45fffa9c","updated":"2023-08-28 13:29:43.000000000","message":"or latest?","commit_id":"3b5cc22c6d275e48be68cbf23d8635c6659beacd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"eae7fbda57ad9055b78c78458be524be79cb80c9","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                parent_last_layer \u003d layer[\"Id\"]"},{"line_number":418,"context_line":"                break"},{"line_number":419,"context_line":"        if not parent_last_layer:"},{"line_number":420,"context_line":"            self.logger.error(\u0027Parent lastest layer is not found, \u0027"},{"line_number":421,"context_line":"                              \u0027cannot squash.\u0027)"},{"line_number":422,"context_line":"            self.image.status \u003d Status.ERROR"},{"line_number":423,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":36,"id":"06ee4205_03630906","line":420,"range":{"start_line":420,"start_character":38,"end_line":420,"end_character":45},"in_reply_to":"90690be9_b2edac72","updated":"2023-08-28 14:02:16.000000000","message":"it has been there for ages, but I agree lastest is a bit weird :-)","commit_id":"3b5cc22c6d275e48be68cbf23d8635c6659beacd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"78687fc57e5f4748e6ccfa6550c0f94ef7dbbd70","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            self.image.status \u003d Status.ERROR"},{"line_number":423,"context_line":"            return"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        self.logger.info(\u0027Parent lastest layer is: %s\u0027 % parent_last_layer)"},{"line_number":426,"context_line":"        utils.squash(image_id, image_tag, from_layer\u003dparent_last_layer,"},{"line_number":427,"context_line":"                     cleanup\u003dself.conf.squash_cleanup,"},{"line_number":428,"context_line":"                     tmp_dir\u003dself.conf.squash_tmp_dir)"}],"source_content_type":"text/x-python","patch_set":36,"id":"2cc92d44_1df5271e","line":425,"range":{"start_line":425,"start_character":33,"end_line":425,"end_character":40},"updated":"2023-08-28 13:35:34.000000000","message":"same wording is already being used here?!?","commit_id":"3b5cc22c6d275e48be68cbf23d8635c6659beacd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"eae7fbda57ad9055b78c78458be524be79cb80c9","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            self.image.status \u003d Status.ERROR"},{"line_number":423,"context_line":"            return"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        self.logger.info(\u0027Parent lastest layer is: %s\u0027 % parent_last_layer)"},{"line_number":426,"context_line":"        utils.squash(image_id, image_tag, from_layer\u003dparent_last_layer,"},{"line_number":427,"context_line":"                     cleanup\u003dself.conf.squash_cleanup,"},{"line_number":428,"context_line":"                     tmp_dir\u003dself.conf.squash_tmp_dir)"}],"source_content_type":"text/x-python","patch_set":36,"id":"f68b3c51_65545c8e","line":425,"range":{"start_line":425,"start_character":33,"end_line":425,"end_character":40},"in_reply_to":"2cc92d44_1df5271e","updated":"2023-08-28 14:02:16.000000000","message":"lastest! ;-)","commit_id":"3b5cc22c6d275e48be68cbf23d8635c6659beacd"}],"kolla/tests/test_build.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66fb6b19408bdbf2d43dca7e224af42dbfbc372d","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.imageChild.parent \u003d self.image"},{"line_number":65,"context_line":"        self.imageChild.path \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @mock.patch(\u0027docker.__version__\u0027, \u00272.7.0\u0027)"},{"line_number":68,"context_line":"    @mock.patch.dict(os.environ, clear\u003dTrue)"},{"line_number":69,"context_line":"    @mock.patch(\u0027docker.DockerClient\u0027)"},{"line_number":70,"context_line":"    def test_push_image_before_v3_0_0(self, mock_client):"}],"source_content_type":"text/x-python","patch_set":32,"id":"7b59c466_8743afb5","line":67,"updated":"2023-08-28 10:03:03.000000000","message":"These all can be dropped, too?","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"14ca95667e452a54bdfc7e1c15a273521ac12279","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.imageChild.parent \u003d self.image"},{"line_number":65,"context_line":"        self.imageChild.path \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @mock.patch(\u0027docker.__version__\u0027, \u00272.7.0\u0027)"},{"line_number":68,"context_line":"    @mock.patch.dict(os.environ, clear\u003dTrue)"},{"line_number":69,"context_line":"    @mock.patch(\u0027docker.DockerClient\u0027)"},{"line_number":70,"context_line":"    def test_push_image_before_v3_0_0(self, mock_client):"}],"source_content_type":"text/x-python","patch_set":32,"id":"2f1f397a_a408eacb","line":67,"in_reply_to":"7b59c466_8743afb5","updated":"2023-08-28 13:12:21.000000000","message":"Done","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66fb6b19408bdbf2d43dca7e224af42dbfbc372d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    @mock.patch(\u0027docker.__version__\u0027, \u00272.7.0\u0027)"},{"line_number":68,"context_line":"    @mock.patch.dict(os.environ, clear\u003dTrue)"},{"line_number":69,"context_line":"    @mock.patch(\u0027docker.DockerClient\u0027)"},{"line_number":70,"context_line":"    def test_push_image_before_v3_0_0(self, mock_client):"},{"line_number":71,"context_line":"        self.engine_client \u003d mock_client"},{"line_number":72,"context_line":"        pusher \u003d tasks.PushTask(self.conf, self.image)"},{"line_number":73,"context_line":"        pusher.run()"}],"source_content_type":"text/x-python","patch_set":32,"id":"9e285e2d_5fb08620","line":70,"updated":"2023-08-28 10:03:03.000000000","message":"and this test is obsolete","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"14ca95667e452a54bdfc7e1c15a273521ac12279","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    @mock.patch(\u0027docker.__version__\u0027, \u00272.7.0\u0027)"},{"line_number":68,"context_line":"    @mock.patch.dict(os.environ, clear\u003dTrue)"},{"line_number":69,"context_line":"    @mock.patch(\u0027docker.DockerClient\u0027)"},{"line_number":70,"context_line":"    def test_push_image_before_v3_0_0(self, mock_client):"},{"line_number":71,"context_line":"        self.engine_client \u003d mock_client"},{"line_number":72,"context_line":"        pusher \u003d tasks.PushTask(self.conf, self.image)"},{"line_number":73,"context_line":"        pusher.run()"}],"source_content_type":"text/x-python","patch_set":32,"id":"99dcf108_a3e57286","line":70,"in_reply_to":"9e285e2d_5fb08620","updated":"2023-08-28 13:12:21.000000000","message":"Done","commit_id":"576890cf731fa1a804286e75f9db040e94b56435"}],"releasenotes/notes/docker-3-0-0-e5f43f9b78ad644d.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c7e8354515585898caa4457136b4050129a376fa","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    docker.DockerClient."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Updated required ``docker`` package version to ``3.0.0``."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"8fe64720_ea4e2529","line":8,"updated":"2023-05-23 05:23:37.000000000","message":"I don\u0027t see where this is actually happening?","commit_id":"10efe2a469e1941ed96ea08cfeef011af708cc6d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e009acf699952a27b1054d188781a8e76aa24f0c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    docker.DockerClient."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Updated required ``docker`` package version to ``3.0.0``."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"be177e09_b2b2a966","line":8,"in_reply_to":"8fe64720_ea4e2529","updated":"2023-08-23 13:15:08.000000000","message":"nowhere it seems, let me remove it.","commit_id":"10efe2a469e1941ed96ea08cfeef011af708cc6d"},{"author":{"_account_id":35104,"name":"Konstantin Yarovoy","email":"k.yarovoy@partner.samsung.com","username":"k.yarovoy"},"change_message_id":"2a5481302dcf46548244a5abd193b4bf9aea0b02","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    docker.DockerClient."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Updated required ``docker`` package version to ``3.0.0``."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"de71b5a8_49fc66a3","line":8,"in_reply_to":"be177e09_b2b2a966","updated":"2023-08-24 08:49:46.000000000","message":"As i remember - reason for this was that in docker \u003c 3.0.0 there is no docker.DockerClient class, which is used in this change. docker.APIClient was used before.\n\nAlso, sorry for not taking time to finish these kolla-podman changes, i have a lot of stuff to work on in different project.","commit_id":"10efe2a469e1941ed96ea08cfeef011af708cc6d"}],"requirements.txt":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"21e00e2c9ccee533a55d8e9cfb31625012ea8eff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":2,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":3,"context_line":"Jinja2\u003e\u003d2.8 # BSD License (3 clause)"},{"line_number":4,"context_line":"GitPython\u003e\u003d1.0.1 # BSD License (3 clause)"},{"line_number":5,"context_line":"oslo.config\u003e\u003d5.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1d02bd87_204b7a64","side":"PARENT","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":26},"updated":"2022-01-21 14:37:27.000000000","message":"Change it to \u003e\u003d3.0.0 (as code change for it) and keep. When you add podman support in second patch then you drop line.","commit_id":"f7ef6c243af0d648e2d32254c52d20e9d0343ed1"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"f21a980771c9f28e7debf130aa17239be3f9ddd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":2,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":3,"context_line":"Jinja2\u003e\u003d2.8 # BSD License (3 clause)"},{"line_number":4,"context_line":"GitPython\u003e\u003d1.0.1 # BSD License (3 clause)"},{"line_number":5,"context_line":"oslo.config\u003e\u003d5.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"e255a672_5ad94ffc","side":"PARENT","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":26},"in_reply_to":"1d02bd87_204b7a64","updated":"2022-01-25 13:45:38.000000000","message":"Done","commit_id":"f7ef6c243af0d648e2d32254c52d20e9d0343ed1"}]}