)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ae9fa4b55feb5853c992326e2a710b3b4d3670b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b32e704_c4bb3c77","updated":"2022-02-02 14:58:34.000000000","message":"recheck","commit_id":"7f74a7abdd6b16c1dca14c368d5a035ec5ae0fd5"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"5ec70e1200a11b68d2937ea161a446e793cb4824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"992cf0e6_85c527d4","updated":"2022-02-14 13:50:24.000000000","message":"For correct Zuul testing - it is needed to make some changes to the test environment:\n1. for docker tests - docker library should be installed beforehand (it isn\u0027t in requirements anymore)\n2. for podman tests - podman and podman library should be installed, podman socket and service should be created (\"podman system service\"), service - started. kolla-build should have additional option (\"--engine podman\")","commit_id":"6a9710730e13240366d2b550cc43f37079f6de02"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"232cc761bdaa5b87fdca71b82f62758655556b9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"95439ff2_d1fa28d6","updated":"2023-09-12 09:38:26.000000000","message":"I will try to resolve comments, but anyone can replicate CI failure ? Because it\u0027s working locally :/\n\n.\n\n.\nINFO:kolla.common.utils:\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nINFO:kolla.common.utils:Successfully built images\nINFO:kolla.common.utils:\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nINFO:kolla.common.utils:base\nINFO:kolla.common.utils:glance-api\nINFO:kolla.common.utils:glance-base\nINFO:kolla.common.utils:openstack-base","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"fb2bc3284253155c203e7cf0e76c2c517048e3d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f36bd96f_86980ee2","updated":"2023-09-12 08:09:12.000000000","message":"recheck upgrade","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e7931dc20234e62c602c70c684836695689203aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"c1bd134a_2cd6989c","updated":"2023-09-15 09:03:23.000000000","message":"recheck rocky9 timeout","commit_id":"38cbbda033ce7660b81ce073d80602cd179d9435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"53cce0ebf3df4790b7e6326b14dc345f49ef9797","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"4ac494a7_40a18788","updated":"2023-09-19 09:13:42.000000000","message":"Should we have a Zuul job that just builds the images using podman?","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3ea387b3c6569e60b221bf1b7a8165be6e35115","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"a5e2e029_58e9a72b","in_reply_to":"4ac494a7_40a18788","updated":"2023-09-19 14:10:18.000000000","message":"Yep, I will propose a patch","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"403c427d24d5992441cb2c12f3dd34e64916f026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"41329076_88247bb0","in_reply_to":"a5e2e029_58e9a72b","updated":"2023-09-21 10:46:49.000000000","message":"Done","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8260f69da723a789b36e569b0e5da46426175cd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"0cbb4083_0147fd0d","updated":"2023-09-19 13:50:12.000000000","message":"Michal\u0027s findings should be addressed first.","commit_id":"2cbc152f70f02961f973d03fa0de84cd69372809"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d69a4b8681ebc1139d097ea22785db47e3e5654b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"a5054577_b6468b32","in_reply_to":"0cbb4083_0147fd0d","updated":"2023-09-19 14:38:10.000000000","message":"It\u0027s already addressed.","commit_id":"2cbc152f70f02961f973d03fa0de84cd69372809"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2c2f371fd07aa008f14590db8fd9c4ec272cf5dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"4b20a843_3dd76995","updated":"2023-09-19 15:13:33.000000000","message":"Okay, let\u0027s merge, CI patch will be added in follow-up, locally tested.","commit_id":"b33153b1c5053bf82f4879a41acd9719c9ff72b7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"359e1b4ccd48bf3a6d5de2be7a5d752917a28b34","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"d11968cf_d63cf22e","updated":"2023-09-19 19:28:29.000000000","message":"strategic -1 until followup with CI jobs passes","commit_id":"b33153b1c5053bf82f4879a41acd9719c9ff72b7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"376b1da417a0d0001ecd54149035c1060be22384","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"e7726916_570c6137","in_reply_to":"d11968cf_d63cf22e","updated":"2023-09-19 23:14:45.000000000","message":"Challenge accepted :)","commit_id":"b33153b1c5053bf82f4879a41acd9719c9ff72b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"403c427d24d5992441cb2c12f3dd34e64916f026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"9b1e9799_7afbc3af","in_reply_to":"e7726916_570c6137","updated":"2023-09-21 10:46:49.000000000","message":"Done","commit_id":"b33153b1c5053bf82f4879a41acd9719c9ff72b7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e2dfb44d56af34f5713c0058b156af95df15af5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"04c11eb4_01f43fb7","updated":"2023-09-21 10:40:37.000000000","message":"Now, passing. Review https://review.opendev.org/c/openstack/kolla/+/896007/1 needs to be merged before this one.","commit_id":"b76bd4c6efa22af43d7895a7b5e95c75806d3893"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"168be35160ffa61d1bca3f8954f167229d88758e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"7eff89e0_58201722","updated":"2023-09-21 11:53:36.000000000","message":"please add \"podman\" to requirements.txt with the appropriate version.","commit_id":"b76bd4c6efa22af43d7895a7b5e95c75806d3893"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"04d5abc778b1db2a531b77ea51e1c051c903740a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"474e0a52_f756fff3","in_reply_to":"7eff89e0_58201722","updated":"2023-09-21 11:55:42.000000000","message":"Check comments above, it was there but was removed based on frickler comments I think. Also, it\u0027s not requirements if you don\u0027t need to build images with podman container engine.","commit_id":"b76bd4c6efa22af43d7895a7b5e95c75806d3893"}],"kolla/common/config.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":249,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027, choices\u003d[\u0027docker\u0027, \u0027podman\u0027],"},{"line_number":250,"context_line":"               help\u003d\u0027Container engine to build images on.\u0027),"},{"line_number":251,"context_line":"    cfg.StrOpt(\u0027podman_base_url\u0027, default\u003d\u0027unix:///run/podman/podman.sock\u0027,"},{"line_number":252,"context_line":"               help\u003d\u0027Path for podman socket, be sure to \u0027"},{"line_number":253,"context_line":"                    \u0027have podman.service active.\u0027)"},{"line_number":254,"context_line":"]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"71f9f8ca_d8ea05cb","line":253,"range":{"start_line":252,"start_character":45,"end_line":253,"end_character":47},"updated":"2023-09-12 08:33:56.000000000","message":"I don\u0027t think that this belongs into the help message","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f41d091e1c311dc6ecb24bf1b847272b8fe6459","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027, choices\u003d[\u0027docker\u0027, \u0027podman\u0027],"},{"line_number":250,"context_line":"               help\u003d\u0027Container engine to build images on.\u0027),"},{"line_number":251,"context_line":"    cfg.StrOpt(\u0027podman_base_url\u0027, default\u003d\u0027unix:///run/podman/podman.sock\u0027,"},{"line_number":252,"context_line":"               help\u003d\u0027Path for podman socket, be sure to \u0027"},{"line_number":253,"context_line":"                    \u0027have podman.service active.\u0027)"},{"line_number":254,"context_line":"]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"8323db5c_8e53bc52","line":253,"range":{"start_line":252,"start_character":45,"end_line":253,"end_character":47},"in_reply_to":"71f9f8ca_d8ea05cb","updated":"2023-09-12 10:08:08.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"53cce0ebf3df4790b7e6326b14dc345f49ef9797","unresolved":true,"context_lines":[{"line_number":249,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027, choices\u003d[\u0027docker\u0027, \u0027podman\u0027],"},{"line_number":250,"context_line":"               help\u003d\u0027Container engine to build images on.\u0027),"},{"line_number":251,"context_line":"    cfg.StrOpt(\u0027podman_base_url\u0027, default\u003d\u0027unix:///run/podman/podman.sock\u0027,"},{"line_number":252,"context_line":"               help\u003d\u0027Path for podman socket.\u0027)"},{"line_number":253,"context_line":"]"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":27,"id":"e7627c86_abc516aa","line":252,"range":{"start_line":252,"start_character":26,"end_line":252,"end_character":29},"updated":"2023-09-19 09:13:42.000000000","message":"to?","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3ea387b3c6569e60b221bf1b7a8165be6e35115","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    cfg.StrOpt(\u0027engine\u0027, default\u003d\u0027docker\u0027, choices\u003d[\u0027docker\u0027, \u0027podman\u0027],"},{"line_number":250,"context_line":"               help\u003d\u0027Container engine to build images on.\u0027),"},{"line_number":251,"context_line":"    cfg.StrOpt(\u0027podman_base_url\u0027, default\u003d\u0027unix:///run/podman/podman.sock\u0027,"},{"line_number":252,"context_line":"               help\u003d\u0027Path for podman socket.\u0027)"},{"line_number":253,"context_line":"]"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":27,"id":"b61d7a2b_39b47eca","line":252,"range":{"start_line":252,"start_character":26,"end_line":252,"end_character":29},"in_reply_to":"e7627c86_abc516aa","updated":"2023-09-19 14:10:18.000000000","message":"Done","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"}],"kolla/engine_adapter/engine.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    import podman"},{"line_number":40,"context_line":"except (ImportError, ModuleNotFoundError):"},{"line_number":41,"context_line":"    pass"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def getEngineException(conf):"}],"source_content_type":"text/x-python","patch_set":14,"id":"79e3818b_575de728","line":41,"updated":"2023-09-12 08:33:56.000000000","message":"Can we keep this right next to the docker import above?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f41d091e1c311dc6ecb24bf1b847272b8fe6459","unresolved":false,"context_lines":[{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    import podman"},{"line_number":40,"context_line":"except (ImportError, ModuleNotFoundError):"},{"line_number":41,"context_line":"    pass"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def getEngineException(conf):"}],"source_content_type":"text/x-python","patch_set":14,"id":"69a70357_2d53c253","line":41,"in_reply_to":"79e3818b_575de728","updated":"2023-09-12 10:08:08.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    if conf.engine \u003d\u003d Engine.DOCKER.value:"},{"line_number":56,"context_line":"        kwargs_env \u003d docker.utils.kwargs_from_env()"},{"line_number":57,"context_line":"        return docker.DockerClient(version\u003d\u0027auto\u0027, **kwargs_env)"},{"line_number":58,"context_line":"    elif conf.engine \u003d\u003d \"podman\":"},{"line_number":59,"context_line":"        client \u003d podman.PodmanClient(base_url\u003dconf.podman_base_url)"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            client.version()"}],"source_content_type":"text/x-python","patch_set":14,"id":"2be685b4_8db932ca","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":32},"updated":"2023-09-12 08:33:56.000000000","message":"Engine.PODMAN.value","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f41d091e1c311dc6ecb24bf1b847272b8fe6459","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    if conf.engine \u003d\u003d Engine.DOCKER.value:"},{"line_number":56,"context_line":"        kwargs_env \u003d docker.utils.kwargs_from_env()"},{"line_number":57,"context_line":"        return docker.DockerClient(version\u003d\u0027auto\u0027, **kwargs_env)"},{"line_number":58,"context_line":"    elif conf.engine \u003d\u003d \"podman\":"},{"line_number":59,"context_line":"        client \u003d podman.PodmanClient(base_url\u003dconf.podman_base_url)"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            client.version()"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff81cd2d_f26a5c93","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":32},"in_reply_to":"2be685b4_8db932ca","updated":"2023-09-12 10:08:08.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            client.version()"},{"line_number":62,"context_line":"        except podman.errors.exceptions.APIError as e:"},{"line_number":63,"context_line":"            e.explanation +\u003d \" Check if podman service is active and address \\"},{"line_number":64,"context_line":"                             to podman.sock is set correctly through \\"},{"line_number":65,"context_line":"                             --podman_base_url\""},{"line_number":66,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":14,"id":"e09236d2_510594f2","line":63,"range":{"start_line":63,"start_character":69,"end_line":63,"end_character":76},"updated":"2023-09-12 08:33:56.000000000","message":"\"... the address ...\"?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f41d091e1c311dc6ecb24bf1b847272b8fe6459","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            client.version()"},{"line_number":62,"context_line":"        except podman.errors.exceptions.APIError as e:"},{"line_number":63,"context_line":"            e.explanation +\u003d \" Check if podman service is active and address \\"},{"line_number":64,"context_line":"                             to podman.sock is set correctly through \\"},{"line_number":65,"context_line":"                             --podman_base_url\""},{"line_number":66,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":14,"id":"c0874891_b202e537","line":63,"range":{"start_line":63,"start_character":69,"end_line":63,"end_character":76},"in_reply_to":"e09236d2_510594f2","updated":"2023-09-12 10:08:08.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6a82510fa920707f248c80069a88d552ae6563a8","unresolved":true,"context_lines":[{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    import podman"},{"line_number":23,"context_line":"except (ImportError, ModuleNotFoundError):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Engine(Enum):"}],"source_content_type":"text/x-python","patch_set":22,"id":"89b79cbb_4edb3ae4","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":8},"updated":"2023-09-14 17:15:39.000000000","message":"why not log a similar debug message to the docker import?","commit_id":"f4866c0235b286583729b3bed4e1123271aacea5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"60cf5e3f1f76652660b068e0764a4e102063b662","unresolved":false,"context_lines":[{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    import podman"},{"line_number":23,"context_line":"except (ImportError, ModuleNotFoundError):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Engine(Enum):"}],"source_content_type":"text/x-python","patch_set":22,"id":"098f0a4e_dff92637","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":8},"in_reply_to":"89b79cbb_4edb3ae4","updated":"2023-09-14 18:52:52.000000000","message":"Done","commit_id":"f4866c0235b286583729b3bed4e1123271aacea5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4652e7c1504c98f862387944422245ec629800de","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            client.version()"},{"line_number":62,"context_line":"        except podman.errors.exceptions.APIError as e:"},{"line_number":63,"context_line":"            e.explanation +\u003d (\" Check if podman service is active and\""},{"line_number":64,"context_line":"                              \"the address to podman.sock is set correctly\""},{"line_number":65,"context_line":"                              \"through --podman_base_url\")"},{"line_number":66,"context_line":"            raise e"},{"line_number":67,"context_line":"        return client"},{"line_number":68,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"2dd3ad44_3f65e70e","line":65,"range":{"start_line":63,"start_character":31,"end_line":65,"end_character":57},"updated":"2023-09-18 07:30:04.000000000","message":"the error explanation should not only give advice what to do, which is excellent, but also what went actually wrong, to the extend possible, i.e. \"error: couldn\u0027t connect to the podman API\"","commit_id":"38cbbda033ce7660b81ce073d80602cd179d9435"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"25edb2a93c8ec7ac5658e8246aed703d1d963ef6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            client.version()"},{"line_number":62,"context_line":"        except podman.errors.exceptions.APIError as e:"},{"line_number":63,"context_line":"            e.explanation +\u003d (\" Check if podman service is active and\""},{"line_number":64,"context_line":"                              \"the address to podman.sock is set correctly\""},{"line_number":65,"context_line":"                              \"through --podman_base_url\")"},{"line_number":66,"context_line":"            raise e"},{"line_number":67,"context_line":"        return client"},{"line_number":68,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"269ae34d_2b3c79d1","line":65,"range":{"start_line":63,"start_character":31,"end_line":65,"end_character":57},"in_reply_to":"2dd3ad44_3f65e70e","updated":"2023-09-19 07:16:08.000000000","message":"As you can see there is \u0027+\u003d\u0027 , that means it\u0027s just adding explanation to original error message. Current output is as below : \n\nINFO:kolla.common.utils:Using engine: podman\nINFO:kolla.common.utils:Found the container image folder at /home/michalarbet/ultimum/git/upstream/kolla/docker\nERROR:kolla.common.utils:Unable to connect to container engine daemon, exiting\nINFO:kolla.common.utils:Exception caught: http://%2Frun%2Fpodman%2Fpodman.sock/v4.6.0/libpod/version (GET operation failed Check if podman service is active andthe address to podman.sock is set correctlythrough --podman_base_url)\n\n\nWhat I am going to fix are spaces missing in output, so I am resolving this comment for now.\n\nFixed output : \n\nINFO:kolla.common.utils:Using engine: podman\nINFO:kolla.common.utils:Found the container image folder at /home/michalarbet/ultimum/git/upstream/kolla/docker\nERROR:kolla.common.utils:Unable to connect to container engine daemon, exiting\nINFO:kolla.common.utils:Exception caught: http://%2Frun%2Fpodman%2Fpodman.sock/v4.6.0/libpod/version (GET operation failed. Check if podman service is active and the address to podman.sock is set correctly through --podman_base_url)","commit_id":"38cbbda033ce7660b81ce073d80602cd179d9435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"53cce0ebf3df4790b7e6326b14dc345f49ef9797","unresolved":true,"context_lines":[{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    import podman"},{"line_number":23,"context_line":"except (ImportError, ModuleNotFoundError):"},{"line_number":24,"context_line":"    LOG.debug(\"Podman python library was not found\")"},{"line_number":25,"context_line":"    pass"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"050ef00e_3ac7f184","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":13},"updated":"2023-09-19 09:13:42.000000000","message":"error?","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3ea387b3c6569e60b221bf1b7a8165be6e35115","unresolved":false,"context_lines":[{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    import podman"},{"line_number":23,"context_line":"except (ImportError, ModuleNotFoundError):"},{"line_number":24,"context_line":"    LOG.debug(\"Podman python library was not found\")"},{"line_number":25,"context_line":"    pass"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"18bcb1f8_9bf239c7","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":13},"in_reply_to":"050ef00e_3ac7f184","updated":"2023-09-19 14:10:18.000000000","message":"No, because actually it\u0027s not an error, podman is not required for kolla-build run. The same behaviour is used for import docker.\n\nkolla/engine_adapter/engine.py-try:\nkolla/engine_adapter/engine.py:    import docker\nkolla/engine_adapter/engine.py-except (ImportError):\nkolla/engine_adapter/engine.py-    LOG.debug(\"Docker python library was not found\")","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"}],"kolla/image/build.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                      \"but library is not found.\""},{"line_number":135,"context_line":"                      \"Try running pip install podman\")"},{"line_number":136,"context_line":"            exit(1)"},{"line_number":137,"context_line":"        if conf.squash:"},{"line_number":138,"context_line":"            squash_version \u003d utils.get_docker_squash_version()"},{"line_number":139,"context_line":"            LOG.info(\u0027Image squash is enabled and \"docker-squash\" version \u0027"},{"line_number":140,"context_line":"                     \u0027is %s\u0027, squash_version)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    kolla \u003d KollaWorker(conf)"},{"line_number":143,"context_line":"    kolla.setup_working_dir()"}],"source_content_type":"text/x-python","patch_set":14,"id":"39b4b020_1ce2baaa","line":140,"range":{"start_line":137,"start_character":7,"end_line":140,"end_character":45},"updated":"2023-09-12 08:33:56.000000000","message":"This block belonged to docker, now it belongs to podman, seems weird","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f41d091e1c311dc6ecb24bf1b847272b8fe6459","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                      \"but library is not found.\""},{"line_number":135,"context_line":"                      \"Try running pip install podman\")"},{"line_number":136,"context_line":"            exit(1)"},{"line_number":137,"context_line":"        if conf.squash:"},{"line_number":138,"context_line":"            squash_version \u003d utils.get_docker_squash_version()"},{"line_number":139,"context_line":"            LOG.info(\u0027Image squash is enabled and \"docker-squash\" version \u0027"},{"line_number":140,"context_line":"                     \u0027is %s\u0027, squash_version)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    kolla \u003d KollaWorker(conf)"},{"line_number":143,"context_line":"    kolla.setup_working_dir()"}],"source_content_type":"text/x-python","patch_set":14,"id":"886b0b66_1d6e6f48","line":140,"range":{"start_line":137,"start_character":7,"end_line":140,"end_character":45},"in_reply_to":"39b4b020_1ce2baaa","updated":"2023-09-12 10:08:08.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"}],"kolla/image/tasks.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"62cb365d03986b91ad95c9cb5e94b878c6249f02","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        kwargs \u003d {}"},{"line_number":372,"context_line":"        if self.conf.engine \u003d\u003d engine.Engine.PODMAN.value:"},{"line_number":373,"context_line":"            # dockerfile path is a workaround,"},{"line_number":374,"context_line":"            # should be removed as soon as it will be fixed in podman-py"},{"line_number":375,"context_line":"            kwargs[\"dockerfile\"] \u003d image.path + \u0027/Dockerfile\u0027"},{"line_number":376,"context_line":"            kwargs[\"squash\"] \u003d self.conf.squash"},{"line_number":377,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"79bb35de_306ee9d5","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":72},"updated":"2023-09-12 06:19:30.000000000","message":"is there a tracking bug upstream, which we could link here?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"60cf5e3f1f76652660b068e0764a4e102063b662","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        kwargs \u003d {}"},{"line_number":372,"context_line":"        if self.conf.engine \u003d\u003d engine.Engine.PODMAN.value:"},{"line_number":373,"context_line":"            # dockerfile path is a workaround,"},{"line_number":374,"context_line":"            # should be removed as soon as it will be fixed in podman-py"},{"line_number":375,"context_line":"            kwargs[\"dockerfile\"] \u003d image.path + \u0027/Dockerfile\u0027"},{"line_number":376,"context_line":"            kwargs[\"squash\"] \u003d self.conf.squash"},{"line_number":377,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7ff1bf58_62556225","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":72},"in_reply_to":"05afd35d_54049397","updated":"2023-09-14 18:52:52.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"53cce0ebf3df4790b7e6326b14dc345f49ef9797","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        kwargs \u003d {}"},{"line_number":372,"context_line":"        if self.conf.engine \u003d\u003d engine.Engine.PODMAN.value:"},{"line_number":373,"context_line":"            # dockerfile path is a workaround,"},{"line_number":374,"context_line":"            # should be removed as soon as it will be fixed in podman-py"},{"line_number":375,"context_line":"            kwargs[\"dockerfile\"] \u003d image.path + \u0027/Dockerfile\u0027"},{"line_number":376,"context_line":"            kwargs[\"squash\"] \u003d self.conf.squash"},{"line_number":377,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"be67f04f_33933ea6","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":72},"in_reply_to":"05afd35d_54049397","updated":"2023-09-19 09:13:42.000000000","message":"can we get this as # TODO(): in the code, so it\u0027s easy to find?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6a82510fa920707f248c80069a88d552ae6563a8","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        kwargs \u003d {}"},{"line_number":372,"context_line":"        if self.conf.engine \u003d\u003d engine.Engine.PODMAN.value:"},{"line_number":373,"context_line":"            # dockerfile path is a workaround,"},{"line_number":374,"context_line":"            # should be removed as soon as it will be fixed in podman-py"},{"line_number":375,"context_line":"            kwargs[\"dockerfile\"] \u003d image.path + \u0027/Dockerfile\u0027"},{"line_number":376,"context_line":"            kwargs[\"squash\"] \u003d self.conf.squash"},{"line_number":377,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"253d9c95_120fcd9c","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":72},"in_reply_to":"05afd35d_54049397","updated":"2023-09-14 17:15:39.000000000","message":"so imho it should be linked to directly in the comment. I also asked in the upstream bug report about any activity, maybe someone could also provide a patch upstream? it doesn\u0027t _sound_ to hard to implement?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":35104,"name":"Konstantin Yarovoy","email":"k.yarovoy@partner.samsung.com","username":"k.yarovoy"},"change_message_id":"bbba68fb618a2e08fb76017c152e3e87b257c46f","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        kwargs \u003d {}"},{"line_number":372,"context_line":"        if self.conf.engine \u003d\u003d engine.Engine.PODMAN.value:"},{"line_number":373,"context_line":"            # dockerfile path is a workaround,"},{"line_number":374,"context_line":"            # should be removed as soon as it will be fixed in podman-py"},{"line_number":375,"context_line":"            kwargs[\"dockerfile\"] \u003d image.path + \u0027/Dockerfile\u0027"},{"line_number":376,"context_line":"            kwargs[\"squash\"] \u003d self.conf.squash"},{"line_number":377,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"05afd35d_54049397","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":72},"in_reply_to":"79bb35de_306ee9d5","updated":"2023-09-14 12:00:06.000000000","message":"https://github.com/containers/podman-py/issues/177","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3ea387b3c6569e60b221bf1b7a8165be6e35115","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        kwargs \u003d {}"},{"line_number":372,"context_line":"        if self.conf.engine \u003d\u003d engine.Engine.PODMAN.value:"},{"line_number":373,"context_line":"            # dockerfile path is a workaround,"},{"line_number":374,"context_line":"            # should be removed as soon as it will be fixed in podman-py"},{"line_number":375,"context_line":"            kwargs[\"dockerfile\"] \u003d image.path + \u0027/Dockerfile\u0027"},{"line_number":376,"context_line":"            kwargs[\"squash\"] \u003d self.conf.squash"},{"line_number":377,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"4a40cc5a_601a6601","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":72},"in_reply_to":"be67f04f_33933ea6","updated":"2023-09-19 14:10:18.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"}],"kolla/tests/test_build.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        kwargs \u003d {}"},{"line_number":159,"context_line":"        if \"podman\" in engine_client:"},{"line_number":160,"context_line":"            kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"},{"line_number":161,"context_line":"            kwargs[\"squash\"] \u003d False"},{"line_number":162,"context_line":"        push_queue \u003d mock.Mock()"},{"line_number":163,"context_line":"        builder \u003d tasks.BuildTask(self.conf, self.image, push_queue)"},{"line_number":164,"context_line":"        builder.run()"}],"source_content_type":"text/x-python","patch_set":14,"id":"04acc5ea_4d07ecc6","line":161,"updated":"2023-09-12 08:33:56.000000000","message":"This block is repeated quite often, refactor into a helper function or similar?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"60cf5e3f1f76652660b068e0764a4e102063b662","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        kwargs \u003d {}"},{"line_number":159,"context_line":"        if \"podman\" in engine_client:"},{"line_number":160,"context_line":"            kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"},{"line_number":161,"context_line":"            kwargs[\"squash\"] \u003d False"},{"line_number":162,"context_line":"        push_queue \u003d mock.Mock()"},{"line_number":163,"context_line":"        builder \u003d tasks.BuildTask(self.conf, self.image, push_queue)"},{"line_number":164,"context_line":"        builder.run()"}],"source_content_type":"text/x-python","patch_set":14,"id":"4a0228cc_9f7c9087","line":161,"in_reply_to":"04acc5ea_4d07ecc6","updated":"2023-09-14 18:52:52.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4652e7c1504c98f862387944422245ec629800de","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        # NOTE(mandre) we want the local copy of FAKE_IMAGE as the parent"},{"line_number":67,"context_line":"        self.imageChild.parent \u003d self.image"},{"line_number":68,"context_line":"        self.imageChild.path \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":69,"context_line":"        # NOTE(yarovkon) maybe it would be better to use different config"},{"line_number":70,"context_line":"        # for podman"},{"line_number":71,"context_line":"        if \"podman\" in engine_client:"},{"line_number":72,"context_line":"            self.conf.set_override(\u0027engine\u0027, \u0027podman\u0027)"},{"line_number":73,"context_line":"            self.build_kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"b2f29153_ed4322c7","line":70,"range":{"start_line":69,"start_character":7,"end_line":70,"end_character":20},"updated":"2023-09-18 07:30:04.000000000","message":"I\u0027m not so sure. It\u0027s not like both will be active at the same time. What would we gain by that? Podman is 95% like docker, so imho the overlap is sufficient to not warrant a distinct config.","commit_id":"38cbbda033ce7660b81ce073d80602cd179d9435"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"25edb2a93c8ec7ac5658e8246aed703d1d963ef6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # NOTE(mandre) we want the local copy of FAKE_IMAGE as the parent"},{"line_number":67,"context_line":"        self.imageChild.parent \u003d self.image"},{"line_number":68,"context_line":"        self.imageChild.path \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":69,"context_line":"        # NOTE(yarovkon) maybe it would be better to use different config"},{"line_number":70,"context_line":"        # for podman"},{"line_number":71,"context_line":"        if \"podman\" in engine_client:"},{"line_number":72,"context_line":"            self.conf.set_override(\u0027engine\u0027, \u0027podman\u0027)"},{"line_number":73,"context_line":"            self.build_kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"ef7e7045_79233fac","line":70,"range":{"start_line":69,"start_character":7,"end_line":70,"end_character":20},"in_reply_to":"b2f29153_ed4322c7","updated":"2023-09-19 07:16:08.000000000","message":"Comment removed.","commit_id":"38cbbda033ce7660b81ce073d80602cd179d9435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"53cce0ebf3df4790b7e6326b14dc345f49ef9797","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        if \"podman\" in engine_client:"},{"line_number":70,"context_line":"            self.conf.set_override(\u0027engine\u0027, \u0027podman\u0027)"},{"line_number":71,"context_line":"            self.build_kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"},{"line_number":72,"context_line":"            self.build_kwargs[\"squash\"] \u003d False"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            self.build_kwargs \u003d {}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"fac12f96_5bf58995","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":47},"updated":"2023-09-19 09:13:42.000000000","message":"squash is not supported?","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3ea387b3c6569e60b221bf1b7a8165be6e35115","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if \"podman\" in engine_client:"},{"line_number":70,"context_line":"            self.conf.set_override(\u0027engine\u0027, \u0027podman\u0027)"},{"line_number":71,"context_line":"            self.build_kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"},{"line_number":72,"context_line":"            self.build_kwargs[\"squash\"] \u003d False"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            self.build_kwargs \u003d {}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"92fa5546_5abcc061","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":47},"in_reply_to":"fac12f96_5bf58995","updated":"2023-09-19 14:10:18.000000000","message":"It is, but podman squash is implemented different and you need to combine different opts while squash\u003dFalse all time.\n\nhttps://github.com/containers/buildah/issues/1234","commit_id":"c749c55be57d6eca77e4c5ff8738908ed46e22c3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b0f49f2286045d4591fb8c6364f06b1b2de3f706","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        if \"podman\" in engine_client:"},{"line_number":70,"context_line":"            self.conf.set_override(\u0027engine\u0027, \u0027podman\u0027)"},{"line_number":71,"context_line":"            self.build_kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"},{"line_number":72,"context_line":"            # Squash implementation is different in podman"},{"line_number":73,"context_line":"            #"},{"line_number":74,"context_line":"            # - Check kolla/image/tasks.py for podman"},{"line_number":75,"context_line":"            # - Check https://github.com/containers/buildah/issues/1234"}],"source_content_type":"text/x-python","patch_set":32,"id":"ee187fc0_699d9e96","line":72,"updated":"2023-09-19 14:43:25.000000000","message":"NOTE: would be nice","commit_id":"e8f1f414a289b8b39c80a02b8fa00060f0ddce5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"405677acc5eb9941b0d9efb7bf95851b5420f349","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if \"podman\" in engine_client:"},{"line_number":70,"context_line":"            self.conf.set_override(\u0027engine\u0027, \u0027podman\u0027)"},{"line_number":71,"context_line":"            self.build_kwargs[\"dockerfile\"] \u003d self.image.path + \u0027/Dockerfile\u0027"},{"line_number":72,"context_line":"            # Squash implementation is different in podman"},{"line_number":73,"context_line":"            #"},{"line_number":74,"context_line":"            # - Check kolla/image/tasks.py for podman"},{"line_number":75,"context_line":"            # - Check https://github.com/containers/buildah/issues/1234"}],"source_content_type":"text/x-python","patch_set":32,"id":"410e22ab_ce44aea9","line":72,"in_reply_to":"ee187fc0_699d9e96","updated":"2023-09-19 15:14:35.000000000","message":"Done","commit_id":"e8f1f414a289b8b39c80a02b8fa00060f0ddce5f"}],"test-requirements.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":7,"context_line":"stestr\u003e\u003d2.2.0 # Apache-2.0"},{"line_number":8,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":9,"context_line":"docker\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":10,"context_line":"podman\u003e\u003d3.2.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":14,"id":"0bf85aa0_bebfea9a","line":10,"updated":"2023-09-12 08:33:56.000000000","message":"I thought we had discussed this earlier, but can\u0027t we keep both of these optional? It doesn\u0027t make sense IMO to have both as required for all of OpenStack.\n\nAlso missing newline at the end of the file.","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f41d091e1c311dc6ecb24bf1b847272b8fe6459","unresolved":true,"context_lines":[{"line_number":7,"context_line":"stestr\u003e\u003d2.2.0 # Apache-2.0"},{"line_number":8,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":9,"context_line":"docker\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":10,"context_line":"podman\u003e\u003d3.2.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":14,"id":"b0016b4c_51e1bfe1","line":10,"in_reply_to":"0bf85aa0_bebfea9a","updated":"2023-09-12 10:08:08.000000000","message":"How I can make both optional ?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"60cf5e3f1f76652660b068e0764a4e102063b662","unresolved":false,"context_lines":[{"line_number":7,"context_line":"stestr\u003e\u003d2.2.0 # Apache-2.0"},{"line_number":8,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":9,"context_line":"docker\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":10,"context_line":"podman\u003e\u003d3.2.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":14,"id":"d1873dfd_2a83fd3c","line":10,"in_reply_to":"b0016b4c_51e1bfe1","updated":"2023-09-14 18:52:52.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"}],"tox.ini":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d pep8,py38-{docker,podman}"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":14,"id":"c00cc9a4_d6392158","line":4,"updated":"2023-09-12 08:33:56.000000000","message":"Shouldn\u0027t this be py310 by now?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"25edb2a93c8ec7ac5658e8246aed703d1d963ef6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d pep8,py38-{docker,podman}"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":14,"id":"60ab5fc0_b7baa480","line":4,"in_reply_to":"42990883_ca6d63ea","updated":"2023-09-19 07:16:08.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f41d091e1c311dc6ecb24bf1b847272b8fe6459","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d pep8,py38-{docker,podman}"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":14,"id":"c08cc0f3_635c2901","line":4,"in_reply_to":"c00cc9a4_d6392158","updated":"2023-09-12 10:08:08.000000000","message":"Hmm, should be ? I really don\u0027t know .. should I change ?","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4652e7c1504c98f862387944422245ec629800de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d pep8,py38-{docker,podman}"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":14,"id":"42990883_ca6d63ea","line":4,"in_reply_to":"c08cc0f3_635c2901","updated":"2023-09-18 07:30:04.000000000","message":"This was changed in https://review.opendev.org/c/openstack/kolla/+/752436 the last time, for the victoria release.\n\nthe basepython version is now just 3.\n\nI would also be in favor of bumping this, just because newer \u003d better (sometimes) ;)","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"62cb365d03986b91ad95c9cb5e94b878c6249f02","unresolved":true,"context_lines":[{"line_number":16,"context_line":"          OS_STDOUT_CAPTURE,OS_STDERR_CAPTURE,OS_LOG_CAPTURE,OS_TEST_TIMEOUT"},{"line_number":17,"context_line":"          PYTHON,OS_TEST_PATH,LISTOPT,IDOPTION"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"setenv \u003d "},{"line_number":20,"context_line":"          TEST_ENGINE\u003d"},{"line_number":21,"context_line":"          py38-docker: TEST_ENGINE\u003ddocker"},{"line_number":22,"context_line":"          py38-podman: TEST_ENGINE\u003dpodman"}],"source_content_type":"text/x-properties","patch_set":14,"id":"d516b620_c12dc6f4","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":9},"updated":"2023-09-12 06:19:30.000000000","message":"whitespace","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6a82510fa920707f248c80069a88d552ae6563a8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"          OS_STDOUT_CAPTURE,OS_STDERR_CAPTURE,OS_LOG_CAPTURE,OS_TEST_TIMEOUT"},{"line_number":17,"context_line":"          PYTHON,OS_TEST_PATH,LISTOPT,IDOPTION"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"setenv \u003d "},{"line_number":20,"context_line":"          TEST_ENGINE\u003d"},{"line_number":21,"context_line":"          py38-docker: TEST_ENGINE\u003ddocker"},{"line_number":22,"context_line":"          py38-podman: TEST_ENGINE\u003dpodman"}],"source_content_type":"text/x-properties","patch_set":14,"id":"da074c9c_1738f519","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":9},"in_reply_to":"d516b620_c12dc6f4","updated":"2023-09-14 17:15:39.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"72029be5ebc674ca94ae64977221f5d7a5270f51","unresolved":true,"context_lines":[{"line_number":19,"context_line":"setenv \u003d "},{"line_number":20,"context_line":"          TEST_ENGINE\u003d"},{"line_number":21,"context_line":"          py38-docker: TEST_ENGINE\u003ddocker"},{"line_number":22,"context_line":"          py38-podman: TEST_ENGINE\u003dpodman"},{"line_number":23,"context_line":"commands \u003d"},{"line_number":24,"context_line":"  find . -type f -name \"*.py[c|o]\" -delete -o -type l -name \"*.py[c|o]\" -delete"},{"line_number":25,"context_line":"  find . -type d -name \"__pycache__\" -delete"}],"source_content_type":"text/x-properties","patch_set":14,"id":"ab2b2907_8162b51e","line":22,"updated":"2023-09-12 08:33:56.000000000","message":"This syntax looks really weird to me as casual tox user. I\u0027d suggest to have two explicit\n\n[testenv:...] setenv \u003d\n\nstanza instead.","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"25edb2a93c8ec7ac5658e8246aed703d1d963ef6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"setenv \u003d "},{"line_number":20,"context_line":"          TEST_ENGINE\u003d"},{"line_number":21,"context_line":"          py38-docker: TEST_ENGINE\u003ddocker"},{"line_number":22,"context_line":"          py38-podman: TEST_ENGINE\u003dpodman"},{"line_number":23,"context_line":"commands \u003d"},{"line_number":24,"context_line":"  find . -type f -name \"*.py[c|o]\" -delete -o -type l -name \"*.py[c|o]\" -delete"},{"line_number":25,"context_line":"  find . -type d -name \"__pycache__\" -delete"}],"source_content_type":"text/x-properties","patch_set":14,"id":"f06e6ef2_6a799ce1","line":22,"in_reply_to":"ab2b2907_8162b51e","updated":"2023-09-19 07:16:08.000000000","message":"Done","commit_id":"733289b8830e793abd1daa75005f9e6aad3353b6"}]}