)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"06044b1a88622fa54a21f51e07e090e96802d2bb","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add skyline Dockerfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add skyline Dockerfile"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint skyline"},{"line_number":12,"context_line":"Change-Id: I68a562f15bf4fdda82b86c446e14fc8b5594413a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"1e3c7a19_549ddf1e","line":9,"updated":"2022-10-13 07:38:03.000000000","message":"Nit: duplicated\n\nAdding one or two small sentences describing skyline instead would be nice.","commit_id":"bf6467290fc3505cb6c83a84a44a2d0ccbe5bbec"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"38f7143877addabf7b5321d0dc72379c6dd65594","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add skyline Dockerfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add skyline Dockerfile"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint skyline"},{"line_number":12,"context_line":"Change-Id: I68a562f15bf4fdda82b86c446e14fc8b5594413a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"ce3a4e8e_c4d6bdbb","line":9,"in_reply_to":"1e3c7a19_549ddf1e","updated":"2022-10-13 09:41:14.000000000","message":"skyline: add new dashboard\n\nSkyline is [here goes 2-3 sentences explaining what it is]\n\nImplements:\nChange-Id:","commit_id":"bf6467290fc3505cb6c83a84a44a2d0ccbe5bbec"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"00dc8c5ff2aff5d19ac71eccf0ca8b0b4e96ba78","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add skyline Dockerfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add skyline Dockerfile"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint skyline"},{"line_number":12,"context_line":"Change-Id: I68a562f15bf4fdda82b86c446e14fc8b5594413a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"6047d214_6602dc29","line":9,"in_reply_to":"ce3a4e8e_c4d6bdbb","updated":"2022-10-13 10:20:58.000000000","message":"Done","commit_id":"bf6467290fc3505cb6c83a84a44a2d0ccbe5bbec"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"ae0ee60e3460369a960839c3792044c61b610d3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"63672d43_4f8f7446","updated":"2022-02-17 05:59:10.000000000","message":"recheck","commit_id":"f481401c6dbab91e52b89a3fdc9c748d3376df09"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"b7e7f4dbc0d8c18f1be2bc0b9ab0feef1ff31cd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7eca4adc_ac948729","updated":"2022-05-27 07:48:45.000000000","message":"Not ready","commit_id":"889bd12ad3d54780b233ac94d7b29505ba86e2d3"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"0b312a4e41614492e2999020bfda521f4d25c49f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c89494ce_89bc4723","updated":"2022-05-28 11:17:38.000000000","message":"recheck","commit_id":"be8c7cd2394ddbea1e17d45b254abec500cf142e"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"cb18d44155afec2335805703a893fa0a7e082771","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6effafaf_727a2e2b","updated":"2022-05-31 12:26:33.000000000","message":"Great, I am still working on skyline related projects. So not ready now. Thanks 😊","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ae8e3b77_3eb7487a","updated":"2022-05-30 08:20:02.000000000","message":"Please also show it working with deployment in Kolla Ansible.","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"00dc8c5ff2aff5d19ac71eccf0ca8b0b4e96ba78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8eae3483_a3144193","in_reply_to":"ae8e3b77_3eb7487a","updated":"2022-10-13 10:20:58.000000000","message":"Still in working","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3de0816c17d6a6a5d313e8389e8cd91e870c68a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"f0c5a9af_88e14a56","updated":"2022-09-30 10:31:14.000000000","message":"Looks like it will skip Zed.\n\nNo kolla-ansible part, no CentOS/RockyLinux support.","commit_id":"9fa51cba9dd813c6f3e27501978a8b78559807d9"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"21d385c3d5815cca32f08fcd8201931841bac89a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"11785eb7_63921a79","in_reply_to":"96bd60cd_dae024f7","updated":"2022-10-13 10:13:06.000000000","message":"\u003e I would like to ask how functional is skyline right now ? Because last time I was trying skyline it was working on half.\n\nSkyline has been released by Zed without kolla and kolla-ansible. Now I am continue to work on these two patches.\nNow we build the skyline docker image just by docker and push it to dockerhub under 99cloud. \"docker pull 99cloud/skyline:latest\" can get the latest image.\n\nafter the kolla and kolla-ansible patches are merged. We can directly use images from kolla.","commit_id":"9fa51cba9dd813c6f3e27501978a8b78559807d9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dfb15954774ffa3944f17cea5e64a855081f24d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"96bd60cd_dae024f7","in_reply_to":"e3a39558_0d355a3f","updated":"2022-10-13 09:48:43.000000000","message":"I would like to ask how functional is skyline right now ? Because last time I was trying skyline it was working on half.","commit_id":"9fa51cba9dd813c6f3e27501978a8b78559807d9"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"873056f6b81c66b24788f93516cccb3ff7ff5c37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e3a39558_0d355a3f","in_reply_to":"f0c5a9af_88e14a56","updated":"2022-10-01 11:29:06.000000000","message":"Will be continue to do some work for the next release. Thanks.","commit_id":"9fa51cba9dd813c6f3e27501978a8b78559807d9"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"24ba0ebd93d40c3dd1b46a6d41d8825ad08835a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"892a32f4_156ac4a6","updated":"2022-10-13 10:25:08.000000000","message":"Ready for review now.\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/828464","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"8e07aa1c4f3a1b2843375abf7d7e824dcf982abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"b17652e8_b4efb2f5","in_reply_to":"892a32f4_156ac4a6","updated":"2022-10-13 10:25:37.000000000","message":"I also rebase and update the kolla-ansible patch","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"166b15a50ab6b4c47599c6c0f38f5189df32be22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"029bbab8_24c066f2","updated":"2022-10-28 07:23:56.000000000","message":"Ready for review now.","commit_id":"08bd2c9709397519698678127903b035896f613b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9b0eb4b7cfbb457390c20bda08ccd3332c4a34de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"379ac34a_59255235","updated":"2022-11-18 14:30:25.000000000","message":"Why there is only one skyline container and not two containers [console,apiserver]","commit_id":"fe04b2de907d01baf7d61b5a652bfa47ac445263"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"9a24323f8ed3dc8f840b2629300135ebdee884c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"7da35f27_b7fa61de","in_reply_to":"379ac34a_59255235","updated":"2022-11-21 02:02:54.000000000","message":"Now we will build both skyline-apiserver and skyline-console images.","commit_id":"fe04b2de907d01baf7d61b5a652bfa47ac445263"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"32cc971441a283396ca4f957c93de5d1e01af97c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"a7a65a57_89ca6442","updated":"2022-11-21 05:15:42.000000000","message":"recheck: kolla-ansible-ubuntu-source TIME_OUT","commit_id":"39418eebcda26b6d5ad817e7d21acc1d3933381c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0de35fb237d8e2685d0435cddd3150ebb12d1a82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"057cb263_4520f1a5","updated":"2022-11-23 06:51:51.000000000","message":"Please don\u0027t rebase unless there is a merge conflict. Zuul and Gerrit will rebase automatically for testing and merging in most cases.","commit_id":"c27962261d95390fee0a30f5a6e1d0d662804183"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"96e569c7cc5634f7d190a52e843f155e594547fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"d2ba4c91_7b6fb814","updated":"2022-11-23 08:34:24.000000000","message":"recheck: kolla-ansible-ubuntu-source, when run tools/init-runonce, fail to get cirros images.","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"49c9bc2e967ddb9adbcf0e6807a99994f6ee612d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"d959a6f3_55a775ed","updated":"2022-11-29 11:21:28.000000000","message":"you may also need to Add skyline project to this file[0];\n\n[0]: https://github.com/openstack/kolla/blob/master/roles/kolla-build-config/defaults/main.yml","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"962de1c444a34004e2bb5f6dbe28ccfc00b23f1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"e556fff4_96d38465","in_reply_to":"d959a6f3_55a775ed","updated":"2022-12-01 05:48:40.000000000","message":"Done","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"0e43dc6f7dcff271b1e2dd26674ab31294bdc484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"8fba3423_c6652ce0","updated":"2022-12-06 11:23:38.000000000","message":"LGTM， thanks","commit_id":"5b4a7337a423e38cebc945fbda569d69612e8c42"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"894756bb39600eb421f61fc076e1356f0332cdc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"f0bcdd89_5eb924e3","updated":"2022-12-07 07:30:59.000000000","message":"Please add to support matrix","commit_id":"5b4a7337a423e38cebc945fbda569d69612e8c42"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"8e6e28939491eb08936b996e1a3a67a59b8f44e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"5ef3b3d5_e970a7f0","in_reply_to":"f0bcdd89_5eb924e3","updated":"2022-12-08 03:16:29.000000000","message":"Done. Add support matrix.","commit_id":"5b4a7337a423e38cebc945fbda569d69612e8c42"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"fd492b7507f1069e2433ceb11b0a3172602ecc76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"846bc4d4_7ed9d420","updated":"2023-01-04 15:20:15.000000000","message":"ready for review","commit_id":"aa50cb253bf3dbed4f5406e3722ada387205d99e"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"6b7d3118d9ae92b112953d1aa33425117787ca6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"4b7aa612_2d78730a","updated":"2023-01-30 01:44:47.000000000","message":"Fix merge conflict and ready for review","commit_id":"cfc6297ec1a991718515c0c1340a50c147b15ec7"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"7335656b7f014fb45c59177bfbb3bea3f247a1e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"17efcffd_55b0c981","updated":"2023-01-30 05:48:40.000000000","message":"recheck: failed for network to build\n\nERROR:kolla.common.utils:influxdb Failed with status: error\nERROR:kolla.common.utils:telegraf Failed with status: error","commit_id":"cfc6297ec1a991718515c0c1340a50c147b15ec7"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"c024b19aae00262b7be61f2ccfbe8bea0882bcb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"9791c96f_db020277","updated":"2023-01-30 23:34:41.000000000","message":"recheck: failed to build\n\nERROR:kolla.common.utils:influxdb Failed with status: error\nERROR:kolla.common.utils:telegraf Failed with status: error","commit_id":"cfc6297ec1a991718515c0c1340a50c147b15ec7"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3ffdaf913a95fc8fae30a37dee299a861ceb876e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"809ab7ea_e02a1ed1","updated":"2023-02-01 05:57:23.000000000","message":"LGTM, thanks","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"6c1abe2f7096d06c671b5b0b26c93744df3b879c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"9fadd8b3_890d1779","updated":"2023-01-31 02:51:33.000000000","message":"LGTM， once CI passed， I would +2 ","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"1fc04d7a123f8b4b01f73aaddab871639a162795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"c8c75d5d_cb54afda","in_reply_to":"9fadd8b3_890d1779","updated":"2023-01-31 08:04:16.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/861687\n\nCI passed","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"}],"README.rst":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59dcfd6f9f23c5fdcda7d63ff667052c6c03e6a7","unresolved":true,"context_lines":[{"line_number":95,"context_line":"- `Octavia \u003chttps://docs.openstack.org/octavia/latest/\u003e`__"},{"line_number":96,"context_line":"- `Sahara \u003chttps://docs.openstack.org/sahara/latest/\u003e`__"},{"line_number":97,"context_line":"- `Senlin \u003chttps://docs.openstack.org/senlin/latest/\u003e`__"},{"line_number":98,"context_line":"- Skyline (`APIServer \u003chttps://docs.openstack.org/skyline-apiserver/latest/\u003e`__ and `Console \u003chttps://docs.openstack.org/skyline-console/latest/\u003e`__)"},{"line_number":99,"context_line":"- `Solum \u003chttps://docs.openstack.org/solum/latest/\u003e`__"},{"line_number":100,"context_line":"- `Swift \u003chttps://docs.openstack.org/swift/latest/\u003e`__"},{"line_number":101,"context_line":"- `Tacker \u003chttps://docs.openstack.org/tacker/latest/\u003e`__"}],"source_content_type":"text/x-rst","patch_set":40,"id":"ae313120_031cd1fd","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":149},"updated":"2023-01-31 00:00:33.000000000","message":"Shouldn\u0027t be the ` at the beggining as others ?\n\nAnd also one \u0027 \u0027 missing at the beggining","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3c8640cf27bec538cdcb55d3328653076a8c6523","unresolved":false,"context_lines":[{"line_number":95,"context_line":"- `Octavia \u003chttps://docs.openstack.org/octavia/latest/\u003e`__"},{"line_number":96,"context_line":"- `Sahara \u003chttps://docs.openstack.org/sahara/latest/\u003e`__"},{"line_number":97,"context_line":"- `Senlin \u003chttps://docs.openstack.org/senlin/latest/\u003e`__"},{"line_number":98,"context_line":"- Skyline (`APIServer \u003chttps://docs.openstack.org/skyline-apiserver/latest/\u003e`__ and `Console \u003chttps://docs.openstack.org/skyline-console/latest/\u003e`__)"},{"line_number":99,"context_line":"- `Solum \u003chttps://docs.openstack.org/solum/latest/\u003e`__"},{"line_number":100,"context_line":"- `Swift \u003chttps://docs.openstack.org/swift/latest/\u003e`__"},{"line_number":101,"context_line":"- `Tacker \u003chttps://docs.openstack.org/tacker/latest/\u003e`__"}],"source_content_type":"text/x-rst","patch_set":40,"id":"c325ec5a_4ca127e3","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":149},"in_reply_to":"ae313120_031cd1fd","updated":"2023-01-31 01:17:49.000000000","message":"Ok, now I got it when I rendered in github :)","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"}],"docker/skyline/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        {% set skyline_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"4b3078d5_530cc21a","line":10,"updated":"2022-05-30 08:20:02.000000000","message":"there is not other install_type, this will not work","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        {% set skyline_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"36f59f83_adfbada6","line":10,"in_reply_to":"4b3078d5_530cc21a","updated":"2022-08-23 09:43:43.000000000","message":"Done","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"58f03891_577648c9","line":49,"updated":"2022-05-30 08:20:02.000000000","message":"this image should be called skyline-apiserver","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4702c03b_6a403cc8","line":49,"in_reply_to":"58f03891_577648c9","updated":"2022-08-23 09:43:43.000000000","message":"In this image, both skyline-apiserver and skyline-console installed. So we named it as skyline","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"38f7143877addabf7b5321d0dc72379c6dd65594","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d [\u0027deb\u0027, \u0027rpm\u0027] %}"},{"line_number":11,"context_line":"    {% set skyline_base_packages \u003d ["},{"line_number":12,"context_line":"        \u0027nginx\u0027"},{"line_number":13,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"f894f380_09fff94a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2022-10-13 09:41:14.000000000","message":"s/\u003d\u003d/in\n\nand just remove whole check as it makes no sense - there are no other options","commit_id":"c75be0b41b3b490f87a37c3c53e8e6a533db42ed"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"94d7ac48bcd51410bafbd62f79a6733581b7c641","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d [\u0027deb\u0027, \u0027rpm\u0027] %}"},{"line_number":11,"context_line":"    {% set skyline_base_packages \u003d ["},{"line_number":12,"context_line":"        \u0027nginx\u0027"},{"line_number":13,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"0dd667c2_04e4162c","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"in_reply_to":"f894f380_09fff94a","updated":"2022-10-13 10:18:44.000000000","message":"Done","commit_id":"c75be0b41b3b490f87a37c3c53e8e6a533db42ed"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"670d20d76e64a8acdb3805598488016c25e08c29","unresolved":true,"context_lines":[{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d [\u0027deb\u0027, \u0027rpm\u0027] %}"},{"line_number":11,"context_line":"    {% set skyline_base_packages \u003d ["},{"line_number":12,"context_line":"        \u0027nginx\u0027"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"498f7b71_673691f2","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":32},"updated":"2022-10-13 09:43:34.000000000","message":"skyline_packages as this is not skyline-base","commit_id":"c75be0b41b3b490f87a37c3c53e8e6a533db42ed"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"94d7ac48bcd51410bafbd62f79a6733581b7c641","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d [\u0027deb\u0027, \u0027rpm\u0027] %}"},{"line_number":11,"context_line":"    {% set skyline_base_packages \u003d ["},{"line_number":12,"context_line":"        \u0027nginx\u0027"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"2cbde3da_5a6d4964","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":32},"in_reply_to":"498f7b71_673691f2","updated":"2022-10-13 10:18:44.000000000","message":"Done","commit_id":"c75be0b41b3b490f87a37c3c53e8e6a533db42ed"}],"docker/skyline/extend_start.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"source\" ]]; then"},{"line_number":4,"context_line":"    SITE_PACKAGES\u003d\"/var/lib/kolla/venv/lib/python${KOLLA_DISTRO_PYTHON_VERSION}/site-packages\""},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [[ ! -d \"/var/log/kolla/skyline\" ]]; then"},{"line_number":8,"context_line":"    mkdir -p /var/log/kolla/skyline"}],"source_content_type":"text/x-sh","patch_set":18,"id":"8c5e7bb4_80bb6d23","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":2},"updated":"2022-05-30 08:20:02.000000000","message":"there is no other install type and this will not work","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"source\" ]]; then"},{"line_number":4,"context_line":"    SITE_PACKAGES\u003d\"/var/lib/kolla/venv/lib/python${KOLLA_DISTRO_PYTHON_VERSION}/site-packages\""},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [[ ! -d \"/var/log/kolla/skyline\" ]]; then"},{"line_number":8,"context_line":"    mkdir -p /var/log/kolla/skyline"}],"source_content_type":"text/x-sh","patch_set":18,"id":"05cc7952_6cd7880c","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":2},"in_reply_to":"8c5e7bb4_80bb6d23","updated":"2022-08-23 09:43:43.000000000","message":"Done","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":29,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\" --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":30,"context_line":"else"},{"line_number":31,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":18,"id":"d3116926_7ed2fa2b","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":2},"updated":"2022-05-30 08:20:02.000000000","message":"ssl certs are managed by kolla-ansible - what is happening here?","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":29,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\" --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":30,"context_line":"else"},{"line_number":31,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":18,"id":"0149d64e_b0987c52","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":2},"in_reply_to":"d3116926_7ed2fa2b","updated":"2022-08-23 09:43:43.000000000","message":"Generate the nginx.conf for nginx.","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ec46b40d_65a277f9","line":34,"updated":"2022-05-30 08:20:02.000000000","message":"kolla-ansible sets the command to run, please follow the current practices...","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":18,"id":"d7968455_38690baa","line":34,"in_reply_to":"ec46b40d_65a277f9","updated":"2022-08-23 09:43:43.000000000","message":"Yes, we will run the command gunicorn to start skyline-apiserver service. Here, we need nginx for skyline-console.","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d97de182ffca2e4489f095e998d43436857e5b0a","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"b1d31991_5b966b4d","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"updated":"2022-10-18 06:14:50.000000000","message":"why are we running nginx in here?","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"68d5b3030a9710e7ccf0c83f13e1bf121de4b67a","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"5951aa9d_b0d22886","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"0c4edd6e_65dcc0f9","updated":"2022-11-03 06:48:57.000000000","message":"Yes, now in the skyline container, we run the nginx for the skyline-console. And we will run the gunicorn for skyline-apiserver.","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"276d72b4bde1603b3052a1165bec77480ed89c5d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"da111e47_23103078","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"2a764b85_e8541c6a","updated":"2022-11-03 10:58:48.000000000","message":"Two processes per container - if Skyline is built around NGINX, we\u0027re not going to force Apache here.","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"30beb4362ce899eb2a725659145492b4fc958aa5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"2a764b85_e8541c6a","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"30877285_2f6b8f4c","updated":"2022-11-03 10:40:33.000000000","message":"BTW, the main problem is two processes in one container or the new service(nginx, or use the same http service like others projects).","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"15f2b5e607e9a32b0771ce7671a065a76631f8e8","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"30877285_2f6b8f4c","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"5951aa9d_b0d22886","updated":"2022-11-03 07:03:33.000000000","message":"That\u0027s against what we do with other containers (excluding bifrost) - so please rework it.","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"4988304572ddd6fc1b5cfbdf5dcc4521f3b7d69e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"818eaec8_ef0f3d04","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"5d0a223f_35c920f5","updated":"2022-11-21 07:17:10.000000000","message":"Done","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"443b9164ba5326bf14518da0a9e426c514ea6b0e","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"5d0a223f_35c920f5","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"5dc50f36_745d57cb","updated":"2022-11-10 02:17:24.000000000","message":"Yes, now we have two processes into the skyline container. But is it strongly for us to sperate those to two containers?\nWe now run gunicorn service as socket and config it into nginx.","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"32a530982562a57d7507ff8c28e20274a263c45d","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"0c4edd6e_65dcc0f9","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"64790614_55f90847","updated":"2022-11-02 13:29:59.000000000","message":"Does that mean we\u0027re running two processes in one container?","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c14e156a98eeff3a7bcc8816a02c7e8be949ac60","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"5dc50f36_745d57cb","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"7202e02e_684552e8","updated":"2022-11-09 10:44:08.000000000","message":"extend_start last line is nginx, and then config.json in K-A patch runs gunicorn - we probably should separate those.","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"1244b6a56b8b3ad4f6f07de833e9937af0dd5ba9","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"64790614_55f90847","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"b1d31991_5b966b4d","updated":"2022-10-28 07:19:32.000000000","message":"Yes, we need to run nginx here to redirect the openstack service api from nginx. And we use nginx for skyline-console to call skyline-apiserver.","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0ceac5fba98ead089745998e52b9fca036f7db55","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    skyline-nginx-generator -o /etc/nginx/nginx.conf --listen-address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":24,"id":"7202e02e_684552e8","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"da111e47_23103078","updated":"2022-11-09 10:39:50.000000000","message":"But are there really two (or three) processes? If only nginx is the main process and it has children for apiserver and console, I think this setup might be o.k.","commit_id":"039d94602ce5dff063c9174df4579303f628dfa6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"32a530982562a57d7507ff8c28e20274a263c45d","unresolved":true,"context_lines":[{"line_number":32,"context_line":"if [[ -n \"${LOG_DIR}\" ]]; then"},{"line_number":33,"context_line":"    GENERATOR_ARGS+\u003d\" --log-dir ${LOG_DIR}\""},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":"skyline-nginx-generator ${GENERATOR_ARGS}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":30,"id":"71e0247b_aac017cb","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":41},"updated":"2022-11-02 13:29:59.000000000","message":"this is printing a lot of debug logs - can we make it quieter?","commit_id":"08bd2c9709397519698678127903b035896f613b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"edef49d30960153575fe78a048240770245ed928","unresolved":true,"context_lines":[{"line_number":32,"context_line":"if [[ -n \"${LOG_DIR}\" ]]; then"},{"line_number":33,"context_line":"    GENERATOR_ARGS+\u003d\" --log-dir ${LOG_DIR}\""},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":"skyline-nginx-generator ${GENERATOR_ARGS}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":30,"id":"cf1a860c_fa00c0e9","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":41},"in_reply_to":"52d2e2a0_923314a2","updated":"2022-11-15 09:59:46.000000000","message":"Why config is not provided by kolla-ansible ?","commit_id":"08bd2c9709397519698678127903b035896f613b"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"68d5b3030a9710e7ccf0c83f13e1bf121de4b67a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"if [[ -n \"${LOG_DIR}\" ]]; then"},{"line_number":33,"context_line":"    GENERATOR_ARGS+\u003d\" --log-dir ${LOG_DIR}\""},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":"skyline-nginx-generator ${GENERATOR_ARGS}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":30,"id":"bda5f8bd_1fcf95b9","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":41},"in_reply_to":"71e0247b_aac017cb","updated":"2022-11-03 06:48:57.000000000","message":"By default, the debug is False. So I think there will not a lot of debug logs.","commit_id":"08bd2c9709397519698678127903b035896f613b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0ceac5fba98ead089745998e52b9fca036f7db55","unresolved":true,"context_lines":[{"line_number":32,"context_line":"if [[ -n \"${LOG_DIR}\" ]]; then"},{"line_number":33,"context_line":"    GENERATOR_ARGS+\u003d\" --log-dir ${LOG_DIR}\""},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":"skyline-nginx-generator ${GENERATOR_ARGS}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":30,"id":"e752b140_14b2b07a","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":41},"in_reply_to":"bda5f8bd_1fcf95b9","updated":"2022-11-09 10:39:50.000000000","message":"So if I understand it correctly, this command generates the configuration for nginx? Is it needed to do this dynamically or could it be done during image generation instead?","commit_id":"08bd2c9709397519698678127903b035896f613b"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"9a24323f8ed3dc8f840b2629300135ebdee884c9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"if [[ -n \"${LOG_DIR}\" ]]; then"},{"line_number":33,"context_line":"    GENERATOR_ARGS+\u003d\" --log-dir ${LOG_DIR}\""},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":"skyline-nginx-generator ${GENERATOR_ARGS}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":30,"id":"96ecfb75_b993523b","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":41},"in_reply_to":"cf1a860c_fa00c0e9","updated":"2022-11-21 02:02:54.000000000","message":"Now we will generated this config by kolla-ansible. And remove this command from kolla.","commit_id":"08bd2c9709397519698678127903b035896f613b"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"443b9164ba5326bf14518da0a9e426c514ea6b0e","unresolved":true,"context_lines":[{"line_number":32,"context_line":"if [[ -n \"${LOG_DIR}\" ]]; then"},{"line_number":33,"context_line":"    GENERATOR_ARGS+\u003d\" --log-dir ${LOG_DIR}\""},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":"skyline-nginx-generator ${GENERATOR_ARGS}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":30,"id":"52d2e2a0_923314a2","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":41},"in_reply_to":"e752b140_14b2b07a","updated":"2022-11-10 02:17:24.000000000","message":"yes, it will generate the config for nginx. And we do this dynamically so that we do not need to pre-config the configuration for nginx and just generate the config with the openstack endpoint from keystone endpoint.","commit_id":"08bd2c9709397519698678127903b035896f613b"}],"docker/skyline/skyline-apiserver/Dockerfile.j2":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"49c9bc2e967ddb9adbcf0e6807a99994f6ee612d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"4857af04_326df717","line":24,"updated":"2022-11-29 11:21:28.000000000","message":"USER skyline-user? I would suggest to add user explicitly, the default user is root.","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"962de1c444a34004e2bb5f6dbe28ccfc00b23f1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"f49f86e7_098bdd0a","line":24,"in_reply_to":"4857af04_326df717","updated":"2022-12-01 05:48:40.000000000","message":"Done","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"}],"docker/skyline/skyline-base/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2279e696267521f8d3c7d827d721a420cb499ae4","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% set skyline_base_packages \u003d ["},{"line_number":13,"context_line":"    \u0027nginx\u0027,"},{"line_number":14,"context_line":"    \u0027traceroute\u0027,"},{"line_number":15,"context_line":"    \u0027vim\u0027,"},{"line_number":16,"context_line":"    \u0027wget\u0027"},{"line_number":17,"context_line":"] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"a27c69c3_0e860aab","line":16,"range":{"start_line":14,"start_character":1,"end_line":16,"end_character":10},"updated":"2022-02-15 05:24:33.000000000","message":"why?","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"a7c7538cc18dba7e136a9cc503a1b73318c0c5fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% set skyline_base_packages \u003d ["},{"line_number":13,"context_line":"    \u0027nginx\u0027,"},{"line_number":14,"context_line":"    \u0027traceroute\u0027,"},{"line_number":15,"context_line":"    \u0027vim\u0027,"},{"line_number":16,"context_line":"    \u0027wget\u0027"},{"line_number":17,"context_line":"] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"b9f65df6_2ccc514d","line":16,"range":{"start_line":14,"start_character":1,"end_line":16,"end_character":10},"in_reply_to":"a27c69c3_0e860aab","updated":"2022-02-15 08:18:12.000000000","message":"Done","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2279e696267521f8d3c7d827d721a420cb499ae4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    \u0027wget\u0027"},{"line_number":17,"context_line":"] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":20,"context_line":"    {% set skyline_base_packages \u003d skyline_base_packages + ["},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"    {% set skyline_base_packages \u003d skyline_base_packages + ["},{"line_number":24,"context_line":"        \u0027iputils-ping\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ed158d1e_592fb4d5","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":8},"updated":"2022-02-15 05:24:33.000000000","message":"if it\u0027s empty, let\u0027s just skip it.","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"a7c7538cc18dba7e136a9cc503a1b73318c0c5fd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0027wget\u0027"},{"line_number":17,"context_line":"] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":20,"context_line":"    {% set skyline_base_packages \u003d skyline_base_packages + ["},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"    {% set skyline_base_packages \u003d skyline_base_packages + ["},{"line_number":24,"context_line":"        \u0027iputils-ping\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fb769de3_bd7c0d2e","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":8},"in_reply_to":"ed158d1e_592fb4d5","updated":"2022-02-15 08:18:12.000000000","message":"Done","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2279e696267521f8d3c7d827d721a420cb499ae4","unresolved":true,"context_lines":[{"line_number":28,"context_line":"{% endif %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{{ macros.install_packages(skyline_base_packages | customizable(\"packages\")) }}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% block skyline_base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"97ec2d5b_ae9f746e","line":31,"updated":"2022-02-15 05:24:33.000000000","message":"USER skyline ? (it will run as root now)","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"494dc2d335d2cf2531721f0914ecba51cfddab13","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{% endif %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{{ macros.install_packages(skyline_base_packages | customizable(\"packages\")) }}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% block skyline_base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"17ac3e24_b3ef6f00","line":31,"in_reply_to":"97ec2d5b_ae9f746e","updated":"2022-02-15 08:35:38.000000000","message":"Done","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"274eab569fa5f645ffa529e62262e0badd40cd9e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027skyline\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% set skyline_base_packages \u003d ["},{"line_number":13,"context_line":"    \u0027nginx\u0027"},{"line_number":14,"context_line":"] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.install_packages(skyline_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"37d1e028_8667c053","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":10},"updated":"2022-11-21 07:39:32.000000000","message":"is nginx used in both console and apiserver?","commit_id":"39418eebcda26b6d5ad817e7d21acc1d3933381c"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"ba76567a3c6e8a1632b44ce188ab08b6e1995530","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027skyline\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% set skyline_base_packages \u003d ["},{"line_number":13,"context_line":"    \u0027nginx\u0027"},{"line_number":14,"context_line":"] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.install_packages(skyline_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"8d7eeaa8_7092259b","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":10},"in_reply_to":"2829a037_e3bb9a0c","updated":"2022-11-23 05:34:56.000000000","message":"Remove it from skyline base, and only install it into skyline-console","commit_id":"39418eebcda26b6d5ad817e7d21acc1d3933381c"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"89b5501181f670d88e7a67f8325a4d75dc8ff14a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027skyline\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% set skyline_base_packages \u003d ["},{"line_number":13,"context_line":"    \u0027nginx\u0027"},{"line_number":14,"context_line":"] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.install_packages(skyline_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"2829a037_e3bb9a0c","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":10},"in_reply_to":"37d1e028_8667c053","updated":"2022-11-21 08:00:25.000000000","message":"No, only for skyline-console","commit_id":"39418eebcda26b6d5ad817e7d21acc1d3933381c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0de35fb237d8e2685d0435cddd3150ebb12d1a82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":34,"id":"42d54c39_c7f96444","line":18,"updated":"2022-11-23 06:51:51.000000000","message":"It seems nothing is really being installed into this container, so I\u0027m not sure that we need it. How about just building -apiserver and -console both from openstack-base directly instead?","commit_id":"c27962261d95390fee0a30f5a6e1d0d662804183"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"62e7412e548d7d66827edb62671e4f6bacb55ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"9a0f738d_95f7ee91","line":18,"in_reply_to":"42d54c39_c7f96444","updated":"2022-11-23 07:00:19.000000000","message":"We need the \"extend_start.sh\" from skyline-base image as kolla_extend_start to run.","commit_id":"c27962261d95390fee0a30f5a6e1d0d662804183"}],"docker/skyline/skyline-console/Dockerfile.j2":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"49c9bc2e967ddb9adbcf0e6807a99994f6ee612d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"95ec4e47_3863a016","line":30,"updated":"2022-11-29 11:21:28.000000000","message":"ditto","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"5551ce36781c8eb0ff548037901c2fb875bb4a12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"d471d6e2_986b2b6c","line":30,"in_reply_to":"82944bb4_abe90523","updated":"2022-12-02 03:59:07.000000000","message":"Done","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"962de1c444a34004e2bb5f6dbe28ccfc00b23f1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"c3f0a524_47b6a9ef","line":30,"in_reply_to":"95ec4e47_3863a016","updated":"2022-12-01 05:48:40.000000000","message":"No, skyline-console run in nginx. like apache, we will not run as non-root now.\nlike cinder-api: https://github.com/openstack/kolla/blob/master/docker/cinder/cinder-api/Dockerfile.j2#L23","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2dfec3e407d5d76e3bfbca905d0619fab701e130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"82944bb4_abe90523","line":30,"in_reply_to":"c3f0a524_47b6a9ef","updated":"2022-12-01 12:38:12.000000000","message":"even if we use root user here, I still trend to add \"user root\" line explicitly. thanks","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"}],"docker/skyline/skyline-console/extend_start.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"274eab569fa5f645ffa529e62262e0badd40cd9e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"b887bfda_6f25be58","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":22},"updated":"2022-11-21 07:39:32.000000000","message":"shouldn\u0027t that be rather in kolla-ansible change? (config.json)","commit_id":"39418eebcda26b6d5ad817e7d21acc1d3933381c"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"ba76567a3c6e8a1632b44ce188ab08b6e1995530","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"04b9fb7b_4c861766","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":22},"in_reply_to":"17c8bd9e_f8840b4b","updated":"2022-11-23 05:34:56.000000000","message":"now I add it into script skyline-nginx. And will call it from config.json","commit_id":"39418eebcda26b6d5ad817e7d21acc1d3933381c"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"89b5501181f670d88e7a67f8325a4d75dc8ff14a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"17c8bd9e_f8840b4b","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":22},"in_reply_to":"b887bfda_6f25be58","updated":"2022-11-21 08:00:25.000000000","message":"How can I correctly write this into config.json.\nWhen I just write as followed into config.json\ncommand: \"nginx -g \u0027daemon off;\u0027\"\n\nit will be failed to start the skyline-console.","commit_id":"39418eebcda26b6d5ad817e7d21acc1d3933381c"}],"docker/skyline/skyline-console/skyline_nginx":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"49c9bc2e967ddb9adbcf0e6807a99994f6ee612d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"d358edd3_9a599cde","line":4,"updated":"2022-11-29 11:21:28.000000000","message":"what about we remove this command to kolla-ansible directly and remove this file? https://review.opendev.org/c/openstack/kolla-ansible/+/828464/32/ansible/roles/skyline/templates/skyline-console.json.j2","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2dfec3e407d5d76e3bfbca905d0619fab701e130","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1339cad4_d525227e","line":4,"in_reply_to":"021ca1cb_8c9dbcf1","updated":"2022-12-01 12:38:12.000000000","message":"Have you tried to escape the single-quote in this command? e.g.\n\n\"command\": \"nginx -g \\‘daemon off\\’\"\n\nthough this looks ugly, it works for me.","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"5551ce36781c8eb0ff548037901c2fb875bb4a12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"cd8dd56f_33994057","line":4,"in_reply_to":"1339cad4_d525227e","updated":"2022-12-02 03:59:07.000000000","message":"Done, I remove this skyline_nginx. And add daemon off; into nginx.conf config file. Now in config.json just use nginx command to run nginx service.","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"962de1c444a34004e2bb5f6dbe28ccfc00b23f1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"e191c7cc_e64d06f9","line":4,"in_reply_to":"d358edd3_9a599cde","updated":"2022-12-01 05:48:40.000000000","message":"Try to set this into config.json like:\n{\n    \"command\": \"nginx -g \u0027daemon off;\u0027\",\n    ......\n}\nBut it failed to start the nginx.","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3e6622ddce100bc39d81fc48eed9b40302d602af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# We need to run the nginx as a frontend service."},{"line_number":4,"context_line":"nginx -g \"daemon off;\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"021ca1cb_8c9dbcf1","line":4,"in_reply_to":"e191c7cc_e64d06f9","updated":"2022-12-01 06:40:07.000000000","message":"then worst scenario - template nginx config with daemon off and use it?","commit_id":"22819f3db3dc88a65881756491ba6e22b6b7b352"}],"docker/skyline/skyline/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2279e696267521f8d3c7d827d721a420cb499ae4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":19,"context_line":"        {{ macros.install_pip(skyline_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}; \\"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"e66dec1a_1efb8d24","line":19,"range":{"start_line":19,"start_character":83,"end_line":19,"end_character":103},"updated":"2022-02-15 05:24:33.000000000","message":"why?","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"a7c7538cc18dba7e136a9cc503a1b73318c0c5fd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":19,"context_line":"        {{ macros.install_pip(skyline_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}; \\"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ea88fc35_9fd53f17","line":19,"range":{"start_line":19,"start_character":83,"end_line":19,"end_character":103},"in_reply_to":"e66dec1a_1efb8d24","updated":"2022-02-15 08:18:12.000000000","message":"skyline use poetry as constraints","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"07c1c13a4515c07e6ef900732c54e5a3f4205247","unresolved":false,"context_lines":[{"line_number":16,"context_line":"] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":19,"context_line":"        {{ macros.install_pip(skyline_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}; \\"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fd630c10_a1694d4e","line":19,"range":{"start_line":19,"start_character":83,"end_line":19,"end_character":103},"in_reply_to":"ea88fc35_9fd53f17","updated":"2022-02-16 06:41:39.000000000","message":"And it\u0027s not in openstack constraints?","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"4cc94b96a1d54f47a9b10a6938dbb7df9a72a0a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":19,"context_line":"        {{ macros.install_pip(skyline_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}; \\"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"54afed6d_34087fda","line":19,"range":{"start_line":19,"start_character":83,"end_line":19,"end_character":103},"in_reply_to":"fd630c10_a1694d4e","updated":"2022-02-17 05:58:35.000000000","message":"yes, there will be conflicting dependencies.","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"07c1c13a4515c07e6ef900732c54e5a3f4205247","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        {% set skyline_packages \u003d ["},{"line_number":14,"context_line":"            \u0027nginx\u0027,"},{"line_number":15,"context_line":"            \u0027traceroute\u0027,"},{"line_number":16,"context_line":"            \u0027iputils-ping\u0027,"},{"line_number":17,"context_line":"            \u0027locales-all\u0027,"},{"line_number":18,"context_line":"            \u0027ssl-cert\u0027"},{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(skyline_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"11280ea0_1e405856","line":18,"range":{"start_line":15,"start_character":1,"end_line":18,"end_character":22},"updated":"2022-02-16 06:41:39.000000000","message":"It\u0027s still here, do we need it?","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"4cc94b96a1d54f47a9b10a6938dbb7df9a72a0a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        {% set skyline_packages \u003d ["},{"line_number":14,"context_line":"            \u0027nginx\u0027,"},{"line_number":15,"context_line":"            \u0027traceroute\u0027,"},{"line_number":16,"context_line":"            \u0027iputils-ping\u0027,"},{"line_number":17,"context_line":"            \u0027locales-all\u0027,"},{"line_number":18,"context_line":"            \u0027ssl-cert\u0027"},{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(skyline_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"b69c354b_21d713e1","line":18,"range":{"start_line":15,"start_character":1,"end_line":18,"end_character":22},"in_reply_to":"11280ea0_1e405856","updated":"2022-02-17 05:58:35.000000000","message":"Yes Otherwise there may be some errors such as ssl error route error","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"c974bdc05cf8a03157c35a827ac09c29f79c82ff","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(skyline_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ADD plugins-archive /"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"f49a5394_744910d3","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":15},"updated":"2022-02-25 01:56:26.000000000","message":"Move this to line 20 ?","commit_id":"66281bed28d456d0a5a1d8e5b12880210243ce7a"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"56e0def7643f8838b610fa0091ea2d4c51d542b3","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(skyline_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ADD plugins-archive /"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"a5c04035_88079e23","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":15},"in_reply_to":"f49a5394_744910d3","updated":"2022-02-25 02:18:13.000000000","message":"Done","commit_id":"66281bed28d456d0a5a1d8e5b12880210243ce7a"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"111b0ad876be24ded54ce57e1956cafd636126e0","unresolved":true,"context_lines":[{"line_number":29,"context_line":"] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":32,"context_line":"        {{ macros.install_pip(skyline_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}; \\"},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"453dd51b_1e6f1185","line":32,"range":{"start_line":32,"start_character":83,"end_line":32,"end_character":102},"updated":"2022-03-07 10:42:35.000000000","message":"This can give us weird results when built in future.\n\nIf skyline requires something in other versions than other OpenStack projects then shouldn\u0027t it handle that in openstack/requirements?","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"9d67e8b02cbd0ee111078bc07aed9be61bc5c7dd","unresolved":true,"context_lines":[{"line_number":29,"context_line":"] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":32,"context_line":"        {{ macros.install_pip(skyline_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}; \\"},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"8de93125_41294e8f","line":32,"range":{"start_line":32,"start_character":83,"end_line":32,"end_character":102},"in_reply_to":"453dd51b_1e6f1185","updated":"2022-05-27 06:48:14.000000000","message":"Done. We have refactor of the skyline related projects.","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"00dc8c5ff2aff5d19ac71eccf0ca8b0b4e96ba78","unresolved":false,"context_lines":[{"line_number":29,"context_line":"] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":32,"context_line":"        {{ macros.install_pip(skyline_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}; \\"},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"2974835c_b3f86b36","line":32,"range":{"start_line":32,"start_character":83,"end_line":32,"end_character":102},"in_reply_to":"8de93125_41294e8f","updated":"2022-10-13 10:20:58.000000000","message":"Done","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"}],"docker/skyline/skyline/extend_start.sh":[{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"fb7bf202c264edea9c5ab7437ba056268ef25a80","unresolved":true,"context_lines":[{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: remove skyline nginx port from nginx.conf"},{"line_number":25,"context_line":"sed -i \"s/listen 9999/listen ${LISTEN_ADDRESS}:9999/\" /etc/nginx/nginx.conf"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":4,"id":"e3d67721_a3f33af5","line":25,"range":{"start_line":25,"start_character":17,"end_line":25,"end_character":21},"updated":"2022-02-10 00:46:48.000000000","message":"port numnber 9999 is hardcode, which should be fix in next patch","commit_id":"e577d049cc7ea166e29ed63333d3a0bd71e05606"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"a7c7538cc18dba7e136a9cc503a1b73318c0c5fd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: remove skyline nginx port from nginx.conf"},{"line_number":25,"context_line":"sed -i \"s/listen 9999/listen ${LISTEN_ADDRESS}:9999/\" /etc/nginx/nginx.conf"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":4,"id":"d3ab29e3_5baabf9b","line":25,"range":{"start_line":25,"start_character":17,"end_line":25,"end_character":21},"in_reply_to":"e3d67721_a3f33af5","updated":"2022-02-15 08:18:12.000000000","message":"Ack","commit_id":"e577d049cc7ea166e29ed63333d3a0bd71e05606"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2279e696267521f8d3c7d827d721a420cb499ae4","unresolved":true,"context_lines":[{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":11,"context_line":"    # TODO: ugly path"},{"line_number":12,"context_line":"    pushd /var/lib/kolla/venv/lib/python3.8/site-packages/skyline_apiserver/db/alembic"},{"line_number":13,"context_line":"    alembic upgrade head"},{"line_number":14,"context_line":"    popd"},{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"54f1cc50_8c9de175","line":15,"range":{"start_line":11,"start_character":0,"end_line":15,"end_character":10},"updated":"2022-02-15 05:24:33.000000000","message":"that is indeed ugly...","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"a7c7538cc18dba7e136a9cc503a1b73318c0c5fd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":11,"context_line":"    # TODO: ugly path"},{"line_number":12,"context_line":"    pushd /var/lib/kolla/venv/lib/python3.8/site-packages/skyline_apiserver/db/alembic"},{"line_number":13,"context_line":"    alembic upgrade head"},{"line_number":14,"context_line":"    popd"},{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"c36f8616_15658bbf","line":15,"range":{"start_line":11,"start_character":0,"end_line":15,"end_character":10},"in_reply_to":"54f1cc50_8c9de175","updated":"2022-02-15 08:18:12.000000000","message":"Done","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2279e696267521f8d3c7d827d721a420cb499ae4","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":19,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: remove skyline nginx port from nginx.conf"},{"line_number":25,"context_line":"sed -i \"s/listen 9999/listen ${LISTEN_ADDRESS}:9999/\" /etc/nginx/nginx.conf"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":5,"id":"aca11c00_3026db37","line":25,"range":{"start_line":18,"start_character":0,"end_line":25,"end_character":75},"updated":"2022-02-15 05:24:33.000000000","message":"I don\u0027t think we use Nginx for any service, and we should not be generating tls/ssl certificates here (that should come from Kolla-Ansible).","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"a7c7538cc18dba7e136a9cc503a1b73318c0c5fd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":19,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: remove skyline nginx port from nginx.conf"},{"line_number":25,"context_line":"sed -i \"s/listen 9999/listen ${LISTEN_ADDRESS}:9999/\" /etc/nginx/nginx.conf"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":5,"id":"a12ce2a2_14234f30","line":25,"range":{"start_line":18,"start_character":0,"end_line":25,"end_character":75},"in_reply_to":"aca11c00_3026db37","updated":"2022-02-15 08:18:12.000000000","message":"nginx.conf is hardcode in skyline.we will fix this todo in next patch after skyline code refactoring.","commit_id":"7307d794c7fbb5e0e0b46e57852ed0345d579a8e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"07c1c13a4515c07e6ef900732c54e5a3f4205247","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    exit 0"},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":26,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\" --listen_address \"${LISTEN_ADDRESS}\""},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --listen_address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":10,"id":"d6d618f3_531ee19b","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":2},"updated":"2022-02-16 06:41:39.000000000","message":"As written before - we don\u0027t generate certs here, user needs to supply them.","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"4cc94b96a1d54f47a9b10a6938dbb7df9a72a0a2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    exit 0"},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":26,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\" --listen_address \"${LISTEN_ADDRESS}\""},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --listen_address \"${LISTEN_ADDRESS}\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"nginx"}],"source_content_type":"text/x-sh","patch_set":10,"id":"61ab0833_4919f605","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":2},"in_reply_to":"d6d618f3_531ee19b","updated":"2022-02-17 05:58:35.000000000","message":"User can configure ssl by kolla-ansible https://review.opendev.org/c/openstack/kolla-ansible/+/828464.","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"c974bdc05cf8a03157c35a827ac09c29f79c82ff","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    chmod 755 /var/lib/skyline"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [[ -d ${SITE_PACKAGES}/skyline_apiserver/db/alembic ]]; then"},{"line_number":22,"context_line":"    DB_ALEMBIC_PATH\u003d\"${SITE_PACKAGES}/skyline_apiserver/db/alembic\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":26,"context_line":"    pushd ${DB_ALEMBIC_PATH}"},{"line_number":27,"context_line":"    alembic upgrade head"},{"line_number":28,"context_line":"    popd"},{"line_number":29,"context_line":"    exit 0"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":33,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\" --listen-address \"${LISTEN_ADDRESS}\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"32bcda16_ae0ffb9d","line":30,"range":{"start_line":21,"start_character":0,"end_line":30,"end_character":2},"updated":"2022-02-25 01:56:26.000000000","message":"if no ${SITE_PACKAGES}/skyline_apiserver/db/alembic, then the value of DB_ALEMBIC_PATH will be blank. And is it correct to do pushd ${DB_ALEMBIC_PATH} ?","commit_id":"66281bed28d456d0a5a1d8e5b12880210243ce7a"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"56e0def7643f8838b610fa0091ea2d4c51d542b3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    chmod 755 /var/lib/skyline"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [[ -d ${SITE_PACKAGES}/skyline_apiserver/db/alembic ]]; then"},{"line_number":22,"context_line":"    DB_ALEMBIC_PATH\u003d\"${SITE_PACKAGES}/skyline_apiserver/db/alembic\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":26,"context_line":"    pushd ${DB_ALEMBIC_PATH}"},{"line_number":27,"context_line":"    alembic upgrade head"},{"line_number":28,"context_line":"    popd"},{"line_number":29,"context_line":"    exit 0"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ -n \"${SSL_CERTFILE}\" \u0026\u0026 -n \"${SSL_KEYFILE}\" ]]; then"},{"line_number":33,"context_line":"    nginx-generator -o /etc/nginx/nginx.conf --ssl-certfile \"${SSL_CERTFILE}\" --ssl-keyfile \"${SSL_KEYFILE}\" --listen-address \"${LISTEN_ADDRESS}\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"5d0d332e_8022d379","line":30,"range":{"start_line":21,"start_character":0,"end_line":30,"end_character":2},"in_reply_to":"32bcda16_ae0ffb9d","updated":"2022-02-25 02:18:13.000000000","message":"Done","commit_id":"66281bed28d456d0a5a1d8e5b12880210243ce7a"}],"kolla/common/config.py":[{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"fb7bf202c264edea9c5ab7437ba056268ef25a80","unresolved":true,"context_lines":[{"line_number":601,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":602,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/senlin/\u0027"},{"line_number":603,"context_line":"                     \u0027senlin-${openstack_branch}.tar.gz\u0027)},"},{"line_number":604,"context_line":"    \u0027skyline-plugin-log\u0027: {"},{"line_number":605,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":606,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/skyline/skyline-apiserver/\u0027"},{"line_number":607,"context_line":"                     \u0027skyline-log-${openstack_branch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":4,"id":"e48f3b53_b741990b","line":604,"range":{"start_line":604,"start_character":4,"end_line":604,"end_character":26},"updated":"2022-02-10 00:46:48.000000000","message":"sort by name?\nskyline-plugin-apiserver should before skyline-plugin-log","commit_id":"e577d049cc7ea166e29ed63333d3a0bd71e05606"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"a7c7538cc18dba7e136a9cc503a1b73318c0c5fd","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":602,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/senlin/\u0027"},{"line_number":603,"context_line":"                     \u0027senlin-${openstack_branch}.tar.gz\u0027)},"},{"line_number":604,"context_line":"    \u0027skyline-plugin-log\u0027: {"},{"line_number":605,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":606,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/skyline/skyline-apiserver/\u0027"},{"line_number":607,"context_line":"                     \u0027skyline-log-${openstack_branch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":4,"id":"2eeb7b67_cb26e321","line":604,"range":{"start_line":604,"start_character":4,"end_line":604,"end_character":26},"in_reply_to":"e48f3b53_b741990b","updated":"2022-02-15 08:18:12.000000000","message":"Done","commit_id":"e577d049cc7ea166e29ed63333d3a0bd71e05606"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                    \u0027proxysql\u0027,"},{"line_number":137,"context_line":"                    \u0027openvswitch\u0027,"},{"line_number":138,"context_line":"                    \u0027rabbitmq\u0027,"},{"line_number":139,"context_line":"                    \u0027skyline\u0027"},{"line_number":140,"context_line":"                ],"},{"line_number":141,"context_line":"                help\u003d\u0027Default images\u0027),"},{"line_number":142,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"26a12638_dc0ac8a3","line":139,"updated":"2022-05-30 08:20:02.000000000","message":"don\u0027t change it","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                    \u0027proxysql\u0027,"},{"line_number":137,"context_line":"                    \u0027openvswitch\u0027,"},{"line_number":138,"context_line":"                    \u0027rabbitmq\u0027,"},{"line_number":139,"context_line":"                    \u0027skyline\u0027"},{"line_number":140,"context_line":"                ],"},{"line_number":141,"context_line":"                help\u003d\u0027Default images\u0027),"},{"line_number":142,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"6eeb3675_75180344","line":139,"in_reply_to":"26a12638_dc0ac8a3","updated":"2022-08-23 09:43:43.000000000","message":"Done","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":602,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":603,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/senlin/\u0027"},{"line_number":604,"context_line":"                     \u0027senlin-${openstack_branch}.tar.gz\u0027)},"},{"line_number":605,"context_line":"    \u0027skyline\u0027: {"},{"line_number":606,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":607,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-apiserver/\u0027"},{"line_number":608,"context_line":"                     \u0027skyline-apiserver-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":18,"id":"0509c96c_8e4aa1d8","line":605,"updated":"2022-05-30 08:20:02.000000000","message":"skyline-apiserver","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":603,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/senlin/\u0027"},{"line_number":604,"context_line":"                     \u0027senlin-${openstack_branch}.tar.gz\u0027)},"},{"line_number":605,"context_line":"    \u0027skyline\u0027: {"},{"line_number":606,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":607,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-apiserver/\u0027"},{"line_number":608,"context_line":"                     \u0027skyline-apiserver-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":18,"id":"abd4645a_d5b720a1","line":605,"in_reply_to":"0509c96c_8e4aa1d8","updated":"2022-08-23 09:43:43.000000000","message":"In this image, both skyline-apiserver and skyline-console installed. So we named it as skyline","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":606,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":607,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-apiserver/\u0027"},{"line_number":608,"context_line":"                     \u0027skyline-apiserver-master.tar.gz\u0027)},"},{"line_number":609,"context_line":"    \u0027skyline-plugin-console\u0027: {"},{"line_number":610,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":611,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-console/\u0027"},{"line_number":612,"context_line":"                     \u0027skyline-console-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":18,"id":"a9ea1742_7a630745","line":609,"range":{"start_line":609,"start_character":5,"end_line":609,"end_character":12},"updated":"2022-05-30 08:20:02.000000000","message":"skyline-apiserver","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":607,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-apiserver/\u0027"},{"line_number":608,"context_line":"                     \u0027skyline-apiserver-master.tar.gz\u0027)},"},{"line_number":609,"context_line":"    \u0027skyline-plugin-console\u0027: {"},{"line_number":610,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":611,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-console/\u0027"},{"line_number":612,"context_line":"                     \u0027skyline-console-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":18,"id":"cccbc40e_6ca2a17b","line":609,"range":{"start_line":609,"start_character":5,"end_line":609,"end_character":12},"in_reply_to":"a9ea1742_7a630745","updated":"2022-08-23 09:43:43.000000000","message":"In this image, both skyline-apiserver and skyline-console installed. So we named it as skyline","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"}],"kolla/common/sources.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"06044b1a88622fa54a21f51e07e090e96802d2bb","unresolved":true,"context_lines":[{"line_number":332,"context_line":"    \u0027skyline\u0027: {"},{"line_number":333,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":334,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-apiserver/\u0027"},{"line_number":335,"context_line":"                     \u0027skyline-apiserver-master.tar.gz\u0027)},"},{"line_number":336,"context_line":"    \u0027skyline-plugin-console\u0027: {"},{"line_number":337,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":338,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-console/\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"165ecbf7_0b000f6a","line":335,"updated":"2022-10-13 07:38:03.000000000","message":"Since it has been released for zed, you should be able to use \"${openstack_branch}\" here instead of \"master\" like for the other projects?","commit_id":"bf6467290fc3505cb6c83a84a44a2d0ccbe5bbec"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"00dc8c5ff2aff5d19ac71eccf0ca8b0b4e96ba78","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    \u0027skyline\u0027: {"},{"line_number":333,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":334,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-apiserver/\u0027"},{"line_number":335,"context_line":"                     \u0027skyline-apiserver-master.tar.gz\u0027)},"},{"line_number":336,"context_line":"    \u0027skyline-plugin-console\u0027: {"},{"line_number":337,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":338,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/openstack/skyline-console/\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"e6b36f99_79c97488","line":335,"in_reply_to":"165ecbf7_0b000f6a","updated":"2022-10-13 10:20:58.000000000","message":"Done","commit_id":"bf6467290fc3505cb6c83a84a44a2d0ccbe5bbec"}],"kolla/image/build.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"07c1c13a4515c07e6ef900732c54e5a3f4205247","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        \"nova-spicehtml5proxy\",  # Missing spicehtml5 package"},{"line_number":108,"context_line":"        \"ovsdpdk\",               # Not supported on CentOS"},{"line_number":109,"context_line":"        \"tgtd\",                  # Not supported on CentOS 8"},{"line_number":110,"context_line":"        \"skyline\","},{"line_number":111,"context_line":"    },"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"278c198e_bf285f29","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":17},"updated":"2022-02-16 06:41:39.000000000","message":"missing comment why it\u0027s unbuildable","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"4cc94b96a1d54f47a9b10a6938dbb7df9a72a0a2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"nova-spicehtml5proxy\",  # Missing spicehtml5 package"},{"line_number":108,"context_line":"        \"ovsdpdk\",               # Not supported on CentOS"},{"line_number":109,"context_line":"        \"tgtd\",                  # Not supported on CentOS 8"},{"line_number":110,"context_line":"        \"skyline\","},{"line_number":111,"context_line":"    },"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"7740c766_fdcf8c95","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":17},"in_reply_to":"278c198e_bf285f29","updated":"2022-02-17 05:58:35.000000000","message":"Done","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"07c1c13a4515c07e6ef900732c54e5a3f4205247","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \u0027debian\u0027: {"},{"line_number":114,"context_line":"        \"qdrouterd\",     # no qdrouterd package in Debian bullseye"},{"line_number":115,"context_line":"        \"skyline\","},{"line_number":116,"context_line":"    },"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    \u0027ubuntu\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"2af0d8fb_f5ac09ae","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":17},"updated":"2022-02-16 06:41:39.000000000","message":"ditto","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":33196,"name":"conna","email":"yang.shaoxue@99cloud.net","username":"yangshaoxue"},"change_message_id":"4cc94b96a1d54f47a9b10a6938dbb7df9a72a0a2","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \u0027debian\u0027: {"},{"line_number":114,"context_line":"        \"qdrouterd\",     # no qdrouterd package in Debian bullseye"},{"line_number":115,"context_line":"        \"skyline\","},{"line_number":116,"context_line":"    },"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    \u0027ubuntu\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"ee4dc970_1b31c453","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":17},"in_reply_to":"2af0d8fb_f5ac09ae","updated":"2022-02-17 05:58:35.000000000","message":"Done","commit_id":"9f89c876ce9ebef36a39c3a83cd4d64db7517ecc"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"111b0ad876be24ded54ce57e1956cafd636126e0","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        \"nova-spicehtml5proxy\",  # Missing spicehtml5 package"},{"line_number":108,"context_line":"        \"ovsdpdk\",               # Not supported on CentOS"},{"line_number":109,"context_line":"        \"tgtd\",                  # Not supported on CentOS 8"},{"line_number":110,"context_line":"        \"skyline\",               # Not supported on CentOS"},{"line_number":111,"context_line":"    },"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":15,"id":"0ac253d4_ce7ded85","line":110,"range":{"start_line":110,"start_character":35,"end_line":110,"end_character":58},"updated":"2022-03-07 10:42:35.000000000","message":"Image uses only nginx from binary packages so what makes it not supported on CentOS?\n\nOther packages listed here miss needed binary packages.","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"9d67e8b02cbd0ee111078bc07aed9be61bc5c7dd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"nova-spicehtml5proxy\",  # Missing spicehtml5 package"},{"line_number":108,"context_line":"        \"ovsdpdk\",               # Not supported on CentOS"},{"line_number":109,"context_line":"        \"tgtd\",                  # Not supported on CentOS 8"},{"line_number":110,"context_line":"        \"skyline\",               # Not supported on CentOS"},{"line_number":111,"context_line":"    },"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":15,"id":"7de99fe9_eddf3fa0","line":110,"range":{"start_line":110,"start_character":35,"end_line":110,"end_character":58},"in_reply_to":"0ac253d4_ce7ded85","updated":"2022-05-27 06:48:14.000000000","message":"Ack","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06ad81dc910d001dfc8adb636eb1370a09cb0856","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        \"nova-spicehtml5proxy\",  # Missing spicehtml5 package"},{"line_number":92,"context_line":"        \"ovsdpdk\",               # Not supported on CentOS"},{"line_number":93,"context_line":"        \"tgtd\",                  # Not supported on CentOS 8"},{"line_number":94,"context_line":"        \"skyline\",               # Not supported on CentOS"},{"line_number":95,"context_line":"    },"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":18,"id":"810978ce_979d517e","line":94,"updated":"2022-05-30 08:20:02.000000000","message":"please sort alphabetically; also, a question: will it never be supported? what\u0027s the issue?","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \"nova-spicehtml5proxy\",  # Missing spicehtml5 package"},{"line_number":92,"context_line":"        \"ovsdpdk\",               # Not supported on CentOS"},{"line_number":93,"context_line":"        \"tgtd\",                  # Not supported on CentOS 8"},{"line_number":94,"context_line":"        \"skyline\",               # Not supported on CentOS"},{"line_number":95,"context_line":"    },"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":18,"id":"d4b5c808_f4727198","line":94,"in_reply_to":"810978ce_979d517e","updated":"2022-08-23 09:43:43.000000000","message":"We donot test in CentOS now. So just ignore on CentOS now.","commit_id":"603195f48114c004346b7d6ed29539d858fb7b26"}],"releasenotes/notes/add-skyline-200d1bca7907b00c.yaml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"111b0ad876be24ded54ce57e1956cafd636126e0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UE."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"da879c1b_60f98842","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":61},"updated":"2022-03-07 10:42:35.000000000","message":"UE or UX?","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"95325756e27267e1901c51a2fab0a74d81c24b1a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UE."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"eac61f08_0388f6d6","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":61},"in_reply_to":"2b0fc570_13f0d88b","updated":"2022-05-27 06:55:15.000000000","message":"that\u0027s normally referred to as UX, but whatever.","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"9d67e8b02cbd0ee111078bc07aed9be61bc5c7dd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UE."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"2b0fc570_13f0d88b","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":61},"in_reply_to":"da879c1b_60f98842","updated":"2022-05-27 06:48:14.000000000","message":"User Experience","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"91d06340fdcf5c895bce74ce129ec6b60e51bee1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UE."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"45bfe1c2_1e25f8e3","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":61},"in_reply_to":"eac61f08_0388f6d6","updated":"2022-08-23 09:43:43.000000000","message":"Ack","commit_id":"252c59e464e36d8a90c528c09bb91996d581d9cb"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"38f7143877addabf7b5321d0dc72379c6dd65594","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UE."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"cc100cd5_10ec6f5a","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":60},"updated":"2022-10-13 09:41:14.000000000","message":"UX","commit_id":"c75be0b41b3b490f87a37c3c53e8e6a533db42ed"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"94d7ac48bcd51410bafbd62f79a6733581b7c641","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UE."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e7262c8b_ad0c4766","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":60},"in_reply_to":"cc100cd5_10ec6f5a","updated":"2022-10-13 10:18:44.000000000","message":"Done","commit_id":"c75be0b41b3b490f87a37c3c53e8e6a533db42ed"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0de35fb237d8e2685d0435cddd3150ebb12d1a82","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UX."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"b7227498_c3c6e858","line":3,"updated":"2022-11-23 06:51:51.000000000","message":"This should mention both new containers now.","commit_id":"c27962261d95390fee0a30f5a6e1d0d662804183"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"62e7412e548d7d66827edb62671e4f6bacb55ff1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UX."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"11475ca9_985ce8f0","line":3,"in_reply_to":"b7227498_c3c6e858","updated":"2022-11-23 07:00:19.000000000","message":"Done","commit_id":"c27962261d95390fee0a30f5a6e1d0d662804183"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59dcfd6f9f23c5fdcda7d63ff667052c6c03e6a7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline(base, apiserver and console) Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UX."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"f9cc41fa_82379ae9","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":55},"updated":"2023-01-31 00:00:33.000000000","message":"image/s","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0869db9b165a51d140a162d9f28ffdb4924f6cc2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline(base, apiserver and console) Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UX."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"bacd9885_3e763b03","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":55},"in_reply_to":"54e6b371_f3cf5bfe","updated":"2023-01-31 03:04:34.000000000","message":"Done","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3c8640cf27bec538cdcb55d3328653076a8c6523","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skyline(base, apiserver and console) Dockerfile."},{"line_number":4,"context_line":"    Skyline is an OpenStack dashboard optimized by UI and UX."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"54e6b371_f3cf5bfe","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":55},"in_reply_to":"f9cc41fa_82379ae9","updated":"2023-01-31 01:17:49.000000000","message":"Hmm, I am not going to block it.","commit_id":"9d4736820f9c3dc589915acd6b0aaedfeaa68912"}]}