)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e69b6d444f92c225962819bdcba60d6b355df044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e423909f_2fb4f671","updated":"2022-02-16 11:58:01.000000000","message":"Hello wangxiyuan, as Marcin said we will likely not accept this patch as we are reducing the number of distros supported inside the images rather than expanding it. Instead, you might want to add openEuler as a supported host distro for Kolla Ansible - we require upstream CI testing but OpenDev already has the nodes for openEuler so you should be fine to add that. In case of questions, please join us on OFTC IRC in the #openstack-kolla channel and/or send a mail to the openstack-discuss mailing list.","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"bdd763a2092aa566d0f97ecdeed8cb9311a95489","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecf4d4f9_6d624c65","updated":"2022-02-16 11:32:23.000000000","message":"The current plan is to limit amount of supported distributions rather than expanding.","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eee5e486bca401d4357566d896b6f6180829c5e3","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{% endblock %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% if base_distro \u003d\u003d \u0027openeuler\u0027 %}"},{"line_number":21,"context_line":"RUN yum install -y shadow-utils"},{"line_number":22,"context_line":"{% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{# NOTE(SamYaple): Avoid uid/gid conflicts by creating each user/group up front. #}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b23227e2_eca9d91b","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":7},"updated":"2022-02-16 11:39:44.000000000","message":"Why yum? In other place you mark dnf as package manager.\n\nAlso missing NOTE why it is needed here.","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eee5e486bca401d4357566d896b6f6180829c5e3","unresolved":true,"context_lines":[{"line_number":68,"context_line":"{% endblock %}"},{"line_number":69,"context_line":"{% endblock %}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"{% if base_distro \u003d\u003d \u0027openeuler\u0027 %}"},{"line_number":72,"context_line":"{% set base_openeuler_packages \u003d ["},{"line_number":73,"context_line":"    \u0027dnf-plugins-core\u0027,"},{"line_number":74,"context_line":"    \u0027glibc-all-langpacks\u0027,"},{"line_number":75,"context_line":"    \u0027ca-certificates\u0027,"},{"line_number":76,"context_line":"    \u0027curl\u0027,"},{"line_number":77,"context_line":"    \u0027findutils\u0027,"},{"line_number":78,"context_line":"    \u0027hostname\u0027,"},{"line_number":79,"context_line":"    \u0027iproute\u0027,"},{"line_number":80,"context_line":"    \u0027iscsi-initiator-utils\u0027,"},{"line_number":81,"context_line":"    \u0027lsof\u0027,"},{"line_number":82,"context_line":"    \u0027lvm2\u0027,"},{"line_number":83,"context_line":"    \u0027ncurses\u0027,"},{"line_number":84,"context_line":"    \u0027procps-ng\u0027,"},{"line_number":85,"context_line":"    \u0027python3\u0027,"},{"line_number":86,"context_line":"    \u0027python3-pip\u0027,"},{"line_number":87,"context_line":"    \u0027socat\u0027,"},{"line_number":88,"context_line":"    \u0027sudo\u0027,"},{"line_number":89,"context_line":"    \u0027tar\u0027,"},{"line_number":90,"context_line":"    \u0027util-linux-user\u0027,"},{"line_number":91,"context_line":"    \u0027which\u0027"},{"line_number":92,"context_line":"] %}"},{"line_number":93,"context_line":"RUN {{ macros.install_packages(base_openeuler_packages | customizable(\"openeuler_packages\"), chain\u003dTrue, clean\u003dFalse) }} \\"},{"line_number":94,"context_line":"    \u0026\u0026 {{ macros.rpm_security_update(clean_package_cache) }}"},{"line_number":95,"context_line":"{% else %}"},{"line_number":96,"context_line":"#### BEGIN REPO ENABLEMENT"},{"line_number":97,"context_line":"{% set base_yum_repo_files \u003d ["},{"line_number":98,"context_line":"    \u0027elasticsearch.repo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5d109436_b81204f1","line":95,"range":{"start_line":71,"start_character":0,"end_line":95,"end_character":10},"updated":"2022-02-16 11:39:44.000000000","message":"I would rather prefer to see openeuler to reuse centos list","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eee5e486bca401d4357566d896b6f6180829c5e3","unresolved":true,"context_lines":[{"line_number":260,"context_line":"# Install base packages"},{"line_number":261,"context_line":"{{ macros.install_packages( base_centos_packages | customizable(\"centos_packages\") | customizable(\"centos_binary_packages\") | customizable(\"centos_source_packages\") ) }}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"{# endif for base_openeuler_packages #}"},{"line_number":264,"context_line":"{%- endif %}"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"{# endif for base_package_type rpm #}"},{"line_number":267,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"cc1f7531_cdda700f","line":264,"range":{"start_line":263,"start_character":0,"end_line":264,"end_character":12},"updated":"2022-02-16 11:39:44.000000000","message":"?","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"}],"docker/keystone/keystone-base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eee5e486bca401d4357566d896b6f6180829c5e3","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    {% endif %}"},{"line_number":43,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":44,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":45,"context_line":"        {% if base_distro \u003d\u003d \u0027openeuler\u0027 %}"},{"line_number":46,"context_line":"            {% set keystone_base_packages \u003d ["},{"line_number":47,"context_line":"                \u0027cyrus-sasl-devel\u0027,"},{"line_number":48,"context_line":"                \u0027openldap-devel\u0027,"},{"line_number":49,"context_line":"            ] %}"},{"line_number":50,"context_line":"        {% else %}"},{"line_number":51,"context_line":"            {% set keystone_base_packages \u003d ["},{"line_number":52,"context_line":"                \u0027cyrus-sasl-devel\u0027,"},{"line_number":53,"context_line":"                \u0027mod_auth_mellon\u0027,"},{"line_number":54,"context_line":"                \u0027mod_auth_openidc\u0027,"},{"line_number":55,"context_line":"                \u0027openldap-devel\u0027,"},{"line_number":56,"context_line":"            ] %}"},{"line_number":57,"context_line":"RUN dnf module enable mod_auth_openidc -y"},{"line_number":58,"context_line":"        {% endif %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{{ macros.install_packages(keystone_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"560f8420_450d6d4a","line":57,"range":{"start_line":44,"start_character":0,"end_line":57,"end_character":41},"updated":"2022-02-16 11:39:44.000000000","message":"1. set base list and expand it for centos\n2. you enable not installed module on openeuler","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eee5e486bca401d4357566d896b6f6180829c5e3","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    {% if base_distro \u003d\u003d \u0027openeuler\u0027 %}"},{"line_number":40,"context_line":"        {% set kolla_toolbox_packages \u003d kolla_toolbox_packages + ["},{"line_number":41,"context_line":"            \u0027python3-crudini\u0027,"},{"line_number":42,"context_line":"            \u0027erlang\u0027,"},{"line_number":43,"context_line":"            \u0027rabbitmq-server\u0027"},{"line_number":44,"context_line":"        ] %}"},{"line_number":45,"context_line":"    {% else %}"},{"line_number":46,"context_line":"        {% set kolla_toolbox_packages \u003d kolla_toolbox_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"81b680f9_27ac6c5e","line":43,"range":{"start_line":42,"start_character":10,"end_line":43,"end_character":29},"updated":"2022-02-16 11:39:44.000000000","message":"which versions are on openeuler?","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"}],"docker/rabbitmq/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eee5e486bca401d4357566d896b6f6180829c5e3","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block rabbitmq_install_plugins %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"{% if base_distro \u003d\u003d \u0027openeuler\u0027 %}"},{"line_number":51,"context_line":"RUN rm -rf /var/lib/rabbitmq/* \\"},{"line_number":52,"context_line":"    \u0026\u0026 mkdir -p /usr/lib/rabbitmq/plugins \\"},{"line_number":53,"context_line":"    \u0026\u0026 /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \\"},{"line_number":54,"context_line":"       rabbitmq_management"},{"line_number":55,"context_line":"{% else %}"},{"line_number":56,"context_line":"RUN rm -rf /var/lib/rabbitmq/* \\"},{"line_number":57,"context_line":"    \u0026\u0026 mkdir -p /usr/lib/rabbitmq/plugins \\"},{"line_number":58,"context_line":"    \u0026\u0026 /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \\"},{"line_number":59,"context_line":"       rabbitmq_management \\"},{"line_number":60,"context_line":"       rabbitmq_prometheus"},{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% endblock %}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"8b3c5fb5_4f62480b","line":61,"range":{"start_line":50,"start_character":0,"end_line":61,"end_character":11},"updated":"2022-02-16 11:39:44.000000000","message":"handle rabbitmq_prometheus part rather than whole block?","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"}],"kolla/template/methods.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eee5e486bca401d4357566d896b6f6180829c5e3","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            # NOTE(hrw): Fallback to distro list"},{"line_number":111,"context_line":"            repo_list \u003d repo_data[base_distro]"},{"line_number":112,"context_line":"        except KeyError:"},{"line_number":113,"context_line":"            # There is no need to update the distro repo"},{"line_number":114,"context_line":"            reponames \u003d []"},{"line_number":115,"context_line":"    for repo in reponames:"},{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            if base_package_type \u003d\u003d \u0027rpm\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b8aa3e70_ae339c8d","line":114,"range":{"start_line":112,"start_character":1,"end_line":114,"end_character":26},"updated":"2022-02-16 11:39:44.000000000","message":"reponames are provided as argument so cleaning them should not be needed","commit_id":"3e69627d08347bc1f295adab20933d123c6a6215"}]}