)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cf96542f61d31055cced6d880578254a5fcaf88c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openstack-base: remove less popular packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All packages used by 10 or less images were dropped."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I495b931acf474aaa43798c96cbd7a074855ee0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"162d908e_558f4c68","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":23},"updated":"2022-03-30 08:57:28.000000000","message":"This seems like a high threshold. When building all images together these packages would be installed 10 times rather than 1.","commit_id":"c2adf670481c15fb409ca5cefda2440a83714c80"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"28959f26eb29ba8f6dfc33f5163cae9de23a4022","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openstack-base: remove less popular packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All packages used by 10 or less images were dropped."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I495b931acf474aaa43798c96cbd7a074855ee0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"37bc342e_9a847a71","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":23},"in_reply_to":"162d908e_558f4c68","updated":"2022-03-30 09:36:15.000000000","message":"Build time is not much changed. And such package is in 10 images (and their children) instead of 50+ children of openstack-base.","commit_id":"c2adf670481c15fb409ca5cefda2440a83714c80"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4e1b6d0c8c2de2b0b5de83b5fec9b9698073424e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openstack-base: remove less popular packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All packages used by 10 or less images were dropped."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I495b931acf474aaa43798c96cbd7a074855ee0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"816a135d_0e52dcf5","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":23},"in_reply_to":"37bc342e_9a847a71","updated":"2022-03-30 09:43:46.000000000","message":"Yes, but as always there is a trade off here. Size of a complete set of images with shared layers, vs. size of a complete set of images without shared layers. By removing these packages you are optimising for the latter, at the expense of the former.\n\nWhat would be useful to know is, do these 10 images have any shared history beyond openstack-base? e.g. if there is a package used in all nova images, could we move it to nova-base?","commit_id":"c2adf670481c15fb409ca5cefda2440a83714c80"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5c68f60d147c981b311bf978c51d6ab2ce3da124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff11a81e_0594cde7","updated":"2022-03-29 17:28:50.000000000","message":"I emptied the list in openstack-base and build everything. Then just grepped logs and counted.","commit_id":"99344cea7d7547ea8216e29756de4d1c8bebbc9e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4386b5ab21fb9cadfb6973aed89af364d27fbb05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"459f9c77_548a4fdd","updated":"2022-03-29 17:28:12.000000000","message":"Uses \u0027name\u0027\n\n00  \u0027contextlib2\u0027\n00  \u0027funcsigs\u0027\n00  \u0027pika\u0027\n00  \u0027pyngus\u0027\n00  \u0027python-editor\u0027\n00  \u0027python-qpid-proton\u0027\n00  \u0027unicodecsv\u0027\n01  \u0027aodhclient\u0027\n01  \u0027python-cloudkittyclient\u0027\n01  \u0027PyYAML\u0027\n02  \u0027python-magnumclient\u0027\n02  \u0027python-memcached\u0027\n02  \u0027python-muranoclient\u0027\n02  \u0027python-saharaclient\u0027\n02  \u0027python-vitrageclient\u0027\n02  \u0027six\u0027\n03  \u0027elasticsearch\u0027\n03  \u0027oslo.config\u0027\n03  \u0027oslo.vmware\u0027\n03  \u0027python-ironicclient\u0027\n03  \u0027python-manilaclient\u0027\n03  \u0027python-troveclient\u0027\n03  \u0027requests\u0027\n04  \u0027gnocchiclient\u0027\n04  \u0027monotonic\u0027\n05  \u0027os-brick\u0027\n05  \u0027retrying\u0027\n06  \u0027python-designateclient\u0027\n07  \u0027os-win\u0027\n07  \u0027pymysql\u0027\n07  \u0027pyroute2\u0027\n07  \u0027python-mistralclient\u0027\n07  \u0027python-openstackclient\u0027\n08  \u0027automaton\u0027\n08  \u0027httplib2\u0027\n08  \u0027paramiko\u0027\n08  \u0027PyNaCl\u0027\n10  \u0027click\u0027\n10  \u0027os-traits\u0027\n10  \u0027python-heatclient\u0027\n10  \u0027simplegeneric\u0027\n10  \u0027WSME\u0027","commit_id":"99344cea7d7547ea8216e29756de4d1c8bebbc9e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"119de291dcd46ddedc7aa50c48ba9d29fc8e83ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e329bb3c_f350dc41","updated":"2022-03-30 07:25:33.000000000","message":"dogpile.cache.exception.PluginNotFound: Couldn\u0027t find cache plugin to load: oslo_cache.memcache_pool\n\nWhich confirms some of these may be implicit and thus you are removing stuff we and other users might be relying on.\n\nOn the other hand, removing packages like \"six\" makes total sense.","commit_id":"a32117a4af3d0b4658b72c762c6643cf55a6f13f"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab2321a9ac4c3877d3b0d393a121e478fcb22e44","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        \u0027os-traits\u0027,"},{"line_number":244,"context_line":"        \u0027os-win\u0027,"},{"line_number":245,"context_line":"        \u0027oslo.concurrency\u0027,"},{"line_number":246,"context_line":"        \u0027oslo.config\u0027,"},{"line_number":247,"context_line":"        \u0027oslo.context\u0027,"},{"line_number":248,"context_line":"        \u0027oslo.db\u0027,"},{"line_number":249,"context_line":"        \u0027oslo.i18n\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7c325260_1634e592","side":"PARENT","line":246,"range":{"start_line":246,"start_character":9,"end_line":246,"end_character":20},"updated":"2022-03-30 11:10:02.000000000","message":"This should be in many images","commit_id":"c572fc61d02071a4fc5a950d12b783e9b8a998ae"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab2321a9ac4c3877d3b0d393a121e478fcb22e44","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        \u0027python-vitrageclient\u0027,"},{"line_number":299,"context_line":"        \u0027pytz\u0027,"},{"line_number":300,"context_line":"        \u0027repoze.lru\u0027,"},{"line_number":301,"context_line":"        \u0027requests\u0027,"},{"line_number":302,"context_line":"        \u0027requestsexceptions\u0027,"},{"line_number":303,"context_line":"        \u0027retrying\u0027,"},{"line_number":304,"context_line":"        \u0027setproctitle\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"4aec8280_a509ca25","side":"PARENT","line":301,"range":{"start_line":301,"start_character":9,"end_line":301,"end_character":17},"updated":"2022-03-30 11:10:02.000000000","message":"This is used quite a lot.","commit_id":"c572fc61d02071a4fc5a950d12b783e9b8a998ae"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab2321a9ac4c3877d3b0d393a121e478fcb22e44","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        \u0027setproctitle\u0027,"},{"line_number":305,"context_line":"        \u0027simplegeneric\u0027,"},{"line_number":306,"context_line":"        \u0027simplejson\u0027,"},{"line_number":307,"context_line":"        \u0027six\u0027,"},{"line_number":308,"context_line":"        \u0027sqlalchemy-migrate\u0027,"},{"line_number":309,"context_line":"        \u0027sqlparse\u0027,"},{"line_number":310,"context_line":"        \u0027stevedore\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"64bdfddb_b3724bcb","side":"PARENT","line":307,"range":{"start_line":307,"start_character":9,"end_line":307,"end_character":12},"updated":"2022-03-30 11:10:02.000000000","message":"Hard to believe only 2 images use it. Maybe it comes in as a distro package.","commit_id":"c572fc61d02071a4fc5a950d12b783e9b8a998ae"}]}
