)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ba85727169303187923957947a4f1bdc11cab6ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Shearer \u003ctshearer@advaoptical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-01 16:49:54 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set correct file permissions on kolla_extend_start binary in kolla-toolbox image."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c2deb4a2e33575d57c852089f856a9acc6818d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ee3e4094_627ba785","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":81},"updated":"2022-04-05 15:17:17.000000000","message":"Nit: could you make the subject line shorter?","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":29771,"name":"Tim Shearer","email":"tshearer@advaoptical.com","username":"timmins"},"change_message_id":"9c59acb60ac4478e9ba33159391a69f43f5c4f4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Shearer \u003ctshearer@advaoptical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-01 16:49:54 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set correct file permissions on kolla_extend_start binary in kolla-toolbox image."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c2deb4a2e33575d57c852089f856a9acc6818d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"87db8ad4_477b126f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":81},"in_reply_to":"ee3e4094_627ba785","updated":"2022-04-05 16:31:18.000000000","message":"Ack","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e6e54c379106bdecf42100bd0100647bef23b83e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b626057_528b6358","updated":"2022-04-04 19:20:57.000000000","message":"any bugs this fixes?","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":29771,"name":"Tim Shearer","email":"tshearer@advaoptical.com","username":"timmins"},"change_message_id":"97f13447c909e27e982cf8f1763103af6afd5f5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19c90e47_d4b9f435","in_reply_to":"0b626057_528b6358","updated":"2022-04-05 03:02:37.000000000","message":"I didn\u0027t create a bug against it, but I\u0027m happy to do so - just let me know.\n\nWithout the fix, our Kolla have startup issues because it is not executable:\n   -rw-r-----. 1 root root 348 Jan 1 1970 kolla_extend_start\n\nShould also mention the Toolbox Dockerfile is the only one missing the chmod on kolla_extend_start.\n\n\nThanks!","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a0e77a15df50ddd32261bae43f1aead6de6dc8c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a31b87c9_7772a6db","in_reply_to":"19c90e47_d4b9f435","updated":"2022-04-05 08:30:18.000000000","message":"Well, these files are sourced, not executed, so the executable bit is irrelevant. I don\u0027t think we should make this one executable, we should rather drop the executable bit from the others. ;-)","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7a0a301c1e831bc810ede2a98162eab1b419ddb3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8fac92e_49eec081","in_reply_to":"41aaa15c_7f96a189","updated":"2022-04-05 14:15:05.000000000","message":"Yes, that sounds sensible, but may be quite a bit of work. Let\u0027s just set 644 in here (and is not it the usual default? are you getting something else?).","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":29771,"name":"Tim Shearer","email":"tshearer@advaoptical.com","username":"timmins"},"change_message_id":"ea25d0ce132c85b955275077440a75ea2fc0d5ad","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41aaa15c_7f96a189","in_reply_to":"a31b87c9_7772a6db","updated":"2022-04-05 13:49:13.000000000","message":"You\u0027re correct, the file needs to be explicitly set readable by the \"other\" permission level (chmod o+r) or else it can\u0027t be sourced. So a change is still needed here, albeit without the executable bits.\n\nFor consistency, I can change the kolla_extend_start permissions to  644 across all the Dockerfiles (subject to testing, obviously). Sound ok? Thanks!","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ba85727169303187923957947a4f1bdc11cab6ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa1d3e48_cf799887","in_reply_to":"a8fac92e_49eec081","updated":"2022-04-05 15:17:17.000000000","message":"I wonder if this is the result of using a non-default umask?","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":29771,"name":"Tim Shearer","email":"tshearer@advaoptical.com","username":"timmins"},"change_message_id":"9c59acb60ac4478e9ba33159391a69f43f5c4f4e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1df292cd_b282f049","in_reply_to":"aa1d3e48_cf799887","updated":"2022-04-05 16:31:18.000000000","message":"It does appear to be umask related. We have private Kolla builds that are fine, and Jenkins builds with 640 permissions on this file.\n\nEither way, it seems prudent to update the kolla-toolbox, just because it\u0027s the outlier (only Dockerfile without the explicit chmod).\n\nI have surveyed/updated all the chmods to 644 for \"extend\" startup files and am currently testing. Happy to submit all, or just limit it to the toolbox :)","commit_id":"7034cc73d6f4bee6d68cdba7ae98c5606fceb515"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"64be020fdf927caf91ed8d5be3447f01985b15c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d07c9146_93185117","updated":"2022-04-11 10:33:38.000000000","message":"check experimental","commit_id":"6ef9cbeb2e261290590b8adf883b98353789e241"},{"author":{"_account_id":29771,"name":"Tim Shearer","email":"tshearer@advaoptical.com","username":"timmins"},"change_message_id":"19484cbfb5be129d118854aa9d5d3728ce039f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"06720b62_15a5b394","in_reply_to":"b153b703_a97654c2","updated":"2022-04-11 11:28:44.000000000","message":"Happy to help!","commit_id":"6ef9cbeb2e261290590b8adf883b98353789e241"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"86be44241532523a1828fab459a968a7d2bd2ca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b153b703_a97654c2","in_reply_to":"d07c9146_93185117","updated":"2022-04-11 10:34:21.000000000","message":"I am running these extra tests to err on the safer side but I think this patch is good. Thank you for working on this.","commit_id":"6ef9cbeb2e261290590b8adf883b98353789e241"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"28b60ea5b2a63e72f85851d0cf71bc3634d53f40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2ffb1984_e869bdb5","updated":"2022-04-11 15:22:49.000000000","message":"I fixed the merge conflict and already applied the followup.","commit_id":"1d96a2bbe1b536b7d7f4cdbf55c6dabae6d058ae"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"64be020fdf927caf91ed8d5be3447f01985b15c5","unresolved":true,"context_lines":[{"line_number":384,"context_line":"{% endif %}"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"RUN touch /usr/local/bin/kolla_extend_start \\"},{"line_number":387,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_start /usr/local/bin/kolla_set_configs /usr/local/bin/kolla_copy_cacerts /usr/local/bin/kolla_httpd_setup \\"},{"line_number":388,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start \\"},{"line_number":389,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":390,"context_line":"    \u0026\u0026 mkdir -p /var/log/kolla \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b18d4242_d8aa8e94","line":387,"range":{"start_line":387,"start_character":126,"end_line":387,"end_character":144},"updated":"2022-04-11 10:33:38.000000000","message":"this one behaves like kolla_extend_start so it is best moved to the next line (as a followup please)","commit_id":"6ef9cbeb2e261290590b8adf883b98353789e241"},{"author":{"_account_id":29771,"name":"Tim Shearer","email":"tshearer@advaoptical.com","username":"timmins"},"change_message_id":"19484cbfb5be129d118854aa9d5d3728ce039f56","unresolved":false,"context_lines":[{"line_number":384,"context_line":"{% endif %}"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"RUN touch /usr/local/bin/kolla_extend_start \\"},{"line_number":387,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_start /usr/local/bin/kolla_set_configs /usr/local/bin/kolla_copy_cacerts /usr/local/bin/kolla_httpd_setup \\"},{"line_number":388,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start \\"},{"line_number":389,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":390,"context_line":"    \u0026\u0026 mkdir -p /var/log/kolla \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"2d38f548_777209d6","line":387,"range":{"start_line":387,"start_character":126,"end_line":387,"end_character":144},"in_reply_to":"b18d4242_d8aa8e94","updated":"2022-04-11 11:28:44.000000000","message":"Ack","commit_id":"6ef9cbeb2e261290590b8adf883b98353789e241"}]}