)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"19b5fe7f5a92fe7b107d39d63313348471823e27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8144ec2_d93772e3","updated":"2022-05-03 08:47:17.000000000","message":"Nice idea","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"613e801fdd59c820a18bfde3496aa4e4188ff8e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d72cfa5_827cb7b3","updated":"2022-05-13 12:58:19.000000000","message":"approving per 2x CR+2; new image tags, here we go!","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5769dee50c5d4ef9cbf32a25ab71a2c527aecb15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26896a21_f7b9ccdb","in_reply_to":"e8144ec2_d93772e3","updated":"2022-05-04 14:32:41.000000000","message":"Thank you.","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"}],"kolla/image/build.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a686f5720af076a87ef5e4b876c386d63e112609","unresolved":true,"context_lines":[{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        self.clean_package_cache \u003d self.conf.clean_package_cache"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"        if self.conf.use_new_naming_scheme:"},{"line_number":651,"context_line":"            self.image_prefix \u003d \u0027\u0027"},{"line_number":652,"context_line":"        else:"},{"line_number":653,"context_line":"            self.image_prefix \u003d self.base + \u0027-\u0027"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"        self.regex \u003d conf.regex"},{"line_number":656,"context_line":"        self.image_statuses_bad \u003d dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"99988676_20d1a1ca","line":653,"range":{"start_line":650,"start_character":0,"end_line":653,"end_character":47},"updated":"2022-05-05 08:20:05.000000000","message":"(kolla) 10:18 (s) marcin@puchatek:kolla$ git diff\ndiff --git a/kolla/image/build.py b/kolla/image/build.py\nindex a186ba4b8..83d216c6a 100755\n--- a/kolla/image/build.py\n+++ b/kolla/image/build.py\n@@ -609,7 +609,6 @@ class KollaWorker(object):\n         self.base \u003d conf.base\n         self.use_dumb_init \u003d conf.use_dumb_init\n         self.base_tag \u003d conf.base_tag\n-        self.tag \u003d conf.tag\n         self.base_arch \u003d conf.base_arch\n         self.debian_arch \u003d self.base_arch\n         if self.base_arch \u003d\u003d \u0027aarch64\u0027:\n@@ -647,10 +646,13 @@ class KollaWorker(object):\n\n         self.clean_package_cache \u003d self.conf.clean_package_cache\n\n+        self.base_distro_version \u003d \u0027bullseye\u0027\n         if self.conf.use_new_naming_scheme:\n             self.image_prefix \u003d \u0027\u0027\n+            self.tag \u003d f\"{self.base}-{self.base_distro_version}-{conf.tag}\"\n         else:\n             self.image_prefix \u003d self.base + \u0027-\u0027\n+            self.tag \u003d conf.tag\n\n         self.regex \u003d conf.regex\n         self.image_statuses_bad \u003d dict()\n(kolla) 10:18 (s) marcin@puchatek:kolla$\n\nBut that\u0027s requires base_distro_version being present somewhere.","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"}],"tests/playbooks/run.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"19b5fe7f5a92fe7b107d39d63313348471823e27","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        kolla_publisher_config:"},{"line_number":28,"context_line":"          DEFAULT:"},{"line_number":29,"context_line":"            namespace: \"{{ kolla_namespace }}\""},{"line_number":30,"context_line":"            tag: \"{{ (zuul.branch | basename) ~ base_distro ~ base_distro_version ~ tag_suffix }}\""},{"line_number":31,"context_line":"            use_new_naming_scheme: true"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        kolla_build_config: \"{{ kolla_build_config | combine(kolla_publisher_config, recursive\u003dTrue) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fbecc27_1b7e0401","line":30,"updated":"2022-05-03 08:47:17.000000000","message":"Shouldn\u0027t kolla generate this?","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"613e801fdd59c820a18bfde3496aa4e4188ff8e4","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        kolla_publisher_config:"},{"line_number":28,"context_line":"          DEFAULT:"},{"line_number":29,"context_line":"            namespace: \"{{ kolla_namespace }}\""},{"line_number":30,"context_line":"            tag: \"{{ (zuul.branch | basename) ~ base_distro ~ base_distro_version ~ tag_suffix }}\""},{"line_number":31,"context_line":"            use_new_naming_scheme: true"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        kolla_build_config: \"{{ kolla_build_config | combine(kolla_publisher_config, recursive\u003dTrue) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d0377035_02e7e0d0","line":30,"in_reply_to":"13cf73b0_d0fd0a26","updated":"2022-05-13 12:58:19.000000000","message":"Could you elaborate on the \"piece\" you mention?","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"95dfb42ee3813c5577e41d974a0b572c16d31f45","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        kolla_publisher_config:"},{"line_number":28,"context_line":"          DEFAULT:"},{"line_number":29,"context_line":"            namespace: \"{{ kolla_namespace }}\""},{"line_number":30,"context_line":"            tag: \"{{ (zuul.branch | basename) ~ base_distro ~ base_distro_version ~ tag_suffix }}\""},{"line_number":31,"context_line":"            use_new_naming_scheme: true"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        kolla_build_config: \"{{ kolla_build_config | combine(kolla_publisher_config, recursive\u003dTrue) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b2555455_59bbc4b9","line":30,"in_reply_to":"5fbecc27_1b7e0401","updated":"2022-05-04 14:32:30.000000000","message":"As I said in the reply to Marcin - one step a time - it was not doing this, so it\u0027s yet another change to be done. I would gladly discuss further steps. For now though, let\u0027s merge this one.","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c3b405f14d0ed0315c8eb903608ba18dd715b9d6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        kolla_publisher_config:"},{"line_number":28,"context_line":"          DEFAULT:"},{"line_number":29,"context_line":"            namespace: \"{{ kolla_namespace }}\""},{"line_number":30,"context_line":"            tag: \"{{ (zuul.branch | basename) ~ base_distro ~ base_distro_version ~ tag_suffix }}\""},{"line_number":31,"context_line":"            use_new_naming_scheme: true"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        kolla_build_config: \"{{ kolla_build_config | combine(kolla_publisher_config, recursive\u003dTrue) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13cf73b0_d0fd0a26","line":30,"in_reply_to":"b2555455_59bbc4b9","updated":"2022-05-13 10:34:48.000000000","message":"Hmm, can you provide another patch where kolla is generating also tag \u003copenstack_release\u003e-\u003cbase_distro\u003e-\u003cbase_distro_version\u003e-\u003carch_suffix\u003e and add to this patchset stack ?\n\nI\u0027ve already reviewed and test this patch and it\u0027s nice, but from my perspective this should be merged when we will have also another piece for tag, not only for image name.\n\nBut when I am thinking about it, as new-naming-scheme is by default false.. it doesn\u0027t matter.","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"342b5183ccecd3f74f578fac5ed4a4727734d944","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        kolla_publisher_config:"},{"line_number":28,"context_line":"          DEFAULT:"},{"line_number":29,"context_line":"            namespace: \"{{ kolla_namespace }}\""},{"line_number":30,"context_line":"            tag: \"{{ (zuul.branch | basename) ~ base_distro ~ base_distro_version ~ tag_suffix }}\""},{"line_number":31,"context_line":"            use_new_naming_scheme: true"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        kolla_build_config: \"{{ kolla_build_config | combine(kolla_publisher_config, recursive\u003dTrue) }}\""},{"line_number":34,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9c5ae5a0_44a36745","line":31,"range":{"start_line":30,"start_character":1,"end_line":31,"end_character":39},"updated":"2022-05-02 09:14:56.000000000","message":"I would like to get tag set on non-ci builds too.","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0e5653a5d4c38292a14f9b75b3a829e0f947792e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        kolla_publisher_config:"},{"line_number":28,"context_line":"          DEFAULT:"},{"line_number":29,"context_line":"            namespace: \"{{ kolla_namespace }}\""},{"line_number":30,"context_line":"            tag: \"{{ (zuul.branch | basename) ~ base_distro ~ base_distro_version ~ tag_suffix }}\""},{"line_number":31,"context_line":"            use_new_naming_scheme: true"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        kolla_build_config: \"{{ kolla_build_config | combine(kolla_publisher_config, recursive\u003dTrue) }}\""},{"line_number":34,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"422c0416_b3f28775","line":31,"range":{"start_line":30,"start_character":1,"end_line":31,"end_character":39},"in_reply_to":"9c5ae5a0_44a36745","updated":"2022-05-02 09:16:57.000000000","message":"well, non-ci has a funny default, not sure if anyone relies on it though, we can improve this in the next step","commit_id":"1e40f08e6c9d0dc5093d89b1c588b178c2f93e08"}]}