)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c66c346e84f4c19558ae63bc8fcb901da6085926","unresolved":true,"context_lines":[{"line_number":26,"context_line":"Therefore redis containers are always restarted"},{"line_number":27,"context_line":"by kolla-ansible. This patch is fixing this."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I8245b9e753fa4175dacfa679a078f63876b0d327"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d1fffc5c_5d97f2f2","line":29,"updated":"2022-05-07 10:03:40.000000000","message":"Closes this bug https://bugs.launchpad.net/kolla-ansible/+bug/1967664\n\nIf you read ansible logs carefully, you will come to the conclusions from that bug report - only sentinel needs this special handling. The other container is restarted simply because of the Ansible quirk.","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"959544882b957bab11929d3f01098a873b3dbf32","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Therefore redis containers are always restarted"},{"line_number":27,"context_line":"by kolla-ansible. This patch is fixing this."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I8245b9e753fa4175dacfa679a078f63876b0d327"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6ed2ef7a_53b2f023","line":29,"in_reply_to":"d1fffc5c_5d97f2f2","updated":"2022-05-10 07:44:01.000000000","message":"Done","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0526f6defcc6d232ffd0a7d6f922374612428ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-10 09:40:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix redis containers always reporting changed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The CONFIG REWRITE command rewrites the redis.conf"},{"line_number":10,"context_line":"file the server was started with, applying the minimal"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ca106771_d16f3990","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":20},"updated":"2022-05-11 13:38:52.000000000","message":"redis-sentinel","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4a79de5b7536b0886cf007b8fab968a39d666994","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-10 09:40:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix redis containers always reporting changed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The CONFIG REWRITE command rewrites the redis.conf"},{"line_number":10,"context_line":"file the server was started with, applying the minimal"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"88a0c305_36702013","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":20},"in_reply_to":"ca106771_d16f3990","updated":"2022-05-11 15:11:38.000000000","message":"Done","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"358f8bbba9879b9797b1ae22f8a8b9203bac0f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87e13ad1_c9fd4e1d","updated":"2022-05-06 16:12:29.000000000","message":"(redis-sentinel)[root@ceph2 /]# diff -u /etc/redis/redis.conf /etc/redis/redis-regenerated-by-config-rewrite.conf \n--- /etc/redis/redis.conf\t2022-05-06 15:44:49.482701712 +0000\n+++ /etc/redis/redis-regenerated-by-config-rewrite.conf\t2022-05-06 15:44:52.246771210 +0000\n@@ -4,8 +4,19 @@\n bind 192.168.205.102\n port 26379\n sentinel myid 5269a2186acc47d7980d82e096461d827d3f59ee\n+sentinel deny-scripts-reconfig yes\n sentinel monitor kolla 192.168.205.100 6379 2\n-sentinel auth-pass kolla SECRET\n sentinel down-after-milliseconds kolla 5000\n sentinel failover-timeout kolla 60000\n-sentinel parallel-syncs kolla 1\n+sentinel auth-pass kolla SECRET\n+# Generated by CONFIG REWRITE\n+protected-mode no\n+user default on nopass ~* +@all\n+dir \"/\"\n+sentinel config-epoch kolla 0\n+sentinel leader-epoch kolla 0\n+sentinel known-replica kolla 192.168.205.102 6379\n+sentinel known-replica kolla 192.168.205.101 6379\n+sentinel known-sentinel kolla 192.168.205.101 26379 d3897b31fd498abd4bffd43a2887d6437622cb07\n+sentinel known-sentinel kolla 192.168.205.100 26379 5e7b716e84ca45368734029edda1088801cc4521\n+sentinel current-epoch 0\n","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7230982c065354629ea3a611ed096f229c03dd75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a10d053_aaee8cb0","updated":"2022-05-10 07:47:13.000000000","message":"k-a part: https://review.opendev.org/c/openstack/kolla-ansible/+/841219","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ca03be88cf9e8d94aa7038afe0d814a61c7bc06d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8a6a2fc3_8079a868","updated":"2022-05-12 12:10:50.000000000","message":"For now I uploaded version with 755 permissions as it is everywhere.","commit_id":"e4199e7fb176d1f8d25070060d48ab8720086cfe"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a7dc131889c8e92a6fe9758814793292384f79a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4a5ef603_33de4b31","updated":"2022-05-17 09:27:26.000000000","message":"recheck","commit_id":"e4199e7fb176d1f8d25070060d48ab8720086cfe"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"22801d9f4518be21f1c34f60eae71baecf8bf51d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf778739_10d761fe","updated":"2022-05-17 11:28:58.000000000","message":"recheck","commit_id":"e4199e7fb176d1f8d25070060d48ab8720086cfe"}],"docker/redis/redis-base/extend_start.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c66c346e84f4c19558ae63bc8fcb901da6085926","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# even if configuration is not changed from"},{"line_number":29,"context_line":"# kolla-ansible side."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONFIG_PATH\u003d$(echo ${CMD} | sed -e \u0027s|\\(.*\\)\\(/etc/redis/.*conf\\)\\(.*\\)|\\2|g\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"561e1903_d04643c2","line":31,"updated":"2022-05-07 10:03:40.000000000","message":"this we can send from kolla-ansible via an environment variable","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"959544882b957bab11929d3f01098a873b3dbf32","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# even if configuration is not changed from"},{"line_number":29,"context_line":"# kolla-ansible side."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONFIG_PATH\u003d$(echo ${CMD} | sed -e \u0027s|\\(.*\\)\\(/etc/redis/.*conf\\)\\(.*\\)|\\2|g\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"2364d200_9af749fb","line":31,"in_reply_to":"561e1903_d04643c2","updated":"2022-05-10 07:44:01.000000000","message":"Done","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c66c346e84f4c19558ae63bc8fcb901da6085926","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONFIG_PATH\u003d$(echo ${CMD} | sed -e \u0027s|\\(.*\\)\\(/etc/redis/.*conf\\)\\(.*\\)|\\2|g\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"649905e8_7cd5735b","line":33,"updated":"2022-05-07 10:03:40.000000000","message":"this variable is added needlessly","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"959544882b957bab11929d3f01098a873b3dbf32","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONFIG_PATH\u003d$(echo ${CMD} | sed -e \u0027s|\\(.*\\)\\(/etc/redis/.*conf\\)\\(.*\\)|\\2|g\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"f779403f_d2b8f3e0","line":33,"in_reply_to":"649905e8_7cd5735b","updated":"2022-05-10 07:44:01.000000000","message":"Done","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c66c346e84f4c19558ae63bc8fcb901da6085926","unresolved":true,"context_lines":[{"line_number":31,"context_line":"CONFIG_PATH\u003d$(echo ${CMD} | sed -e \u0027s|\\(.*\\)\\(/etc/redis/.*conf\\)\\(.*\\)|\\2|g\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"4b73854b_8b8e6bd3","line":34,"updated":"2022-05-07 10:03:40.000000000","message":"this we can also set from kolla-ansible","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"959544882b957bab11929d3f01098a873b3dbf32","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONFIG_PATH\u003d$(echo ${CMD} | sed -e \u0027s|\\(.*\\)\\(/etc/redis/.*conf\\)\\(.*\\)|\\2|g\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"b3b86d6b_1c159817","line":34,"in_reply_to":"4b73854b_8b8e6bd3","updated":"2022-05-10 07:44:01.000000000","message":"Done","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c66c346e84f4c19558ae63bc8fcb901da6085926","unresolved":true,"context_lines":[{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NEW_CMD\u003d$(echo ${CMD} | sed -e \"s|${ORIG_CONFIG_PATH}|${REDIS_GENERATED_CONFIG_PATH}|g\")"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"dedcf494_0750d7ac","line":36,"updated":"2022-05-07 10:03:40.000000000","message":"only this needs to stay, and only for the sentinel container","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"959544882b957bab11929d3f01098a873b3dbf32","unresolved":false,"context_lines":[{"line_number":33,"context_line":"ORIG_CONFIG_PATH\u003d\"${CONFIG_PATH}\""},{"line_number":34,"context_line":"REDIS_GENERATED_CONFIG_PATH\u003d$(echo $CONFIG_PATH | sed -e \u0027s/\\(.*\\)\\(\\.conf\\)/\\1-regenerated-by-config-rewrite\\2/g\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NEW_CMD\u003d$(echo ${CMD} | sed -e \"s|${ORIG_CONFIG_PATH}|${REDIS_GENERATED_CONFIG_PATH}|g\")"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"13d948a5_a7530a5b","line":36,"in_reply_to":"dedcf494_0750d7ac","updated":"2022-05-10 07:44:01.000000000","message":"Done","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c66c346e84f4c19558ae63bc8fcb901da6085926","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NEW_CMD\u003d$(echo ${CMD} | sed -e \"s|${ORIG_CONFIG_PATH}|${REDIS_GENERATED_CONFIG_PATH}|g\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CMD\u003d\"${NEW_CMD}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"78cc5800_27a88dd2","line":38,"updated":"2022-05-07 10:03:40.000000000","message":"kolla-ansible can already use this new path to config file","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"959544882b957bab11929d3f01098a873b3dbf32","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cp ${ORIG_CONFIG_PATH} ${REDIS_GENERATED_CONFIG_PATH}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NEW_CMD\u003d$(echo ${CMD} | sed -e \"s|${ORIG_CONFIG_PATH}|${REDIS_GENERATED_CONFIG_PATH}|g\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CMD\u003d\"${NEW_CMD}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"56751389_500523da","line":38,"in_reply_to":"78cc5800_27a88dd2","updated":"2022-05-10 07:44:01.000000000","message":"Done","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c66c346e84f4c19558ae63bc8fcb901da6085926","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NEW_CMD\u003d$(echo ${CMD} | sed -e \"s|${ORIG_CONFIG_PATH}|${REDIS_GENERATED_CONFIG_PATH}|g\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CMD\u003d\"${NEW_CMD}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"2d42b9ac_96b714be","line":40,"updated":"2022-05-07 10:03:40.000000000","message":"then you would not need to do this","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"959544882b957bab11929d3f01098a873b3dbf32","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"NEW_CMD\u003d$(echo ${CMD} | sed -e \"s|${ORIG_CONFIG_PATH}|${REDIS_GENERATED_CONFIG_PATH}|g\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CMD\u003d\"${NEW_CMD}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"6e5ee2aa_89f2ea63","line":40,"in_reply_to":"2d42b9ac_96b714be","updated":"2022-05-10 07:44:01.000000000","message":"Done","commit_id":"96d873711cf1f44491f1d7bd59f900c7397830e4"}],"docker/redis/redis-sentinel/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0526f6defcc6d232ffd0a7d6f922374612428ff","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{ macros.install_packages(redis_sentinel_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block redis_sentinel_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"cb361252_a03e0890","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":14},"updated":"2022-05-11 13:38:52.000000000","message":"644","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c087e5fc6d555f03199e10f0055a4b6272253760","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{ macros.install_packages(redis_sentinel_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block redis_sentinel_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"75a0410c_4f3bcd12","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":14},"in_reply_to":"2eb4979e_fd4f7b8f","updated":"2022-05-12 07:07:37.000000000","message":"644 here","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"128253be691786705de79c8a643e5ffd5140afc9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{{ macros.install_packages(redis_sentinel_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block redis_sentinel_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ca987e97_172f9fd5","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":14},"in_reply_to":"75a0410c_4f3bcd12","updated":"2022-05-12 13:49:05.000000000","message":"Done","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4a79de5b7536b0886cf007b8fab968a39d666994","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{{ macros.install_packages(redis_sentinel_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block redis_sentinel_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"2eb4979e_fd4f7b8f","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":14},"in_reply_to":"cb361252_a03e0890","updated":"2022-05-11 15:11:38.000000000","message":"Done","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"}],"docker/redis/redis-sentinel/extend_start.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0526f6defcc6d232ffd0a7d6f922374612428ff","unresolved":true,"context_lines":[{"line_number":24,"context_line":"# /usr/local/bin/kolla_set_configs --check"},{"line_number":25,"context_line":"# is always reporting changed."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# Therefore redis containers are always restarted"},{"line_number":28,"context_line":"# even if configuration is not changed from"},{"line_number":29,"context_line":"# kolla-ansible side."},{"line_number":30,"context_line":"if [ ! -z \"${REDIS_CONF}\" ] \u0026\u0026 [ ! -z ${REDIS_GEN_CONF} ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"303cb4ee_dbc29f08","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":32},"updated":"2022-05-11 13:38:52.000000000","message":"redis-sentinel is","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4a79de5b7536b0886cf007b8fab968a39d666994","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# /usr/local/bin/kolla_set_configs --check"},{"line_number":25,"context_line":"# is always reporting changed."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# Therefore redis containers are always restarted"},{"line_number":28,"context_line":"# even if configuration is not changed from"},{"line_number":29,"context_line":"# kolla-ansible side."},{"line_number":30,"context_line":"if [ ! -z \"${REDIS_CONF}\" ] \u0026\u0026 [ ! -z ${REDIS_GEN_CONF} ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dbdeb3b7_dd290902","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":32},"in_reply_to":"303cb4ee_dbc29f08","updated":"2022-05-11 15:11:38.000000000","message":"Done","commit_id":"68c8254fcf6a0df390c5a540ea925a2c75ca041c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c087e5fc6d555f03199e10f0055a4b6272253760","unresolved":true,"context_lines":[{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [[ $(stat -c %a /var/log/kolla/redis) !\u003d \"755\" ]]; then"},{"line_number":8,"context_line":"    chmod 644 /var/log/kolla/redis"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The CONFIG REWRITE command rewrites the redis.conf"}],"source_content_type":"text/x-sh","patch_set":3,"id":"df1f346f_d7696485","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":14},"updated":"2022-05-12 07:07:37.000000000","message":"755 here","commit_id":"c327177aace57f7b1200dbf7a1a75b9b3cf821c5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"128253be691786705de79c8a643e5ffd5140afc9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [[ $(stat -c %a /var/log/kolla/redis) !\u003d \"755\" ]]; then"},{"line_number":8,"context_line":"    chmod 644 /var/log/kolla/redis"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The CONFIG REWRITE command rewrites the redis.conf"}],"source_content_type":"text/x-sh","patch_set":3,"id":"a8d6c147_d9dd7ed3","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":14},"in_reply_to":"a8caf023_3d5d30a7","updated":"2022-05-12 13:49:05.000000000","message":"Yeah, you mixed up something before but now it\u0027s good, thanks.","commit_id":"c327177aace57f7b1200dbf7a1a75b9b3cf821c5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4738130f58f824800a5a8b151d43d8c32d5b1f1e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [[ $(stat -c %a /var/log/kolla/redis) !\u003d \"755\" ]]; then"},{"line_number":8,"context_line":"    chmod 644 /var/log/kolla/redis"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The CONFIG REWRITE command rewrites the redis.conf"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dd5ae962_c82756e4","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":14},"in_reply_to":"b0e8b8d5_ee2edfe1","updated":"2022-05-12 12:07:39.000000000","message":"Hmm, ok 644 for log is ok.\nBut why everywhere (*all* images) it\u0027s 755 ? \n\n755 permissions has also redis-base, so if I am replacing kolla_extend_start from redis-base by new one. I should copy what was inherited from redis-base + my code.\n \nmichalarbet@pixla:~/ultimum/git/upstream/kolla$ grep -Ri \u0027stat .*var/log\u0027 | grep redis\ndocker/redis/redis-base/extend_start.sh:if [[ $(stat -c %a /var/log/kolla/redis) !\u003d \"755\" ]]; then\ndocker/redis/redis-sentinel/extend_start.sh:if [[ $(stat -c %a /var/log/kolla/redis) !\u003d \"755\" ]]; then\n\nSo, should I change both to 644 ?\nNo image has 644 for log dir.","commit_id":"c327177aace57f7b1200dbf7a1a75b9b3cf821c5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2493dd74e09da63640226b489f823f8c707b0b99","unresolved":true,"context_lines":[{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [[ $(stat -c %a /var/log/kolla/redis) !\u003d \"755\" ]]; then"},{"line_number":8,"context_line":"    chmod 644 /var/log/kolla/redis"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The CONFIG REWRITE command rewrites the redis.conf"}],"source_content_type":"text/x-sh","patch_set":3,"id":"a8caf023_3d5d30a7","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":14},"in_reply_to":"dd5ae962_c82756e4","updated":"2022-05-12 12:11:35.000000000","message":"Ok, maybe I didn\u0027t understood :) ... now it is ok I hope.","commit_id":"c327177aace57f7b1200dbf7a1a75b9b3cf821c5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b76a089a811d34facd8477695865fe2da9b9a26b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [[ $(stat -c %a /var/log/kolla/redis) !\u003d \"755\" ]]; then"},{"line_number":8,"context_line":"    chmod 644 /var/log/kolla/redis"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The CONFIG REWRITE command rewrites the redis.conf"}],"source_content_type":"text/x-sh","patch_set":3,"id":"b0e8b8d5_ee2edfe1","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":14},"in_reply_to":"df1f346f_d7696485","updated":"2022-05-12 07:26:57.000000000","message":"still 755 missing","commit_id":"c327177aace57f7b1200dbf7a1a75b9b3cf821c5"}]}