)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d272d4512e4873866877db861719b7ff83a4af18","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix local sources of git repositories"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is I2cbf1f539880d512aa223c3ef3a4b19ee18854ac extended to fix"},{"line_number":10,"context_line":"the case when a git repository is used with a git repo."},{"line_number":11,"context_line":"This is probably a rarer use case but, still, we use it in CI"},{"line_number":12,"context_line":"for in-review changes testing."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"172d4243_3cffee8e","line":10,"updated":"2022-05-18 15:22:31.000000000","message":"\"repo\" for me is just short for \"repository\", so this sentence seems weird. do you mean \"... is used from a local checkout\"?","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f0b4f53788e370373276b38b0b4bfaf0be7b17c1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix local sources of git repositories"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is I2cbf1f539880d512aa223c3ef3a4b19ee18854ac extended to fix"},{"line_number":10,"context_line":"the case when a git repository is used with a git repo."},{"line_number":11,"context_line":"This is probably a rarer use case but, still, we use it in CI"},{"line_number":12,"context_line":"for in-review changes testing."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"453c8c69_14f45a70","line":10,"in_reply_to":"172d4243_3cffee8e","updated":"2022-05-18 15:29:52.000000000","message":"Yeah, a local checkout of a repository which is often just called a repo as well.","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"83dd8e12792e1c61da44e17eacd2aa6321a879e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0838130c_34d7f823","updated":"2022-05-18 15:24:34.000000000","message":"Passed https://zuul.opendev.org/t/openstack/build/b762acf91dc445b3806893d30ce22361","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f0b4f53788e370373276b38b0b4bfaf0be7b17c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd91cd8d_04a208d2","updated":"2022-05-18 15:29:52.000000000","message":"Thansk for quick review.","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"08f1e525f1749b2d79898b0f1e197ce30bac0247","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1aa2f300_282313e4","updated":"2022-05-18 14:22:12.000000000","message":"breaks testing in bifrost CI","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d272d4512e4873866877db861719b7ff83a4af18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ead7a664_4aa9abd2","updated":"2022-05-18 15:22:31.000000000","message":"lgtm in general, waiting for test result, questions inline","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"baaa524610b09511da567090ae594bee7363e892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d756eee8_6cc6e4e6","updated":"2022-05-18 14:22:49.000000000","message":"testing it in https://review.opendev.org/c/openstack/bifrost/+/842332","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"}],"kolla/image/build.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d272d4512e4873866877db861719b7ff83a4af18","unresolved":true,"context_lines":[{"line_number":328,"context_line":"        # avoids an issue introduced by the fix for git CVE-2022-24765,"},{"line_number":329,"context_line":"        # which breaks PBR when the source checkout is not owned by the"},{"line_number":330,"context_line":"        # user installing it. LP#1969096"},{"line_number":331,"context_line":"        def reset_userinfo(tarinfo):"},{"line_number":332,"context_line":"            tarinfo.uid \u003d tarinfo.gid \u003d 0"},{"line_number":333,"context_line":"            tarinfo.uname \u003d tarinfo.gname \u003d \"root\""},{"line_number":334,"context_line":"            return tarinfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1a88257_0e914719","line":331,"updated":"2022-05-18 15:22:31.000000000","message":"If you move this away from right next to where it is being used, can we make it a static function, possibly even outside of the class scope?","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3b3c450b715f64a7fa6dec998c2081e4397759d6","unresolved":true,"context_lines":[{"line_number":328,"context_line":"        # avoids an issue introduced by the fix for git CVE-2022-24765,"},{"line_number":329,"context_line":"        # which breaks PBR when the source checkout is not owned by the"},{"line_number":330,"context_line":"        # user installing it. LP#1969096"},{"line_number":331,"context_line":"        def reset_userinfo(tarinfo):"},{"line_number":332,"context_line":"            tarinfo.uid \u003d tarinfo.gid \u003d 0"},{"line_number":333,"context_line":"            tarinfo.uname \u003d tarinfo.gname \u003d \"root\""},{"line_number":334,"context_line":"            return tarinfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d564fab_04a181b5","line":331,"in_reply_to":"23ae6838_42679b0e","updated":"2022-05-18 15:42:01.000000000","message":"We use it only here so I am with Radek on it.","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f0b4f53788e370373276b38b0b4bfaf0be7b17c1","unresolved":true,"context_lines":[{"line_number":328,"context_line":"        # avoids an issue introduced by the fix for git CVE-2022-24765,"},{"line_number":329,"context_line":"        # which breaks PBR when the source checkout is not owned by the"},{"line_number":330,"context_line":"        # user installing it. LP#1969096"},{"line_number":331,"context_line":"        def reset_userinfo(tarinfo):"},{"line_number":332,"context_line":"            tarinfo.uid \u003d tarinfo.gid \u003d 0"},{"line_number":333,"context_line":"            tarinfo.uname \u003d tarinfo.gname \u003d \"root\""},{"line_number":334,"context_line":"            return tarinfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"23ae6838_42679b0e","line":331,"in_reply_to":"f1a88257_0e914719","updated":"2022-05-18 15:29:52.000000000","message":"I guess? Let\u0027s wait if others have comments. I would merge it as it is and worry another time.","commit_id":"b888f68daf6cb3ed9782fe85045858b6a04d4911"}]}