)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7a6b5eb3433748f970913805cad53cc54077124d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Marcin Juszkiewicz \u003cmarcin.juszkiewicz+kolla@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-01 17:17:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to overwrite repos.yaml file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Several people use Kolla behind firewall/proxy. Internal mirrors are"},{"line_number":10,"context_line":"often in use then. We do not provide a way to replace repos.yaml file in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f549cab0_47c64ce1","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":18},"updated":"2022-06-02 09:31:44.000000000","message":"use user-supplied? overwrite seems a bit destructive ;-)","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2cdc5b779dc16c92842977f775a010366beae68d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marcin Juszkiewicz \u003cmarcin.juszkiewicz+kolla@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-01 17:17:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to overwrite repos.yaml file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Several people use Kolla behind firewall/proxy. Internal mirrors are"},{"line_number":10,"context_line":"often in use then. We do not provide a way to replace repos.yaml file in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2c1833ac_180dfe6c","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":18},"in_reply_to":"f549cab0_47c64ce1","updated":"2022-06-02 09:47:45.000000000","message":"Done","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"79382c1ceae311f98b45cd4d711c9cdf074c46ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98cde0b5_b8b0a87c","updated":"2022-06-01 15:54:25.000000000","message":"I would argue if calling it repos-yaml is not overly verbose but meh.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7a6b5eb3433748f970913805cad53cc54077124d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"efadfedc_73515c91","updated":"2022-06-02 09:31:44.000000000","message":"Overall looks fine, but we need some docs on this.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"db0f4acd0e0850545f66223e2c320bda23161cb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b842f9f8_6fb1dc7a","updated":"2022-06-02 09:19:26.000000000","message":"may be we need to use merge_yaml here to merge original with custom files?","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"19baa2e0c849ae99b88446d4b51e2794a76b92e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58fe3ef0_9b15861e","updated":"2022-06-02 09:13:11.000000000","message":"recheck","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0866b60bdee2d5541551edb8338ae6af614a2f0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a49f7e5e_0935d294","updated":"2022-06-01 23:45:01.000000000","message":"the good idea to solve the issue proposed in https://review.opendev.org/c/openstack/kolla/+/842472\nbut! there is no way to do this as IaC in Kayobe (for example)","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"46f5ae3f3f1bd729b7df7252fd2ac8b3fd650ee9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d61bbddd_a8cbef02","in_reply_to":"08c13c28_71bbb1b4","updated":"2022-06-02 08:46:55.000000000","message":"Kayobe needs Kolla to run Kolla. Kayobe can learn where the original file is. Kayobe can then use it as it sees fit. I find the solution on Kolla\u0027s side to be perfect as it is.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cfbfd2efff8a8c6fd67a025dbc6b088f2de4032d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08c13c28_71bbb1b4","in_reply_to":"29be3b84_da3e40ed","updated":"2022-06-02 08:38:21.000000000","message":"yep, but kayobe need the copy of the same file. and then we need to support the file in the several repos.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"aac992580ff46289025eef62f4acdccd1d28a716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a24aa76_1dc54f89","in_reply_to":"407dac5f_844010d2","updated":"2022-06-02 09:51:37.000000000","message":"I wrote handle_repos() function with assumption that not every \"repo name\" needs to be present in every distribution. Debian/Ubuntu does not have EPEL for example.\n\nUsers are also free to have own set of repos defined directly in base image and ignore repos.yaml funtionality by providing empty file.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c25c2cdfcf6ca9efeac50909ede73dff31e8c1c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a208453c_9b47c4b0","in_reply_to":"77f66ac9_3ea99b9e","updated":"2022-06-02 09:17:04.000000000","message":"Marcin: I\u0027m ok with this as a separate solution, not trying to simplify \"new syntax overkill\" in my change. Kolla is required component for Kayobe, so my change to solve issue on the both sides.\nRadosław: what is Your proposal to use merge_yaml from the \u0027overcloud container image build\u0027 command?","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6a3ef6a8662264ce5cf7e4a79097606cbdb80089","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2fd768f7_6220a790","in_reply_to":"98cde0b5_b8b0a87c","updated":"2022-06-01 16:06:24.000000000","message":"This patch is kind of \u0027proof of concept\u0027 so suggestions/renames are very welcome.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5db7dd7f75637462974fb6aa1db82878dc6b4fda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4386e8b_29f07f8c","in_reply_to":"9fbb57e7_2878bc7d","updated":"2022-06-02 09:27:46.000000000","message":"but what the best? modify original file from kayobe or call kolla-build with extra option which merges data to file? may be we need extend this prior merge as is?","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"28c10bee0b3f51bf3a858ebf83afbebda74e97f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b717f208_a069e533","in_reply_to":"a208453c_9b47c4b0","updated":"2022-06-02 09:22:17.000000000","message":"I\u0027m not going to propose it but basically you can make Kayobe find the original repos.yaml (Kayobe knows the path to Kolla), then use merge_yaml with your additional input and use that file in kolla-build call.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c29aeebc0dd51fdbd15ad64cb90104b90c4276c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0ccdd51_ea017993","in_reply_to":"a49f7e5e_0935d294","updated":"2022-06-02 08:13:48.000000000","message":"How come? You can generate the yaml.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ad6a22624c205028d62dc6a2350cd73f6289c3ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29be3b84_da3e40ed","in_reply_to":"b5612cc4_ea91625d","updated":"2022-06-02 08:29:32.000000000","message":"Well, kayobe can do that with merge_yaml.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"28c10bee0b3f51bf3a858ebf83afbebda74e97f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fbb57e7_2878bc7d","in_reply_to":"b842f9f8_6fb1dc7a","updated":"2022-06-02 09:22:17.000000000","message":"Makes sense, you can propose this extended approach.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b5beed2f720205c3f4f7462f1ba4aab3b4654379","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5612cc4_ea91625d","in_reply_to":"c0ccdd51_ea017993","updated":"2022-06-02 08:28:02.000000000","message":"same way I can modify the original file in separate branch and use it.\nmy idea was to override parts of the data via variable in the kolla.yaml","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3996e557d6deb62f3657378b286ab36a35a5a566","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"407dac5f_844010d2","in_reply_to":"c4386e8b_29f07f8c","updated":"2022-06-02 09:34:49.000000000","message":"I think it\u0027s valid that in air-gapped env a user would anyway overwrite all the details so this is the most straightforward way to do it. Personally, I would not bother with complicating and simply handle this externally (like you in Kayobe). What could be useful, however, is to have some Kolla signalling if a repo is missing - so that new repos do not go unnoticed. This could be a separate mode, or a config param.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e85184ab1934bd0e2329124d11f1930440a89675","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77f66ac9_3ea99b9e","in_reply_to":"d61bbddd_a8cbef02","updated":"2022-06-02 09:06:53.000000000","message":"Maksim: Kayobe is not required component to use Kolla/Kolla-Ansible.\n\nAbility to provide own repos.yaml is helpful to those building in \"offline\" environments.\n\nThrough all those years of my Kolla use I never used Kayobe - my all-in-one (or all-in-one + compute) setups do not need it\u0027s functionality.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2cdc5b779dc16c92842977f775a010366beae68d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d0726f4_66036f7a","in_reply_to":"efadfedc_73515c91","updated":"2022-06-02 09:47:45.000000000","message":"reno added","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a7dc0c0919e044d1692c7d46f0658e9a406eb3f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61746f73_cd19eb06","updated":"2022-06-06 09:02:35.000000000","message":"-1 Documentation please!","commit_id":"213190ae030e9971225ea3f103b4be0a7f2532d4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4d730d3f271c4c10d3f23512c46059b1b008ea3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3438c186_f2201040","updated":"2022-06-02 09:52:53.000000000","message":"what about doc/source/admin/image-building.rst block [Custom repos] ?, it seems that it\u0027s not actual and should be changed.","commit_id":"213190ae030e9971225ea3f103b4be0a7f2532d4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2357f02d706d8d24b3cc460917754bf279e12f8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d985045_b50f96fa","in_reply_to":"3438c186_f2201040","updated":"2022-06-02 10:05:32.000000000","message":"It needs to be expanded. What is there is still valid, just we assume that no one is using it (backward compatibility).","commit_id":"213190ae030e9971225ea3f103b4be0a7f2532d4"}],"kolla/common/config.py":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"48a78a402e5912ffdadd60b95101578749f251ea","unresolved":true,"context_lines":[{"line_number":252,"context_line":"    cfg.StrOpt(\u0027image-name-prefix\u0027, default\u003d\u0027\u0027,"},{"line_number":253,"context_line":"               help\u003d\u0027Prefix prepended to image names\u0027),"},{"line_number":254,"context_line":"    cfg.StrOpt(\u0027repos-yaml\u0027, default\u003d\u0027\u0027,"},{"line_number":255,"context_line":"               help\u003d\u0027Path to alternative repos.yaml file\u0027),"},{"line_number":256,"context_line":"]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"d20111ba_20234404","line":255,"range":{"start_line":255,"start_character":21,"end_line":255,"end_character":56},"updated":"2022-06-02 09:49:09.000000000","message":"I think this should be reworded somehow to let user knoew exactly that this repos.yaml path will not be added to existing kolla built-in repos.yaml but it will be replacing that one. If no, i am ok also with this version.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a0413dac29bf5cde7b08ad82c588463590d09f7d","unresolved":true,"context_lines":[{"line_number":252,"context_line":"    cfg.StrOpt(\u0027image-name-prefix\u0027, default\u003d\u0027\u0027,"},{"line_number":253,"context_line":"               help\u003d\u0027Prefix prepended to image names\u0027),"},{"line_number":254,"context_line":"    cfg.StrOpt(\u0027repos-yaml\u0027, default\u003d\u0027\u0027,"},{"line_number":255,"context_line":"               help\u003d\u0027Path to alternative repos.yaml file\u0027),"},{"line_number":256,"context_line":"]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ebb2fc9e_c3e59b93","line":255,"range":{"start_line":255,"start_character":21,"end_line":255,"end_character":56},"in_reply_to":"d20111ba_20234404","updated":"2022-06-02 09:53:11.000000000","message":"That\u0027s what \"alternative file\" sounds to me - file which will be used instead of original.\n\nBut my English grammar was never proper.","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"664330dde5f0264b7a347f94d93e422609f3b8ee","unresolved":true,"context_lines":[{"line_number":252,"context_line":"    cfg.StrOpt(\u0027image-name-prefix\u0027, default\u003d\u0027\u0027,"},{"line_number":253,"context_line":"               help\u003d\u0027Prefix prepended to image names\u0027),"},{"line_number":254,"context_line":"    cfg.StrOpt(\u0027repos-yaml\u0027, default\u003d\u0027\u0027,"},{"line_number":255,"context_line":"               help\u003d\u0027Path to alternative repos.yaml file\u0027),"},{"line_number":256,"context_line":"]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"a1635e75_cdb77013","line":255,"range":{"start_line":255,"start_character":21,"end_line":255,"end_character":56},"in_reply_to":"ebb2fc9e_c3e59b93","updated":"2022-06-02 09:55:14.000000000","message":"HH, mine is also not good :)","commit_id":"7dbab755048497471faa6335e98361f4c2c31b10"}]}