)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"82f9303716748f690f6c20f4ef5d3cce75da5092","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9636847b_b0ceda8b","updated":"2022-08-25 11:29:02.000000000","message":"an alternative has been proposed with https://review.opendev.org/c/openstack/kolla-ansible/+/839715\n\nbut this default seems sane and can be made overridable with k-a as well without limiting fds","commit_id":"ca67946df6e2e70a6cd1d12cb6d8439481edf44a"}],"docker/rabbitmq/Dockerfile.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"51c6dabeb5ca3450316dadf8937de8d76eee5e66","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{{ macros.enable_extra_repos([\u0027erlang\u0027, \u0027powertools\u0027, \u0027rabbitmq\u0027]) }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{#"},{"line_number":20,"context_line":"NOTE(hrw): On RHEL9 family hosts we have 1.073.741.816 file descriptors"},{"line_number":21,"context_line":"available. This results in 1.6GB memory use by Erlang."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Let limit amount of those."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5167726b_abecbe14","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":54},"updated":"2022-08-25 11:48:59.000000000","message":"Use commas to distinguish from decimal point?","commit_id":"ca67946df6e2e70a6cd1d12cb6d8439481edf44a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"627aeff73c360c96e4ff29e6e529aaf80556d6a3","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{{ macros.enable_extra_repos([\u0027erlang\u0027, \u0027powertools\u0027, \u0027rabbitmq\u0027]) }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{#"},{"line_number":20,"context_line":"NOTE(hrw): On RHEL9 family hosts we have 1.073.741.816 file descriptors"},{"line_number":21,"context_line":"available. This results in 1.6GB memory use by Erlang."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Let limit amount of those."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"86e41836_69922ce8","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":54},"in_reply_to":"48d994dd_ab4a803b","updated":"2022-08-25 12:12:32.000000000","message":"Right, but since you use 1.6GB below, rather than 1,6GB like in France or Germany, you are already making a choice. I just found it confusing to have the same character used for two different purposes in the same paragraph.","commit_id":"ca67946df6e2e70a6cd1d12cb6d8439481edf44a"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b2f03a1f918957a4b2706bb5403c0890e6ea441d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{{ macros.enable_extra_repos([\u0027erlang\u0027, \u0027powertools\u0027, \u0027rabbitmq\u0027]) }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{#"},{"line_number":20,"context_line":"NOTE(hrw): On RHEL9 family hosts we have 1.073.741.816 file descriptors"},{"line_number":21,"context_line":"available. This results in 1.6GB memory use by Erlang."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Let limit amount of those."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"48d994dd_ab4a803b","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":54},"in_reply_to":"5167726b_abecbe14","updated":"2022-08-25 12:00:58.000000000","message":"Each country has own way of split big numbers into parts. I asume that people think.\n\n1,073,741,816 would confuse someone else\n1 073 741 816 can be confusing to another person\n1073741816 is unreadable to anyone","commit_id":"ca67946df6e2e70a6cd1d12cb6d8439481edf44a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"707c44fb95df9855c53a1255a4405667e1120e8f","unresolved":true,"context_lines":[{"line_number":25,"context_line":"See https://github.com/rabbitmq/erlang-rpm/discussions/104 for discussion."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#}"},{"line_number":28,"context_line":"ENV ERL_MAX_PORTS 100000"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block rabbitmq_install %}"},{"line_number":31,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"95378f5e_94e9d110","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":24},"updated":"2022-08-25 12:18:30.000000000","message":"Do we need to set that in Dockerfile instead of allow users to set it in kolla-ansible? I even used the nofile ulimit for that in the kolla-ansible EL9 patch.","commit_id":"ca67946df6e2e70a6cd1d12cb6d8439481edf44a"}]}