)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0a623036fe268c0858fbe1c9897065416d0e1fa8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Hoai-Thu Vuong \u003cthuvh87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-18 10:12:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove unused variable in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If42a89642f0322c52bed44f402a8dcbb9c0a9bd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"297fa197_7894be9d","line":7,"updated":"2022-11-18 10:43:51.000000000","message":"You are not removing anything, just renaming. IMO this is a minor style issue not worth patching.","commit_id":"035118ca950c67bc15782311ac038881d51b8bf0"},{"author":{"_account_id":13114,"name":"Hoai-Thu Vuong","email":"thuvh87@gmail.com","username":"thuvh"},"change_message_id":"34349ca1f57d316aa471e37d6bbaf2a67c8f6984","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Hoai-Thu Vuong \u003cthuvh87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-18 10:12:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove unused variable in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If42a89642f0322c52bed44f402a8dcbb9c0a9bd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f05df03b_af0221ec","line":7,"in_reply_to":"133be9e1_21057c49","updated":"2022-11-20 07:30:08.000000000","message":"I think, it\u0027s easier to read and understand if you don\u0027t care about unused variable. I updated the commit message. If this pr is bad, I\u0027m happy to close it.","commit_id":"035118ca950c67bc15782311ac038881d51b8bf0"},{"author":{"_account_id":13114,"name":"Hoai-Thu Vuong","email":"thuvh87@gmail.com","username":"thuvh"},"change_message_id":"a09362d9ee6174911e822b1f47009d133c0c7485","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Hoai-Thu Vuong \u003cthuvh87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-18 10:12:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove unused variable in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If42a89642f0322c52bed44f402a8dcbb9c0a9bd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d168a80c_1ef14b3d","line":7,"in_reply_to":"297fa197_7894be9d","updated":"2022-11-18 10:59:44.000000000","message":"Yep, this patch fixes typo only. Some document (PEP 640, stackoverflow, ..) recommends use underscore for unused variable.\n\nhttps://peps.python.org/pep-0640/","commit_id":"035118ca950c67bc15782311ac038881d51b8bf0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f3e45e3fc3cdee63db697052a661882214bef32c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Hoai-Thu Vuong \u003cthuvh87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-18 10:12:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove unused variable in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If42a89642f0322c52bed44f402a8dcbb9c0a9bd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"133be9e1_21057c49","line":7,"in_reply_to":"d168a80c_1ef14b3d","updated":"2022-11-18 11:18:28.000000000","message":"PEP 640 is rejected. It also wanted to move away from using \"_\".\n\nI don\u0027t question that \"_\" is a slightly nicer name for unused variables, I just question that it is good enough a reason to touch existing working code. And at a minimum the commit message should be correct about what the patch is doing.","commit_id":"035118ca950c67bc15782311ac038881d51b8bf0"},{"author":{"_account_id":13114,"name":"Hoai-Thu Vuong","email":"thuvh87@gmail.com","username":"thuvh"},"change_message_id":"dad2d9fda81e6d694161787bd77ebd8d0a47a54b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hoai-Thu Vuong \u003cthuvh87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-18 10:12:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove unused variable in loop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If42a89642f0322c52bed44f402a8dcbb9c0a9bd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"87e07942_317ac0a1","line":7,"in_reply_to":"f05df03b_af0221ec","updated":"2022-12-23 17:58:44.000000000","message":"Done","commit_id":"035118ca950c67bc15782311ac038881d51b8bf0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0a623036fe268c0858fbe1c9897065416d0e1fa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d3ac6735_718ff128","updated":"2022-11-18 10:43:51.000000000","message":"The CI issues are indeed unrelated, you can ignore them for now, but please see my comment inline.","commit_id":"035118ca950c67bc15782311ac038881d51b8bf0"},{"author":{"_account_id":13114,"name":"Hoai-Thu Vuong","email":"thuvh87@gmail.com","username":"thuvh"},"change_message_id":"0a9675b5881ed56a64a064c3849425dae0081cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef3be7d0_0de26d5a","updated":"2022-11-18 10:31:39.000000000","message":"don\u0027t know why ci failed. Run success on local.","commit_id":"035118ca950c67bc15782311ac038881d51b8bf0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a013545ae97b04961bae974de8aa2ca9cba4125f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64558bf0_902d52c1","updated":"2023-01-31 01:30:15.000000000","message":"recheck","commit_id":"b8ebae9e37ddcf53576b1e24d993a6e76b886b0c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"601fd22fb355748557ce953fefea8d18499bf11d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4e64303_a3f8b5b6","updated":"2023-01-31 04:12:16.000000000","message":"recheck","commit_id":"b8ebae9e37ddcf53576b1e24d993a6e76b886b0c"}]}
