)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"c111189fc8a6b38b38f07eec46c81d281e97082d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3e7e6fb0_12667f82","updated":"2023-04-07 13:37:22.000000000","message":"how about that one?\n./docker/neutron/neutron-mlnx-agent/Dockerfile.j2:24:RUN sed -e \"s/^pyzmq\u003d\u003d\u003d20.0.0/pyzmq\u003d\u003d21.*/g\" -i /requirements/upper-constraints.txt \\","commit_id":"3e2180c2ff017c98cfd713d8f3be6ef173780f9e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"128923239d2c3d51ad8d35605d31aec84e3488d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d3cca2ff_3ffab03d","in_reply_to":"3e7e6fb0_12667f82","updated":"2023-04-07 15:40:54.000000000","message":"Ah, that one was merged in meantime. Patch needs rebasing.","commit_id":"3e2180c2ff017c98cfd713d8f3be6ef173780f9e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"96ca04fcbcd0196ba343a2f1c4bfe5296e6715c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1592bc65_5277663a","in_reply_to":"d3cca2ff_3ffab03d","updated":"2023-04-12 16:33:28.000000000","message":"Done","commit_id":"3e2180c2ff017c98cfd713d8f3be6ef173780f9e"}],"docker/ceilometer/ceilometer-base/Dockerfile.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"16bd41db62c6cf7a2b2abe09ab3e9658becf8a20","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(egonzalez): Remove ceilometer from constraint or will fail."},{"line_number":27,"context_line":"RUN ln -s ceilometer-base-source/* ceilometer \\"},{"line_number":28,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ceilometer\u003d\u003d\u003d\") }} \\"},{"line_number":29,"context_line":"    \u0026\u0026 {{ macros.install_pip(ceilometer_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":30,"context_line":"    \u0026\u0026 mkdir -p /etc/ceilometer \\"},{"line_number":31,"context_line":"    \u0026\u0026 cp -r /ceilometer/etc/ceilometer/* /etc/ceilometer/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"d040fa08_bb8d877d","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":63},"updated":"2023-04-17 18:31:49.000000000","message":"There is no need to send \"ceilometer\u003d\u003d\u003d\" to macro as uppper constraints format is always package\u003d\u003d\u003dversion\n\nThere should be \n\n\u0026\u0026 {{ macros.upper_constraints_remove(\"ceilometer\") }} \\\n\nI think.","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"396fae5084a1b695101819b2ba2ede9ce2f286a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(egonzalez): Remove ceilometer from constraint or will fail."},{"line_number":27,"context_line":"RUN ln -s ceilometer-base-source/* ceilometer \\"},{"line_number":28,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ceilometer\u003d\u003d\u003d\") }} \\"},{"line_number":29,"context_line":"    \u0026\u0026 {{ macros.install_pip(ceilometer_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":30,"context_line":"    \u0026\u0026 mkdir -p /etc/ceilometer \\"},{"line_number":31,"context_line":"    \u0026\u0026 cp -r /ceilometer/etc/ceilometer/* /etc/ceilometer/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"c176ccfd_881f13f9","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":63},"in_reply_to":"28796b43_6b3e1412","updated":"2023-04-21 08:02:57.000000000","message":"Done","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3eb4ed5da229243e2408414667a5b655499450c7","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(egonzalez): Remove ceilometer from constraint or will fail."},{"line_number":27,"context_line":"RUN ln -s ceilometer-base-source/* ceilometer \\"},{"line_number":28,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ceilometer\u003d\u003d\u003d\") }} \\"},{"line_number":29,"context_line":"    \u0026\u0026 {{ macros.install_pip(ceilometer_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":30,"context_line":"    \u0026\u0026 mkdir -p /etc/ceilometer \\"},{"line_number":31,"context_line":"    \u0026\u0026 cp -r /ceilometer/etc/ceilometer/* /etc/ceilometer/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"d60492f0_9fe96269","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":63},"in_reply_to":"a0715cbd_44771e61","updated":"2023-04-18 09:47:00.000000000","message":"Why ? Did you check my proposal for macros.upper_constraints_remove below ?\n\nProposal  \u003e\u003e\n\nsed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt\n\nto\n\nsed -e \"/^{{ package_name }}\u003d\u003d\u003d.*/d\" -i requirements/upper-constraints.txt\n\nThere is \u003d\u003d\u003d addded to sed command ..so if u-c will have \n\nceilometer\u003d\u003d\u003d1.2.3\nceilometer-xyz\u003d1.2.3\n\nyou will send ceilometer to macro and sed command will render ceilometer\u003d\u003d\u003d only so it will not take ceilometer-xyz ..because macro changed and added \u003d\u003d\u003d","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7133f65dd3f097a511095a75bd11eafa20578066","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(egonzalez): Remove ceilometer from constraint or will fail."},{"line_number":27,"context_line":"RUN ln -s ceilometer-base-source/* ceilometer \\"},{"line_number":28,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ceilometer\u003d\u003d\u003d\") }} \\"},{"line_number":29,"context_line":"    \u0026\u0026 {{ macros.install_pip(ceilometer_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":30,"context_line":"    \u0026\u0026 mkdir -p /etc/ceilometer \\"},{"line_number":31,"context_line":"    \u0026\u0026 cp -r /ceilometer/etc/ceilometer/* /etc/ceilometer/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"a0715cbd_44771e61","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":63},"in_reply_to":"d040fa08_bb8d877d","updated":"2023-04-18 08:53:59.000000000","message":"if u-c has \"ceilometer-zyx\u003d\u003d\u003d341.1\" then your change removes both","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"14e4ad19e12f132ad6614880a61a545ef06b5cef","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(egonzalez): Remove ceilometer from constraint or will fail."},{"line_number":27,"context_line":"RUN ln -s ceilometer-base-source/* ceilometer \\"},{"line_number":28,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ceilometer\u003d\u003d\u003d\") }} \\"},{"line_number":29,"context_line":"    \u0026\u0026 {{ macros.install_pip(ceilometer_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":30,"context_line":"    \u0026\u0026 mkdir -p /etc/ceilometer \\"},{"line_number":31,"context_line":"    \u0026\u0026 cp -r /ceilometer/etc/ceilometer/* /etc/ceilometer/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"28796b43_6b3e1412","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":63},"in_reply_to":"d60492f0_9fe96269","updated":"2023-04-18 10:01:50.000000000","message":"https://raw.githubusercontent.com/openstack/requirements/master/upper-constraints.txt  always \u003d\u003d\u003d","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"}],"docker/horizon/Dockerfile.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"16bd41db62c6cf7a2b2abe09ab3e9658becf8a20","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# NOTE(hrw): to install horizon from unpacked sources we cannot have it in upper-constraints.txt"},{"line_number":49,"context_line":"RUN ln -s horizon-source/* horizon \\"},{"line_number":50,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"horizon\u003d\") }} \\"},{"line_number":51,"context_line":"    \u0026\u0026 {{ macros.install_pip(horizon_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":52,"context_line":"    \u0026\u0026 mkdir -p /etc/openstack-dashboard \\"},{"line_number":53,"context_line":"    \u0026\u0026 cp -r /horizon/openstack_dashboard/conf/* /etc/openstack-dashboard/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"db25518d_669875ed","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":58},"updated":"2023-04-17 18:31:49.000000000","message":"Ditto\n\n\u0026\u0026 {{ macros.upper_constraints_remove(\"horizon\u003d\") }} \\\n\nto\n\n\u0026\u0026 {{ macros.upper_constraints_remove(\"horizon\") }} \\","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"396fae5084a1b695101819b2ba2ede9ce2f286a4","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# NOTE(hrw): to install horizon from unpacked sources we cannot have it in upper-constraints.txt"},{"line_number":49,"context_line":"RUN ln -s horizon-source/* horizon \\"},{"line_number":50,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"horizon\u003d\") }} \\"},{"line_number":51,"context_line":"    \u0026\u0026 {{ macros.install_pip(horizon_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":52,"context_line":"    \u0026\u0026 mkdir -p /etc/openstack-dashboard \\"},{"line_number":53,"context_line":"    \u0026\u0026 cp -r /horizon/openstack_dashboard/conf/* /etc/openstack-dashboard/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"f0dcef11_e1a7b0d2","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":58},"in_reply_to":"a22b90cd_39471e38","updated":"2023-04-21 08:02:57.000000000","message":"Done","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7133f65dd3f097a511095a75bd11eafa20578066","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# NOTE(hrw): to install horizon from unpacked sources we cannot have it in upper-constraints.txt"},{"line_number":49,"context_line":"RUN ln -s horizon-source/* horizon \\"},{"line_number":50,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"horizon\u003d\") }} \\"},{"line_number":51,"context_line":"    \u0026\u0026 {{ macros.install_pip(horizon_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":52,"context_line":"    \u0026\u0026 mkdir -p /etc/openstack-dashboard \\"},{"line_number":53,"context_line":"    \u0026\u0026 cp -r /horizon/openstack_dashboard/conf/* /etc/openstack-dashboard/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"f332d20a_7bb012cd","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":58},"in_reply_to":"db25518d_669875ed","updated":"2023-04-18 08:53:59.000000000","message":"ditto","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3eb4ed5da229243e2408414667a5b655499450c7","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# NOTE(hrw): to install horizon from unpacked sources we cannot have it in upper-constraints.txt"},{"line_number":49,"context_line":"RUN ln -s horizon-source/* horizon \\"},{"line_number":50,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"horizon\u003d\") }} \\"},{"line_number":51,"context_line":"    \u0026\u0026 {{ macros.install_pip(horizon_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":52,"context_line":"    \u0026\u0026 mkdir -p /etc/openstack-dashboard \\"},{"line_number":53,"context_line":"    \u0026\u0026 cp -r /horizon/openstack_dashboard/conf/* /etc/openstack-dashboard/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"a22b90cd_39471e38","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":58},"in_reply_to":"f332d20a_7bb012cd","updated":"2023-04-18 09:47:00.000000000","message":"ditto","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"}],"docker/kuryr/kuryr-base/Dockerfile.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"16bd41db62c6cf7a2b2abe09ab3e9658becf8a20","unresolved":true,"context_lines":[{"line_number":20,"context_line":"# NOTE(Jeffrey4l): remove kuryr-lib constraint in upper-constraints.txt file."},{"line_number":21,"context_line":"# Otherwise, it will be failed."},{"line_number":22,"context_line":"RUN ln -s kuryr-base-source/* kuryr-base \\"},{"line_number":23,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"kuryr-lib\u003d\u003d\u003d\") }} \\"},{"line_number":24,"context_line":"    \u0026\u0026 {{ macros.install_pip(kuryr_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 mkdir -p /etc/kuryr \\"},{"line_number":26,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"03ebf5fe_9f7e4e80","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":62},"updated":"2023-04-17 18:31:49.000000000","message":"Ditto \n\n    \u0026\u0026 {{ macros.upper_constraints_remove(\"kuryr-lib\u003d\u003d\u003d\") }} \\\n    \n    to\n\n    \u0026\u0026 {{ macros.upper_constraints_remove(\"kuryr-lib\") }} \\","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3eb4ed5da229243e2408414667a5b655499450c7","unresolved":true,"context_lines":[{"line_number":20,"context_line":"# NOTE(Jeffrey4l): remove kuryr-lib constraint in upper-constraints.txt file."},{"line_number":21,"context_line":"# Otherwise, it will be failed."},{"line_number":22,"context_line":"RUN ln -s kuryr-base-source/* kuryr-base \\"},{"line_number":23,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"kuryr-lib\u003d\u003d\u003d\") }} \\"},{"line_number":24,"context_line":"    \u0026\u0026 {{ macros.install_pip(kuryr_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 mkdir -p /etc/kuryr \\"},{"line_number":26,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"2b232d83_4b68eaaa","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":62},"in_reply_to":"03ebf5fe_9f7e4e80","updated":"2023-04-18 09:47:00.000000000","message":"\u003e Ditto \n\u003e \n\u003e     \u0026\u0026 {{ macros.upper_constraints_remove(\"kuryr-lib\u003d\u003d\u003d\") }} \\\n\u003e     \n\u003e     to\n\u003e \n\u003e     \u0026\u0026 {{ macros.upper_constraints_remove(\"kuryr-lib\") }} \\","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"396fae5084a1b695101819b2ba2ede9ce2f286a4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# NOTE(Jeffrey4l): remove kuryr-lib constraint in upper-constraints.txt file."},{"line_number":21,"context_line":"# Otherwise, it will be failed."},{"line_number":22,"context_line":"RUN ln -s kuryr-base-source/* kuryr-base \\"},{"line_number":23,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"kuryr-lib\u003d\u003d\u003d\") }} \\"},{"line_number":24,"context_line":"    \u0026\u0026 {{ macros.install_pip(kuryr_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 mkdir -p /etc/kuryr \\"},{"line_number":26,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fdec46e2_ea13db1b","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":62},"in_reply_to":"2b232d83_4b68eaaa","updated":"2023-04-21 08:02:57.000000000","message":"Done","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"}],"docker/macros.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d134a661d27862b799b50df7cc597967aa33f94c","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro upper_constrains_remove(package_name) -%}"},{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1074015d_2d84346b","line":80,"range":{"start_line":80,"start_character":9,"end_line":80,"end_character":25},"updated":"2023-03-27 18:28:03.000000000","message":"upper-constraints","commit_id":"db1151ebe6fcd689902921e14ecec936f66bd9d6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"220be2eee988d07eb975887052a6059d4e05c022","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro upper_constrains_remove(package_name) -%}"},{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"52554d1b_da9937b1","line":80,"range":{"start_line":80,"start_character":9,"end_line":80,"end_character":25},"in_reply_to":"1074015d_2d84346b","updated":"2023-03-27 20:34:06.000000000","message":"we have snake_case on all macro names","commit_id":"db1151ebe6fcd689902921e14ecec936f66bd9d6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"128923239d2c3d51ad8d35605d31aec84e3488d3","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro upper_constrains_remove(package_name) -%}"},{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b1a04387_b204d423","line":80,"range":{"start_line":80,"start_character":9,"end_line":80,"end_character":25},"in_reply_to":"274b1647_995af9fa","updated":"2023-04-07 15:40:54.000000000","message":"ah.","commit_id":"db1151ebe6fcd689902921e14ecec936f66bd9d6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f39f580f20ac15709dbe4287285e28b8d7c3cfdf","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro upper_constrains_remove(package_name) -%}"},{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"274b1647_995af9fa","line":80,"range":{"start_line":80,"start_character":9,"end_line":80,"end_character":25},"in_reply_to":"52554d1b_da9937b1","updated":"2023-03-28 04:52:50.000000000","message":"i meant missing t 😊","commit_id":"db1151ebe6fcd689902921e14ecec936f66bd9d6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d134a661d27862b799b50df7cc597967aa33f94c","unresolved":true,"context_lines":[{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% macro upper_constrains_version_change(from, to) -%}"},{"line_number":85,"context_line":"sed -e \"s/^{{ from }}/{{ to }}/g\" -i requirements/upper-constraints.txt"},{"line_number":86,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fffa17ad_a2678582","line":84,"range":{"start_line":84,"start_character":9,"end_line":84,"end_character":25},"updated":"2023-03-27 18:28:03.000000000","message":"ditto","commit_id":"db1151ebe6fcd689902921e14ecec936f66bd9d6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"220be2eee988d07eb975887052a6059d4e05c022","unresolved":false,"context_lines":[{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% macro upper_constrains_version_change(from, to) -%}"},{"line_number":85,"context_line":"sed -e \"s/^{{ from }}/{{ to }}/g\" -i requirements/upper-constraints.txt"},{"line_number":86,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d8d65f49_4e5e3c17","line":84,"range":{"start_line":84,"start_character":9,"end_line":84,"end_character":25},"in_reply_to":"fffa17ad_a2678582","updated":"2023-03-27 20:34:06.000000000","message":"ditto","commit_id":"db1151ebe6fcd689902921e14ecec936f66bd9d6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"16bd41db62c6cf7a2b2abe09ab3e9658becf8a20","unresolved":true,"context_lines":[{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro upper_constraints_remove(package_name) -%}"},{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% macro upper_constraints_version_change(from, to) -%}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"6383f237_a5eb91eb","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":69},"updated":"2023-04-17 18:31:49.000000000","message":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt\n\nto \n\nsed -e \"/^{{ package_name }}\u003d\u003d\u003d.*/d\" -i requirements/upper-constraints.txt","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"396fae5084a1b695101819b2ba2ede9ce2f286a4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro upper_constraints_remove(package_name) -%}"},{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% macro upper_constraints_version_change(from, to) -%}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"29d6f122_17714eb5","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":69},"in_reply_to":"6383f237_a5eb91eb","updated":"2023-04-21 08:02:57.000000000","message":"Done","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6df3140091c825f4137f1f80cebefe17825b926c","unresolved":true,"context_lines":[{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}\u003d\u003d\u003d/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% macro upper_constraints_version_change(from, to) -%}"},{"line_number":85,"context_line":"sed -e \"s/^{{ from }}/{{ to }}/g\" -i requirements/upper-constraints.txt"},{"line_number":86,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1c377995_e4ac7b99","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":55},"updated":"2023-04-21 08:25:35.000000000","message":"What about expand macro by one parameter ? package, from, to ?\nIt will also address typos as you proposed below in a code \u003e\u003e\n\nRUN {{ macros.upper_constraints_version_change(\"pyzmq\u003d\u003d\u003d20.0.0\", \"pyzmq\u003d\u003d21.*\") \n}} \\\n\n\u003d\u003d\u003d vs \u003d\u003d\n\nSomething like\n\nsed -e \"s/^{{ package }}\u003d\u003d\u003d{{ from }}/{{ package }}\u003d\u003d\u003d{{ to }}/g\" -i requirements/upper-constraints.txt\n\nWhat do u think ?","commit_id":"2a782058bcc86a3638f69dafa7dec9d53ae71fcf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b11d2a97526362ad303b09a828bea327245097f9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}\u003d\u003d\u003d/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% macro upper_constraints_version_change(from, to) -%}"},{"line_number":85,"context_line":"sed -e \"s/^{{ from }}/{{ to }}/g\" -i requirements/upper-constraints.txt"},{"line_number":86,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"8cc51438_769c7af5","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":55},"in_reply_to":"11fd81d1_7ef59c3e","updated":"2023-04-21 13:40:58.000000000","message":"Done","commit_id":"2a782058bcc86a3638f69dafa7dec9d53ae71fcf"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"9ba78e142e86754c903bf1da6a5ba7f27ccfc30b","unresolved":true,"context_lines":[{"line_number":81,"context_line":"sed -e \"/^{{ package_name }}\u003d\u003d\u003d/d\" -i requirements/upper-constraints.txt"},{"line_number":82,"context_line":"{%- endmacro %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% macro upper_constraints_version_change(from, to) -%}"},{"line_number":85,"context_line":"sed -e \"s/^{{ from }}/{{ to }}/g\" -i requirements/upper-constraints.txt"},{"line_number":86,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"11fd81d1_7ef59c3e","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":55},"in_reply_to":"1c377995_e4ac7b99","updated":"2023-04-21 08:44:14.000000000","message":"I like the idea","commit_id":"2a782058bcc86a3638f69dafa7dec9d53ae71fcf"}],"docker/neutron/neutron-mlnx-agent/Dockerfile.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"16bd41db62c6cf7a2b2abe09ab3e9658becf8a20","unresolved":true,"context_lines":[{"line_number":21,"context_line":"] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{# NOTE(hrw): pyzmq 20 fails to build while 19.* and 21.* build fine. #}"},{"line_number":24,"context_line":"RUN {{ macros.upper_constraints_version_change(\"^pyzmq\u003d\u003d\u003d20.0.0\", \"pyzmq\u003d\u003d21.*\") }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 {{ macros.install_pip(neutron_mlnx_agent_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% block neutron_mlnx_agent_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"a8bb5232_15557487","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":85},"updated":"2023-04-17 18:31:49.000000000","message":"RUN {{ macros.upper_constraints_version_change(\"^pyzmq\u003d\u003d\u003d20.0.0\", \"pyzmq\u003d\u003d21.*\") }} \\\n\nto\n\nRUN {{ macros.upper_constraints_version_change(\"pyzmq\u003d\u003d\u003d20.0.0\", \"pyzmq\u003d\u003d21.*\") }} \\","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"396fae5084a1b695101819b2ba2ede9ce2f286a4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{# NOTE(hrw): pyzmq 20 fails to build while 19.* and 21.* build fine. #}"},{"line_number":24,"context_line":"RUN {{ macros.upper_constraints_version_change(\"^pyzmq\u003d\u003d\u003d20.0.0\", \"pyzmq\u003d\u003d21.*\") }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 {{ macros.install_pip(neutron_mlnx_agent_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% block neutron_mlnx_agent_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"e92854f0_816c275d","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":85},"in_reply_to":"a8bb5232_15557487","updated":"2023-04-21 08:02:57.000000000","message":"Done","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"16bd41db62c6cf7a2b2abe09ab3e9658becf8a20","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                    is usually newer than UC entry and older version would get installed"},{"line_number":190,"context_line":"                    in venv (see https://launchpad.net/bugs/1961874)."},{"line_number":191,"context_line":"#}"},{"line_number":192,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ovs\u003d\") }} \\"},{"line_number":193,"context_line":"    \u0026\u0026 mkdir -p /var/lib/kolla \\"},{"line_number":194,"context_line":"    \u0026\u0026 {{ macros.install_pip([\u0027virtualenv\u0027])}} \\"},{"line_number":195,"context_line":"    \u0026\u0026 virtualenv --system-site-packages /var/lib/kolla/venv"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"63eb747b_84a18d33","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":54},"updated":"2023-04-17 18:31:49.000000000","message":"\u0026\u0026 {{ macros.upper_constraints_remove(\"ovs\u003d\") }} \\\n    \n    to\n    \n    \u0026\u0026 {{ macros.upper_constraints_remove(\"ovs\") }} \\","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7133f65dd3f097a511095a75bd11eafa20578066","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                    is usually newer than UC entry and older version would get installed"},{"line_number":190,"context_line":"                    in venv (see https://launchpad.net/bugs/1961874)."},{"line_number":191,"context_line":"#}"},{"line_number":192,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ovs\u003d\") }} \\"},{"line_number":193,"context_line":"    \u0026\u0026 mkdir -p /var/lib/kolla \\"},{"line_number":194,"context_line":"    \u0026\u0026 {{ macros.install_pip([\u0027virtualenv\u0027])}} \\"},{"line_number":195,"context_line":"    \u0026\u0026 virtualenv --system-site-packages /var/lib/kolla/venv"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"69f0cedc_b42032ad","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":54},"in_reply_to":"63eb747b_84a18d33","updated":"2023-04-18 08:53:59.000000000","message":"what if u-c has \"ovs\u003d\u003d\u003d3.4.5\" and \"ovs-xyz\u003d\u003d2.5\"?","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"396fae5084a1b695101819b2ba2ede9ce2f286a4","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                    is usually newer than UC entry and older version would get installed"},{"line_number":190,"context_line":"                    in venv (see https://launchpad.net/bugs/1961874)."},{"line_number":191,"context_line":"#}"},{"line_number":192,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ovs\u003d\") }} \\"},{"line_number":193,"context_line":"    \u0026\u0026 mkdir -p /var/lib/kolla \\"},{"line_number":194,"context_line":"    \u0026\u0026 {{ macros.install_pip([\u0027virtualenv\u0027])}} \\"},{"line_number":195,"context_line":"    \u0026\u0026 virtualenv --system-site-packages /var/lib/kolla/venv"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"c7d2a7d0_c3971a24","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":54},"in_reply_to":"69f0cedc_b42032ad","updated":"2023-04-21 08:02:57.000000000","message":"Done","commit_id":"4ef4f8ee251acd6c2cf5f359815f21d82c28a156"}]}