)]}'
{"id":"openstack%2Fkolla~879041","triplet_id":"openstack%2Fkolla~master~I634fd70eefc85c785b0cf108ef67198e5286fec7","project":"openstack/kolla","branch":"master","topic":"fix_compression","attention_set":{},"removed_from_attention_set":{"22629":{"account":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"last_update":"2023-04-07 13:27:54.000000000","reason":"\u003cGERRIT_ACCOUNT_22629\u003e replied on the change","reason_account":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}},"9545":{"account":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"last_update":"2023-04-07 16:59:51.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I634fd70eefc85c785b0cf108ef67198e5286fec7","subject":"Use consistent tar compression","status":"ABANDONED","created":"2023-03-30 11:45:13.000000000","updated":"2023-04-07 17:00:26.000000000","total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"d3dbff5d423b524b5967f40f2e60c84aface38ae","_number":879041,"virtual_id_number":879041,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-03-30 13:14:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-30 12:15:29.000000000","updated_by":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"reviewer":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"state":"CC"},{"updated":"2023-03-30 13:14:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"165fb036b0c4d059664bb8d339273f8f132da027","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2023-03-30 11:45:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"77b971ad10048ea277302dacbf2840bbebaf2047","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2023-03-30 11:48:57.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a3c690bb2563088f78df30d4c6a50972c5e1ba7d","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2023-03-30 12:15:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4ed0cf8ced11bf65fe2a4ce3b9a8c6dce7974b91","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-30 13:14:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ac57d1595d05414bb4b9fa821f3ec64c\n\n- kolla-build-centos9s https://zuul.opendev.org/t/openstack/build/2d97b8b082384f28ba9238b9d195374d : SUCCESS in 20m 46s (non-voting)\n- kolla-ansible-centos9s https://zuul.opendev.org/t/openstack/build/bdba750ee1ea417592aa813a3fa1b236 : SUCCESS in 1h 15m 06s (non-voting)\n- kolla-build-debian https://zuul.opendev.org/t/openstack/build/1441bef8dc5c4c099585b8a14192eb4f : SUCCESS in 14m 54s\n- kolla-ansible-debian https://zuul.opendev.org/t/openstack/build/2874dde4aa1349978f952672f61c2128 : SUCCESS in 1h 05m 05s\n- kolla-ansible-debian-upgrade https://zuul.opendev.org/t/openstack/build/8933f3a672c640c19962854fb58f5ffa : SUCCESS in 1h 12m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/60ddc258675c4f5b8768fea0e576fa5b : SUCCESS in 3m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/adb3010e6ef746a29b5d8f85de62c03a : SUCCESS in 3m 47s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/3fd4ed3f7f63443ea19277357761d188 : SUCCESS in 3m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b888c377a18d4cbbaaba645bc2140cf8 : SUCCESS in 3m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/45d914673620439f942f2ee9a9bbefff : SUCCESS in 5m 25s\n- kolla-build-rocky9 https://zuul.opendev.org/t/openstack/build/acc63f164a9849e78d2a8d7e272e325d : SUCCESS in 14m 18s\n- kolla-ansible-rocky9 https://zuul.opendev.org/t/openstack/build/53f4745bab914d6baaac08f1aa5da737 : SUCCESS in 1h 19m 43s\n- kolla-ansible-rocky9-upgrade https://zuul.opendev.org/t/openstack/build/90bc899104444e9ab5980e549f584e6d : SUCCESS in 1h 06m 04s\n- kolla-build-ubuntu https://zuul.opendev.org/t/openstack/build/da9cbd7ad63c4565bef1fbccf7a73806 : SUCCESS in 23m 10s\n- kolla-ansible-ubuntu https://zuul.opendev.org/t/openstack/build/5ad261abeb574e3bb4a45f38e776528a : SUCCESS in 50m 33s\n- kolla-ansible-ubuntu-upgrade https://zuul.opendev.org/t/openstack/build/275e2e86d5ed461cb7210d3abf9f6eb2 : SUCCESS in 1h 12m 14s","accounts_in_message":[],"_revision_number":2},{"id":"849e84f1319f1be73727d7a719a36a43f6c9d5a7","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2023-03-30 13:52:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ce250f8f6222d5461dabdf87397ee43430ba56f5","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-30 14:29:07.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/332a7932c4fd469b8767516465fcddb4\n\n- kolla-build-centos9s-aarch64 https://zuul.opendev.org/t/openstack/build/2363cff35ac4457d90b3aa4c20a1646a : SUCCESS in 20m 44s (non-voting)\n- kolla-build-debian-aarch64 https://zuul.opendev.org/t/openstack/build/8c50f622d5454fd688db8c34854e3017 : SUCCESS in 19m 06s\n- kolla-ansible-debian-aarch64 https://zuul.opendev.org/t/openstack/build/8559068fda844d15af88e21cda8bc21d : SUCCESS in 2h 37m 25s\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/8dcdcb840e31473cb2431b5f546992c9 : SUCCESS in 2m 52s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/df67fa1253034f3faaabb8940e2188cb : SUCCESS in 5m 37s (non-voting)\n- kolla-build-rocky9-aarch64 https://zuul.opendev.org/t/openstack/build/2b8956389168425d8b00580ec9c755a8 : SUCCESS in 23m 26s (non-voting)\n- kolla-build-ubuntu-aarch64 https://zuul.opendev.org/t/openstack/build/8a9227893dc3420d8a13e43b7b3d01f0 : SUCCESS in 1h 39m 52s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"19c300cacc70429a69a71b33741666846eaff3c0","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2023-04-07 13:27:54.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d0153ef152d00312e7f72522d11549db2a8a1bc9","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2023-04-07 16:59:51.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2},{"id":"d3dbff5d423b524b5967f40f2e60c84aface38ae","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2023-04-07 17:00:26.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"23a13e533ed42e4132287b2536cec52daee876dd","revisions":{"867420c2a89c1b262e076f58c80b6ab5aafd6c6f":{"kind":"REWORK","_number":1,"created":"2023-03-30 11:45:13.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/41/879041/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/41/879041/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/41/879041/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/41/879041/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/41/879041/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/41/879041/1"}}},"commit":{"parents":[{"commit":"30cc9c58e017f82e20a27549929ecb9cf02fe0d0","subject":"Merge \"Add support for running Nova upgrade checks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/30cc9c58e017f82e20a27549929ecb9cf02fe0d0"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2023-03-30 11:44:59.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2023-03-30 11:45:08.000000000","tz":120},"subject":"Use consistent tar compression","message":"Use consistent tar compression\n\nThe following change I650fcbc8f773fad8116338f6fb0cf7b4f4f17b33\nintroduced a check for malicious tarballs that assums tarfile is gzip\ncompressed.\nUnfortunatelly, the fact that all other places at kolla/image/tasks.py create\nuncompressed tar files does not allow to pass the new check.\n\nThis change tries to unify the way of working with tar files and use the\nsame compression everywhere.\n\nChange-Id: I634fd70eefc85c785b0cf108ef67198e5286fec7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/867420c2a89c1b262e076f58c80b6ab5aafd6c6f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/867420c2a89c1b262e076f58c80b6ab5aafd6c6f"}]},"branch":"refs/heads/master"},"23a13e533ed42e4132287b2536cec52daee876dd":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-03-30 11:48:57.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/41/879041/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/41/879041/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/41/879041/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/41/879041/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/41/879041/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/41/879041/2"}}},"commit":{"parents":[{"commit":"30cc9c58e017f82e20a27549929ecb9cf02fe0d0","subject":"Merge \"Add support for running Nova upgrade checks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/30cc9c58e017f82e20a27549929ecb9cf02fe0d0"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2023-03-30 11:44:59.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2023-03-30 11:48:25.000000000","tz":120},"subject":"Use consistent tar compression","message":"Use consistent tar compression\n\nThe following change I650fcbc8f773fad8116338f6fb0cf7b4f4f17b33\nintroduced a check for malicious tarballs that assums tarfile is gzip\ncompressed.\nUnfortunatelly, the fact that all other places at kolla/image/tasks.py create\nuncompressed tar files does not allow to pass the new check.\n\n    DEBUG:kolla.common.utils.openstack-base:Getting local archive from /workspace/files/pip\n    ERROR:kolla.common.utils:Unhandled error when running BuildTask(openstack-base)\n    Traceback (most recent call last):\n      File \"/tmp/kolla_env/lib/python3.9/site-packages/kolla/image/build.py\", line 77, in run\n        task.run()\n      File \"/tmp/kolla_env/lib/python3.9/site-packages/kolla/image/tasks.py\", line 139, in run\n        self.builder(self.image)\n      File \"/tmp/kolla_env/lib/python3.9/site-packages/kolla/image/tasks.py\", line 355, in builder\n        additions_am \u003d make_an_archive(image.additions, \u0027additions\u0027)\n      File \"/tmp/kolla_env/lib/python3.9/site-packages/kolla/image/tasks.py\", line 288, in make_an_archive\n        _test_malicious_tarball(archive, items_path)\n      File \"/tmp/kolla_env/lib/python3.9/site-packages/kolla/image/tasks.py\", line 268, in _test_malicious_tarball\n        tar_file \u003d tarfile.open(archive, \u0027r|gz\u0027)\n      File \"/usr/lib64/python3.9/tarfile.py\", line 1648, in open\n        stream \u003d _Stream(name, filemode, comptype, fileobj, bufsize)\n      File \"/usr/lib64/python3.9/tarfile.py\", line 370, in __init__\n        self._init_read_gz()\n      File \"/usr/lib64/python3.9/tarfile.py\", line 477, in _init_read_gz\n        raise ReadError(\"not a gzip file\")\n    tarfile.ReadError: not a gzip file\n\nThis change tries to unify the way of working with tar files and use the\nsame compression everywhere.\n\nChange-Id: I634fd70eefc85c785b0cf108ef67198e5286fec7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/23a13e533ed42e4132287b2536cec52daee876dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/23a13e533ed42e4132287b2536cec52daee876dd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}