)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"66a71a77c47f4455d76bfe985aa909dc9872e916","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gaël THEROND (Fl1nt) \u003cgael.therond@bitswalk.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-25 13:55:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve kolla-toolbox offline support."},{"line_number":8,"context_line":"  * Use structure that allow for custom package version and base URL."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I169e51c0f5c691518ada1837990b5bdd2a3d1481"},{"line_number":11,"context_line":"Closes-bug: #2020761"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d24321d9_e5684d05","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":69},"updated":"2023-05-25 11:58:35.000000000","message":"newline in the middle","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e30f961d0cb412f1ab5b5d4a70d26364411fb398","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gaël THEROND (Fl1nt) \u003cgael.therond@bitswalk.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-25 13:55:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve kolla-toolbox offline support."},{"line_number":8,"context_line":"  * Use structure that allow for custom package version and base URL."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I169e51c0f5c691518ada1837990b5bdd2a3d1481"},{"line_number":11,"context_line":"Closes-bug: #2020761"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"29cb271c_e5f9d111","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":69},"in_reply_to":"d24321d9_e5684d05","updated":"2023-05-25 13:14:14.000000000","message":"Ack","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"66a71a77c47f4455d76bfe985aa909dc9872e916","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"792831e6_31d62b3d","updated":"2023-05-25 11:58:35.000000000","message":"workflow -1 so it doesn\u0027t get merged before we branch","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"66e89c4ccfd2691b870a11ea265fc96c681f2c5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b9b3667_d1172379","in_reply_to":"792831e6_31d62b3d","updated":"2023-06-20 14:40:23.000000000","message":"can we remove workflow and rp -1 now?","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b2d0dd3779b6a1e6364e087db9c08414016ca207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f754454_77258dda","updated":"2023-05-25 13:15:04.000000000","message":"also closes-bug should be changed to related-bug to solve the issue right way in followup. thanks!","commit_id":"9c617931d095cb61571665e5cd901642ebbd4073"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"846a4de214e457d824e78470dc9a865edb33a26f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e07d0221_aaf950d0","updated":"2023-05-25 13:13:15.000000000","message":"releasenotes and commit message should be changed too","commit_id":"9c617931d095cb61571665e5cd901642ebbd4073"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"abd687db97474326c0ebbce7c220817aa9913d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5c224418_9c0f30c1","updated":"2023-08-01 10:50:26.000000000","message":"Can we merge this patch and backport it to xena/yoga and zed releaese?","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f5181b65aace58b66d1dd64a5bd4dc9430d04998","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"81590fa3_7536198c","updated":"2023-06-30 05:35:21.000000000","message":"I\u0027m not convinced we need a separate layer for this (another RUN instruction)","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"919561251d1c2a66b800ffd518ae79c034b8b785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b759b597_9d95c042","updated":"2023-05-25 14:43:33.000000000","message":"lgtm now","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cac801e3471053e34a618a06d79f015a06a9e27d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ca5b2fd3_b115d012","in_reply_to":"04a186ee_3c0a3385","updated":"2023-06-30 09:07:18.000000000","message":"I confirm that it is necessary","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7ab655939ac4bf8fdd2bd7e3cb198675ecbce310","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"04a186ee_3c0a3385","in_reply_to":"81590fa3_7536198c","updated":"2023-06-30 08:36:14.000000000","message":"This is needed as we create a new block control.","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1500a50935e22b3e7fb53b4744dcd4dc35521d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b7c2ddce_8f2ace60","in_reply_to":"afb0d810_2231df35","updated":"2023-06-30 13:00:52.000000000","message":"Haven’t noticed the copy, looks ok - though I hate the additional layer that is the effect.","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a5e9f227eb890731f145b6604e2c6c932e25656c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eba40ae6_b3a91a72","in_reply_to":"ca5b2fd3_b115d012","updated":"2023-06-30 09:13:12.000000000","message":"it’s not, you can still do \u0026\u0026 inside a block, convince me it’s impossible :-)","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"2065588e7d4b666525235ec62c9abce82681f9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"afb0d810_2231df35","in_reply_to":"eba40ae6_b3a91a72","updated":"2023-06-30 09:19:44.000000000","message":"Could you please point the RUN command you\u0027re talking about? there are multiples.\n\nAnd if you talk about the RUN from the kolla_toolbox_collections_install block then could you please show what you want to do?\n\nYou can\u0027t do that in this specific block as the RUN follow a COPY instruction, if you start mixing COPY and RUN block in the same command then you completely goes against containers layering philosophy and that\u0027s once again another topic, that I won\u0027t address in here.","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2c3eadd05937eededb34939adc383dc514972131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"69530a0a_203b73f9","in_reply_to":"eba40ae6_b3a91a72","updated":"2023-06-30 09:18:45.000000000","message":"we have the COPY statement between two RUN, so they can\u0027t be joined with \u0026\u0026.","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d92230e985e320fc4e922a1fdbc499f693dfacb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"267c71ad_830d781f","updated":"2023-09-06 05:44:14.000000000","message":"Been here too long","commit_id":"7f38e1df71eafb250b14c4e125c7313bd9218f7d"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"d05a6db0b2f1772171b226b11dae01ceb217b980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3254a8b8_ea94da7a","updated":"2023-08-01 22:39:14.000000000","message":"thanks!","commit_id":"7f38e1df71eafb250b14c4e125c7313bd9218f7d"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ff4ebce9141fdfc80ddd7e05d72a48d290ed8a79","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ venv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":84,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }} \\"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"{% set kolla_toolbox_ansible_collections \u003d ["},{"line_number":87,"context_line":"        \u0027ansible-posix\u0027: \u00271.5.4\u0027,"},{"line_number":88,"context_line":"        \u0027community-general\u0027: \u00273.8.9\u0027,"},{"line_number":89,"context_line":"        \u0027community-mysql\u0027: \u00272.4.1\u0027,"},{"line_number":90,"context_line":"        \u0027community-rabbitmq\u0027: \u00271.2.3\u0027,"},{"line_number":91,"context_line":"        \u0027openstack-cloud\u0027: \u00272.1.0\u0027,"},{"line_number":92,"context_line":"        \u0027openvswitch-openvswitch\u0027: \u00272.1.1\u0027,"},{"line_number":93,"context_line":"    ] %}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"{% set kolla_toolbox_galaxy_url \u003d \u0027https://galaxy.ansible.com/download\u0027 %}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% for dict_item in kolla_toolbox_ansible_collections %}"},{"line_number":98,"context_line":"{% for key, value in dict_item.items() %}"},{"line_number":99,"context_line":"RUN curl -o /tmp/{{ key }}-{{ value }}.tar.gz ${kolla_toolbox_galaxy_url}/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":100,"context_line":"    \u0026\u0026 ansible-galaxy collection install /tmp/{{ key }}-{{ value }}.tar.gz --timeout 120  -p /usr/share/ansible/collections \\"},{"line_number":101,"context_line":"    \u0026\u0026 rm -rf /tmp/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":102,"context_line":"{% endfor %}"},{"line_number":103,"context_line":"{% endfor %}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5e2452a5_68a7c622","line":103,"range":{"start_line":86,"start_character":0,"end_line":103,"end_character":12},"updated":"2023-05-25 12:08:43.000000000","message":"this is really bad switching to the curl! we completely lost ability to use sources. for air-gapped environments requirements.yml can be customized like:\n---\ncollections:\n  - name: ansible.posix\n    version: \u00271.5.2\u0027\n    source: \u0027git+http://local-git-server.com/ansible.posix.git\u0027\n    type: \u0027git\u0027\n...\netc.\nand there are many more possible solutions with custom requirements.yml","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f59aa4922ce358590f8ce35ad48ab9807e0ea124","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ venv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":84,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }} \\"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"{% set kolla_toolbox_ansible_collections \u003d ["},{"line_number":87,"context_line":"        \u0027ansible-posix\u0027: \u00271.5.4\u0027,"},{"line_number":88,"context_line":"        \u0027community-general\u0027: \u00273.8.9\u0027,"},{"line_number":89,"context_line":"        \u0027community-mysql\u0027: \u00272.4.1\u0027,"},{"line_number":90,"context_line":"        \u0027community-rabbitmq\u0027: \u00271.2.3\u0027,"},{"line_number":91,"context_line":"        \u0027openstack-cloud\u0027: \u00272.1.0\u0027,"},{"line_number":92,"context_line":"        \u0027openvswitch-openvswitch\u0027: \u00272.1.1\u0027,"},{"line_number":93,"context_line":"    ] %}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"{% set kolla_toolbox_galaxy_url \u003d \u0027https://galaxy.ansible.com/download\u0027 %}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% for dict_item in kolla_toolbox_ansible_collections %}"},{"line_number":98,"context_line":"{% for key, value in dict_item.items() %}"},{"line_number":99,"context_line":"RUN curl -o /tmp/{{ key }}-{{ value }}.tar.gz ${kolla_toolbox_galaxy_url}/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":100,"context_line":"    \u0026\u0026 ansible-galaxy collection install /tmp/{{ key }}-{{ value }}.tar.gz --timeout 120  -p /usr/share/ansible/collections \\"},{"line_number":101,"context_line":"    \u0026\u0026 rm -rf /tmp/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":102,"context_line":"{% endfor %}"},{"line_number":103,"context_line":"{% endfor %}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f3526039_79e53e0c","line":103,"range":{"start_line":86,"start_character":0,"end_line":103,"end_character":12},"in_reply_to":"2e2a5d7a_4d98c8fe","updated":"2023-05-25 13:09:30.000000000","message":"dependency resolution is the really pain, at least in the way you choose.\nalso all this logic should be wrapped with ovverides block.\nwhat is someone want use an old galaxy method instead?","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"31355437ddf1100e89c70ab35aa2a80425bf09d5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ venv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":84,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }} \\"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"{% set kolla_toolbox_ansible_collections \u003d ["},{"line_number":87,"context_line":"        \u0027ansible-posix\u0027: \u00271.5.4\u0027,"},{"line_number":88,"context_line":"        \u0027community-general\u0027: \u00273.8.9\u0027,"},{"line_number":89,"context_line":"        \u0027community-mysql\u0027: \u00272.4.1\u0027,"},{"line_number":90,"context_line":"        \u0027community-rabbitmq\u0027: \u00271.2.3\u0027,"},{"line_number":91,"context_line":"        \u0027openstack-cloud\u0027: \u00272.1.0\u0027,"},{"line_number":92,"context_line":"        \u0027openvswitch-openvswitch\u0027: \u00272.1.1\u0027,"},{"line_number":93,"context_line":"    ] %}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"{% set kolla_toolbox_galaxy_url \u003d \u0027https://galaxy.ansible.com/download\u0027 %}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% for dict_item in kolla_toolbox_ansible_collections %}"},{"line_number":98,"context_line":"{% for key, value in dict_item.items() %}"},{"line_number":99,"context_line":"RUN curl -o /tmp/{{ key }}-{{ value }}.tar.gz ${kolla_toolbox_galaxy_url}/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":100,"context_line":"    \u0026\u0026 ansible-galaxy collection install /tmp/{{ key }}-{{ value }}.tar.gz --timeout 120  -p /usr/share/ansible/collections \\"},{"line_number":101,"context_line":"    \u0026\u0026 rm -rf /tmp/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":102,"context_line":"{% endfor %}"},{"line_number":103,"context_line":"{% endfor %}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2e2a5d7a_4d98c8fe","line":103,"range":{"start_line":86,"start_character":0,"end_line":103,"end_character":12},"in_reply_to":"5e2452a5_68a7c622","updated":"2023-05-25 12:38:29.000000000","message":"This can\u0027t fix the issue, it require platform OPS to get local downstream patches and to keep updating them and it broke on any major upgrade.\n\nI can improve the patch to add requirements dependancies.","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"20de07ee9ab80df59c76fd06ffcbf32ed4a08bd3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ venv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":84,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }} \\"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"{% set kolla_toolbox_ansible_collections \u003d ["},{"line_number":87,"context_line":"        \u0027ansible-posix\u0027: \u00271.5.4\u0027,"},{"line_number":88,"context_line":"        \u0027community-general\u0027: \u00273.8.9\u0027,"},{"line_number":89,"context_line":"        \u0027community-mysql\u0027: \u00272.4.1\u0027,"},{"line_number":90,"context_line":"        \u0027community-rabbitmq\u0027: \u00271.2.3\u0027,"},{"line_number":91,"context_line":"        \u0027openstack-cloud\u0027: \u00272.1.0\u0027,"},{"line_number":92,"context_line":"        \u0027openvswitch-openvswitch\u0027: \u00272.1.1\u0027,"},{"line_number":93,"context_line":"    ] %}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"{% set kolla_toolbox_galaxy_url \u003d \u0027https://galaxy.ansible.com/download\u0027 %}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% for dict_item in kolla_toolbox_ansible_collections %}"},{"line_number":98,"context_line":"{% for key, value in dict_item.items() %}"},{"line_number":99,"context_line":"RUN curl -o /tmp/{{ key }}-{{ value }}.tar.gz ${kolla_toolbox_galaxy_url}/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":100,"context_line":"    \u0026\u0026 ansible-galaxy collection install /tmp/{{ key }}-{{ value }}.tar.gz --timeout 120  -p /usr/share/ansible/collections \\"},{"line_number":101,"context_line":"    \u0026\u0026 rm -rf /tmp/{{ key }}-{{ value }}.tar.gz \\"},{"line_number":102,"context_line":"{% endfor %}"},{"line_number":103,"context_line":"{% endfor %}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ccc0b98f_ed512128","line":103,"range":{"start_line":86,"start_character":0,"end_line":103,"end_character":12},"in_reply_to":"f3526039_79e53e0c","updated":"2023-05-25 13:13:57.000000000","message":"Yes, you\u0027re right, I\u0027ve just push back the old method surrounded with a block for overrides on template-overrides.j2","commit_id":"d3bc88d50bb7cae873720be91c8f80083f0d4bb8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dd977501e7aff21a9730c2a0793af12ed75b24ec","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"{% block kolla_toolbox_collections_install %}"},{"line_number":87,"context_line":"COPY requirements.yml /var/lib/ansible/"},{"line_number":88,"context_line":"RUN for i in {1..5}; do ansible-galaxy collection install --timeout 120 -p /usr/share/ansible/collections -r /var/lib/ansible/requirements.yml \\"},{"line_number":89,"context_line":"    \u0026\u0026 break || sleep 15; done"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"004d3a63_195dd06e","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":144},"updated":"2023-06-20 14:51:29.000000000","message":"the worst case timeout for this would be 10 minutes.\n\ndid someone measure how long a typical installation takes? maybe we can lower this value?","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5cb1e0f2bcf3ad954da839e630c13a267df16121","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"{% block kolla_toolbox_collections_install %}"},{"line_number":87,"context_line":"COPY requirements.yml /var/lib/ansible/"},{"line_number":88,"context_line":"RUN for i in {1..5}; do ansible-galaxy collection install --timeout 120 -p /usr/share/ansible/collections -r /var/lib/ansible/requirements.yml \\"},{"line_number":89,"context_line":"    \u0026\u0026 break || sleep 15; done"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1dcfda32_3aab4ff5","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":144},"in_reply_to":"004d3a63_195dd06e","updated":"2023-06-20 14:57:00.000000000","message":"in most cases roles downloaded in one pass and this takes a couple minutes","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"70f776d54cf3de2587d6f9e0b6bf766cd75b1683","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"{% block kolla_toolbox_collections_install %}"},{"line_number":87,"context_line":"COPY requirements.yml /var/lib/ansible/"},{"line_number":88,"context_line":"RUN for i in {1..5}; do ansible-galaxy collection install --timeout 120 -p /usr/share/ansible/collections -r /var/lib/ansible/requirements.yml \\"},{"line_number":89,"context_line":"    \u0026\u0026 break || sleep 15; done"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"21193bf4_e1a760f0","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":144},"in_reply_to":"1dcfda32_3aab4ff5","updated":"2023-06-20 15:44:09.000000000","message":"That is IMHO out of scope in here as it’s code already existing from master.\n\nIf we want to reduce or variabilize it I personally think that it should be another patch.","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"}],"releasenotes/notes/bug-2020761-c31f28c922ebcf84.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c465f06e1c3fdba5842123f2a5bd0f0d39550911","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes missing way for kolla-toolbox to be build offline."},{"line_number":5,"context_line":"    `LP#2020761 \u003chttps://launchpad.net/bugs/2020761\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"695282f7_c92a138c","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":51},"updated":"2023-06-20 14:46:08.000000000","message":"nit: built","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"8198129a26cba5d1dd099b75f83ab0d16fd6cc09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes missing way for kolla-toolbox to be build offline."},{"line_number":5,"context_line":"    `LP#2020761 \u003chttps://launchpad.net/bugs/2020761\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"66254647_bbff7645","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":51},"in_reply_to":"695282f7_c92a138c","updated":"2023-08-01 11:38:03.000000000","message":"Done","commit_id":"ec58ec1b946c65efc76caafa8380740c7373083c"}]}