)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":12,"context_line":"This change extends kolla to be also able to build images for ovn-bgp-agent and FRR, as this is"},{"line_number":13,"context_line":"a requirement for ovn-bgp-agent."},{"line_number":14,"context_line":"Furthermore, it also extends the horizon integration to enable the BGPVPN dashboard plugin,"},{"line_number":15,"context_line":"that is also required for certain scenarios with ovn-bgp-agent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change is part of a set of changes in several projects that are necessary to fully"},{"line_number":18,"context_line":"implement ovn-bgp-agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"6187dc4d_d6449232","line":15,"range":{"start_line":15,"start_character":26,"end_line":15,"end_character":43},"updated":"2024-02-09 08:51:28.000000000","message":"could we describe these scenarios either in the commit message or in the docs?\nor if there is upstream documentation for this just link to that instead?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"74b36b15b7933f91ca11ae515eec55226b604376","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This change extends kolla to be also able to build images for ovn-bgp-agent and FRR, as this is"},{"line_number":13,"context_line":"a requirement for ovn-bgp-agent."},{"line_number":14,"context_line":"Furthermore, it also extends the horizon integration to enable the BGPVPN dashboard plugin,"},{"line_number":15,"context_line":"that is also required for certain scenarios with ovn-bgp-agent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change is part of a set of changes in several projects that are necessary to fully"},{"line_number":18,"context_line":"implement ovn-bgp-agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"51cb52dc_e32fd242","line":15,"range":{"start_line":15,"start_character":26,"end_line":15,"end_character":43},"in_reply_to":"6187dc4d_d6449232","updated":"2024-02-09 16:11:25.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Furthermore, it also extends the horizon integration to enable the BGPVPN dashboard plugin,"},{"line_number":15,"context_line":"that is also required for certain scenarios with ovn-bgp-agent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change is part of a set of changes in several projects that are necessary to fully"},{"line_number":18,"context_line":"implement ovn-bgp-agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://opendev.org/openstack/ovn-bgp-agent"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bb191f88_abe87dde","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":24},"updated":"2024-02-09 08:51:28.000000000","message":"do we have a link/topic handy to watch these? I assume it\u0027s more then the one change in \"Depends-On\"?\n\nThe currently used topic doesn\u0027t even have the \"Depends-On\" change.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"74b36b15b7933f91ca11ae515eec55226b604376","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Furthermore, it also extends the horizon integration to enable the BGPVPN dashboard plugin,"},{"line_number":15,"context_line":"that is also required for certain scenarios with ovn-bgp-agent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change is part of a set of changes in several projects that are necessary to fully"},{"line_number":18,"context_line":"implement ovn-bgp-agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://opendev.org/openstack/ovn-bgp-agent"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"586e5855_71e0adb2","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":24},"in_reply_to":"bb191f88_abe87dde","updated":"2024-02-09 16:11:25.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fd6d65e760b2f2080bd849e977b03a8e53ac05f1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ovn-bgp-agent / FRR / Horizon BGPVPN dashboard"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ovn-bgp-agent [1] is a new component that exposes VMs/containers through BGP on OVN"},{"line_number":10,"context_line":"environments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change extends kolla to be also able to build images for ovn-bgp-agent and FRR, as this is"},{"line_number":13,"context_line":"a requirement for ovn-bgp-agent."},{"line_number":14,"context_line":"Furthermore, it also extends the horizon integration to enable the BGPVPN dashboard plugin."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://opendev.org/openstack/ovn-bgp-agent"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I788fbb76af3cd2fc4bd1cafb6004ba09c2362db6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"f0185aac_311115bf","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":0},"updated":"2024-05-28 11:46:22.000000000","message":"lines should be wrapped at 72 characters\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"},{"author":{"_account_id":35638},"change_message_id":"72c1f378a5bc9f48da51c07ceca913f46ecf1a5f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ovn-bgp-agent / FRR / Horizon BGPVPN dashboard"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ovn-bgp-agent [1] is a new component that exposes VMs/containers through BGP on OVN"},{"line_number":10,"context_line":"environments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change extends kolla to be also able to build images for ovn-bgp-agent and FRR, as this is"},{"line_number":13,"context_line":"a requirement for ovn-bgp-agent."},{"line_number":14,"context_line":"Furthermore, it also extends the horizon integration to enable the BGPVPN dashboard plugin."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://opendev.org/openstack/ovn-bgp-agent"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I788fbb76af3cd2fc4bd1cafb6004ba09c2362db6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"d8e3700f_209e18c8","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"f0185aac_311115bf","updated":"2024-06-07 10:33:17.000000000","message":"Done","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35638},"change_message_id":"d6d85c23984ae93a6788d2162ea9365e376fcb61","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fcdb7be1_1148eab6","updated":"2023-08-24 15:30:54.000000000","message":"I saw that other components like rabbitmq or mariadb are also grabbed from their own repository, so I took over that design. \n\nEven in Rocky 9, the included version is about a year old and contains a number of CVEs. I am not sure how critical they are though. \n\nDebian 11 still contains FRR 7, which is even older.\n\nBecause its consistent to other roles of kolla and also ensures a recent codebase, I would vote for that, even if its not a hard opinion.\n\nWhat would you say?","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"37551992e10a3241d84f03990fdd2016ec885f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f626bb28_c2e99ff2","in_reply_to":"fcdb7be1_1148eab6","updated":"2023-11-22 23:25:51.000000000","message":"Sounds fine to me.","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dab05b1c16dc2e94a44ab4c6d4b309bd55ed8bee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f3b5b5c_d277ad97","updated":"2024-01-11 16:09:32.000000000","message":"NOTE to self - rework ovs_ensure_bridge/port/configured to kolla-ansible and remove it from Kolla","commit_id":"f3a78a775bd59653047425e8c779d5319f33f1d1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f2335ea4e290f86569344c727b1b7cba51992f76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b17e6c25_67845dc9","in_reply_to":"5f3b5b5c_d277ad97","updated":"2024-02-05 18:38:44.000000000","message":"Done","commit_id":"f3a78a775bd59653047425e8c779d5319f33f1d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a3d183ab_edfd7185","updated":"2024-02-09 08:51:28.000000000","message":"It would be nice if we could please stop copying and pasting code without checking if it\u0027s still actually needed today.\n\nThis is the very definition of \"cargo culting\" and is really not a good thing to do.\n\nMost of the code is still fine I guess. I\u0027d be glad to review the next iteration. :)","commit_id":"df829a0ccd2d1e15e6abc359da753f7cdbcfee75"},{"author":{"_account_id":35638},"change_message_id":"f22b120000dedc492b30b2f128072de968be15fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"277d98c4_02778c81","updated":"2024-02-14 17:04:38.000000000","message":"To keep the images consistent some of the code is indeed identical to other modules of kolla.\nWhile developing this change, I was unaware that there are old and new patterns in the code.\nRight now I\u0027m working on adapting the recent changes into our CI and once thats finished I will work on the remaining unresolved comments and post a new patchset.","commit_id":"b2580d760074f83278374fadd0a88ca13a4c7c8d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"38473cc31837ff8fbaa0d7212d6b75a46c7155a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":30,"id":"b0b21210_830e7ba9","updated":"2024-04-02 09:37:35.000000000","message":"job kolla-ansible-debian-upgrade fails in check-logs.sh with critical errors in:\nhttps://zuul.opendev.org/t/openstack/build/92f59659d69d4e5ca63a9b5190890f75/log/primary/logs/kolla/all-CRITICAL.txt\n\n\n```\n/var/log/kolla/nova/privsep-helper.log\n\n2024-03-28 11:01:27.496 1065 CRITICAL privsep [-] Unhandled error: FileNotFoundError: [Errno 2] No such file or directory\n```\n\nthe complete errror is:\n\n```\n2024-03-28 11:01:27.496 1065 CRITICAL privsep [-] Unhandled error: FileNotFoundError: [Errno 2] No such file or directory\n\n2024-03-28 11:01:27.496 1065 ERROR privsep Traceback (most recent call last):\n\n2024-03-28 11:01:27.496 1065 ERROR privsep   File \"/var/lib/kolla/venv/bin/privsep-helper\", line 8, in \u003cmodule\u003e\n\n2024-03-28 11:01:27.496 1065 ERROR privsep     sys.exit(helper_main())\n\n2024-03-28 11:01:27.496 1065 ERROR privsep              ^^^^^^^^^^^^^\n\n2024-03-28 11:01:27.496 1065 ERROR privsep   File \"/var/lib/kolla/venv/lib/python3.11/site-packages/oslo_privsep/daemon.py\", line 568, in helper_main\n\n2024-03-28 11:01:27.496 1065 ERROR privsep     sock.connect(cfg.CONF.privsep_sock_path)\n\n2024-03-28 11:01:27.496 1065 ERROR privsep FileNotFoundError: [Errno 2] No such file or directory\n\n2024-03-28 11:01:27.496 1065 ERROR privsep \n```\n\nit seems a socket was not reachable, looking at the traceback.","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd35a435c31c4bab8e3e567bc9002ff240fe3bff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"fe68909e_a7f045d2","in_reply_to":"b0b21210_830e7ba9","updated":"2024-04-16 18:40:15.000000000","message":"Done","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"7f85421e_16835ec7","updated":"2024-04-19 10:44:29.000000000","message":"LGTM so far, one minor nit (see comments below).\n\nInterestingly, the octavia jobs seem to fail with this one. Didn\u0027t yet check why, but seems worth investigating.","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed0f626cb8e2a34f1a3bdf17a30dd4b11cb35e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"42efed4d_17f31a08","in_reply_to":"7f85421e_16835ec7","updated":"2024-06-11 08:09:41.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"18e58efc8309f29b1ccb235069a572f7f0693043","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"41d1e96f_0eb713f1","updated":"2024-04-29 09:49:40.000000000","message":"FRR10 requires libyang 2.1.128 which is not provided by the distro repositories.\nAs a consequence FRR does not start.\n\nWe can either revert back to FRR9 or include a newer libyang from an external repository.\nThe latter option was chosen for the upstream FRR docker image.\n\nIs there any preference from a kolla project side?","commit_id":"b314e354dba9d9875fba3679800330a80d440306"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c2b4e8c09be109cadd16af01d89a154dd49d2f59","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":36,"id":"1762cce0_aedd014c","in_reply_to":"41d1e96f_0eb713f1","updated":"2024-04-29 09:54:17.000000000","message":"So let\u0027s use FRR9 for now.","commit_id":"b314e354dba9d9875fba3679800330a80d440306"},{"author":{"_account_id":35638},"change_message_id":"e285f0ba086ac85056c88f88c85fefc2f46e047a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":36,"id":"654ebc62_7083ca6f","in_reply_to":"41d1e96f_0eb713f1","updated":"2024-04-29 09:55:10.000000000","message":"This should not be resolved.","commit_id":"b314e354dba9d9875fba3679800330a80d440306"},{"author":{"_account_id":35638},"change_message_id":"1a3be033c03e1b01e900dac49b6b613fcabac8b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"d84e3049_70770dca","in_reply_to":"654ebc62_7083ca6f","updated":"2024-04-29 09:55:42.000000000","message":"I agree. Will downgrade in next patchset.","commit_id":"b314e354dba9d9875fba3679800330a80d440306"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bce6dcc97ec115d87c02981b5f2ca194a7160c75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"8687e2c5_3cecd54f","updated":"2024-06-05 15:58:04.000000000","message":"agree with Maksims comments.","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0e303890d80b815ed6aaf9c6812233fe2481b996","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"8cf6a8b6_5bb05439","updated":"2024-05-03 14:06:42.000000000","message":"deletion of the loadbalancer in test-octavia.sh fails with:\n\n```\n openstack loadbalancer delete lb --cascade --wait\n\nThe resource could not be successfully deleted. (HTTP n/a) (Request-ID: None)\n```\n\nit seems weird that no HTTP code is returned.","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed0f626cb8e2a34f1a3bdf17a30dd4b11cb35e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"87e4b709_b9f7f58e","in_reply_to":"474dd7fb_1c88016b","updated":"2024-06-11 08:09:41.000000000","message":"Acknowledged","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f06f72d1156bcce6f391f1fffaea3e5ec28531f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"474dd7fb_1c88016b","in_reply_to":"8cf6a8b6_5bb05439","updated":"2024-05-06 07:07:23.000000000","message":"It\u0027s not caused by this patch, it always fails - for some reason has problems removing Nova instance.","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0782701723ddbd61a8b2b35e31b78cb14d4f5138","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"df680ab2_ff2b3891","updated":"2024-06-18 09:39:59.000000000","message":"LGTM, but please accept suggested from Sven.","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a6b837629a2a9b630b051f4392cb7939ff7abd9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"fbbb90af_6cae7801","updated":"2024-06-17 14:59:12.000000000","message":"LGTM, maybe obvious question, but: Did you test the resulting image somewhere already?\nThat would be nice to know.","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed0f626cb8e2a34f1a3bdf17a30dd4b11cb35e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"cd444a13_4788f279","updated":"2024-06-11 08:09:41.000000000","message":"recheck mariadb base container build failed with Connection failed [IP: 2606:4700::6811:bf0e 443]","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"},{"author":{"_account_id":35638},"change_message_id":"0a45cdc9731d2cd8ade4740e8981320ca3f36830","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"bfca9bee_6186366c","in_reply_to":"fbbb90af_6cae7801","updated":"2024-06-17 17:24:53.000000000","message":"Yes, we\u0027re using these images in combination with my kolla-ansible patch for deployment.","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"55664973424a5c9e7a2582bbb8c5606fc752f1f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":39,"id":"614d6928_5aea29c9","updated":"2024-06-19 12:35:31.000000000","message":"LGTM - but now we need demonstration of working in the kolla-ansible patch","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e339c5a9c29a5bc5fde218a79fad388324d41f23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"aeda1c00_48795e50","updated":"2024-06-19 12:32:29.000000000","message":"LGTM :)\n\nside note and maybe a nice to know information for new contributors in general:\nIt feels weird that you are voting on your own patch. In general a review should be done by someone else and not the author themselves.\n\nThere are rare exceptions, e.g. a core maintainer fixing an urgent bug when no one else is available and the fix must be pushed out asap to users, but in the general non urgent situation we should not review our own patches.\n\nThe reason we are doing reviews is, to spot errors or design mistakes in each others code, as we usually don\u0027t see the errors in our own code.\nIt is basically assumed that you think your code is \"+1/+2\" quality, because you uploaded it and didn\u0027t mark it as \"work in progress\". ;)\n\nThat being said, it\u0027s not really harmful to vote on your own contributions, just not the norm, so no harm done.\n\nHope this helps, and thanks for your contribution!","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"1fecfc69a92c339e226660495e90d187e1f05330","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":39,"id":"fdd82e7e_aec58f60","updated":"2024-06-28 17:07:26.000000000","message":"So I pulled this in, and it looks like the latest frr package from that repository is broken. \n\nStderr: \u0027/usr/bin/vtysh: symbol lookup error: /lib64/libfrr.so.0: undefined symbol: lyd_parent\n\nThat appears in both the frr log and the ovn-bgp-agent log, preventing them from starting up.","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ac93643d9254cbef382668fb3223298207aad2d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":39,"id":"f7749dc2_89bd952a","in_reply_to":"0639b56f_12d489a4","updated":"2024-07-04 14:31:19.000000000","message":"For the sake of getting the feature in Kolla/Kolla-Ansible to working state - please pin - but obviously please add a link to the bug upstream.","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":35638},"change_message_id":"eee4a5a4ff9263b5dcc982018bc5514afe705bf1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":39,"id":"f4452ffd_44860543","in_reply_to":"6b7f5af9_337f1ab4","updated":"2024-07-04 07:39:38.000000000","message":"Yep, can confirm.\nI opened a bug report upstream: https://github.com/FRRouting/frr/issues/16308\nSeems like they are compiling / depending the wrong libyang.\n\nI modified our environment to install the old version, not sure whether it would be best practice to pin the version in this change here as well.","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"a5414e445351f20f7fad41645bace1dca0f942d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":39,"id":"0639b56f_12d489a4","in_reply_to":"f4452ffd_44860543","updated":"2024-07-04 14:21:50.000000000","message":"I also pinned to the previous version I had, but I agree, I don\u0027t know if that\u0027s the right way to go. We may have to do that anyway if this isn\u0027t going to change.","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":35638},"change_message_id":"ff964eaaa79152406f84cb53fb36680b6c8eaf68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"32b8a128_417a4eb6","in_reply_to":"f7749dc2_89bd952a","updated":"2024-07-12 13:22:27.000000000","message":"While preparing the pin, I realized that under normal circumstances the correct libyang package would be grabbed from the frr-extras repository.\nThis repository was in my original patch, but somehow got lost in the past patchsets.\nThe latest patchset readds that, FRR 9.1.1 is now able to start.","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"af3b402be6cfe47b51c65dbf0f4563bec9734ac6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":39,"id":"6b7f5af9_337f1ab4","in_reply_to":"fdd82e7e_aec58f60","updated":"2024-06-28 19:08:23.000000000","message":"Broke down the container that got built, and this is the version that was installed:\n\n()[root@6d5957391ccd /]# rpm -qa | grep frr\nfrr-9.1.1-01.el9.x86_64\nfrr-pythontools-9.1.1-01.el9.x86_64\n\nOn the previous iteration (2 weeks or so ago):\n\n(frr)[root@arcosl0011104 /]# rpm -qa | grep frr\nfrr-9.1-01.el9.x86_64\nfrr-pythontools-9.1-01.el9.x86_64\n\nLooks like its been updated in the repos and that breaks.","commit_id":"6fa300f66797c253186ac310a8f7fe09f6d38c96"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"9e81ce9b8845a9656c78bb5c43b29ce0e0b15369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"8aeeae14_d5bbca25","updated":"2024-12-04 18:34:33.000000000","message":"I am going to refactor this into a new change to get this pushed in, as we need the basic functionality of ovn-bgp-agent for production purposes, without EVPN.","commit_id":"8c73b8863759ddcd8b70ca874b9645d65ef434a4"},{"author":{"_account_id":36250,"name":"Przemysław Kuczyński","display_name":"przemekk","email":"przemyslaw.kuczynski@ochk.pl","username":"przemekk"},"change_message_id":"762eec52448a76986f977bf69c36b7914c5233fe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":45,"id":"23bf18f5_a2a57aff","updated":"2024-09-19 15:33:33.000000000","message":"There is missing one change related to dashboard. Its hard because there is no dedicated repo for bgpvpn_dashboard https://github.com/openstack/networking-bgpvpn/tree/master/bgpvpn_dashboard\nroles/kolla-build-config/defaults/main.yml \nopenstack/bgpvpn-dashboard: neutron-base-plugin-networking-bgpvpn","commit_id":"8c73b8863759ddcd8b70ca874b9645d65ef434a4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"543a3e2c451429618df55a2d3f3b8d6c4bb4aaa2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":45,"id":"2617f4d2_7924f597","in_reply_to":"23bf18f5_a2a57aff","updated":"2024-11-27 15:26:37.000000000","message":"what\u0027s the status of this comment? is this still missing? will this be adressed in this patchset?","commit_id":"8c73b8863759ddcd8b70ca874b9645d65ef434a4"}],"README.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5759152d5b93b76ca4f9a1b45ead1539ebf393c","unresolved":true,"context_lines":[{"line_number":143,"context_line":"- `ZooKeeper \u003chttps://zookeeper.apache.org/\u003e`__ as a centralized service for maintaining"},{"line_number":144,"context_line":"  configuration information, naming, providing distributed synchronization, and providing"},{"line_number":145,"context_line":"  group services."},{"line_number":146,"context_line":"- `FRR \u003chttps://frrouting.org/\u003e`__ as a routing daemon for OVN-BGP-Agent."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Directories"},{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":43,"id":"a196dba8_e9190bc0","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":2},"updated":"2024-08-30 13:24:50.000000000","message":"nit: please keep this list also alphabetically sorted","commit_id":"c585e554bec20fec705e101e3fb70fac5a379019"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5a1456c1538a0f7e31081d6024ad40c7baf5f51e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"- `ZooKeeper \u003chttps://zookeeper.apache.org/\u003e`__ as a centralized service for maintaining"},{"line_number":144,"context_line":"  configuration information, naming, providing distributed synchronization, and providing"},{"line_number":145,"context_line":"  group services."},{"line_number":146,"context_line":"- `FRR \u003chttps://frrouting.org/\u003e`__ as a routing daemon for OVN-BGP-Agent."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Directories"},{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":43,"id":"7d6a0014_88452311","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":2},"in_reply_to":"a196dba8_e9190bc0","updated":"2024-09-03 08:55:32.000000000","message":"Done","commit_id":"c585e554bec20fec705e101e3fb70fac5a379019"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"408090a2756d928a0b08a192fb90ba76f34d620b","unresolved":true,"context_lines":[{"line_number":309,"context_line":"   {\u0027name\u0027: \u0027opensearch\u0027, \u0027url\u0027: \u0027https://artifacts.opensearch.org/publickeys/opensearch.pgp\u0027},"},{"line_number":310,"context_line":"   {\u0027name\u0027: \u0027proxysql\u0027, \u0027url\u0027: \u0027https://repo.proxysql.com/ProxySQL/proxysql-2.5.x/repo_pub_key\u0027},"},{"line_number":311,"context_line":"   {\u0027name\u0027: \u0027treasuredata\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-td-agent\u0027},"},{"line_number":312,"context_line":"   {\u0027name\u0027: \u0027frr\u0027, \u0027url\u0027: \u0027https://deb.frrouting.org/frr/keys.asc\u0027},"},{"line_number":313,"context_line":"] %}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"{% block base_ubuntu_package_installation %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9f928cbe_e63e9ce6","line":312,"range":{"start_line":312,"start_character":0,"end_line":312,"end_character":2},"updated":"2024-02-08 15:21:07.000000000","message":"looking at https://deb.frrouting.org/frr/ I see a gpg and an asc key, but the asc key hasn\u0027t been changed since 2020, while the gpg key was changed in 2023.\n\nthe docs also mention to use the gpg key:\nhttps://deb.frrouting.org/\n\nshould we maybe use the gpg key instead? I didn\u0027t yet inspect the keys themselves.","commit_id":"df5d2ec6980191cc2098b6d8c1a471e106340ced"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"51be711871149d40af6b0cd35b40ccd2f6d1ccab","unresolved":false,"context_lines":[{"line_number":309,"context_line":"   {\u0027name\u0027: \u0027opensearch\u0027, \u0027url\u0027: \u0027https://artifacts.opensearch.org/publickeys/opensearch.pgp\u0027},"},{"line_number":310,"context_line":"   {\u0027name\u0027: \u0027proxysql\u0027, \u0027url\u0027: \u0027https://repo.proxysql.com/ProxySQL/proxysql-2.5.x/repo_pub_key\u0027},"},{"line_number":311,"context_line":"   {\u0027name\u0027: \u0027treasuredata\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-td-agent\u0027},"},{"line_number":312,"context_line":"   {\u0027name\u0027: \u0027frr\u0027, \u0027url\u0027: \u0027https://deb.frrouting.org/frr/keys.asc\u0027},"},{"line_number":313,"context_line":"] %}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"{% block base_ubuntu_package_installation %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"7e004e1b_2d118807","line":312,"range":{"start_line":312,"start_character":0,"end_line":312,"end_character":2},"in_reply_to":"9f928cbe_e63e9ce6","updated":"2024-02-08 15:23:28.000000000","message":"importing these locally shows they seem to be the exactly same keys.","commit_id":"df5d2ec6980191cc2098b6d8c1a471e106340ced"}],"docker/base/frr.repo":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8c0d571633a79d805d3e3ffbd8a3725816023924","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[frr]"},{"line_number":2,"context_line":"name\u003dFRRouting 8.x Packages for Enterprise Linux $releasever - $basearch"},{"line_number":3,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr8"},{"line_number":4,"context_line":"enabled\u003d0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f70e46d4_375a197c","line":1,"updated":"2023-08-17 06:56:34.000000000","message":"What\u0027s wrong with frr from AppStream?","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a8f420f7acfe0987d3103a37a0a15ab9bb48019","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[frr]"},{"line_number":2,"context_line":"name\u003dFRRouting 8.x Packages for Enterprise Linux $releasever - $basearch"},{"line_number":3,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr8"},{"line_number":4,"context_line":"enabled\u003d0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1c5bb81f_dc9f9e49","line":1,"in_reply_to":"f70e46d4_375a197c","updated":"2023-11-22 23:29:46.000000000","message":"Done","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a8f420f7acfe0987d3103a37a0a15ab9bb48019","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[frr]"},{"line_number":2,"context_line":"name\u003dFRRouting 8.x Packages for Enterprise Linux $releasever - $basearch"},{"line_number":3,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr8"},{"line_number":4,"context_line":"enabled\u003d0"},{"line_number":5,"context_line":"gpgcheck\u003d0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fcef7bc8_8502795a","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":18},"updated":"2023-11-22 23:29:46.000000000","message":"should we go with 9.x?","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2183f35983458aa0db60902476d16db844dd678d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[frr]"},{"line_number":2,"context_line":"name\u003dFRRouting 8.x Packages for Enterprise Linux $releasever - $basearch"},{"line_number":3,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr8"},{"line_number":4,"context_line":"enabled\u003d0"},{"line_number":5,"context_line":"gpgcheck\u003d0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"03bbf349_81e56a7b","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":18},"in_reply_to":"fcef7bc8_8502795a","updated":"2024-01-11 16:06:44.000000000","message":"Done","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c827f515760b08f91d3ae3603c0a0834ee5bbed8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"enabled\u003d0"},{"line_number":5,"context_line":"gpgcheck\u003d0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[frr-RPKI]"},{"line_number":8,"context_line":"name\u003dFRRouting 9.x Packages with RPKI for Enterprise Linux $releasever - $basearch"},{"line_number":9,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr-rpki"},{"line_number":10,"context_line":"enabled\u003d0"},{"line_number":11,"context_line":"gpgcheck\u003d0"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[frr-extras]"},{"line_number":14,"context_line":"name\u003dFRRouting Dependencies for Enterprise Linux $releasever - $basearch"},{"line_number":15,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/extras"},{"line_number":16,"context_line":"enabled\u003d0"},{"line_number":17,"context_line":"gpgcheck\u003d0"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"db3564b7_29aea75c","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":10},"updated":"2024-02-26 08:23:38.000000000","message":"this seems to be not used","commit_id":"da85e194c0477dbf2bfe3c1d9e3d119a9be6fc33"},{"author":{"_account_id":35638},"change_message_id":"1ddab124b32ad43adebdeb3a67b3d4668133bd03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"enabled\u003d0"},{"line_number":5,"context_line":"gpgcheck\u003d0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[frr-RPKI]"},{"line_number":8,"context_line":"name\u003dFRRouting 9.x Packages with RPKI for Enterprise Linux $releasever - $basearch"},{"line_number":9,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr-rpki"},{"line_number":10,"context_line":"enabled\u003d0"},{"line_number":11,"context_line":"gpgcheck\u003d0"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[frr-extras]"},{"line_number":14,"context_line":"name\u003dFRRouting Dependencies for Enterprise Linux $releasever - $basearch"},{"line_number":15,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/extras"},{"line_number":16,"context_line":"enabled\u003d0"},{"line_number":17,"context_line":"gpgcheck\u003d0"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"717bb9a4_71fac70a","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":10},"in_reply_to":"ba7b12c3_0f4698ba","updated":"2024-03-17 12:38:58.000000000","message":"Done","commit_id":"da85e194c0477dbf2bfe3c1d9e3d119a9be6fc33"},{"author":{"_account_id":35638},"change_message_id":"e38a52559bdf05d5f0b4017a00c8be4cd5aed826","unresolved":true,"context_lines":[{"line_number":4,"context_line":"enabled\u003d0"},{"line_number":5,"context_line":"gpgcheck\u003d0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[frr-RPKI]"},{"line_number":8,"context_line":"name\u003dFRRouting 9.x Packages with RPKI for Enterprise Linux $releasever - $basearch"},{"line_number":9,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/frr-rpki"},{"line_number":10,"context_line":"enabled\u003d0"},{"line_number":11,"context_line":"gpgcheck\u003d0"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[frr-extras]"},{"line_number":14,"context_line":"name\u003dFRRouting Dependencies for Enterprise Linux $releasever - $basearch"},{"line_number":15,"context_line":"baseurl\u003dhttps://rpm.frrouting.org/repo/el$releasever/extras"},{"line_number":16,"context_line":"enabled\u003d0"},{"line_number":17,"context_line":"gpgcheck\u003d0"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"ba7b12c3_0f4698ba","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":10},"in_reply_to":"db3564b7_29aea75c","updated":"2024-03-04 21:53:27.000000000","message":"Seems you\u0027re right. Copied that over from the installation docs if I remember right. Will remove in next patchset.","commit_id":"da85e194c0477dbf2bfe3c1d9e3d119a9be6fc33"}],"docker/frr/Dockerfile.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.enable_extra_repos([\u0027frr\u0027]) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% set frr_packages \u003d ["},{"line_number":19,"context_line":"        \u0027frr\u0027,"},{"line_number":20,"context_line":"        \u0027frr-pythontools\u0027,"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    {% set frr_packages \u003d ["},{"line_number":26,"context_line":"        \u0027frr\u0027,"},{"line_number":27,"context_line":"        \u0027frr-pythontools\u0027,"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"COPY frr_sudoers /etc/sudoers.d/kolla_frr_sudoers"},{"line_number":33,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"4a6bebd6_08e0e0b8","line":30,"range":{"start_line":16,"start_character":1,"end_line":30,"end_character":11},"updated":"2024-02-09 08:51:28.000000000","message":"why do we make this distinction here if the package names are exactly the same for rpm and deb?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c0a4792214054656e4eb30e7ba6d98592c645b9","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.enable_extra_repos([\u0027frr\u0027]) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% set frr_packages \u003d ["},{"line_number":19,"context_line":"        \u0027frr\u0027,"},{"line_number":20,"context_line":"        \u0027frr-pythontools\u0027,"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    {% set frr_packages \u003d ["},{"line_number":26,"context_line":"        \u0027frr\u0027,"},{"line_number":27,"context_line":"        \u0027frr-pythontools\u0027,"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"COPY frr_sudoers /etc/sudoers.d/kolla_frr_sudoers"},{"line_number":33,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"222acd74_903bbec7","line":30,"range":{"start_line":16,"start_character":1,"end_line":30,"end_character":11},"in_reply_to":"4a6bebd6_08e0e0b8","updated":"2024-02-09 15:45:29.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{{ macros.install_packages(frr_packages | customizable(\"packages\")) }} \\"},{"line_number":36,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_frr_sudoers \\"},{"line_number":37,"context_line":"    \u0026\u0026 mkdir -p /etc/frr/ \\"},{"line_number":38,"context_line":"    \u0026\u0026 rm -Rf /etc/frr/* \\"},{"line_number":39,"context_line":"    \u0026\u0026 mkdir -p /var/run/frr/ \\"},{"line_number":40,"context_line":"    \u0026\u0026 chown -R {{ frr_user }}: /var/run/frr/ \\"},{"line_number":41,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"3c68440f_18b80f99","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":26},"updated":"2024-02-09 08:51:28.000000000","message":"either the directory does not exist, and we need to mkdir it, but then it will be empty so no `rm` needed, or rm is needed, because there is already content there, but then the mkdir is not needed.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1663c1681d423c0a55484791d8a54f5418c629db","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{{ macros.install_packages(frr_packages | customizable(\"packages\")) }} \\"},{"line_number":36,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_frr_sudoers \\"},{"line_number":37,"context_line":"    \u0026\u0026 mkdir -p /etc/frr/ \\"},{"line_number":38,"context_line":"    \u0026\u0026 rm -Rf /etc/frr/* \\"},{"line_number":39,"context_line":"    \u0026\u0026 mkdir -p /var/run/frr/ \\"},{"line_number":40,"context_line":"    \u0026\u0026 chown -R {{ frr_user }}: /var/run/frr/ \\"},{"line_number":41,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"839b964e_9ce19895","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":26},"in_reply_to":"3c68440f_18b80f99","updated":"2024-02-15 07:25:00.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8f31a9442c7f024f9fb5a52c0b2e380eadf66bb7","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{ macros.install_packages(frr_packages | customizable(\"packages\")) }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_frr_sudoers \\"},{"line_number":26,"context_line":"    \u0026\u0026 mkdir -p /var/run/frr/ \\"},{"line_number":27,"context_line":"    \u0026\u0026 chown -R {{ frr_user }}: /var/run/frr/ \\"},{"line_number":28,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block frr_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"c55e4441_7e8a9ba4","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":47},"updated":"2024-04-02 09:29:11.000000000","message":"nit: are we sure these are needed? afaik `/var/run` is always a symlink to `/run` these days and an application is to be expected to create it\u0027s, well, _run_time directories on the fly at runtime.\n\nsee: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s15.html","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"22e9dd4ecda0cfdbcb0c2f0ce039df03351928d8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{ macros.install_packages(frr_packages | customizable(\"packages\")) }} \\"},{"line_number":25,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_frr_sudoers \\"},{"line_number":26,"context_line":"    \u0026\u0026 mkdir -p /var/run/frr/ \\"},{"line_number":27,"context_line":"    \u0026\u0026 chown -R {{ frr_user }}: /var/run/frr/ \\"},{"line_number":28,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block frr_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"9eba936c_ec1d3dde","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":47},"in_reply_to":"c55e4441_7e8a9ba4","updated":"2024-04-17 06:00:54.000000000","message":"Done","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"29bac5531da6a2251b39c7a62b294f90cf6ce87d","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.configure_user(name\u003dfrr_user) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.enable_extra_repos([\u0027frr\u0027]) }}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"51d44c2b_e5b7f839","line":12,"range":{"start_line":12,"start_character":30,"end_line":12,"end_character":38},"updated":"2024-07-18 15:54:39.000000000","message":"for 99% of usecases we don\u0027t use a variable here:\n\n```suggestion\n{{ macros.configure_user(name\u003d\u0027frr\u0027) }}\n```\n\na notable exception to the above is fluentd, because upstream changed the used name frequently. I don\u0027t expect that for frr though, or do you?","commit_id":"9235bbc2da9c296efc520552a5f046705e292437"},{"author":{"_account_id":35638},"change_message_id":"2e9443682b3e86b3530a750cab266e19d479678f","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.configure_user(name\u003dfrr_user) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.enable_extra_repos([\u0027frr\u0027]) }}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"6cc42541_03964383","line":12,"range":{"start_line":12,"start_character":30,"end_line":12,"end_character":38},"in_reply_to":"51d44c2b_e5b7f839","updated":"2024-07-25 11:25:33.000000000","message":"Done","commit_id":"9235bbc2da9c296efc520552a5f046705e292437"}],"docker/frr/extend_start.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":false,"context_lines":[{"line_number":9,"context_line":"USERGROUP\u003d\"frr:kolla\""},{"line_number":10,"context_line":"FRR\u003d\"frr\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ ! -d /var/log/kolla/frr ]; then"},{"line_number":13,"context_line":"    mkdir -p /var/log/kolla/frr"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla/frr) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":16,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla/frr"}],"source_content_type":"text/x-sh","patch_set":12,"id":"09638b6a_fb4058c9","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":31},"updated":"2024-02-09 08:51:28.000000000","message":"I know this is an existing (useless) pattern in kolla, but do we really want to replicate it, even in completely new files?\n\nThis increases the needed effort to clean this up in the future imho.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [ ! -d /var/log/kolla/frr ]; then"},{"line_number":13,"context_line":"    mkdir -p /var/log/kolla/frr"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla/frr) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":16,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla/frr"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":"if [[ $(stat -c %a /var/log/kolla/frr) !\u003d \"2775\" ]]; then"},{"line_number":19,"context_line":"    sudo chmod 2775 /var/log/kolla/frr"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ (-d /var/lib/${FRR}) \u0026\u0026 ($(stat -c %U:%G /var/lib/${FRR}) !\u003d \"${USERGROUP}\") ]]; then"},{"line_number":22,"context_line":"    sudo chown ${USERGROUP} /var/lib/${FRR}"},{"line_number":23,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":12,"id":"795d73fd_688dcf29","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":43},"updated":"2024-02-09 08:51:28.000000000","message":"see above","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"}],"docker/frr/frr_sudoers":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/log/kolla, /usr/bin/chown frr\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/lib/frr, /usr/bin/chown frr\\:kolla /var/lib/frr"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/frr, /usr/bin/chmod 2775 /var/lib/frr"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"934047bf_b4795551","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":90},"updated":"2024-02-09 08:51:28.000000000","message":"is there actually a platform left where chmod and chown are located in `/bin/`?\n\nI checked fedora and ubuntu and both distributions have both binaries located in `/usr/bin/`, so I would assume the same is true for debian and EL variants as well.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"74b36b15b7933f91ca11ae515eec55226b604376","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/log/kolla, /usr/bin/chown frr\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/lib/frr, /usr/bin/chown frr\\:kolla /var/lib/frr"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/frr, /usr/bin/chmod 2775 /var/lib/frr"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7758eb37_508aef81","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":90},"in_reply_to":"576cfa4d_4d8a84c5","updated":"2024-02-09 16:11:25.000000000","message":"And we use the same approach in several places, we could move to /usr/bin/chown only, but I think this needs a followup and testing.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b606d66e9c4634845b7f5afa2b0b4b074bcb3a07","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/log/kolla, /usr/bin/chown frr\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/lib/frr, /usr/bin/chown frr\\:kolla /var/lib/frr"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/frr, /usr/bin/chmod 2775 /var/lib/frr"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"9e89c1b4_3bd7f23d","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":90},"in_reply_to":"7758eb37_508aef81","updated":"2024-02-19 15:30:04.000000000","message":"you really need to check stuff more carefully ;) :)\n\n```\nfor i in master-rocky-9 master-debian-bookworm master-ubuntu-jammy; do echo $i \u0026\u0026 docker run -it quay.io/openstack.kolla/base:$i ls -l /bin; done                                                          ✔  took 43s  at 16:27:03 \nmaster-rocky-9\nlrwxrwxrwx. 1 root root 7 May 16  2022 /bin -\u003e usr/bin\nmaster-debian-bookworm\nlrwxrwxrwx. 1 root root 7 Feb 11 00:00 /bin -\u003e usr/bin\nmaster-ubuntu-jammy\nlrwxrwxrwx. 1 root root 7 Feb 12 14:02 /bin -\u003e usr/bin\n\n```","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1276b1334afc8a0f5a91b30f90e208338e498f3b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/log/kolla, /usr/bin/chown frr\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/lib/frr, /usr/bin/chown frr\\:kolla /var/lib/frr"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/frr, /usr/bin/chmod 2775 /var/lib/frr"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"576cfa4d_4d8a84c5","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":90},"in_reply_to":"934047bf_b4795551","updated":"2024-02-09 15:49:09.000000000","message":"$ for i in master-rocky-9 master-debian-bookworm master-ubuntu-jammy; do echo $i \u0026\u0026 docker run -it quay.io/openstack.kolla/base:$i ls -l /bin/chown; done\nmaster-rocky-9\n-r-xr-xr-x. 1 root root 52 Apr 23  2023 /bin/chown\nmaster-debian-bookworm\n-rwxr-xr-x. 1 root root 72752 Sep 20  2022 /bin/chown\nmaster-ubuntu-jammy\n-rwxr-xr-x. 1 root root 59904 Feb  7  2022 /bin/chown\n\n$ for i in master-rocky-9 master-debian-bookworm master-ubuntu-jammy; do echo $i \u0026\u0026 docker run -it quay.io/openstack.kolla/base:$i ls -l /usr/bin/chown; done\nmaster-rocky-9\n-r-xr-xr-x. 1 root root 52 Apr 23  2023 /usr/bin/chown\nmaster-debian-bookworm\n-rwxr-xr-x. 1 root root 72752 Sep 20  2022 /usr/bin/chown\nmaster-ubuntu-jammy\n-rwxr-xr-x. 1 root root 59904 Feb  7  2022 /usr/bin/chown","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c7d7233369ff9d63eab5d366275f035dfa2a69d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/log/kolla, /usr/bin/chown frr\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/lib/frr, /usr/bin/chown frr\\:kolla /var/lib/frr"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/frr, /usr/bin/chmod 2775 /var/lib/frr"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"bc098127_e43aa189","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":90},"in_reply_to":"9da4dab7_76dbfe19","updated":"2024-02-23 11:17:03.000000000","message":"marking this as \"resolved\" for now, as I have no good solution right now. Still it\u0027s a code smell.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1801a7099f8ce97387c5a42d1c4683f11519aabf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/log/kolla, /usr/bin/chown frr\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/lib/frr, /usr/bin/chown frr\\:kolla /var/lib/frr"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/frr, /usr/bin/chmod 2775 /var/lib/frr"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"cd039e0b_075b8dab","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":90},"in_reply_to":"9e89c1b4_3bd7f23d","updated":"2024-02-19 15:52:58.000000000","message":"I just meant it doesn\u0027t matter where the binary is, it rather matters what the software calling sudo is using - and we should change it in all other places, not only one image.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4d82a0465db03fe87e1f649c6ebaefef37151847","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/log/kolla, /usr/bin/chown frr\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown frr\\:kolla /var/lib/frr, /usr/bin/chown frr\\:kolla /var/lib/frr"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/frr, /usr/bin/chmod 2775 /var/lib/frr"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"9da4dab7_76dbfe19","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":90},"in_reply_to":"cd039e0b_075b8dab","updated":"2024-02-19 16:16:59.000000000","message":"that\u0027s right. I have no clue which paths the callers use though, else I would provide a separate patch to fix this on kollas side (for all containers).","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"}],"docker/horizon/extend_start.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"function config_bgpvpn_dashboard {"},{"line_number":49,"context_line":"    for file in ${SITE_PACKAGES}/bgpvpn_dashboard/enabled/_*[^__].py; do"},{"line_number":50,"context_line":"        config_dashboard \"yes\" \\"},{"line_number":51,"context_line":"            \"${SITE_PACKAGES}/bgpvpn_dashboard/enabled/${file##*/}\" \\"},{"line_number":52,"context_line":"            \"${SITE_PACKAGES}/openstack_dashboard/local/enabled/${file##*/}\""},{"line_number":53,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":12,"id":"0d3436b5_5c4cf466","line":50,"range":{"start_line":50,"start_character":26,"end_line":50,"end_character":29},"updated":"2024-02-09 08:51:28.000000000","message":"why is this always enabled?\nthe commit message only mentions \"that is also required for certain scenarios with ovn-bgp-agent.\" so could we just enable it for these \"certain scenarios\"?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aa325970410955373815f00b1e8dc6afb7d85d7c","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"function config_bgpvpn_dashboard {"},{"line_number":49,"context_line":"    for file in ${SITE_PACKAGES}/bgpvpn_dashboard/enabled/_*[^__].py; do"},{"line_number":50,"context_line":"        config_dashboard \"yes\" \\"},{"line_number":51,"context_line":"            \"${SITE_PACKAGES}/bgpvpn_dashboard/enabled/${file##*/}\" \\"},{"line_number":52,"context_line":"            \"${SITE_PACKAGES}/openstack_dashboard/local/enabled/${file##*/}\""},{"line_number":53,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":12,"id":"e518c0ea_fcd40c31","line":50,"range":{"start_line":50,"start_character":26,"end_line":50,"end_character":29},"in_reply_to":"0d3436b5_5c4cf466","updated":"2024-02-09 15:51:19.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            \"${SITE_PACKAGES}/openstack_dashboard/local/enabled/${file##*/}\""},{"line_number":53,"context_line":"    done"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    config_dashboard \"yes\" \\"},{"line_number":56,"context_line":"        \"${SITE_PACKAGES}/bgpvpn_dashboard/etc/bgpvpn-horizon.yaml\" \\"},{"line_number":57,"context_line":"        \"/etc/openstack-dashboard/bgpvpn-horizon.yaml\""},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":12,"id":"d4c6cf13_320576b5","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":25},"updated":"2024-02-09 08:51:28.000000000","message":"see above","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aa325970410955373815f00b1e8dc6afb7d85d7c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \"${SITE_PACKAGES}/openstack_dashboard/local/enabled/${file##*/}\""},{"line_number":53,"context_line":"    done"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    config_dashboard \"yes\" \\"},{"line_number":56,"context_line":"        \"${SITE_PACKAGES}/bgpvpn_dashboard/etc/bgpvpn-horizon.yaml\" \\"},{"line_number":57,"context_line":"        \"/etc/openstack-dashboard/bgpvpn-horizon.yaml\""},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":12,"id":"667e56ab_d9951444","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":25},"in_reply_to":"d4c6cf13_320576b5","updated":"2024-02-09 15:51:19.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"}],"docker/neutron/ovn-bgp-agent/Dockerfile.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"29bac5531da6a2251b39c7a62b294f90cf6ce87d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% set ovn_bgp_agent_user \u003d \u0027ovn-bgp-agent\u0027 %}"},{"line_number":7,"context_line":"{% set frr_user \u003d \u0027frr\u0027 %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block ovn_bgp_agent_header %}{% endblock %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{{ macros.configure_user(name\u003dovn_bgp_agent_user) }}"},{"line_number":14,"context_line":"{{ macros.configure_user(name\u003dfrr_user) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.enable_extra_repos([\u0027frr\u0027]) }}"},{"line_number":17,"context_line":"{{ macros.enable_extra_repos([\u0027openvswitch\u0027]) }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"ea56cab6_1b34dcd9","line":14,"range":{"start_line":6,"start_character":0,"end_line":14,"end_character":42},"updated":"2024-07-18 15:54:39.000000000","message":"```suggestion\n{% block ovn_bgp_agent_header %}{% endblock %}\n\n{% import \"macros.j2\" as macros with context %}\n\n{{ macros.configure_user(name\u003d\u0027ovn-bgp-agent\u0027) }}\n{{ macros.configure_user(name\u003d\u0027frr\u0027) }}\n```","commit_id":"9235bbc2da9c296efc520552a5f046705e292437"},{"author":{"_account_id":35638},"change_message_id":"2e9443682b3e86b3530a750cab266e19d479678f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% set ovn_bgp_agent_user \u003d \u0027ovn-bgp-agent\u0027 %}"},{"line_number":7,"context_line":"{% set frr_user \u003d \u0027frr\u0027 %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block ovn_bgp_agent_header %}{% endblock %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{{ macros.configure_user(name\u003dovn_bgp_agent_user) }}"},{"line_number":14,"context_line":"{{ macros.configure_user(name\u003dfrr_user) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{{ macros.enable_extra_repos([\u0027frr\u0027]) }}"},{"line_number":17,"context_line":"{{ macros.enable_extra_repos([\u0027openvswitch\u0027]) }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"19d45ead_6f24baaf","line":14,"range":{"start_line":6,"start_character":0,"end_line":14,"end_character":42},"in_reply_to":"ea56cab6_1b34dcd9","updated":"2024-07-25 11:25:33.000000000","message":"Done","commit_id":"9235bbc2da9c296efc520552a5f046705e292437"}],"docker/neutron/ovn-bgp-agent/extend_start.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"29bac5531da6a2251b39c7a62b294f90cf6ce87d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"USERGROUP\u003d\"ovn-bgp-agent:kolla\""},{"line_number":10,"context_line":"OVNBGPAGENT\u003d\"ovn-bgp-agent\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [[ (-d /var/lib/${OVNBGPAGENT}) \u0026\u0026 ($(stat -c %U:%G /var/lib/${OVNBGPAGENT}) !\u003d \"${USERGROUP}\") ]]; then"},{"line_number":13,"context_line":"    sudo chown ${USERGROUP} /var/lib/${OVNBGPAGENT}"},{"line_number":14,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":40,"id":"d87a5089_a02216a2","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":34},"updated":"2024-07-18 15:54:39.000000000","message":"not sure what we are gaining by checking for this first?","commit_id":"9235bbc2da9c296efc520552a5f046705e292437"},{"author":{"_account_id":35638},"change_message_id":"2e9443682b3e86b3530a750cab266e19d479678f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"USERGROUP\u003d\"ovn-bgp-agent:kolla\""},{"line_number":10,"context_line":"OVNBGPAGENT\u003d\"ovn-bgp-agent\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [[ (-d /var/lib/${OVNBGPAGENT}) \u0026\u0026 ($(stat -c %U:%G /var/lib/${OVNBGPAGENT}) !\u003d \"${USERGROUP}\") ]]; then"},{"line_number":13,"context_line":"    sudo chown ${USERGROUP} /var/lib/${OVNBGPAGENT}"},{"line_number":14,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":40,"id":"a2c4346a_b22ea17b","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":34},"in_reply_to":"d87a5089_a02216a2","updated":"2024-07-25 11:25:33.000000000","message":"If the folder does not exist it would throw an error here","commit_id":"9235bbc2da9c296efc520552a5f046705e292437"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"543a3e2c451429618df55a2d3f3b8d6c4bb4aaa2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# Give processes executed with the \"kolla\" group the permission to create files"},{"line_number":4,"context_line":"# and sub-directories in the /var/log/kolla directory."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log/kolla directory so that new"},{"line_number":7,"context_line":"# files and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"USERGROUP\u003d\"ovn-bgp-agent:kolla\""},{"line_number":10,"context_line":"OVNBGPAGENT\u003d\"ovn-bgp-agent\""}],"source_content_type":"text/x-sh","patch_set":45,"id":"f5fc7615_c219a288","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":77},"updated":"2024-11-27 15:26:37.000000000","message":"this comment doesn\u0027t match the code anymore, is this not needed anymore?","commit_id":"8c73b8863759ddcd8b70ca874b9645d65ef434a4"}],"docker/openvswitch/openvswitch-db-server/ovs_ensure_port.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a8f420f7acfe0987d3103a37a0a15ab9bb48019","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o errexit"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"bridge\u003d$1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"75f8dd1d_5b29cd90","line":1,"updated":"2023-11-22 23:29:46.000000000","message":"Renaming that file needs at least a reno and I don\u0027t think it\u0027s backwards compatible","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f2335ea4e290f86569344c727b1b7cba51992f76","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o errexit"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"bridge\u003d$1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ac30c318_cfb69b45","line":1,"in_reply_to":"75f8dd1d_5b29cd90","updated":"2024-02-05 18:38:44.000000000","message":"Done","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"}],"docker/ovn-bgp-agent/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6aa416187e4ca5f08d057f0f90cc3c53119d26dd","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/{{ ovn_bgp_agent_user }} \\"},{"line_number":60,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"RUN pip3 install git+https://opendev.org/openstack/ovn-bgp-agent.git"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% block ovn_bgp_agent_footer %}{% endblock %}"},{"line_number":65,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"c84180da_7986db4e","line":62,"updated":"2024-01-11 17:59:01.000000000","message":"use regular Kolla sources","commit_id":"2fb0ae2696a011db8bfaedd3e5a7ae0db232ac68"},{"author":{"_account_id":35638},"change_message_id":"ba2ea2e3b5b6e968ea303480a9940769b3882c10","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/{{ ovn_bgp_agent_user }} \\"},{"line_number":60,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"RUN pip3 install git+https://opendev.org/openstack/ovn-bgp-agent.git"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% block ovn_bgp_agent_footer %}{% endblock %}"},{"line_number":65,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"6c749344_93427db2","line":62,"in_reply_to":"2dcea4d4_c98038e6","updated":"2024-02-06 14:11:14.000000000","message":"Starting with 2023.2, ovn-bgp-agent has published a release specific branch, should we grab that instead?","commit_id":"2fb0ae2696a011db8bfaedd3e5a7ae0db232ac68"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"69a44b77c3e26adfa9a457fadabe5a76001b2887","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/{{ ovn_bgp_agent_user }} \\"},{"line_number":60,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"RUN pip3 install git+https://opendev.org/openstack/ovn-bgp-agent.git"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% block ovn_bgp_agent_footer %}{% endblock %}"},{"line_number":65,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"d2670c7a_0bcad05f","line":62,"in_reply_to":"6c749344_93427db2","updated":"2024-02-08 10:43:14.000000000","message":"No, for master we grab master, when we release everything will automatically use stable branch - but this patch won\u0027t be back ported to 2023.2 - because it\u0027s a feature.","commit_id":"2fb0ae2696a011db8bfaedd3e5a7ae0db232ac68"},{"author":{"_account_id":35638},"change_message_id":"6da2bf8207ab00f9c95649bdbf4b470ff3215e00","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/{{ ovn_bgp_agent_user }} \\"},{"line_number":60,"context_line":"    \u0026\u0026 chmod 644 /usr/local/bin/kolla_extend_start"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"RUN pip3 install git+https://opendev.org/openstack/ovn-bgp-agent.git"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% block ovn_bgp_agent_footer %}{% endblock %}"},{"line_number":65,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"2dcea4d4_c98038e6","line":62,"in_reply_to":"c84180da_7986db4e","updated":"2024-02-06 14:09:24.000000000","message":"First of all, sorry for my late reply. \nIs this still an issue? What would be the regular kolla source?","commit_id":"2fb0ae2696a011db8bfaedd3e5a7ae0db232ac68"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":43,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{{ macros.install_packages(ovn_bgp_agent_packages | customizable(\"packages\")) }} \\"},{"line_number":46,"context_line":"# NOTE(hrw): Upstream moved tcpdump to /usr/bin/ in 4.99 version (used in Debian)"},{"line_number":47,"context_line":"    \u0026\u0026 if [ -e /usr/sbin/tcpdump ]; then mv /usr/sbin/tcpdump /usr/bin/tcpdump; fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% set ovn_bgp_agent_pip_packages \u003d ["},{"line_number":50,"context_line":"    \u0027/ovn-bgp-agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"931b701a_fac9acc9","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":82},"updated":"2024-02-09 08:51:28.000000000","message":"I don\u0027t know where this code was copied and pasted from, but did you check if it still applies?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"be59163e21c386c4d3e935dceff921a84132196a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{{ macros.install_packages(ovn_bgp_agent_packages | customizable(\"packages\")) }} \\"},{"line_number":46,"context_line":"# NOTE(hrw): Upstream moved tcpdump to /usr/bin/ in 4.99 version (used in Debian)"},{"line_number":47,"context_line":"    \u0026\u0026 if [ -e /usr/sbin/tcpdump ]; then mv /usr/sbin/tcpdump /usr/bin/tcpdump; fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% set ovn_bgp_agent_pip_packages \u003d ["},{"line_number":50,"context_line":"    \u0027/ovn-bgp-agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"2367c767_7ef49846","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":82},"in_reply_to":"931b701a_fac9acc9","updated":"2024-02-12 13:41:38.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    \u0026\u0026 mkdir -p /etc/frr \\"},{"line_number":57,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/ovn-bgp-agent /etc/ovn-bgp-agent/ \\"},{"line_number":58,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/frr /etc/frr/ \\"},{"line_number":59,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ovn-bgp-agent/rootwrap.conf \\"},{"line_number":60,"context_line":"    \u0026\u0026 mkdir -o /var/run/ovn-bgp-agent \\"},{"line_number":61,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/ovn-bgp-agent \\"},{"line_number":62,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"360309e9_0b0f3154","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"updated":"2024-02-09 08:51:28.000000000","message":"wouldn\u0027t it be nice to use a proper patch here, or even provide it upstream so we don\u0027t have to sed this here? are we sure this sed still works and doesn\u0027t do bad things with upstreams code? It also looks like it was copied and pasted from somewhere else, is that the case?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c0a4792214054656e4eb30e7ba6d98592c645b9","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    \u0026\u0026 mkdir -p /etc/frr \\"},{"line_number":57,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/ovn-bgp-agent /etc/ovn-bgp-agent/ \\"},{"line_number":58,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/frr /etc/frr/ \\"},{"line_number":59,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ovn-bgp-agent/rootwrap.conf \\"},{"line_number":60,"context_line":"    \u0026\u0026 mkdir -o /var/run/ovn-bgp-agent \\"},{"line_number":61,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/ovn-bgp-agent \\"},{"line_number":62,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"60bab48f_6b7a5425","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"in_reply_to":"360309e9_0b0f3154","updated":"2024-02-09 15:45:29.000000000","message":"Yes, pasted from other images, feel free to change it in a followup ;-)","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1276b1334afc8a0f5a91b30f90e208338e498f3b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0026\u0026 mkdir -p /etc/frr \\"},{"line_number":57,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/ovn-bgp-agent /etc/ovn-bgp-agent/ \\"},{"line_number":58,"context_line":"    \u0026\u0026 cp -r /ovn-bgp-agent/etc/frr /etc/frr/ \\"},{"line_number":59,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ovn-bgp-agent/rootwrap.conf \\"},{"line_number":60,"context_line":"    \u0026\u0026 mkdir -o /var/run/ovn-bgp-agent \\"},{"line_number":61,"context_line":"    \u0026\u0026 chown -R {{ ovn_bgp_agent_user }}: /var/run/ovn-bgp-agent \\"},{"line_number":62,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9494d480_6571ba2b","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"in_reply_to":"60bab48f_6b7a5425","updated":"2024-02-09 15:49:09.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"}],"docker/ovn-bgp-agent/extend_start.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":9,"context_line":"USERGROUP\u003d\"ovn-bgp-agent:kolla\""},{"line_number":10,"context_line":"OVNBGPAGENT\u003d\"ovn-bgp-agent\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ ! -d /var/log/kolla/ovn-bgp-agent ]; then"},{"line_number":13,"context_line":"    mkdir -p /var/log/kolla/ovn-bgp-agent"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla/ovn-bgp-agent) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":16,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla/ovn-bgp-agent"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":"if [[ $(stat -c %a /var/log/kolla/ovn-bgp-agent) !\u003d \"2775\" ]]; then"},{"line_number":19,"context_line":"    sudo chmod 2775 /var/log/kolla/ovn-bgp-agent"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ (-d /var/lib/${OVNBGPAGENT}) \u0026\u0026 ($(stat -c %U:%G /var/lib/${OVNBGPAGENT}) !\u003d \"${USERGROUP}\") ]]; then"},{"line_number":22,"context_line":"    sudo chown ${USERGROUP} /var/lib/${OVNBGPAGENT}"},{"line_number":23,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":12,"id":"54aea839_f460bea0","line":22,"range":{"start_line":12,"start_character":0,"end_line":22,"end_character":51},"updated":"2024-02-09 08:51:28.000000000","message":"see my other comment about cargo culting old patterns into new files","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fa1801facfb238a6d1fe7084e5d592e9e5421118","unresolved":false,"context_lines":[{"line_number":9,"context_line":"USERGROUP\u003d\"ovn-bgp-agent:kolla\""},{"line_number":10,"context_line":"OVNBGPAGENT\u003d\"ovn-bgp-agent\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ ! -d /var/log/kolla/ovn-bgp-agent ]; then"},{"line_number":13,"context_line":"    mkdir -p /var/log/kolla/ovn-bgp-agent"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla/ovn-bgp-agent) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":16,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla/ovn-bgp-agent"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":"if [[ $(stat -c %a /var/log/kolla/ovn-bgp-agent) !\u003d \"2775\" ]]; then"},{"line_number":19,"context_line":"    sudo chmod 2775 /var/log/kolla/ovn-bgp-agent"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ (-d /var/lib/${OVNBGPAGENT}) \u0026\u0026 ($(stat -c %U:%G /var/lib/${OVNBGPAGENT}) !\u003d \"${USERGROUP}\") ]]; then"},{"line_number":22,"context_line":"    sudo chown ${USERGROUP} /var/lib/${OVNBGPAGENT}"},{"line_number":23,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":12,"id":"29e708f4_c5555027","line":22,"range":{"start_line":12,"start_character":0,"end_line":22,"end_character":51},"in_reply_to":"54aea839_f460bea0","updated":"2024-03-28 11:20:15.000000000","message":"Acknowledged","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"}],"docker/ovn-bgp-agent/ovn_bgp_agent_sudoers":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown ovn-bgp-agent\\:kolla /var/log/kolla, /usr/bin/chown ovn-bgp-agent\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown ovn-bgp-agent\\:kolla /var/lib/ovn-bgp-agent, /usr/bin/chown ovn-bgp-agent\\:kolla /var/lib/ovn-bgp-agent"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/ovn-bgp-agent, /usr/bin/chmod 2775 /var/lib/ovn-bgp-agent"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa23fd6b_f7a25cef","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":110},"updated":"2024-02-09 08:51:28.000000000","message":"see my other comment about `/bin/` vs `/usr/bin/`","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9db437371f4a5138c720d0e5546fad56971c0d6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown ovn-bgp-agent\\:kolla /var/log/kolla, /usr/bin/chown ovn-bgp-agent\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown ovn-bgp-agent\\:kolla /var/lib/ovn-bgp-agent, /usr/bin/chown ovn-bgp-agent\\:kolla /var/lib/ovn-bgp-agent"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/ovn-bgp-agent, /usr/bin/chmod 2775 /var/lib/ovn-bgp-agent"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"acbad85d_97cc5812","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":110},"in_reply_to":"fa23fd6b_f7a25cef","updated":"2024-02-15 10:43:44.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"}],"kolla/common/config.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fd6d65e760b2f2080bd849e977b03a8e53ac05f1","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                    \u0027redis\u0027,"},{"line_number":68,"context_line":"                    \u0027storm\u0027,"},{"line_number":69,"context_line":"                    \u0027tgtd\u0027,"},{"line_number":70,"context_line":"                    \u0027frr\u0027,"},{"line_number":71,"context_line":"                    \u0027ovn-bgp-agent\u0027,"},{"line_number":72,"context_line":"                ],"},{"line_number":73,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":74,"context_line":"    cfg.ListOpt(\u0027main\u0027,"}],"source_content_type":"text/x-python","patch_set":37,"id":"e066e8a8_30130ee7","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":36},"updated":"2024-05-28 11:46:22.000000000","message":"please place this alphabetically sorted","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"},{"author":{"_account_id":35638},"change_message_id":"72c1f378a5bc9f48da51c07ceca913f46ecf1a5f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                    \u0027redis\u0027,"},{"line_number":68,"context_line":"                    \u0027storm\u0027,"},{"line_number":69,"context_line":"                    \u0027tgtd\u0027,"},{"line_number":70,"context_line":"                    \u0027frr\u0027,"},{"line_number":71,"context_line":"                    \u0027ovn-bgp-agent\u0027,"},{"line_number":72,"context_line":"                ],"},{"line_number":73,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":74,"context_line":"    cfg.ListOpt(\u0027main\u0027,"}],"source_content_type":"text/x-python","patch_set":37,"id":"f4dda5a8_9acfefee","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":36},"in_reply_to":"e066e8a8_30130ee7","updated":"2024-06-07 10:33:17.000000000","message":"Done","commit_id":"68ef25d416b1e6327bccb588ac81daccb8fd2576"}],"kolla/image/unbuildable.py":[{"author":{"_account_id":35638},"change_message_id":"c586ac149f356300853df42dd060800161ae6d67","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \u0027centos+aarch64\u0027: {"},{"line_number":34,"context_line":"        \"frr\",           # no aarch64 packages"},{"line_number":35,"context_line":"        \"telegraf\",      # no binary package"},{"line_number":36,"context_line":"    },"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":12,"id":"a0cd96d8_0789aa7d","line":35,"updated":"2024-02-08 12:30:01.000000000","message":"Same thing here?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ed858e42b1f72717b6d206117d6c8a703166edb0","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \u0027centos+aarch64\u0027: {"},{"line_number":34,"context_line":"        \"frr\",           # no aarch64 packages"},{"line_number":35,"context_line":"        \"telegraf\",      # no binary package"},{"line_number":36,"context_line":"    },"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \u0027debian\u0027: {"}],"source_content_type":"text/x-python","patch_set":12,"id":"2a38b1b5_c7db438b","line":35,"in_reply_to":"a0cd96d8_0789aa7d","updated":"2024-02-08 12:34:13.000000000","message":"Nope, look at bottom, moved for alphabetical order.","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a6b837629a2a9b630b051f4392cb7939ff7abd9f","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \u0027centos+aarch64\u0027: {"},{"line_number":34,"context_line":"        \"frr\",            # no aarch64 packages"},{"line_number":35,"context_line":"        \"ovn-bgp-agent\",  # no frr aarch64 packages"},{"line_number":36,"context_line":"        \"telegraf\",       # no binary package"},{"line_number":37,"context_line":"    },"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"8d757e07_5a458171","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":34},"updated":"2024-06-17 14:59:12.000000000","message":"nit:\n\n```suggestion\n        \"ovn-bgp-agent\",  # no aarch64 packages\n```","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"},{"author":{"_account_id":35638},"change_message_id":"2cee8e9b718e7a3d87666a3650d54b65e291427e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \u0027centos+aarch64\u0027: {"},{"line_number":34,"context_line":"        \"frr\",            # no aarch64 packages"},{"line_number":35,"context_line":"        \"ovn-bgp-agent\",  # no frr aarch64 packages"},{"line_number":36,"context_line":"        \"telegraf\",       # no binary package"},{"line_number":37,"context_line":"    },"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"465dc340_890b76c3","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":34},"in_reply_to":"8d757e07_5a458171","updated":"2024-06-19 10:43:58.000000000","message":"Done","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a6b837629a2a9b630b051f4392cb7939ff7abd9f","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    \u0027rocky+aarch64\u0027: {"},{"line_number":52,"context_line":"        \"frr\",            # no aarch64 packages"},{"line_number":53,"context_line":"        \"ovn-bgp-agent\",  # no frr aarch64 packages"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    \u0027ubuntu\u0027: {"}],"source_content_type":"text/x-python","patch_set":38,"id":"cd124f37_94fc5fa1","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":13},"updated":"2024-06-17 14:59:12.000000000","message":"nit:\n```suggestion\n        \"ovn-bgp-agent\",  # no aarch64 packages\n```","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"},{"author":{"_account_id":35638},"change_message_id":"2cee8e9b718e7a3d87666a3650d54b65e291427e","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    \u0027rocky+aarch64\u0027: {"},{"line_number":52,"context_line":"        \"frr\",            # no aarch64 packages"},{"line_number":53,"context_line":"        \"ovn-bgp-agent\",  # no frr aarch64 packages"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    \u0027ubuntu\u0027: {"}],"source_content_type":"text/x-python","patch_set":38,"id":"14ea12cb_71091ce0","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":13},"in_reply_to":"cd124f37_94fc5fa1","updated":"2024-06-19 10:43:58.000000000","message":"Done","commit_id":"a273e3805c412b59238d5be76b7166dc7352162f"}],"kolla/template/repos.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8c0d571633a79d805d3e3ffbd8a3725816023924","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    suite: \"bullseye\""},{"line_number":84,"context_line":"    component: \"contrib\""},{"line_number":85,"context_line":"    gpg_key: \"treasuredata.asc\""},{"line_number":86,"context_line":"  frr:"},{"line_number":87,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":88,"context_line":"    suite: \"bullseye\""},{"line_number":89,"context_line":"    component: \"frr-8\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9b30afa8_c5535a6b","line":86,"updated":"2023-08-17 06:56:34.000000000","message":"what\u0027s wrong with the one in Debian repos?","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f2335ea4e290f86569344c727b1b7cba51992f76","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    suite: \"bullseye\""},{"line_number":84,"context_line":"    component: \"contrib\""},{"line_number":85,"context_line":"    gpg_key: \"treasuredata.asc\""},{"line_number":86,"context_line":"  frr:"},{"line_number":87,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":88,"context_line":"    suite: \"bullseye\""},{"line_number":89,"context_line":"    component: \"frr-8\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"818be07a_7d97a595","line":86,"in_reply_to":"9b30afa8_c5535a6b","updated":"2024-02-05 18:38:44.000000000","message":"Done","commit_id":"fd1e4512a01aef8286f9e5d46f3ec88cf54b9fb9"},{"author":{"_account_id":35638},"change_message_id":"19d299cea67042f80a3555649f535deb9ba4c10a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  opstools: \"centos-opstools\""},{"line_number":17,"context_line":"  proxysql: \"proxysql\""},{"line_number":18,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":19,"context_line":"  td-agent: \"treasuredata\""},{"line_number":20,"context_line":"  frr: \"frr\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"centos-aarch64:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6ef24916_21525c2d","line":19,"updated":"2024-02-08 12:19:47.000000000","message":"Is it intended to have td-agent in this change?","commit_id":"96ba24eb47833563480ac721b10450ebf94d59c5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cec5668db2366c294d6686f9bfdb8ac712976b24","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  opstools: \"centos-opstools\""},{"line_number":17,"context_line":"  proxysql: \"proxysql\""},{"line_number":18,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":19,"context_line":"  td-agent: \"treasuredata\""},{"line_number":20,"context_line":"  frr: \"frr\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"centos-aarch64:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0bb1c644_fee1703d","line":19,"in_reply_to":"6ef24916_21525c2d","updated":"2024-02-08 12:21:28.000000000","message":"Thanks for spotting this, don\u0027t know how it got there...","commit_id":"96ba24eb47833563480ac721b10450ebf94d59c5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":89,"context_line":"  frr:"},{"line_number":90,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":91,"context_line":"    suite: \"bullseye\""},{"line_number":92,"context_line":"    component: \"frr-8\""},{"line_number":93,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"debian-aarch64:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ad78f66b_3ed42d07","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":21},"updated":"2024-02-09 08:51:28.000000000","message":"9?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c0a4792214054656e4eb30e7ba6d98592c645b9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  frr:"},{"line_number":90,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":91,"context_line":"    suite: \"bullseye\""},{"line_number":92,"context_line":"    component: \"frr-8\""},{"line_number":93,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"debian-aarch64:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"151d082d_17463f3b","line":92,"range":{"start_line":92,"start_character":20,"end_line":92,"end_character":21},"in_reply_to":"ad78f66b_3ed42d07","updated":"2024-02-09 15:45:29.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":144,"context_line":"  frr:"},{"line_number":145,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":146,"context_line":"    suite: \"bullseye\""},{"line_number":147,"context_line":"    component: \"frr-8\""},{"line_number":148,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"rocky:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"855ee428_ffd8654c","line":147,"range":{"start_line":147,"start_character":20,"end_line":147,"end_character":21},"updated":"2024-02-09 08:51:28.000000000","message":"9?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c0a4792214054656e4eb30e7ba6d98592c645b9","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  frr:"},{"line_number":145,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":146,"context_line":"    suite: \"bullseye\""},{"line_number":147,"context_line":"    component: \"frr-8\""},{"line_number":148,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"rocky:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"cba3dea9_0999e0fe","line":147,"range":{"start_line":147,"start_character":20,"end_line":147,"end_character":21},"in_reply_to":"855ee428_ffd8654c","updated":"2024-02-09 15:45:29.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":234,"context_line":"  frr:"},{"line_number":235,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":236,"context_line":"    suite: \"jammy\""},{"line_number":237,"context_line":"    component: \"frr-8\""},{"line_number":238,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"ubuntu-aarch64:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ee71ba02_031884d7","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":21},"updated":"2024-02-09 08:51:28.000000000","message":"9?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c0a4792214054656e4eb30e7ba6d98592c645b9","unresolved":false,"context_lines":[{"line_number":234,"context_line":"  frr:"},{"line_number":235,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":236,"context_line":"    suite: \"jammy\""},{"line_number":237,"context_line":"    component: \"frr-8\""},{"line_number":238,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"ubuntu-aarch64:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"75506959_79bb9c68","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":21},"in_reply_to":"ee71ba02_031884d7","updated":"2024-02-09 15:45:29.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5cf34c69ecef7dcaf97a8bacbbdae277aa022ce","unresolved":true,"context_lines":[{"line_number":287,"context_line":"  frr:"},{"line_number":288,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":289,"context_line":"    suite: \"jammy\""},{"line_number":290,"context_line":"    component: \"frr-8\""},{"line_number":291,"context_line":"    gpg_key: \"frr.asc\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6ebf8084_52307112","line":290,"range":{"start_line":290,"start_character":20,"end_line":290,"end_character":21},"updated":"2024-02-09 08:51:28.000000000","message":"9?","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c0a4792214054656e4eb30e7ba6d98592c645b9","unresolved":false,"context_lines":[{"line_number":287,"context_line":"  frr:"},{"line_number":288,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":289,"context_line":"    suite: \"jammy\""},{"line_number":290,"context_line":"    component: \"frr-8\""},{"line_number":291,"context_line":"    gpg_key: \"frr.asc\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e608e7fa_dc44c85f","line":290,"range":{"start_line":290,"start_character":20,"end_line":290,"end_character":21},"in_reply_to":"6ebf8084_52307112","updated":"2024-02-09 15:45:29.000000000","message":"Done","commit_id":"553c0d77c0e40665fabe8bf009ffc064afa44722"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8f31a9442c7f024f9fb5a52c0b2e380eadf66bb7","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  opstools: \"centos-opstools\""},{"line_number":36,"context_line":"  proxysql: \"proxysql\""},{"line_number":37,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":38,"context_line":"  frr: \"frr\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE(mnasiadka): For RabbitMQ Debuntu suite names is following:"},{"line_number":41,"context_line":"# https://www.rabbitmq.com/install-debian.html#apt-cloudsmith"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"72c32c8b_ad6c055a","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"updated":"2024-04-02 09:29:11.000000000","message":"in https://review.opendev.org/c/openstack/kolla/+/891617/30/kolla/image/unbuildable.py#33 this is marked as unbuildable?","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"18184afa9444118df7aa336e32ae36be18d85a22","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  opstools: \"centos-opstools\""},{"line_number":36,"context_line":"  proxysql: \"proxysql\""},{"line_number":37,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":38,"context_line":"  frr: \"frr\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE(mnasiadka): For RabbitMQ Debuntu suite names is following:"},{"line_number":41,"context_line":"# https://www.rabbitmq.com/install-debian.html#apt-cloudsmith"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"b136efab_d22b6a74","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"in_reply_to":"72c32c8b_ad6c055a","updated":"2024-04-15 07:00:31.000000000","message":"And what\u0027s the problem with it?","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd35a435c31c4bab8e3e567bc9002ff240fe3bff","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  opstools: \"centos-opstools\""},{"line_number":36,"context_line":"  proxysql: \"proxysql\""},{"line_number":37,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":38,"context_line":"  frr: \"frr\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE(mnasiadka): For RabbitMQ Debuntu suite names is following:"},{"line_number":41,"context_line":"# https://www.rabbitmq.com/install-debian.html#apt-cloudsmith"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"b9b0480e_759600af","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"in_reply_to":"b136efab_d22b6a74","updated":"2024-04-16 18:40:15.000000000","message":"Done","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8f31a9442c7f024f9fb5a52c0b2e380eadf66bb7","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  opstools: \"centos-opstools\""},{"line_number":165,"context_line":"  proxysql: \"proxysql\""},{"line_number":166,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":167,"context_line":"  frr: \"frr\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"rocky-aarch64:"},{"line_number":170,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"e545d19e_05100ca1","line":167,"range":{"start_line":167,"start_character":0,"end_line":167,"end_character":2},"updated":"2024-04-02 09:29:11.000000000","message":"this is also marked as unbuildable, why is it added here?","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd35a435c31c4bab8e3e567bc9002ff240fe3bff","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  opstools: \"centos-opstools\""},{"line_number":165,"context_line":"  proxysql: \"proxysql\""},{"line_number":166,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":167,"context_line":"  frr: \"frr\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"rocky-aarch64:"},{"line_number":170,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"2863e83b_bb1bbf2a","line":167,"range":{"start_line":167,"start_character":0,"end_line":167,"end_character":2},"in_reply_to":"8054859e_6cc463ed","updated":"2024-04-16 18:40:15.000000000","message":"Done","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"18184afa9444118df7aa336e32ae36be18d85a22","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  opstools: \"centos-opstools\""},{"line_number":165,"context_line":"  proxysql: \"proxysql\""},{"line_number":166,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":167,"context_line":"  frr: \"frr\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"rocky-aarch64:"},{"line_number":170,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"8054859e_6cc463ed","line":167,"range":{"start_line":167,"start_character":0,"end_line":167,"end_character":2},"in_reply_to":"e545d19e_05100ca1","updated":"2024-04-15 07:00:31.000000000","message":"Why not? When the packages are there we just remove that from unbuildable","commit_id":"57e871e5c398169ccdecb207bede6e3b42a98cbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  opstools: \"centos-opstools\""},{"line_number":17,"context_line":"  proxysql: \"proxysql\""},{"line_number":18,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":19,"context_line":"  frr: \"frr\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"centos-aarch64:"},{"line_number":22,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"fd3a4032_b0a24a2c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":2},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  opstools: \"centos-opstools\""},{"line_number":17,"context_line":"  proxysql: \"proxysql\""},{"line_number":18,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":19,"context_line":"  frr: \"frr\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"centos-aarch64:"},{"line_number":22,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"b4ca5e89_ed193498","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":2},"in_reply_to":"fd3a4032_b0a24a2c","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  opstools: \"centos-opstools\""},{"line_number":36,"context_line":"  proxysql: \"proxysql\""},{"line_number":37,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":38,"context_line":"  frr: \"frr\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE(mnasiadka): For RabbitMQ Debuntu suite names is following:"},{"line_number":41,"context_line":"# https://www.rabbitmq.com/install-debian.html#apt-cloudsmith"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"da6cf664_3bf296d5","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  opstools: \"centos-opstools\""},{"line_number":36,"context_line":"  proxysql: \"proxysql\""},{"line_number":37,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":38,"context_line":"  frr: \"frr\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE(mnasiadka): For RabbitMQ Debuntu suite names is following:"},{"line_number":41,"context_line":"# https://www.rabbitmq.com/install-debian.html#apt-cloudsmith"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"87e9ae2a_d9128264","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":2},"in_reply_to":"da6cf664_3bf296d5","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    suite: \"bullseye\""},{"line_number":87,"context_line":"    component: \"main\""},{"line_number":88,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":89,"context_line":"  frr:"},{"line_number":90,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":91,"context_line":"    suite: \"bullseye\""},{"line_number":92,"context_line":"    component: \"frr-9\""},{"line_number":93,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"debian-aarch64:"},{"line_number":96,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"99284ccd_c19cf551","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":22},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    suite: \"bullseye\""},{"line_number":87,"context_line":"    component: \"main\""},{"line_number":88,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":89,"context_line":"  frr:"},{"line_number":90,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":91,"context_line":"    suite: \"bullseye\""},{"line_number":92,"context_line":"    component: \"frr-9\""},{"line_number":93,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"debian-aarch64:"},{"line_number":96,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"1de6bb7d_bd14a4ae","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":22},"in_reply_to":"99284ccd_c19cf551","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":141,"context_line":"    # syncing binary-aarch64 - we\u0027re using amd64 here."},{"line_number":142,"context_line":"    arch: \"amd64\""},{"line_number":143,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":144,"context_line":"  frr:"},{"line_number":145,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":146,"context_line":"    suite: \"bullseye\""},{"line_number":147,"context_line":"    component: \"frr-9\""},{"line_number":148,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"rocky:"},{"line_number":151,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"e85ba110_259f1fc4","line":148,"range":{"start_line":144,"start_character":0,"end_line":148,"end_character":22},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    # syncing binary-aarch64 - we\u0027re using amd64 here."},{"line_number":142,"context_line":"    arch: \"amd64\""},{"line_number":143,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":144,"context_line":"  frr:"},{"line_number":145,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":146,"context_line":"    suite: \"bullseye\""},{"line_number":147,"context_line":"    component: \"frr-9\""},{"line_number":148,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"rocky:"},{"line_number":151,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"f5b2b9a8_509a8f1d","line":148,"range":{"start_line":144,"start_character":0,"end_line":148,"end_character":22},"in_reply_to":"e85ba110_259f1fc4","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":164,"context_line":"  opstools: \"centos-opstools\""},{"line_number":165,"context_line":"  proxysql: \"proxysql\""},{"line_number":166,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":167,"context_line":"  frr: \"frr\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"rocky-aarch64:"},{"line_number":170,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"0a62e95c_4217f12a","line":167,"range":{"start_line":167,"start_character":0,"end_line":167,"end_character":2},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  opstools: \"centos-opstools\""},{"line_number":165,"context_line":"  proxysql: \"proxysql\""},{"line_number":166,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":167,"context_line":"  frr: \"frr\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"rocky-aarch64:"},{"line_number":170,"context_line":"  ceph: \"centos-ceph-reef\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"12d5919e_7e90f3d9","line":167,"range":{"start_line":167,"start_character":0,"end_line":167,"end_character":2},"in_reply_to":"0a62e95c_4217f12a","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":183,"context_line":"  opstools: \"centos-opstools\""},{"line_number":184,"context_line":"  proxysql: \"proxysql\""},{"line_number":185,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":186,"context_line":"  frr: \"frr\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"ubuntu:"},{"line_number":189,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"5bfdc9c4_22dde63e","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":2},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":183,"context_line":"  opstools: \"centos-opstools\""},{"line_number":184,"context_line":"  proxysql: \"proxysql\""},{"line_number":185,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":186,"context_line":"  frr: \"frr\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"ubuntu:"},{"line_number":189,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"78fde5e3_a2a07643","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":2},"in_reply_to":"5bfdc9c4_22dde63e","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":231,"context_line":"    suite: \"jammy\""},{"line_number":232,"context_line":"    component: \"main\""},{"line_number":233,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":234,"context_line":"  frr:"},{"line_number":235,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":236,"context_line":"    suite: \"jammy\""},{"line_number":237,"context_line":"    component: \"frr-9\""},{"line_number":238,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"ubuntu-aarch64:"},{"line_number":241,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"1e2a5197_b7ceed1b","line":238,"range":{"start_line":234,"start_character":0,"end_line":238,"end_character":22},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    suite: \"jammy\""},{"line_number":232,"context_line":"    component: \"main\""},{"line_number":233,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":234,"context_line":"  frr:"},{"line_number":235,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":236,"context_line":"    suite: \"jammy\""},{"line_number":237,"context_line":"    component: \"frr-9\""},{"line_number":238,"context_line":"    gpg_key: \"frr.asc\""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"ubuntu-aarch64:"},{"line_number":241,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"a93f91d1_079ec4dc","line":238,"range":{"start_line":234,"start_character":0,"end_line":238,"end_character":22},"in_reply_to":"1e2a5197_b7ceed1b","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db64525f5179136955ddbab980c0155be47e4759","unresolved":true,"context_lines":[{"line_number":284,"context_line":"    component: \"main\""},{"line_number":285,"context_line":"    arch: \"amd64\""},{"line_number":286,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":287,"context_line":"  frr:"},{"line_number":288,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":289,"context_line":"    suite: \"jammy\""},{"line_number":290,"context_line":"    component: \"frr-9\""},{"line_number":291,"context_line":"    gpg_key: \"frr.asc\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"46a81409_fdc6a2ca","line":291,"range":{"start_line":287,"start_character":0,"end_line":291,"end_character":22},"updated":"2024-04-19 10:44:29.000000000","message":"nit: please keep these alphabetically sorted","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"},{"author":{"_account_id":35638},"change_message_id":"1a171cbd61940ebc9fb0e321dd4966522dbbab37","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    component: \"main\""},{"line_number":285,"context_line":"    arch: \"amd64\""},{"line_number":286,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":287,"context_line":"  frr:"},{"line_number":288,"context_line":"    url: \"https://deb.frrouting.org/frr\""},{"line_number":289,"context_line":"    suite: \"jammy\""},{"line_number":290,"context_line":"    component: \"frr-9\""},{"line_number":291,"context_line":"    gpg_key: \"frr.asc\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"a44d3de6_61963cbc","line":291,"range":{"start_line":287,"start_character":0,"end_line":291,"end_character":22},"in_reply_to":"46a81409_fdc6a2ca","updated":"2024-04-26 11:18:07.000000000","message":"Done","commit_id":"331a452ef67aaa9ab2d81783afe68dbeef77dc10"}]}