)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7c960791512f4978f966c569982442e199a1bf5f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"for more details, refer to the changelog[1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"the gpg key now is imported from the ubuntu key server,"},{"line_number":15,"context_line":"as is done in fluentds packaging itself[2]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[0]: https://web.archive.org/web/20231006084137/https://www.fluentd.org/blog/upgrade-td-agent-v4-to-v5"},{"line_number":18,"context_line":"[1]: https://github.com/fluent/fluent-package-builder/blob/b4b7017c09d78f2c404db62612733b40f69668a6/CHANGELOG.md#release-v500---20230729"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"adb884bf_42d2eada","line":15,"updated":"2023-10-12 10:31:46.000000000","message":"I fail to see where this is happening. You still have\n\ngpg_key: \"treasuredata.asc\"\n\nin the repo definitions?","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"11782215d6805a1b5598a25c0f3499504e51c52e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"for more details, refer to the changelog[1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"the gpg key now is imported from the ubuntu key server,"},{"line_number":15,"context_line":"as is done in fluentds packaging itself[2]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[0]: https://web.archive.org/web/20231006084137/https://www.fluentd.org/blog/upgrade-td-agent-v4-to-v5"},{"line_number":18,"context_line":"[1]: https://github.com/fluent/fluent-package-builder/blob/b4b7017c09d78f2c404db62612733b40f69668a6/CHANGELOG.md#release-v500---20230729"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e371f6cc_f8644d65","line":15,"in_reply_to":"adb884bf_42d2eada","updated":"2023-10-12 14:00:19.000000000","message":"Done","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6806e236b177f9a7a604eacb77ab0372c1a76be6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8cd6aaec_5894e11e","updated":"2023-09-13 17:44:17.000000000","message":"I hope I catched everything, not really sure, tbh, might fail somewhere in the process.\nI\u0027ll wait for CI to throw the breakage back at me :)","commit_id":"8726199a9801941cb0d4607121efc933b6430bd7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e987c3102c88aab48249c82c22de9c7bf5ff692b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de03ad76_3b3d2d1a","updated":"2023-10-06 10:48:12.000000000","message":"new errors:\n\nhttps://zuul.opendev.org/t/openstack/build/3fefdffe6d7641a581f862350945e796/log/kolla/build/000_FAILED_fluentd.log\n```\nERROR:kolla.common.utils.fluentd:\u001b[91mE: Failed to fetch https://td-agent-package-browser.herokuapp.com/lts/5/debian/bookworm/dists/bookworm/InRelease  Clearsigned file isn\u0027t valid, got \u0027NOSPLIT\u0027 (does the network require authentication?)\n\nE: The repository \u0027https://td-agent-package-browser.herokuapp.com/lts/5/debian/bookworm bookworm InRelease\u0027 is not signed.\n```","commit_id":"4ae38d3f675dc05dd9291d5019d1c154be15686a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c79e117c56c0a8cb7cee90d48d1fab0b0bb116f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4072694a_70dd2378","updated":"2023-10-09 13:00:00.000000000","message":"recheck unrelated spurious network error at rackspace","commit_id":"4ae38d3f675dc05dd9291d5019d1c154be15686a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b756ca459eb44a808afd8f9a73ed4cf3985f6dc7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"83e15c35_c94fcad7","in_reply_to":"4072694a_70dd2378","updated":"2023-10-09 14:23:58.000000000","message":"I still get:\n\n```\nERROR:kolla.common.utils.fluentd:\u001b[91mE: Failed to fetch https://td-agent-package-browser.herokuapp.com/lts/5/ubuntu/jammy/dists/jammy/InRelease  Clearsigned file isn\u0027t valid, got \u0027NOSPLIT\u0027 (does the network require authentication?)\n\nE: The repository \u0027https://td-agent-package-browser.herokuapp.com/lts/5/ubuntu/jammy jammy InRelease\u0027 is not signed.\n```\n\nso, just in case, I manually checked the signature of said file:\n\n\n```\ngpg --import GPG-KEY-td-agent                                                                                                                                                                             2 ✘  at 16:16:48 \ngpg: Schlüssel 901F9177AB97ACBE: Öffentlicher Schlüssel \"Treasure Data, Inc (Treasure Agent Official Signing key) \u003csupport@treasure-data.com\u003e\" importiert\ngpg: Anzahl insgesamt bearbeiteter Schlüssel: 1\ngpg:                              importiert: 1\n gpg --verify InRelease                                                                                                                                                                                      ✔  at 16:17:26 \ngpg: Signatur vom Fr 25 Aug 2023 07:01:36 CEST\ngpg:                mittels RSA-Schlüssel BEE682289B2217F45AF4CC3F901F9177AB97ACBE\ngpg: Korrekte Signatur von \"Treasure Data, Inc (Treasure Agent Official Signing key) \u003csupport@treasure-data.com\u003e\" [unbekannt]\ngpg: WARNUNG: Dieser Schlüssel trägt keine vertrauenswürdige Signatur!\ngpg:          Es gibt keinen Hinweis, daß die Signatur wirklich dem vorgeblichen Besitzer gehört.\nHaupt-Fingerabdruck  \u003d BEE6 8228 9B22 17F4 5AF4  CC3F 901F 9177 AB97 ACBE\n```\n\nso gpg shows the file is correctly signed but from a key which has itself no trusted signature - which is okay in this case.\n\nat least it\u0027s not an error with this key. I also checked the other fluentd key, which does not work/was not used to sign this file.\n\nso the most likely explanation is, that something is wrong with the download of said file.\n\nthis is the new build log for reference: https://zuul.opendev.org/t/openstack/build/ca7a2a6f88924b458ec32b79d007611b/log/primary/logs/build/000_FAILED_fluentd.log\n\nthe old failing job was in rackspace DC in Dallas.\n\nthis new one is at OVH in region \"GRA1\".\n\nSo I doubt it is anything infrastructure related on the openinfra side.\n\nStill investigating.","commit_id":"4ae38d3f675dc05dd9291d5019d1c154be15686a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"328b01141e0a510eee5a2d7335e71a21611b334c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3c5f9bc7_b6ee2438","in_reply_to":"83e15c35_c94fcad7","updated":"2023-10-12 07:20:31.000000000","message":"I\u0027m fairly certain the original build failures are solved (wrong mirror URLs etc, path etc).\n\nthe container image builds fine locally with this changeset applied.\n\nThe rest of the issues seem to be related to the CI, which I try to debug in: https://review.opendev.org/c/openstack/kolla/+/897843\n\nthus marking this as resolved.","commit_id":"4ae38d3f675dc05dd9291d5019d1c154be15686a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"67fc905e118148d9b674384d509a3a6b590bfc40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e29b1676_6f265702","in_reply_to":"de03ad76_3b3d2d1a","updated":"2023-10-09 15:26:48.000000000","message":"using the correct base address `https://packages.treasuredata.com/lts/5/ubuntu/jammy/` hopefully helps.","commit_id":"4ae38d3f675dc05dd9291d5019d1c154be15686a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fafe10b21619368c17d5231bb4894463f916580e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bc3f957a_aae4d36e","updated":"2023-10-10 11:12:36.000000000","message":"recheck unrelated build failure in kolla toolbox","commit_id":"042529258867aa175318e96b9795f11e56bdc1d8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"328b01141e0a510eee5a2d7335e71a21611b334c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f3688aa5_03d6cc3d","updated":"2023-10-12 07:20:31.000000000","message":"recheck CI should now be green again","commit_id":"f34b02aca8bc664cad6c131bad46d5b97b12845c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"af8580536e48ff9e1c3e0691b8dac4bcebbb4fc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d1d77717_5ab2171f","updated":"2023-10-12 09:03:30.000000000","message":"recheck bug #2039051","commit_id":"f34b02aca8bc664cad6c131bad46d5b97b12845c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c9f25cc7095ef6596328db7ae93c8c8b5dc1f4aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"459a2feb_951ce067","updated":"2023-10-11 06:47:49.000000000","message":"recheck dependencies were still borked on mirror","commit_id":"f34b02aca8bc664cad6c131bad46d5b97b12845c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"39ccdef590553f69de672f299e72038f2de0237e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c6085597_d9c9ae48","updated":"2023-10-12 10:07:30.000000000","message":"kolla-build-rocky9 now fails with:\n\n```\nERROR:kolla.common.utils.grafana:\u001b[91mError: Failed to download metadata for repo \u0027grafana\u0027: Yum repo downloading error: Downloading error(s): repodata/2898011ccfcfb46888b9e444410ec5e8de3b33caaf1c5c191f6e5182947be500-primary.xml.gz - Cannot download, all mirrors were already tried without success; repodata/a906483b77a2ab39c2e929bde3c5355504e400af3d96bbfdaa90e555d8495b6f-filelists.xml.gz - Cannot download, all mirrors were already tried without success\n```","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9899359ff37ac2b9cba693f9d8da263971c25bae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1530c059_70732fd5","updated":"2023-10-12 10:27:17.000000000","message":"recheck tmp rocky grafana mirror issue","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"053c3d21702cdc3ff5aa94362dd197a77f1006d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7fe095d0_4f36b6b3","in_reply_to":"c6085597_d9c9ae48","updated":"2023-10-12 14:10:54.000000000","message":"Done","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d199b6a89829b412590a4019adac30aa306da487","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a6f9ceba_f63f6de2","updated":"2023-10-12 15:11:24.000000000","message":"fluentd container doesn\u0027t keep running, see e.g. https://zuul.opendev.org/t/openstack/build/2a68ef5e7e324996940f03fe6a994d5b\nI\u0027ll try to run it locally to see what fails exactly, I don\u0027t see much in the logs atm.","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c0ef27891cc6d8f6266bb638fe5dbf235efb0fc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"21cbf8d9_f36dd1d0","in_reply_to":"795b19ea_090df92b","updated":"2023-11-29 13:43:50.000000000","message":"Done","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ae6a6aa0571da66be8ea36acc6bf563ec89064c0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"795b19ea_090df92b","in_reply_to":"a6f9ceba_f63f6de2","updated":"2023-10-12 15:29:03.000000000","message":"so I\u0027m still not sure why the container fails, at least when starting the container locally and checking fluentd via `--dry-run` option everything seems fine:\n\n```\n()[td-agent@ae260d780c39 /]$ fluentd --dry-run\n2023-10-12 15:26:51 +0000 [info]: init supervisor logger path\u003dnil rotate_age\u003dnil rotate_size\u003dnil\n2023-10-12 15:26:51 +0000 [info]: parsing config file is succeeded path\u003d\"/etc/fluent/fluentd.conf\"\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluentd\u0027 version \u00271.16.2\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-calyptia-monitoring\u0027 version \u00270.1.3\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-elasticsearch\u0027 version \u00275.3.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-flowcounter-simple\u0027 version \u00270.1.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-grok-parser\u0027 version \u00272.6.2\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-kafka\u0027 version \u00270.19.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-metrics-cmetrics\u0027 version \u00270.1.2\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-opensearch\u0027 version \u00271.1.3\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-prometheus\u0027 version \u00272.1.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-prometheus_pushgateway\u0027 version \u00270.1.1\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-record-modifier\u0027 version \u00272.1.1\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-rewrite-tag-filter\u0027 version \u00272.4.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-s3\u0027 version \u00271.7.2\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-sd-dns\u0027 version \u00270.1.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-systemd\u0027 version \u00271.0.5\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-td\u0027 version \u00271.2.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-utmpx\u0027 version \u00270.5.0\u0027\n2023-10-12 15:26:51 +0000 [info]: gem \u0027fluent-plugin-webhdfs\u0027 version \u00271.5.0\u0027\n2023-10-12 15:26:51 +0000 [info]: starting fluentd-1.16.2 as dry run mode ruby\u003d\"3.2.2\"\n2023-10-12 15:26:51 +0000 [info]: using configuration file: \u003cROOT\u003e\n  \u003cmatch td.*.*\u003e\n    @type tdlog\n    @id output_td\n    apikey xxxxxx\n    auto_create_table \n    \u003cbuffer\u003e\n      @type \"file\"\n      path \"/var/log/fluent/buffer/td\"\n    \u003c/buffer\u003e\n    \u003csecondary\u003e\n      @type \"secondary_file\"\n      directory \"/var/log/fluent/failed_records\"\n    \u003c/secondary\u003e\n  \u003c/match\u003e\n  \u003cmatch debug.**\u003e\n    @type stdout\n    @id output_stdout\n  \u003c/match\u003e\n  \u003csource\u003e\n    @type forward\n    @id input_forward\n  \u003c/source\u003e\n  \u003csource\u003e\n    @type http\n    @id input_http\n    port 8888\n  \u003c/source\u003e\n  \u003csource\u003e\n    @type debug_agent\n    @id input_debug_agent\n    bind \"127.0.0.1\"\n    port 24230\n  \u003c/source\u003e\n\u003c/ROOT\u003e\n2023-10-12 15:26:51 +0000 [info]: finished dry run mode\n()[td-agent@ae260d780c39 /]$ echo $?\n0\n```\n\n\nlooking at all the logs again now.","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c49df7a75f67e1ce53eb22cecd1caa3b055e535f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e3547a25_e82f56b5","updated":"2023-10-13 12:52:59.000000000","message":"another issue, in kolla-ansible:\n\n```\n2023-10-13T09:59:24.621600016Z + echo \u0027Running command: \u0027\\\u0027\u0027/usr/sbin/td-agent -o /var/log/kolla/fluentd/fluentd.log\u0027\\\u0027\u0027\u0027\n\n2023-10-13T09:59:24.621643617Z + exec /usr/sbin/td-agent -o /var/log/kolla/fluentd/fluentd.log\n\n2023-10-13T09:59:24.621718071Z Running command: \u0027/usr/sbin/td-agent -o /var/log/kolla/fluentd/fluentd.log\u0027\n\n2023-10-13T09:59:24.621832377Z /usr/local/bin/kolla_start: line 24: /usr/sbin/td-agent: No such file or directory\n\n\n```\n\nhttps://zuul.opendev.org/t/openstack/build/3cbaa20e315d4bd8b564fe66009ec6dd/log/primary/logs/container_logs/fluentd.txt\n\nin job: kolla-ansible-centos9s","commit_id":"6e5ea067625802822929a90ca49813ad3a6f339c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"06683dd9a914d86a32ec3022e251698c08e8698d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"92fd43a5_d6e6e1c3","in_reply_to":"624525a9_0ec2ad21","updated":"2023-11-22 15:15:25.000000000","message":"Done","commit_id":"6e5ea067625802822929a90ca49813ad3a6f339c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f2d8e964600545104df27d828ed81e3ae7b823cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"624525a9_0ec2ad21","in_reply_to":"e3547a25_e82f56b5","updated":"2023-10-13 13:19:54.000000000","message":"should be fixed with: https://review.opendev.org/c/openstack/kolla-ansible/+/898227","commit_id":"6e5ea067625802822929a90ca49813ad3a6f339c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b761ec5da761fe058b65868ed753dcb6ca2b22fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"160948a1_468ca634","updated":"2023-11-22 07:41:05.000000000","message":"recheck (depends on changed)","commit_id":"a299c8a9ead9687657973abdac1d6c45c157fdbf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"819073e2c1e8d6de1b785da6f3280e8ba729cb6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"a7ac8b1b_511a9552","updated":"2023-11-21 22:53:17.000000000","message":"recheck (depends on changed)","commit_id":"a299c8a9ead9687657973abdac1d6c45c157fdbf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d0d389c30b10da7407b48660952a916fcf1d11ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"270f3f54_d8c95b24","updated":"2023-11-21 14:45:59.000000000","message":"recheck (depends-on changed)","commit_id":"a299c8a9ead9687657973abdac1d6c45c157fdbf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"88d1b54a2f2ca6a5af10ab3d1ec204d26b619298","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"0e2c57a5_3ee49a44","updated":"2023-11-28 10:25:16.000000000","message":"recheck (depends on changed)","commit_id":"ad205e41ebed1a78df9436e4175e355d8ef53621"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a00ac864ed2b073bd15d45fd35125081e18ff2be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"4bc4bbe2_87fca23f","updated":"2023-11-23 07:15:57.000000000","message":"recheck (depends on changed)","commit_id":"ad205e41ebed1a78df9436e4175e355d8ef53621"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4a742a38eaa0a43ad8990f50347083e6ea7c34e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"be8c74d2_da82d9bb","updated":"2023-11-22 15:14:07.000000000","message":"recheck (depends on changed)","commit_id":"ad205e41ebed1a78df9436e4175e355d8ef53621"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4ce2ab95eb900e30f508d7762478851459e3336e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"dc66fe6e_b210af1c","updated":"2023-11-22 23:24:40.000000000","message":"recheck (depends on changed)","commit_id":"ad205e41ebed1a78df9436e4175e355d8ef53621"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3d2456639380c21f7c732dd6b49865ac781cc792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"9b140cb1_bbfe36d6","updated":"2023-11-29 09:52:41.000000000","message":"recheck (depends on changed)","commit_id":"46b7c3e8cb78ff9e2d7661c35e21bc86f8d89cdc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6792c865e2a96c547033d8c7334d4ee1fa3523f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"ed4acd87_6a3e467b","updated":"2023-11-30 16:14:21.000000000","message":"merging for release hopefully tomorrow","commit_id":"c0aee4adb69e25f0e75fc9f907cf962ef024f358"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c5b5592017b721b9b4499485695f48b4d6c75ec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"fe7e01ec_3e8325a3","updated":"2023-11-30 17:54:06.000000000","message":"recheck - debian repos sync in progress","commit_id":"c0aee4adb69e25f0e75fc9f907cf962ef024f358"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1a5fed65f68230ea86ea7c744fdb1c6dc4006331","unresolved":true,"context_lines":[{"line_number":297,"context_line":"   {\u0027name\u0027: \u0027proxysql\u0027, \u0027url\u0027: \u0027https://repo.proxysql.com/ProxySQL/proxysql-2.5.x/repo_pub_key\u0027},"},{"line_number":298,"context_line":"   {\u0027name\u0027: \u0027treasuredata\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-td-agent\u0027},"},{"line_number":299,"context_line":"   {\u0027name\u0027: \u0027fluentd\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-fluent-package\u0027},"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"] %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"{% block base_ubuntu_package_installation %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"f9d24deb_a419feda","line":300,"updated":"2023-10-13 08:43:43.000000000","message":"nit: no need to add an empty line here?","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db0059684ade8ddbadc402d2c0a518dee05ffcbe","unresolved":false,"context_lines":[{"line_number":297,"context_line":"   {\u0027name\u0027: \u0027proxysql\u0027, \u0027url\u0027: \u0027https://repo.proxysql.com/ProxySQL/proxysql-2.5.x/repo_pub_key\u0027},"},{"line_number":298,"context_line":"   {\u0027name\u0027: \u0027treasuredata\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-td-agent\u0027},"},{"line_number":299,"context_line":"   {\u0027name\u0027: \u0027fluentd\u0027, \u0027url\u0027: \u0027https://packages.treasuredata.com/GPG-KEY-fluent-package\u0027},"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"] %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"{% block base_ubuntu_package_installation %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"af17f8b4_8f7c3a84","line":300,"in_reply_to":"f9d24deb_a419feda","updated":"2023-10-17 08:14:40.000000000","message":"Done","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"}],"docker/base/td.repo":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"63ec5b9753e0d4f1a0ef8b3845d820081c864068","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[fluent-package-lts]"},{"line_number":2,"context_line":"name\u003dFluentd Project"},{"line_number":3,"context_line":"baseurl\u003dhttps://packages.treasuredata.com/lts/5/redhat/$releasever/$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"47c2fd15_5326a808","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":19},"updated":"2023-11-17 13:38:20.000000000","message":"Well, it\u0027s still treasuredata - so why the repo name change?","commit_id":"4ae38d3f675dc05dd9291d5019d1c154be15686a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"667bb979a382d33fca1e1ecccdfa57b46cdc717b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[fluent-package-lts]"},{"line_number":2,"context_line":"name\u003dFluentd Project"},{"line_number":3,"context_line":"baseurl\u003dhttps://packages.treasuredata.com/lts/5/redhat/$releasever/$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"0992be46_a794e3b4","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":19},"in_reply_to":"47c2fd15_5326a808","updated":"2023-11-17 13:48:56.000000000","message":"Ok, I read a bit and I know.","commit_id":"4ae38d3f675dc05dd9291d5019d1c154be15686a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ada284b7c90341d7e9e9dcdd72a170b6e17d2a1f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"baseurl\u003dhttps://packages.treasuredata.com/lts/5/redhat/$releasever/$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"},{"line_number":5,"context_line":"gpgkey\u003dhttps://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":6,"context_line":"       https://packages.treasuredata.com/GPG-KEY-fluent-package"},{"line_number":7,"context_line":"enabled\u003d0"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"d5f7dd76_8d2efff7","line":6,"updated":"2023-10-12 10:28:03.000000000","message":"do you really need two keys for this repo now or did you mean to replace the old one?","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db0059684ade8ddbadc402d2c0a518dee05ffcbe","unresolved":false,"context_lines":[{"line_number":3,"context_line":"baseurl\u003dhttps://packages.treasuredata.com/lts/5/redhat/$releasever/$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"},{"line_number":5,"context_line":"gpgkey\u003dhttps://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":6,"context_line":"       https://packages.treasuredata.com/GPG-KEY-fluent-package"},{"line_number":7,"context_line":"enabled\u003d0"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"5a8bbabb_568ee21d","line":6,"in_reply_to":"139a0bf2_dcbe97db","updated":"2023-10-17 08:14:40.000000000","message":"Done","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"de84947bc956b0993246341cfa01d420a1ab299b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"baseurl\u003dhttps://packages.treasuredata.com/lts/5/redhat/$releasever/$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"},{"line_number":5,"context_line":"gpgkey\u003dhttps://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":6,"context_line":"       https://packages.treasuredata.com/GPG-KEY-fluent-package"},{"line_number":7,"context_line":"enabled\u003d0"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"139a0bf2_dcbe97db","line":6,"in_reply_to":"727ad3f1_608762fd","updated":"2023-10-13 12:48:46.000000000","message":"okay, fine for me, this avoids the multiple key handling logic in `methods.py` (which is a mess).","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1a5fed65f68230ea86ea7c744fdb1c6dc4006331","unresolved":true,"context_lines":[{"line_number":3,"context_line":"baseurl\u003dhttps://packages.treasuredata.com/lts/5/redhat/$releasever/$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"},{"line_number":5,"context_line":"gpgkey\u003dhttps://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":6,"context_line":"       https://packages.treasuredata.com/GPG-KEY-fluent-package"},{"line_number":7,"context_line":"enabled\u003d0"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"727ad3f1_608762fd","line":6,"in_reply_to":"c2c05dc1_baa5e798","updated":"2023-10-13 08:43:43.000000000","message":"upstream done nonsense, fine. I they would sign current pkgs with both keys, this would make sense, but as it stands, we only need the old key, so I would prefer to stick to only that one and switch when upstream switches","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"11782215d6805a1b5598a25c0f3499504e51c52e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"baseurl\u003dhttps://packages.treasuredata.com/lts/5/redhat/$releasever/$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"},{"line_number":5,"context_line":"gpgkey\u003dhttps://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":6,"context_line":"       https://packages.treasuredata.com/GPG-KEY-fluent-package"},{"line_number":7,"context_line":"enabled\u003d0"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"c2c05dc1_baa5e798","line":6,"in_reply_to":"d5f7dd76_8d2efff7","updated":"2023-10-12 14:00:19.000000000","message":"yes I need the two, as stated in the linked docs and this is also a 1:1 copy of what upstream does.\n\nto quote the changelog:\n\n\u003e Introduced new package signing key. The new key will be used in the future release. we still use using old signing key for a while. (#507)","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"}],"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a01a9c2a79a50ef859e483ac3cbbc91463b8c0b2","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.enable_extra_repos([\u0027td-agent\u0027]) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fdb7747_4ab63bbf","line":12,"range":{"start_line":12,"start_character":31,"end_line":12,"end_character":39},"updated":"2023-09-14 08:10:19.000000000","message":"this needs to be the same as in repos.yaml","commit_id":"8726199a9801941cb0d4607121efc933b6430bd7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"88774157397a456024cc7216a134bdbde14f335b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.enable_extra_repos([\u0027td-agent\u0027]) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"edfbf21e_76f8f220","line":12,"range":{"start_line":12,"start_character":31,"end_line":12,"end_character":39},"in_reply_to":"5fdb7747_4ab63bbf","updated":"2023-09-14 09:17:15.000000000","message":"Done","commit_id":"8726199a9801941cb0d4607121efc933b6430bd7"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3e70d7cd3f97b69cddaa81d478aa12f3437977a9","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.enable_extra_repos([\u0027fluentd-package\u0027]) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"d3c6f6fd_5ee09e6a","line":12,"updated":"2023-10-10 12:27:55.000000000","message":"Why not just \u0027fluentd\u0027?","commit_id":"52c441bb6b6bcd9e7c0088f07951b38b67d156a8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8cb11f1de8240c22b03d8766ff3121f40c5abeee","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.enable_extra_repos([\u0027fluentd-package\u0027]) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"396da1f5_0d25f172","line":12,"in_reply_to":"d3c6f6fd_5ee09e6a","updated":"2023-10-10 13:03:20.000000000","message":"I just went with upstreams decision on package and repository naming.\nI really have no interest to shave this yak.","commit_id":"52c441bb6b6bcd9e7c0088f07951b38b67d156a8"}],"docker/fluentd/extend_start.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"34007701da2e8d00faec1752eb7589f85ecbe763","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    USERGROUP\u003d\"td-agent:kolla\""},{"line_number":11,"context_line":"    FLUENTD\u003d\"td-agent\""},{"line_number":12,"context_line":"else"},{"line_number":13,"context_line":"    USERGROUP\u003d\"fluentd:kolla\""},{"line_number":14,"context_line":"    FLUENTD\u003d\"fluentd\" #TODO: check if this is correct for fluentd-package v5"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"if [ ! -d /var/log/kolla ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"e74b1a66_f5ca7eb2","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":76},"updated":"2023-09-14 11:42:30.000000000","message":"the package from upstream does the following in it\u0027s postinst script in the deb package:\n\n```\nadduser --group --system --force-badname --home /var/lib/fluent _fluentd\nuseradd -u $TD_UID -g $TD_GID -o -d /var/lib/fluent -s /usr/sbin/nologin _fluentd\n```\n\nso it seems the username is now `_fluentd` and the directory `/var/lib/fluent`\n\nnot sure if we can deviate from this or if we need to migrate data on upgrades. the migration guide doesn\u0027t mention this, so I hope we should be fine with the new directory.","commit_id":"aaee6ff55cd00993948737ffb7ab85841a4ad026"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6ff75d9b45e2d3df6654b8fa4380fc9cbcfe6b59","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    USERGROUP\u003d\"td-agent:kolla\""},{"line_number":11,"context_line":"    FLUENTD\u003d\"td-agent\""},{"line_number":12,"context_line":"else"},{"line_number":13,"context_line":"    USERGROUP\u003d\"fluentd:kolla\""},{"line_number":14,"context_line":"    FLUENTD\u003d\"fluentd\" #TODO: check if this is correct for fluentd-package v5"},{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"if [ ! -d /var/log/kolla ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"0c5cf079_5b25b10a","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":76},"in_reply_to":"e74b1a66_f5ca7eb2","updated":"2023-10-06 09:12:24.000000000","message":"the docs [0] also mention this:\n\n\u003e With the change of package name, install path, service name (e.g. /opt/fluent, fluentd.service) and so on were also changed. Basically, for td-agent v4 users, it aims to keep compatibility as far as possible by executing the migration process with copying old files or providing symbolic links for it.\n\nalso of note are the extended changelog which has more explanation in detail, available here[1].\n\n[0]: https://web.archive.org/web/20231006084137/https://www.fluentd.org/blog/upgrade-td-agent-v4-to-v5\n\n[1]: https://github.com/fluent/fluent-package-builder/blob/b4b7017c09d78f2c404db62612733b40f69668a6/CHANGELOG.md#release-v500---20230729","commit_id":"aaee6ff55cd00993948737ffb7ab85841a4ad026"}],"docker/fluentd/fluentd_sudoers":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1a5fed65f68230ea86ea7c744fdb1c6dc4006331","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/log/kolla, /usr/bin/chown fluentd\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/log/kolla, /usr/bin/chown td-agent\\:kolla /var/log/kolla"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/lib/fluentd, /usr/bin/chown fluentd\\:kolla /var/lib/fluentd"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/lib/td-agent, /usr/bin/chown td-agent\\:kolla /var/lib/td-agent"},{"line_number":5,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":6,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/fluentd, /usr/bin/chmod 2775 /var/lib/fluentd"},{"line_number":7,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/td-agent, /usr/bin/chmod 2775 /var/lib/td-agent"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"83049867_4eaf2429","line":4,"updated":"2023-10-13 08:43:43.000000000","message":"2023-10-12T14:28:25.902459989Z ++ sudo chown fluentd:kolla /var/lib/td-agent\n\nThis combination of parameters is missing here","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db0059684ade8ddbadc402d2c0a518dee05ffcbe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/log/kolla, /usr/bin/chown fluentd\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/log/kolla, /usr/bin/chown td-agent\\:kolla /var/log/kolla"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/lib/fluentd, /usr/bin/chown fluentd\\:kolla /var/lib/fluentd"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/lib/td-agent, /usr/bin/chown td-agent\\:kolla /var/lib/td-agent"},{"line_number":5,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":6,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/fluentd, /usr/bin/chmod 2775 /var/lib/fluentd"},{"line_number":7,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/td-agent, /usr/bin/chmod 2775 /var/lib/td-agent"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"07416be7_62db37a7","line":4,"in_reply_to":"536a4026_81f05e27","updated":"2023-10-17 08:14:40.000000000","message":"Done","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"de84947bc956b0993246341cfa01d420a1ab299b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/log/kolla, /usr/bin/chown fluentd\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/log/kolla, /usr/bin/chown td-agent\\:kolla /var/log/kolla"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/lib/fluentd, /usr/bin/chown fluentd\\:kolla /var/lib/fluentd"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/lib/td-agent, /usr/bin/chown td-agent\\:kolla /var/lib/td-agent"},{"line_number":5,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":6,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/fluentd, /usr/bin/chmod 2775 /var/lib/fluentd"},{"line_number":7,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/td-agent, /usr/bin/chmod 2775 /var/lib/td-agent"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"536a4026_81f05e27","line":4,"in_reply_to":"83049867_4eaf2429","updated":"2023-10-13 12:48:46.000000000","message":"ah thanks, I saw a warning for that but didn\u0027t imagine it was new, so didn\u0027t check the sudoers file.","commit_id":"1c65d1ec7b289d6b10ef80d0097948a7717dc096"}],"docker/macros.j2":[{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a26227451dd677055c89d8a4665955b8c663a49d","unresolved":true,"context_lines":[{"line_number":61,"context_line":"{% macro install_fluent_plugins(plugins, chain\u003dFalse) -%}"},{"line_number":62,"context_line":"{% if plugins is defined and plugins|length \u003e 0 -%}"},{"line_number":63,"context_line":"    {% if not chain -%} RUN {% endif -%}"},{"line_number":64,"context_line":"    ulimit -n 1024 \u0026\u0026 fluent-gem install {{ plugins | join(\u0027 \u0027) }}"},{"line_number":65,"context_line":"{%- endif %}"},{"line_number":66,"context_line":"{%- endmacro %}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"c00608a9_b6cdae23","line":64,"updated":"2023-11-29 14:16:21.000000000","message":"As the command for installing gems is changing names from td-agent-gem to fluent-gem, we may need a releasenote to inform about this change.","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c69bffe736e0a83f27bd2d4a03f442cd33e44e5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"{% macro install_fluent_plugins(plugins, chain\u003dFalse) -%}"},{"line_number":62,"context_line":"{% if plugins is defined and plugins|length \u003e 0 -%}"},{"line_number":63,"context_line":"    {% if not chain -%} RUN {% endif -%}"},{"line_number":64,"context_line":"    ulimit -n 1024 \u0026\u0026 fluent-gem install {{ plugins | join(\u0027 \u0027) }}"},{"line_number":65,"context_line":"{%- endif %}"},{"line_number":66,"context_line":"{%- endmacro %}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"6668e0d8_90f43aaa","line":64,"in_reply_to":"c00608a9_b6cdae23","updated":"2023-11-30 07:00:08.000000000","message":"For me that\u0027s logical, td-agent-gem does not exist now - effect is the same - no user noticeable behaviour change.","commit_id":"1a5162d88144831dac094c0935146b39043049b6"}],"kolla/template/repos.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ada284b7c90341d7e9e9dcdd72a170b6e17d2a1f","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  opstools: \"centos-opstools\""},{"line_number":16,"context_line":"  proxysql: \"proxysql\""},{"line_number":17,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":18,"context_line":"  fluentd-package: \"fluent-package-lts\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"centos-aarch64:"},{"line_number":21,"context_line":"  ceph: \"centos-ceph-quincy\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4d4de94c_24a41900","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":17},"updated":"2023-10-12 10:28:03.000000000","message":"\"fluentd\" would be enough and more in line with the other things? also please keep these lists sorted by keys.","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"de84947bc956b0993246341cfa01d420a1ab299b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  opstools: \"centos-opstools\""},{"line_number":16,"context_line":"  proxysql: \"proxysql\""},{"line_number":17,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":18,"context_line":"  fluentd-package: \"fluent-package-lts\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"centos-aarch64:"},{"line_number":21,"context_line":"  ceph: \"centos-ceph-quincy\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ebc37723_56575df3","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":17},"in_reply_to":"1a541c11_3c335c28","updated":"2023-10-13 12:48:46.000000000","message":"yes, the bike shedding comment was a stab at the naming, not ordering.\n\nif you really want to argue about the name, here is a real argument for sticking with upstreams naming instead of inventing our own:\n\nif you take over the name of upstream stuff it\u0027s easier to find solutions to common problems online, then if you invent your own naming. if you invent your own naming you only find your own docs and bug trackers, not upstream, if searching for a specific term. that can be both positive and negative.\n\nin my experience it\u0027s mostly negative when projects invent \"new\" names for already established stuff, it makes it generally hard to find any related information.\n\nso it could be argued the more consistent naming is the one, where a name stays the same everywhere.\n\nbut as upstream seems to change the name every few releases anyway, this ship has already sailed I guess.\n\nin general, arguing about naming is still considered bike shedding, which tends to eat time that is better spent on more important things.\n\nsee also: https://en.wikipedia.org/wiki/Law_of_triviality\n\nI\u0027ll still stick to the old name, because I really do _not_ want to discuss this anymore.","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"11782215d6805a1b5598a25c0f3499504e51c52e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  opstools: \"centos-opstools\""},{"line_number":16,"context_line":"  proxysql: \"proxysql\""},{"line_number":17,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":18,"context_line":"  fluentd-package: \"fluent-package-lts\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"centos-aarch64:"},{"line_number":21,"context_line":"  ceph: \"centos-ceph-quincy\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c3173b46_3859cf37","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":17},"in_reply_to":"4d4de94c_24a41900","updated":"2023-10-12 14:00:19.000000000","message":"I tried to deviate only from upstream where necessary. I didn\u0027t find a name necessary, as it can in theory be arbitrary chosen. as this is the second complaint about naming things, I yield.\n\nI still think we should probably focus our reviewing efforts on quality and functionality and not on the colour of our bike sheds.\n\nalso addressed the ordering.","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1a5fed65f68230ea86ea7c744fdb1c6dc4006331","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  opstools: \"centos-opstools\""},{"line_number":16,"context_line":"  proxysql: \"proxysql\""},{"line_number":17,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":18,"context_line":"  fluentd-package: \"fluent-package-lts\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"centos-aarch64:"},{"line_number":21,"context_line":"  ceph: \"centos-ceph-quincy\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a541c11_3c335c28","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":17},"in_reply_to":"c3173b46_3859cf37","updated":"2023-10-13 08:43:43.000000000","message":"keep ordered lists ordered is code quality. keeping naming schemes consistent also is code quality.","commit_id":"ba9d4d6a4d5b9905127de7a0b983238de0150d7e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"63a588d080d62d21fe31e256ce6a2449fdb82cee","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  opstools: \"centos-opstools\""},{"line_number":34,"context_line":"  proxysql: \"proxysql\""},{"line_number":35,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":36,"context_line":"  fluentd: \"fluent-package-lts\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# NOTE(mnasiadka): For RabbitMQ Debuntu suite names is following:"},{"line_number":39,"context_line":"# https://www.rabbitmq.com/install-debian.html#apt-cloudsmith"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3226a592_2b1d6df5","line":36,"updated":"2023-11-29 13:57:32.000000000","message":"when I was complaining about the lack of ordering earlier, I was implicitly assuming that this would apply to all distros, my fault for not being verbose enough. I\u0027m fine with fixing this in a followup though, if you prefer","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c69bffe736e0a83f27bd2d4a03f442cd33e44e5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  opstools: \"centos-opstools\""},{"line_number":34,"context_line":"  proxysql: \"proxysql\""},{"line_number":35,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":36,"context_line":"  fluentd: \"fluent-package-lts\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# NOTE(mnasiadka): For RabbitMQ Debuntu suite names is following:"},{"line_number":39,"context_line":"# https://www.rabbitmq.com/install-debian.html#apt-cloudsmith"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1d8f1c76_2c136469","line":36,"in_reply_to":"3226a592_2b1d6df5","updated":"2023-11-30 07:00:08.000000000","message":"Done","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"63a588d080d62d21fe31e256ce6a2449fdb82cee","unresolved":true,"context_lines":[{"line_number":129,"context_line":"    # syncing binary-aarch64 - we\u0027re using amd64 here."},{"line_number":130,"context_line":"    arch: \"amd64\""},{"line_number":131,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":132,"context_line":"  fluentd:"},{"line_number":133,"context_line":"    url: \"https://packages.treasuredata.com/lts/5/debian/bookworm\""},{"line_number":134,"context_line":"    suite: \"bookworm\""},{"line_number":135,"context_line":"    component: \"contrib\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bcea8679_205c5f5e","line":132,"updated":"2023-11-29 13:57:32.000000000","message":"dito","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c69bffe736e0a83f27bd2d4a03f442cd33e44e5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # syncing binary-aarch64 - we\u0027re using amd64 here."},{"line_number":130,"context_line":"    arch: \"amd64\""},{"line_number":131,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":132,"context_line":"  fluentd:"},{"line_number":133,"context_line":"    url: \"https://packages.treasuredata.com/lts/5/debian/bookworm\""},{"line_number":134,"context_line":"    suite: \"bookworm\""},{"line_number":135,"context_line":"    component: \"contrib\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"904473f2_29c20962","line":132,"in_reply_to":"bcea8679_205c5f5e","updated":"2023-11-30 07:00:08.000000000","message":"Done","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"63a588d080d62d21fe31e256ce6a2449fdb82cee","unresolved":true,"context_lines":[{"line_number":151,"context_line":"  opstools: \"centos-opstools\""},{"line_number":152,"context_line":"  proxysql: \"proxysql\""},{"line_number":153,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":154,"context_line":"  fluentd: \"fluent-package-lts\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"rocky-aarch64:"},{"line_number":157,"context_line":"  ceph: \"centos-ceph-quincy\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"8367edb3_a0c9fd3b","line":154,"updated":"2023-11-29 13:57:32.000000000","message":"dito","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c69bffe736e0a83f27bd2d4a03f442cd33e44e5","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  opstools: \"centos-opstools\""},{"line_number":152,"context_line":"  proxysql: \"proxysql\""},{"line_number":153,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":154,"context_line":"  fluentd: \"fluent-package-lts\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"rocky-aarch64:"},{"line_number":157,"context_line":"  ceph: \"centos-ceph-quincy\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dad3f53d_f3043671","line":154,"in_reply_to":"8367edb3_a0c9fd3b","updated":"2023-11-30 07:00:08.000000000","message":"Done","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"63a588d080d62d21fe31e256ce6a2449fdb82cee","unresolved":true,"context_lines":[{"line_number":169,"context_line":"  opstools: \"centos-opstools\""},{"line_number":170,"context_line":"  proxysql: \"proxysql\""},{"line_number":171,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":172,"context_line":"  fluentd: \"fluent-package-lts\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"ubuntu:"},{"line_number":175,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"6b473acb_e74cfb1f","line":172,"updated":"2023-11-29 13:57:32.000000000","message":"dito","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c69bffe736e0a83f27bd2d4a03f442cd33e44e5","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  opstools: \"centos-opstools\""},{"line_number":170,"context_line":"  proxysql: \"proxysql\""},{"line_number":171,"context_line":"  rabbitmq: \"rabbitmq_rabbitmq-server\""},{"line_number":172,"context_line":"  fluentd: \"fluent-package-lts\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"ubuntu:"},{"line_number":175,"context_line":"  erlang:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"c15b0088_d4bc4e9c","line":172,"in_reply_to":"6b473acb_e74cfb1f","updated":"2023-11-30 07:00:08.000000000","message":"Done","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"63a588d080d62d21fe31e256ce6a2449fdb82cee","unresolved":true,"context_lines":[{"line_number":212,"context_line":"    suite: \"jammy\""},{"line_number":213,"context_line":"    component: \"main\""},{"line_number":214,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":215,"context_line":"  fluentd:"},{"line_number":216,"context_line":"    url: \"https://packages.treasuredata.com/lts/5/ubuntu/jammy/\""},{"line_number":217,"context_line":"    suite: \"jammy\""},{"line_number":218,"context_line":"    component: \"contrib\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"89190ca3_7582e67c","line":215,"updated":"2023-11-29 13:57:32.000000000","message":"dito","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c69bffe736e0a83f27bd2d4a03f442cd33e44e5","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    suite: \"jammy\""},{"line_number":213,"context_line":"    component: \"main\""},{"line_number":214,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":215,"context_line":"  fluentd:"},{"line_number":216,"context_line":"    url: \"https://packages.treasuredata.com/lts/5/ubuntu/jammy/\""},{"line_number":217,"context_line":"    suite: \"jammy\""},{"line_number":218,"context_line":"    component: \"contrib\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"6b2dba23_71b9728d","line":215,"in_reply_to":"89190ca3_7582e67c","updated":"2023-11-30 07:00:08.000000000","message":"Done","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"63a588d080d62d21fe31e256ce6a2449fdb82cee","unresolved":true,"context_lines":[{"line_number":260,"context_line":"    component: \"main\""},{"line_number":261,"context_line":"    arch: \"amd64\""},{"line_number":262,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":263,"context_line":"  fluentd:"},{"line_number":264,"context_line":"    url: \"https://packages.treasuredata.com/lts/5/ubuntu/jammy/\""},{"line_number":265,"context_line":"    suite: \"jammy\""},{"line_number":266,"context_line":"    component: \"contrib\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"e91ae005_0aff7639","line":263,"updated":"2023-11-29 13:57:32.000000000","message":"dito","commit_id":"1a5162d88144831dac094c0935146b39043049b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c69bffe736e0a83f27bd2d4a03f442cd33e44e5","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    component: \"main\""},{"line_number":261,"context_line":"    arch: \"amd64\""},{"line_number":262,"context_line":"    gpg_key: \"rabbitmq.gpg\""},{"line_number":263,"context_line":"  fluentd:"},{"line_number":264,"context_line":"    url: \"https://packages.treasuredata.com/lts/5/ubuntu/jammy/\""},{"line_number":265,"context_line":"    suite: \"jammy\""},{"line_number":266,"context_line":"    component: \"contrib\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"e8c0d24a_7d84cd35","line":263,"in_reply_to":"e91ae005_0aff7639","updated":"2023-11-30 07:00:08.000000000","message":"Done","commit_id":"1a5162d88144831dac094c0935146b39043049b6"}]}