)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5b6958984c3cc9547ae0f40641d4a6120e0ec889","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jorhson Deng \u003cjorhson_deng@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-05 06:37:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unify curl use"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change provides the ability for user to override the URLs"},{"line_number":10,"context_line":"by UPPER_CONSTRAINTS_FILE options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7531b279_cc14ff21","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":14},"updated":"2023-12-05 07:31:07.000000000","message":"not really?","commit_id":"670e39958734bb2938a35cfaf436426147ac9d17"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"da07ac20df8efed12e814dda2961aaefae95dc87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ecfa9269_3ae4e3b8","updated":"2024-03-26 12:53:47.000000000","message":"user can override UPPER_CONSTRAINTS_FILE in the base_pip_conf block","commit_id":"670e39958734bb2938a35cfaf436426147ac9d17"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ac78239acedb758faf57cc1d888a322cf76a00d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cf015cea_4ee78d43","in_reply_to":"8adfd1db_10714d05","updated":"2024-04-08 06:27:23.000000000","message":"please open an issue on the launchpad, provide a logs with issue and attach bugreport to the change if so.","commit_id":"670e39958734bb2938a35cfaf436426147ac9d17"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"10780fe238b4d57c0b482942b4bd02be4b030b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8adfd1db_10714d05","in_reply_to":"ecfa9269_3ae4e3b8","updated":"2024-04-08 03:23:26.000000000","message":"yes, but the user has defined the UPPER_CONSTRAINTS_FILE in the base_pip_conf block, and we should set the defination to be validated here. Otherwise, the parameter UPPER_CONSTRAINTS_FILE will be ignored and the file of upper-constraints.txt will use the default value.","commit_id":"670e39958734bb2938a35cfaf436426147ac9d17"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5b6958984c3cc9547ae0f40641d4a6120e0ec889","unresolved":true,"context_lines":[{"line_number":190,"context_line":"                    is usually newer than UC entry and older version would get installed"},{"line_number":191,"context_line":"                    in venv (see https://launchpad.net/bugs/1961874)."},{"line_number":192,"context_line":"#}"},{"line_number":193,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":194,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ovs\") }} \\"},{"line_number":195,"context_line":"    \u0026\u0026 mkdir -p /var/lib/kolla \\"},{"line_number":196,"context_line":"    \u0026\u0026 python3 -m venv --system-site-packages /var/lib/kolla/venv"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dc6ee159_a2345d0d","line":193,"updated":"2023-12-05 07:31:07.000000000","message":"Well, we link it from openstack-base-source - and then overwrite using curl? I don\u0027t think that\u0027s optimal.","commit_id":"670e39958734bb2938a35cfaf436426147ac9d17"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"72506679685b3b54cef2cc387f2f9682f1afbbc7","unresolved":true,"context_lines":[{"line_number":190,"context_line":"                    is usually newer than UC entry and older version would get installed"},{"line_number":191,"context_line":"                    in venv (see https://launchpad.net/bugs/1961874)."},{"line_number":192,"context_line":"#}"},{"line_number":193,"context_line":"    \u0026\u0026 curl -o /requirements/upper-constraints.txt ${UPPER_CONSTRAINTS_FILE:-https://releases.openstack.org/constraints/upper/{{ openstack_release }}} \\"},{"line_number":194,"context_line":"    \u0026\u0026 {{ macros.upper_constraints_remove(\"ovs\") }} \\"},{"line_number":195,"context_line":"    \u0026\u0026 mkdir -p /var/lib/kolla \\"},{"line_number":196,"context_line":"    \u0026\u0026 python3 -m venv --system-site-packages /var/lib/kolla/venv"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0a5a67af_90e5dca9","line":193,"in_reply_to":"dc6ee159_a2345d0d","updated":"2023-12-05 09:12:41.000000000","message":"I refer to  https://opendev.org/openstack/kolla/src/commit/83efe325462e683e2c99d088012cd611d7a0b138/docker/kolla-toolbox/Dockerfile.j2#L67\n\nmaybe there will be better if we use the condiction:\n{% if condition %}\n    \u0026\u0026 curl -o /requirements/upper-constraints.txt $UPPER_CONSTRAINTS_FILE \\\n{% endif %}\nI try to define the condtion, but failed","commit_id":"670e39958734bb2938a35cfaf436426147ac9d17"}]}