)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3c62d2ba4b84a13cb7f80d5cab3527b99a21d563","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Support collecting libvirt qemu domain logs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change causes the logs to be collected in /var/log/kolla."},{"line_number":10,"context_line":"Unfortuantly, it was not possible to change the log directory via a"},{"line_number":11,"context_line":"config option, so we need to symlink the hardcoded path to a directory"},{"line_number":12,"context_line":"under /var/log/kolla. The consequence of this is that the logs are"},{"line_number":13,"context_line":"collected in the kolla logs volume where other programs, such as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"979c370d_6c113c1f","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":12},"updated":"2024-06-06 15:55:54.000000000","message":"typo: \"Unfortunately\"\n\nPS: for the curious, the hardcoded path in nova is here:\n\nhttps://github.com/openstack/nova/blob/7dc4b1ea627d864a0ee2745cc9de4336fc0ba7b5/nova/virt/libvirt/driver.py#L4897\n\nit would in theory be possible to change this via `instances_path` config option but this affects of course the complete instance path and not only the logs.","commit_id":"ed4180e9401f324a84e2c32aec4e5bcf4f1ddc7c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d56455e11b5ed37d18b77200531387e67429c929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d080abc6_46a1a646","updated":"2024-06-03 14:05:42.000000000","message":"recheck: logs are gone","commit_id":"0f6a1aeed7c5fb32555c61293769797c4c60c88c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3c62d2ba4b84a13cb7f80d5cab3527b99a21d563","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5b712af_25efa8ea","updated":"2024-06-06 15:55:54.000000000","message":"for the record, I don\u0027t really like that we use a symlink for this, but I see no other good option currently.\n\nIt could be worth it to file an RFE with nova though, maybe they could make the instance log path configurable.","commit_id":"ed4180e9401f324a84e2c32aec4e5bcf4f1ddc7c"}],"docker/nova/nova-libvirt/extend_start.sh":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"db09c79fabc4aea19ed56c053c258d13bcaf1beb","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ ! -e \"/var/log/kolla/libvirt/qemu\" ]]; then"},{"line_number":19,"context_line":"    mkdir -p /var/log/kolla/libvirt/qemu"},{"line_number":20,"context_line":"    chown root:42400 /var/log/kolla/libvirt/qemu"},{"line_number":21,"context_line":"    chmod 2755 /var/log/kolla/libvirt/qemu"},{"line_number":22,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"977fb1d3_c9fc143f","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":20},"updated":"2024-01-15 12:42:24.000000000","message":"strange group. is this ok?","commit_id":"0f6a1aeed7c5fb32555c61293769797c4c60c88c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5f9fdd530d68b4aa5cffd6363afa284524d8d2d5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ ! -e \"/var/log/kolla/libvirt/qemu\" ]]; then"},{"line_number":19,"context_line":"    mkdir -p /var/log/kolla/libvirt/qemu"},{"line_number":20,"context_line":"    chown root:42400 /var/log/kolla/libvirt/qemu"},{"line_number":21,"context_line":"    chmod 2755 /var/log/kolla/libvirt/qemu"},{"line_number":22,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"6ad3f16e_087710e6","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":20},"in_reply_to":"53618897_636fd99c","updated":"2024-01-16 11:20:34.000000000","message":"oh, its ok to use numeric with chown, forgot that we have constants.","commit_id":"0f6a1aeed7c5fb32555c61293769797c4c60c88c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"75ec12e7d2f1fc0967a51dd77362dc383111a4ac","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ ! -e \"/var/log/kolla/libvirt/qemu\" ]]; then"},{"line_number":19,"context_line":"    mkdir -p /var/log/kolla/libvirt/qemu"},{"line_number":20,"context_line":"    chown root:42400 /var/log/kolla/libvirt/qemu"},{"line_number":21,"context_line":"    chmod 2755 /var/log/kolla/libvirt/qemu"},{"line_number":22,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"53618897_636fd99c","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":20},"in_reply_to":"977fb1d3_c9fc143f","updated":"2024-01-16 09:30:25.000000000","message":"So this is the kolla-user: \n\nhttps://github.com/openstack/kolla/blob/0eddd35da52c3e74a4c372796bf65247b261f7f0/kolla/common/users.py#L16-L19. \n\nIt was supposed to be the equivalent of this line in the fluentd start up script:\n\nhttps://github.com/openstack/kolla/blob/0eddd35da52c3e74a4c372796bf65247b261f7f0/docker/fluentd/extend_start.sh#L13\n\nbut the kolla user doesn\u0027t exist in this container, so I used the ID instead. Is there a cleaner way? Possibly I could add the kolla user so we could reference it by name?","commit_id":"0f6a1aeed7c5fb32555c61293769797c4c60c88c"}]}