)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ce7112725393991c95c17e07169ec19f3fdefb39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"18933e91_ac06df19","updated":"2024-02-16 12:14:55.000000000","message":"great work. thanks.","commit_id":"fe3eb5c0cb2e5a7a35db6c5c925a3d92ed000e3b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6f5626ce4e8450b6696ea2df57eee95a0491ee32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b92614c1_74a089cd","updated":"2024-02-20 10:11:09.000000000","message":"can you split moving the sources and updating the versions into dedicated patches?\n\nboth renaming the config blocks and updating the versions need release notes, then, too","commit_id":"899640fcbe2a97ba07181cb4a8f7f9d2f3d2a524"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7599addf05a0a2622743569260641ed708171e25","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"fcb07013_eecc5267","in_reply_to":"733f54a8_5e6f8d6a","updated":"2024-02-20 11:18:42.000000000","message":"seems it is only etcd going from 3.4 to 3.5","commit_id":"899640fcbe2a97ba07181cb4a8f7f9d2f3d2a524"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c49a8309b06ba0d772f4a110ec17a746ff1da96b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"733f54a8_5e6f8d6a","in_reply_to":"b92614c1_74a089cd","updated":"2024-02-20 10:14:19.000000000","message":"I think I haven\u0027t updated the versions - used the same ones, unless I did a mistake somewhere?","commit_id":"899640fcbe2a97ba07181cb4a8f7f9d2f3d2a524"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca331af9241acc8e1502bd4227f17be8ca1225b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2e23cf71_b4e38de7","in_reply_to":"fcb07013_eecc5267","updated":"2024-02-20 12:46:46.000000000","message":"Fixed","commit_id":"899640fcbe2a97ba07181cb4a8f7f9d2f3d2a524"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"77f91d0d487d02dbf01f1869e70968c996be7f1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"6186cd28_a2afff6b","updated":"2024-02-22 10:05:08.000000000","message":"recheck (opensearch builds fixed)","commit_id":"750a137815f1ca58c7e65d23e9d63403ea282b1a"}],"docker/etcd/Dockerfile.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c95e62cccc0429d4b04ef52f6bda771d6855aaae","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027etcd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ADD etcd-archive /etcd-source"},{"line_number":13,"context_line":"RUN ln -s etcd-source/* etcd \\"},{"line_number":14,"context_line":"    \u0026\u0026 cp /etcd/etcd /etcd/etcdctl /etcd/etcdutl /usr/bin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"COPY etcd_sudoers /etc/sudoers.d/kolla_etcd_sudoers"},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"030391e4_ed7bb5ac","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":57},"updated":"2024-02-16 12:10:46.000000000","message":"{% block etcd_install %}\nADD etcd-archive /etcd-source\nRUN ln -s etcd-source/* etcd \\\n    \u0026\u0026 cp /etcd/etcd /etcd/etcdctl /etcd/etcdutl /usr/bin\n{% endblock %}","commit_id":"3c0a7c84e96f5c4ceff2c5a8cb32f461a40a8fa1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b2f180241f6bb70d83ebcb7792d83dd3d8a670f","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027etcd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ADD etcd-archive /etcd-source"},{"line_number":13,"context_line":"RUN ln -s etcd-source/* etcd \\"},{"line_number":14,"context_line":"    \u0026\u0026 cp /etcd/etcd /etcd/etcdctl /etcd/etcdutl /usr/bin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"COPY etcd_sudoers /etc/sudoers.d/kolla_etcd_sudoers"},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"59d02fbf_f0aa380b","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":57},"in_reply_to":"030391e4_ed7bb5ac","updated":"2024-02-16 12:12:46.000000000","message":"Done","commit_id":"3c0a7c84e96f5c4ceff2c5a8cb32f461a40a8fa1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2545a76bdba60dbac1aeb7b1c8194957530fa79c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027etcd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block etcd_repository_version %}"},{"line_number":13,"context_line":"# NOTE(wszumski): It is suggested to upgrade one minor version at a time:"},{"line_number":14,"context_line":"# https://github.com/etcd-io/website/blob/cf046546dec9e1dcea966dc21ea38027c3290e9a/content/en/docs/v3.4/upgrades/upgrade_3_4.md#upgrade-requirements"},{"line_number":15,"context_line":"ARG etcd_version\u003dv3.4.27"},{"line_number":16,"context_line":"ARG etcd_url\u003dhttps://github.com/etcd-io/etcd/releases/download/${etcd_version}/etcd-${etcd_version}-linux-{{debian_arch}}.tar.gz"},{"line_number":17,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"49cc4c9e_af4384e6","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":148},"updated":"2024-02-20 17:14:39.000000000","message":"we do lose this comment in the current iteration of this patch.\nnot sure if we want to preserve it - I think it might be worthwhile, because not everyone might be familiar with the etcd upgrade scheme when proposing or reviewing etcd version bumps.\n\nWhat do you think?","commit_id":"b276a9cdb52502a9abe1b0f3cf866d952f201b5d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"77f91d0d487d02dbf01f1869e70968c996be7f1c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027etcd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block etcd_repository_version %}"},{"line_number":13,"context_line":"# NOTE(wszumski): It is suggested to upgrade one minor version at a time:"},{"line_number":14,"context_line":"# https://github.com/etcd-io/website/blob/cf046546dec9e1dcea966dc21ea38027c3290e9a/content/en/docs/v3.4/upgrades/upgrade_3_4.md#upgrade-requirements"},{"line_number":15,"context_line":"ARG etcd_version\u003dv3.4.27"},{"line_number":16,"context_line":"ARG etcd_url\u003dhttps://github.com/etcd-io/etcd/releases/download/${etcd_version}/etcd-${etcd_version}-linux-{{debian_arch}}.tar.gz"},{"line_number":17,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"6e497ddc_ff94fdd5","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":148},"in_reply_to":"49cc4c9e_af4384e6","updated":"2024-02-22 10:05:08.000000000","message":"Done","commit_id":"b276a9cdb52502a9abe1b0f3cf866d952f201b5d"}],"kolla/common/sources.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c95e62cccc0429d4b04ef52f6bda771d6855aaae","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                     \u0027designate-${openstack_branch}.tar.gz\u0027)},"},{"line_number":58,"context_line":"    \u0027etcd\u0027: {"},{"line_number":59,"context_line":"        \u0027version\u0027: \u00273.5.12\u0027,"},{"line_number":60,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":61,"context_line":"        \u0027location\u0027: (\u0027https://github.com/etcd-io/etcd/\u0027"},{"line_number":62,"context_line":"                     \u0027releases/download/v${version}\u0027"},{"line_number":63,"context_line":"                     \u0027/etcd-v${version}-linux-${debian_arch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":10,"id":"eece863d_a84a12de","line":60,"updated":"2024-02-16 12:10:46.000000000","message":"lost sha256sums from\nhttps://review.opendev.org/c/openstack/kolla/+/908989/10/docker/letsencrypt/letsencrypt-lego/Dockerfile.j2#b30","commit_id":"3c0a7c84e96f5c4ceff2c5a8cb32f461a40a8fa1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b2f180241f6bb70d83ebcb7792d83dd3d8a670f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                     \u0027designate-${openstack_branch}.tar.gz\u0027)},"},{"line_number":58,"context_line":"    \u0027etcd\u0027: {"},{"line_number":59,"context_line":"        \u0027version\u0027: \u00273.5.12\u0027,"},{"line_number":60,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":61,"context_line":"        \u0027location\u0027: (\u0027https://github.com/etcd-io/etcd/\u0027"},{"line_number":62,"context_line":"                     \u0027releases/download/v${version}\u0027"},{"line_number":63,"context_line":"                     \u0027/etcd-v${version}-linux-${debian_arch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":10,"id":"88203b02_9b61a689","line":60,"in_reply_to":"eece863d_a84a12de","updated":"2024-02-16 12:12:46.000000000","message":"Done","commit_id":"3c0a7c84e96f5c4ceff2c5a8cb32f461a40a8fa1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c95e62cccc0429d4b04ef52f6bda771d6855aaae","unresolved":true,"context_lines":[{"line_number":201,"context_line":"                     \u0027kuryr-libnetwork-${openstack_branch}.tar.gz\u0027)},"},{"line_number":202,"context_line":"    \u0027letsencrypt-lego\u0027: {"},{"line_number":203,"context_line":"        \u0027version\u0027: \u0027v4.6.0\u0027,"},{"line_number":204,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":205,"context_line":"        \u0027location\u0027: (\u0027https://github.com/go-acme/lego/\u0027"},{"line_number":206,"context_line":"                     \u0027releases/download/${version}/\u0027"},{"line_number":207,"context_line":"                     \u0027lego_${version}_linux_${debian_arch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":10,"id":"19864c63_07e51c09","line":204,"updated":"2024-02-16 12:10:46.000000000","message":"lets add sha256 checksums from here: https://github.com/go-acme/lego/releases/download/v4.6.0/lego_4.6.0_checksums.txt","commit_id":"3c0a7c84e96f5c4ceff2c5a8cb32f461a40a8fa1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b2f180241f6bb70d83ebcb7792d83dd3d8a670f","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                     \u0027kuryr-libnetwork-${openstack_branch}.tar.gz\u0027)},"},{"line_number":202,"context_line":"    \u0027letsencrypt-lego\u0027: {"},{"line_number":203,"context_line":"        \u0027version\u0027: \u0027v4.6.0\u0027,"},{"line_number":204,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":205,"context_line":"        \u0027location\u0027: (\u0027https://github.com/go-acme/lego/\u0027"},{"line_number":206,"context_line":"                     \u0027releases/download/${version}/\u0027"},{"line_number":207,"context_line":"                     \u0027lego_${version}_linux_${debian_arch}.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f33460d_b30e3328","line":204,"in_reply_to":"19864c63_07e51c09","updated":"2024-02-16 12:12:46.000000000","message":"Done","commit_id":"3c0a7c84e96f5c4ceff2c5a8cb32f461a40a8fa1"}],"kolla/image/tasks.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"19f3bde1a000631b2c23e92f9651d39c8ac1975d","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                    conf_sha \u003d source[\u0027sha256\u0027][self.conf.debian_arch]"},{"line_number":204,"context_line":"                    computed_sha \u003d hashlib.sha256(r.content).hexdigest()"},{"line_number":205,"context_line":"                    if conf_sha !\u003d computed_sha:"},{"line_number":206,"context_line":"                        self.logger.debug(\"%s SHA256 checksum does not match\""},{"line_number":207,"context_line":"                                          \"(configured: %s, computed: %s)\","},{"line_number":208,"context_line":"                                          source[\u0027source\u0027],"},{"line_number":209,"context_line":"                                          conf_sha,"}],"source_content_type":"text/x-python","patch_set":22,"id":"6750e4f1_cbff3510","line":206,"range":{"start_line":206,"start_character":36,"end_line":206,"end_character":41},"updated":"2024-02-20 15:28:20.000000000","message":"why is this only at debug log level when we set the image status to error? this does seem inconsistent to me.","commit_id":"76f9059fc765dd7251708f0fa267f222e312074a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5c23a06d28d7bad181ee9b13d51c0a3c997b8737","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                    conf_sha \u003d source[\u0027sha256\u0027][self.conf.debian_arch]"},{"line_number":204,"context_line":"                    computed_sha \u003d hashlib.sha256(r.content).hexdigest()"},{"line_number":205,"context_line":"                    if conf_sha !\u003d computed_sha:"},{"line_number":206,"context_line":"                        self.logger.debug(\"%s SHA256 checksum does not match\""},{"line_number":207,"context_line":"                                          \"(configured: %s, computed: %s)\","},{"line_number":208,"context_line":"                                          source[\u0027source\u0027],"},{"line_number":209,"context_line":"                                          conf_sha,"}],"source_content_type":"text/x-python","patch_set":22,"id":"6c0583b4_a20d5949","line":206,"range":{"start_line":206,"start_character":36,"end_line":206,"end_character":41},"in_reply_to":"6750e4f1_cbff3510","updated":"2024-02-20 15:35:50.000000000","message":"Good catch! thanks - fixed","commit_id":"76f9059fc765dd7251708f0fa267f222e312074a"}],"releasenotes/notes/move-curl-sources-d8fac9c8c57445cf.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"19f3bde1a000631b2c23e92f9651d39c8ac1975d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Overriding Prometheus/Let\u0027s Encrypt lego and etcd source urls, versions"},{"line_number":9,"context_line":"    and sha256 sums using ``template-overrides.j2`` is now not supported."},{"line_number":10,"context_line":"    Please migrate those overrides to ``kolla-build.conf``."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d1d9bcc2_ee371755","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":73},"updated":"2024-02-20 15:28:20.000000000","message":"\"is not supported anymore.\"?","commit_id":"76f9059fc765dd7251708f0fa267f222e312074a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04d33a9260bdba0788e4a2403158b2b71477c61d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Overriding Prometheus/Let\u0027s Encrypt lego and etcd source urls, versions"},{"line_number":9,"context_line":"    and sha256 sums using ``template-overrides.j2`` is now not supported."},{"line_number":10,"context_line":"    Please migrate those overrides to ``kolla-build.conf``."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"b495cbbf_a41489f0","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":73},"in_reply_to":"d1d9bcc2_ee371755","updated":"2024-02-20 15:33:20.000000000","message":"Done","commit_id":"76f9059fc765dd7251708f0fa267f222e312074a"}]}