)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b56f93386969f354751e0143047dccecca8813b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e995d81_b4bbd297","updated":"2024-02-23 09:41:31.000000000","message":"I don\u0027t know too much about bifrost, so sorry if my questions are too naive","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fe1c937f48ef5a537bb846aafbed4af20af17de4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7a7cba1_ee387377","updated":"2024-02-26 08:22:59.000000000","message":"recheck (RMQ repos fixed)","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"}],"docker/bifrost/bifrost-base/Dockerfile.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b56f93386969f354751e0143047dccecca8813b1","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    /bifrost/playbooks/install.yaml \\"},{"line_number":48,"context_line":"    -e git_branch\u003d{{ openstack_branch_slashed }} \\"},{"line_number":49,"context_line":"    -e ipa_upstream_release\u003d{{ openstack_branch }} \\"},{"line_number":50,"context_line":"    -e enable_inspector\u003dtrue \\"},{"line_number":51,"context_line":"    -e @/tmp/build_arg.yml \u0026\u0026 \\"},{"line_number":52,"context_line":"{%- if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":53,"context_line":"    apt-get clean \u0026\u0026 rm -rf /var/lib/apt/lists/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"2eda621e_5878a551","line":50,"updated":"2024-02-23 09:41:31.000000000","message":"did you make sure that this doesn\u0027t conflict with the bifrost internal support?\n\nwould it make sense (and be possible) to make this configurable at run time instead of hardcoding it into the build?","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fb7d336435cb00b0dc9c149185684d9cbff8f927","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    /bifrost/playbooks/install.yaml \\"},{"line_number":48,"context_line":"    -e git_branch\u003d{{ openstack_branch_slashed }} \\"},{"line_number":49,"context_line":"    -e ipa_upstream_release\u003d{{ openstack_branch }} \\"},{"line_number":50,"context_line":"    -e enable_inspector\u003dtrue \\"},{"line_number":51,"context_line":"    -e @/tmp/build_arg.yml \u0026\u0026 \\"},{"line_number":52,"context_line":"{%- if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":53,"context_line":"    apt-get clean \u0026\u0026 rm -rf /var/lib/apt/lists/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfa1d4d9_1e48fa2f","line":50,"in_reply_to":"08d3b76b_9ae32d41","updated":"2024-02-23 10:19:58.000000000","message":"Done","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"54900397365b825e2cea747749243a805c40e8a5","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    /bifrost/playbooks/install.yaml \\"},{"line_number":48,"context_line":"    -e git_branch\u003d{{ openstack_branch_slashed }} \\"},{"line_number":49,"context_line":"    -e ipa_upstream_release\u003d{{ openstack_branch }} \\"},{"line_number":50,"context_line":"    -e enable_inspector\u003dtrue \\"},{"line_number":51,"context_line":"    -e @/tmp/build_arg.yml \u0026\u0026 \\"},{"line_number":52,"context_line":"{%- if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":53,"context_line":"    apt-get clean \u0026\u0026 rm -rf /var/lib/apt/lists/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e6a43284_21ca1713","line":50,"in_reply_to":"2eda621e_5878a551","updated":"2024-02-23 09:46:10.000000000","message":"Basically this installs ironic-inspector in the image, we build bifrost in a way, that we run the installation playbooks so users with constrained internet connection don\u0027t have to fetch anything additional.\n\nSecond thing is - the ,,native in-ironic inspection\u0027\u0027 is experimental and does not deliver what ironic-inspector gives (introspection rules, that are extensively used in Kayobe).\n\nSo... we can\u0027t really make it optional here - we can make it overridable via template overrides for users building the images by themselves (by adding a separate block) if that helps.","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"20450823cc19a9e64b3c6f61ca4e3976916ff501","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    /bifrost/playbooks/install.yaml \\"},{"line_number":48,"context_line":"    -e git_branch\u003d{{ openstack_branch_slashed }} \\"},{"line_number":49,"context_line":"    -e ipa_upstream_release\u003d{{ openstack_branch }} \\"},{"line_number":50,"context_line":"    -e enable_inspector\u003dtrue \\"},{"line_number":51,"context_line":"    -e @/tmp/build_arg.yml \u0026\u0026 \\"},{"line_number":52,"context_line":"{%- if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":53,"context_line":"    apt-get clean \u0026\u0026 rm -rf /var/lib/apt/lists/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"08d3b76b_9ae32d41","line":50,"in_reply_to":"e6a43284_21ca1713","updated":"2024-02-23 09:50:38.000000000","message":"In addition to what Michal said, this will essentially just make sure that it is installed into the kolla venv. It won\u0027t actually be deployed unless you also set enable_inspector during the bootstrap: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/bifrost/tasks/bootstrap.yml#L16.","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0ca1146c6eb468b7cca7864212fba262c42a6db5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    /bifrost/playbooks/install.yaml \\"},{"line_number":48,"context_line":"    -e git_branch\u003d{{ openstack_branch_slashed }} \\"},{"line_number":49,"context_line":"    -e ipa_upstream_release\u003d{{ openstack_branch }} \\"},{"line_number":50,"context_line":"    -e enable_inspector\u003dtrue \\"},{"line_number":51,"context_line":"    -e @/tmp/build_arg.yml \u0026\u0026 \\"},{"line_number":52,"context_line":"{%- if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":53,"context_line":"    apt-get clean \u0026\u0026 rm -rf /var/lib/apt/lists/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a256934_c3bc3187","line":50,"in_reply_to":"e6a43284_21ca1713","updated":"2024-02-23 09:48:32.000000000","message":"ah, so this is only about installing the code, I guess that\u0027s fine, then","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da2a680a3d3c07b65c1f3c2fca8ad79352cce308","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    /bifrost/playbooks/install.yaml \\"},{"line_number":48,"context_line":"    -e git_branch\u003d{{ openstack_branch_slashed }} \\"},{"line_number":49,"context_line":"    -e ipa_upstream_release\u003d{{ openstack_branch }} \\"},{"line_number":50,"context_line":"    -e enable_inspector\u003dtrue \\"},{"line_number":51,"context_line":"    -e @/tmp/build_arg.yml \u0026\u0026 \\"},{"line_number":52,"context_line":"{%- if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":53,"context_line":"    apt-get clean \u0026\u0026 rm -rf /var/lib/apt/lists/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a2a5debb_74799126","line":50,"in_reply_to":"e6a43284_21ca1713","updated":"2024-02-23 09:47:30.000000000","message":"see https://docs.openstack.org/ironic/latest/admin/inspection/index.html","commit_id":"832a6381c314c947abbb6409122ddc8aa044e7f9"}]}