)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8ea2ac9ec26504ad366c08e3617eba49c6e3bd1d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump rabbitmq to 3.13"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Erlang 26.2.* is required as per [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1]: https://rabbitmq-website.pages.dev/docs/which-erlang"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4226ca88_a010c7ac","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":2},"updated":"2024-03-05 13:02:00.000000000","message":"I don\u0027t want to disagree just to disagree, but the linked docs page says the minimum required version of Erlang for rabbitmq 3.13 is 26.0. So it seems the commit message is wrong?\n\nI think it might still be worthwhile to bump erlang as well, even if only ensuring everything works going forward with newer versions.\n\nThat being said it would be technically possible and maybe worth it to break the erlang change out into it\u0027s own change.\n\nThe benefit would maybe be easier testing,separating bugs introduced from erlang bump and bugs introduced from rabbitmq bump into their own ci pipeline.\n\non the other hand it\u0027s theoretically also possible that rabbitmq runs into bugs with the minimum required version.\n\nSo what do you think?","commit_id":"e5178f9a1856c7acd631fcf76253a35787161d1a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3d2e755346b3bc376321efdb2394dedc1521703c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump rabbitmq to 3.13"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Erlang 26.2.* is required as per [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1]: https://rabbitmq-website.pages.dev/docs/which-erlang"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5bf30608_cc1357d6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":2},"in_reply_to":"4226ca88_a010c7ac","updated":"2024-03-06 13:04:44.000000000","message":"Ok, I missed the column on the left - but that pin would be still beneficial so that we don\u0027t install 26.3.* which will not be supported (and we\u0027ve been in that garden once in the past).\nI\u0027ll update the commit message and reno.","commit_id":"e5178f9a1856c7acd631fcf76253a35787161d1a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8ea2ac9ec26504ad366c08e3617eba49c6e3bd1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0115e7a_8bd8de92","updated":"2024-03-05 13:02:00.000000000","message":"LGTM apart from the discussion if we really need/want to bump erlang in the same Change.\nWe certainly could, but we don\u0027t need to, strictly speaking.","commit_id":"e5178f9a1856c7acd631fcf76253a35787161d1a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3879d27799e04dac444c7685dbe814c29505d8c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c40b191_f9c04d85","updated":"2024-03-07 11:41:48.000000000","message":"a careful +1 for now (CI breakage is not related, but let\u0027s see what CI says once other issues are fixed).","commit_id":"b652f6ac491343ae6b1aad14947070cc3f61e9eb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3d2e755346b3bc376321efdb2394dedc1521703c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ec55d92_c57f55e1","updated":"2024-03-06 13:04:44.000000000","message":"recheck (cephadm jobs fixed)","commit_id":"b652f6ac491343ae6b1aad14947070cc3f61e9eb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"38271722d394df8324d0d3d3b0cbf1d2309d8cfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88a88d97_ab339428","updated":"2024-03-06 17:25:42.000000000","message":"recheck lets see if keystone passlib drama is persistent","commit_id":"b652f6ac491343ae6b1aad14947070cc3f61e9eb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3a98660eb565113550ac31c5a711d112d27c26c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5d7cf7d8_3940e1b3","updated":"2024-03-11 15:12:04.000000000","message":"rebased to also get proper aarch64 results","commit_id":"a0e22caa8a131486de6cbcf0a4d9b13c6e7c0547"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"14490eabe0be905c6dacbcf04dfb0c0644229fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0a9f412_536b5c7c","updated":"2024-03-12 10:53:47.000000000","message":"recheck debian upgrade rmq reconfigure failed","commit_id":"a0e22caa8a131486de6cbcf0a4d9b13c6e7c0547"}],"releasenotes/notes/rabbitmq-3-13-56852b220fd50bc0.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8ea2ac9ec26504ad366c08e3617eba49c6e3bd1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``RabbitMQ`` version has been upgraded to ``3.13``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee8a0d82_1d6e53a9","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2024-03-05 13:02:00.000000000","message":"should we mention the erlang upgrade here as well?","commit_id":"e5178f9a1856c7acd631fcf76253a35787161d1a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3d2e755346b3bc376321efdb2394dedc1521703c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``RabbitMQ`` version has been upgraded to ``3.13``."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f77da71f_7d77479b","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"ee8a0d82_1d6e53a9","updated":"2024-03-06 13:04:44.000000000","message":"Acknowledged","commit_id":"e5178f9a1856c7acd631fcf76253a35787161d1a"}]}