)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90b591e35d00d25aba2f5bc05ad02bb0fe099de7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6d637ac_5bcdd7d1","updated":"2024-03-14 13:53:28.000000000","message":"I like this. LGTM","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d02de90e90b35e2f54b042a2ee3ff72dd1a56781","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f565368_89bdc123","updated":"2024-03-18 12:20:13.000000000","message":"Looks good, but it seems worth tweaking for the corner case Will pointed out","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2a63ae4ceae009431f44a6ab44d5413b8c841d4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06e934ad_ca36c64d","updated":"2024-03-14 15:34:38.000000000","message":"This shouldn\u0027t break people using the existing approach of using the image footer or overwriting `grafana_plugins_install` to install custom plugins. It\u0027s slightly nicer this way. I gave it a quick test and it seems fine:\n\nSetting:\n\n`grafana_plugins_append: [timomyl-organisations-panel, vertica-grafana-datasource]`\n\nResults in the expected behaviour:\n\n```\nINFO:kolla.common.utils.grafana:Step 9/11 : RUN grafana-cli plugins install gnocchixyz-gnocchi-datasource \u0026\u0026 grafana-cli\n plugins install grafana-opensearch-datasource \u0026\u0026 grafana-cli plugins install timomyl-organisations-panel \u0026\u0026 grafana-cli\n plugins install vertica-grafana-datasource\n ```","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0cc7e92139a8be4407119d2b1464a1ddd8bc6e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31532434_dedf74ab","updated":"2024-04-17 14:49:12.000000000","message":"please provide a simple docs paragraph describing how to add/remove grafana plugins, maybe extend:\n\nhttps://docs.openstack.org/kolla/latest/admin/image-building.html#plugin-functionality\n\nThanks\n\nThe code itself LGTM. :)","commit_id":"7f83865abda210230ee531b45326dfc3ba32fdd4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e81d9564d04711c6a4d9d0b37b14659b63cbfd49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3e88b5ab_9abd28a4","updated":"2024-04-19 12:03:07.000000000","message":"Actually, Maksim and Sven are right - can you add a note to packages-customisation docs that the same mechanism works for Grafana plugins?","commit_id":"569b1896be7239f736d9c29bba38d57e9ab30b47"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9a58d0ba8751d8e8f2a20eeb94657115a19674be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6d0f2200_8a0064ce","updated":"2024-04-19 09:47:27.000000000","message":"LGTM\n\nIt still would be nice to have docs though.","commit_id":"569b1896be7239f736d9c29bba38d57e9ab30b47"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"399824c6c425de368612106b34ce579abd2d16c6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8e311e87_7a92049c","updated":"2024-06-21 17:45:34.000000000","message":"please address comments","commit_id":"85e2138104f2f12688d50d2ed7d01c01638a9af0"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"01a686be56792cbc0488d79e565c3092af2ae677","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"72c61d36_63a746e6","in_reply_to":"8e311e87_7a92049c","updated":"2024-06-28 13:46:25.000000000","message":"Done","commit_id":"85e2138104f2f12688d50d2ed7d01c01638a9af0"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"01a686be56792cbc0488d79e565c3092af2ae677","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"58da3804_a2c3920a","updated":"2024-06-28 13:46:25.000000000","message":"I think we need to get this moving instead of nitpicking small issues. Docs have been updated and I would appreciate if this could be merged. Thank you 😊","commit_id":"077e0003d41746a0052564ee1487d981f125cec9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a9d1c915fc1c1a3197c7251a8df59920f51fcc0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"657e25d9_290b722f","updated":"2024-06-28 16:44:51.000000000","message":"Let\u0027s merge this, been here long.","commit_id":"077e0003d41746a0052564ee1487d981f125cec9"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"87b614124cff4f85d48f22708f77b5da2f311aa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"963e97ba_efaf1546","updated":"2024-06-28 10:02:22.000000000","message":"recheck mirror sync issue? Grafana image build failed,  11.1 recently released","commit_id":"077e0003d41746a0052564ee1487d981f125cec9"}],"doc/source/admin/image-building.rst":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fbae62b13562592af60a77fd10c5a478d8dd54a1","unresolved":true,"context_lines":[{"line_number":404,"context_line":"Grafana plugins"},{"line_number":405,"context_line":"^^^^^^^^^^^^^^^"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Additional Grafana plugins can be installed by adding the plugin name to the"},{"line_number":408,"context_line":"``grafana_plugins_append`` list."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1d81feb5_9c0d0a0f","line":407,"updated":"2024-04-19 20:06:26.000000000","message":"forgot to say about other possible suffixes usage. eg override or remove.\nand it would be good to mention about the same mechanism  used in the \u0027Packages customisation\u0027 paragraph and provide the link to it.","commit_id":"5dc2a5c146e62c50fd47f890577d00c6284c870b"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"01a686be56792cbc0488d79e565c3092af2ae677","unresolved":false,"context_lines":[{"line_number":404,"context_line":"Grafana plugins"},{"line_number":405,"context_line":"^^^^^^^^^^^^^^^"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Additional Grafana plugins can be installed by adding the plugin name to the"},{"line_number":408,"context_line":"``grafana_plugins_append`` list."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7bee5f55_792298d5","line":407,"in_reply_to":"1d81feb5_9c0d0a0f","updated":"2024-06-28 13:46:25.000000000","message":"Done","commit_id":"5dc2a5c146e62c50fd47f890577d00c6284c870b"}],"docker/grafana/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2a63ae4ceae009431f44a6ab44d5413b8c841d4d","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% endblock %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d22b9d95_706b5fc9","line":28,"updated":"2024-03-14 15:34:38.000000000","message":"I\u0027ve checked that grafana-cli doesn\u0027t support installing them all at once to simplify this (in a single command). It doesn\u0027t. This looks good.","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"86de669087512198492713ea37560516172c02f7","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% endblock %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ad1f44ab_9aac5731","line":28,"updated":"2024-03-18 09:45:00.000000000","message":"Just thought... we probably need to make this conditional on grafana_plugins not being an empty list otherwise we will end up with an empty RUN statement.","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"317e407599425d127f32c2ea0aae5ffc241842ba","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% endblock %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"89a36c4b_105b3752","line":28,"in_reply_to":"9d179ceb_add0fdab","updated":"2024-03-18 18:04:48.000000000","message":"Done","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d02de90e90b35e2f54b042a2ee3ff72dd1a56781","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% endblock %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9d179ceb_add0fdab","line":28,"in_reply_to":"ad1f44ab_9aac5731","updated":"2024-03-18 12:20:13.000000000","message":"Fair point. It seems unlikely to remove all plugins, and you could just override the block in that case, but still a rough edge that could easily be fixed..\n\n@Dawud, setting this in kolla.yml should trigger the issue:\nkolla_build_customizations:\n    grafana_plugins_remove: [gnocchixyz-gnocchi-datasource, grafana-opensearch-datasource]","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"353a5db7f107a6af630f7deb866691ca2aa73eb4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% endblock %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d6913dbe_d27346ae","line":28,"in_reply_to":"d22b9d95_706b5fc9","updated":"2024-03-15 14:54:02.000000000","message":"Acknowledged","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"57ff151c0561103cb36e3dd252f39af4a109b5ed","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% if grafana_plugins|length \u003e 0 %}"},{"line_number":29,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ce1e0af_b8679163","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":22},"updated":"2024-03-28 14:46:34.000000000","message":"add spaces around |","commit_id":"43d8b84d3e971ce08b45159f971dc0c99511a233"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"b77afe9d147ea6edce0765e8c54a59ed757fb80e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% if grafana_plugins|length \u003e 0 %}"},{"line_number":29,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e61f913e_1771db41","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":22},"in_reply_to":"3ce1e0af_b8679163","updated":"2024-04-17 13:10:53.000000000","message":"Done","commit_id":"43d8b84d3e971ce08b45159f971dc0c99511a233"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0cc7e92139a8be4407119d2b1464a1ddd8bc6e0a","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% if grafana_plugins | length \u003e 0 %}"},{"line_number":29,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"6ee18063_cc670fda","line":30,"updated":"2024-04-17 14:49:12.000000000","message":"nit: unaligned usage of newlines: either remove the newline after RUN\nor append a newline before RUN.","commit_id":"7f83865abda210230ee531b45326dfc3ba32fdd4"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"d04ab57a896cd821d523c83ded8b7928ff82aac1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% if grafana_plugins | length \u003e 0 %}"},{"line_number":29,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"b08e5aa1_fd6487ee","line":30,"in_reply_to":"6ee18063_cc670fda","updated":"2024-04-18 21:51:59.000000000","message":"Done","commit_id":"7f83865abda210230ee531b45326dfc3ba32fdd4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d53911f9f6c911bee404757d3a2c09d0be634b44","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% if grafana_plugins | length \u003e 0 %}"},{"line_number":29,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{% endblock %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3d0981c3_e7d2d919","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":11},"updated":"2024-06-28 12:48:34.000000000","message":"shouldn\u0027t be this a macro ? as pip install packages ?","commit_id":"077e0003d41746a0052564ee1487d981f125cec9"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d87e8d919b651e70a685ff91a4a58547b9a017fa","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% if grafana_plugins | length \u003e 0 %}"},{"line_number":29,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{% endblock %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"fdaf4290_9649c10d","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":11},"in_reply_to":"3d0981c3_e7d2d919","updated":"2024-06-28 13:03:31.000000000","message":"It wouldn\u0027t be used outside this container, unlike the pip macro, so I don\u0027t think it\u0027s necessary. I\u0027m happy to be convinced otherwise?","commit_id":"077e0003d41746a0052564ee1487d981f125cec9"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"01a686be56792cbc0488d79e565c3092af2ae677","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% set grafana_default_plugins \u003d [\u0027gnocchixyz-gnocchi-datasource\u0027, \u0027grafana-opensearch-datasource\u0027]  %}"},{"line_number":26,"context_line":"{% set grafana_plugins \u003d  grafana_default_plugins | customizable(\"plugins\") %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% if grafana_plugins | length \u003e 0 %}"},{"line_number":29,"context_line":"RUN {{ ([\u0027grafana-cli plugins install %s\u0027] * grafana_plugins | length ) | join(\u0027 \u0026\u0026 \u0027) | format(*grafana_plugins) }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{% endblock %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"8c040017_d0ce5c0e","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":11},"in_reply_to":"fdaf4290_9649c10d","updated":"2024-06-28 13:46:25.000000000","message":"Done","commit_id":"077e0003d41746a0052564ee1487d981f125cec9"}],"releasenotes/notes/merge-grafana-plugins-b9a837b9fccff691.yaml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2a63ae4ceae009431f44a6ab44d5413b8c841d4d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New logic for installing grafana plugins. When building you can pass a"},{"line_number":5,"context_line":"    variable ``grafana_plugins_append`` that contains a list of plugins you"},{"line_number":6,"context_line":"    want to install. This will be appended to the default list of plugins."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"772ba689_45d1174f","line":6,"updated":"2024-03-14 15:34:38.000000000","message":"You could mention that the old way of using the footer still continues to work","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"beac4d5ade18dd641aaa7f754405578979d5fb4f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New logic for installing grafana plugins. When building you can pass a"},{"line_number":5,"context_line":"    variable ``grafana_plugins_append`` that contains a list of plugins you"},{"line_number":6,"context_line":"    want to install. This will be appended to the default list of plugins."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2164442b_784d3e56","line":6,"in_reply_to":"772ba689_45d1174f","updated":"2024-03-26 12:39:01.000000000","message":"Done","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90b591e35d00d25aba2f5bc05ad02bb0fe099de7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37605933_f8e76f39","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":1},"updated":"2024-03-14 13:53:28.000000000","message":"it might be nice to list here the default plugins","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"01a686be56792cbc0488d79e565c3092af2ae677","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c36a02f7_a6b1b4d4","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":1},"in_reply_to":"2f640001_71ad5b25","updated":"2024-06-28 13:46:25.000000000","message":"Done","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"47415874291fffa4b34dde56a9cadd0e53cf95ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4745f968_26a5a452","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":1},"in_reply_to":"37605933_f8e76f39","updated":"2024-03-26 12:24:07.000000000","message":"here should be mentioned not only default plugins, but also the method of customisation, not only _append also _replace etc. maybe add some fragment to the documentation would be good.","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"1ddae77ce6cfaf9be748b9761aa11b71098e6305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d445c092_6eb6f129","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":1},"in_reply_to":"4745f968_26a5a452","updated":"2024-03-26 12:36:15.000000000","message":"The documentation already exists. https://docs.openstack.org/kolla/latest/admin/image-building.html#packages-customisation","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7f2d8ec4eb122215102765a6b4f6b8d1ff7e63a9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f640001_71ad5b25","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":1},"in_reply_to":"d445c092_6eb6f129","updated":"2024-03-26 13:06:48.000000000","message":"its about packages, not plugins\nsince this is \u0027new logic\u0027 as you mention in reno - this should be well described and used in other Dockerfiles","commit_id":"22eb1d7eeffa763207adcab8888baae97959b22d"}]}