)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"48f81814956d1ea841b09c59aac04744b655e2f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"72f018d2_ccfc706e","updated":"2024-03-20 14:15:03.000000000","message":"reno missing","commit_id":"a0972455ad9df0f99a06b5d410772129282add35"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b6e80d87b04471eca64fb2f4f5bd351191776bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a05f69b_c500bf80","updated":"2024-03-20 16:56:46.000000000","message":"upgrade test fails in test-core-openstack with:\n\n```\n+ openstack server create --wait --image cirros --flavor m1.tiny --key-name mykey --network demo-net kolla_boot_test\nget() takes 1 positional argument but 2 were given\n```\n\nI found this code to be somewhat flaky in that the ipv4 call site has an empty argument which resurfaces here.\n\nI fixed this in the shellcheck change by changing the code to be:\n\n```\nif [[ $IP_VERSION -eq 6 ]]; then\n        # NOTE(yoctozepto): CirrOS has no IPv6 metadata support, hence need to use configdrive\n        openstack server create --wait --image cirros --flavor m1.tiny --key-name mykey --network demo-net --config-drive True \"${name}\"\n    else\n        openstack server create --wait --image cirros --flavor m1.tiny --key-name mykey --network demo-net \"${name}\"\n    fi\n```\n\ncurrently it is this instead:\n\n```\n\n    if [[ $IP_VERSION -eq 6 ]]; then\n        # NOTE(yoctozepto): CirrOS has no IPv6 metadata support, hence need to use configdrive\n        server_create_extra\u003d\"${server_create_extra} --config-drive True\"\n    fi\n\n    openstack server create --wait --image cirros --flavor m1.tiny --key-name mykey --network demo-net ${server_create_extra} ${name}\n```\n\nthe current version has the disadvantage to supply the `server_create_extra` var to the openstack server create command, even if it is empty, and it is empty by default in the ipv4 case which led to errors in the shellcheck change because you suddenly have `\u0027\u0027` on the command line.\n\nNot 100% sure this is the same error here, but it might be the case.","commit_id":"a0972455ad9df0f99a06b5d410772129282add35"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8d1adf3f50acf198637ea7a9ca6ee9a19afec6df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a137ecfd_4c055429","in_reply_to":"0a05f69b_c500bf80","updated":"2024-03-20 16:59:20.000000000","message":"I actually think this must be something else, because we don\u0027t see spurious \u0027\u0027 on the commandline and also the specific error message was afaik another one.","commit_id":"a0972455ad9df0f99a06b5d410772129282add35"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"481186c81abe6d7ddf6f502ba88ef5c846c3dbc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5041d06_e9b1e59f","in_reply_to":"72f018d2_ccfc706e","updated":"2024-03-20 14:21:28.000000000","message":"there is no any reno for previous releases at all","commit_id":"a0972455ad9df0f99a06b5d410772129282add35"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c7778feae28949d404d0d7db04475f0be1cf5702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f05e3c6_06a2e43d","in_reply_to":"a137ecfd_4c055429","updated":"2024-03-25 10:38:34.000000000","message":"Done","commit_id":"a0972455ad9df0f99a06b5d410772129282add35"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"92b1a159692202209f6b60516f97da212a7cc167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"142c567a_0529d05a","in_reply_to":"d5041d06_e9b1e59f","updated":"2024-03-20 14:31:29.000000000","message":"Ok then, fine by me - sort of we assume that it\u0027s logical that we use Caracal UCA in Caracal.","commit_id":"a0972455ad9df0f99a06b5d410772129282add35"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1ab07ad65b195a761f6a3041640cf7ea53154f83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4dc51506_74e2f066","updated":"2024-03-20 20:38:15.000000000","message":"lets split the chain","commit_id":"1ccccec9b9e0fb8b39f2c70d52e897a56063dfdf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"82bad114a021c7ba2febaee79d60123651de6435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9da1e971_c6ee2b91","updated":"2024-03-24 16:06:35.000000000","message":"recheck gather new logs","commit_id":"1ccccec9b9e0fb8b39f2c70d52e897a56063dfdf"}]}